Isn't that actually the same?
It also ignores the number of full descriptors, which I guess is wrong.
And it looks like the whole parsing code is broken. It ignores the
number of partial descriptors and does FullList++
Timo
janderwald(a)svn.reactos.org schrieb:
> Author: janderwald
> Date: Sat Apr 25 16:05:08 2009
> New Revision: 40694
>
> URL: http://svn.reactos.org/svn/reactos?rev=40694&view=rev
> Log:
> - Fix allocation of CM_RESOURCE_LIST
> - Might fix bug 4354
> See issue #4354 for more details.
>
> Modified:
> trunk/reactos/drivers/video/videoprt/dispatch.c
>
> Modified: trunk/reactos/drivers/video/videoprt/dispatch.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/dis…
> ==============================================================================
> --- trunk/reactos/drivers/video/videoprt/dispatch.c [iso-8859-1] (original)
> +++ trunk/reactos/drivers/video/videoprt/dispatch.c [iso-8859-1] Sat Apr 25 16:05:08 2009
> @@ -340,9 +340,11 @@
>
> /* Save the resource list */
> ResourceCount = AllocatedResources->List[0].PartialResourceList.Count;
> - ResourceListSize =
> - FIELD_OFFSET(CM_RESOURCE_LIST, List[0].PartialResourceList.
> - PartialDescriptors[ResourceCount]);
> + ResourceListSize = sizeof(CM_RESOURCE_LIST);
> +
> + if (ResourceCount > 1)
> + ResourceListSize += (ResourceCount-1) * sizeof(CM_PARTIAL_RESOURCE_DESCRIPTOR);
> +
> DeviceExtension->AllocatedResources = ExAllocatePool(PagedPool, ResourceListSize);
> if (DeviceExtension->AllocatedResources == NULL)
> {
>
>
>
I feel that some things really need to be clearly explained, regarding apps
being use to test releases with.
At the moment, despite numerous attempts, i failed to find who (if anyone)
is responsible for compiling and maintaining the list of apps used for
release version testing. Especially, the non-downloader stuff section is
basically changing completely with every release, making those tests
virtually pointless, if we cant keep any consistency. On the other hand,
looks like no one is responsible for maintaining Downloader app list.
Without such responsibilites set, we are slipping into disorganisation,
which is both confusing and uproductive. Clear policies should be set and
observed in this matter, taking care of such basic thing as
adding/linking/opening a bug report for an app that failed in release Test.
I feel that testers have more productive things to do, than cleaning
up/sorting test entries, incorrectly made up by first timers.
Sorry if anyone feels this post to sound harsh, but its still really gentle
and kind, compared to obscenities, curses and swears others have to put up,
when i vent out after seeing the current state of Release testing wiki.
HI!
I was wondering if you people were interested in a new ISO/QUEMU/VMWARE
download mirror, I got space and on my server and I would like to help this
wonder full project.
If the service I'm offering you for free please answer back with the
information for starting "mirroring"
Here's my server's information:
Conection speed: VLAN on 100Mbits
Mirroring protocol: HTTP
Space reserved for ReactOS: 7GB,
Bandwith: Unlimited Bandwith
Waiting your answer,
Jorge Guerra
Kernel Error Administrator
Will Rogers <http://www.brainyquote.com/quotes/authors/w/will_rogers.html>
- "I don't make jokes. I just watch the government and report the
facts."
Hi,
by today most of the bugs which were having 0.3.9 as a milestone are
fixed - including fixing 4-months old bug with richedit control,
properly trimming DLL names during PE loading so that apps now can
find their DLLs (previously that failed in some cases), newest
downloader problem introduced yesterday and fixed today (not to speak
about yesterday's fixes too!).
This is a very good example of team collaboration, team effort aimed
at a narrow set of problems. It worked very well, and I think we
would utilise such bugfixing sessions in future too.
Branching date is now set to tomorrow, 17th of April, 2009 and is not
going to be changed anymore. As soon as the 0.3.9 branch is created,
feature freeze is considered to be finished.
After the release is branched, usual testing will be conducted,
actual packages built and released as usual.
Thank you for your efforts and for being patient with regards to the
feature freeze.
WBR,
Aleksey Bragin.
Dmitry! Please! It's only a few hours left till we create a branch
and normal development resumes!
WBR,
Aleksey Bragin.
On Apr 18, 2009, at 1:01 AM, dgorbachev(a)svn.reactos.org wrote:
> Author: dgorbachev
> Date: Sat Apr 18 01:01:56 2009
> New Revision: 40565
>
> URL: http://svn.reactos.org/svn/reactos?rev=40565&view=rev
> Log:
> Begin Japanese translation of USetup
>
> Added:
> trunk/reactos/media/vgafonts/932-8x8.bin (with props)
> Modified:
> trunk/reactos/base/setup/usetup/lang/ja-JP.h
> trunk/reactos/base/setup/usetup/muifonts.h
> trunk/reactos/base/setup/usetup/muilanguages.h
> trunk/reactos/media/vgafonts/vgafonts.rbuild