Ros-dev

ros-dev@reactos.org

5790 discussions

[ros-diffs] [reactos] 01/02: [PSDK] Fix definition of INVALID_PROCESSTRACE_HANDLE as suggested by Thomas. #267
by James Tabor 08 Jan '18

08 Jan '18

Just curious, why does that just look so wrong to me....... https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e3459ec36ecd783d67c27… commit e3459ec36ecd783d67c27dac4e81ad9facc08605 Author: Mark Jansen <mark.jansen at reactos.org <http://www.reactos.org/mailman/listinfo/ros-diffs>> AuthorDate: Sat Jan 6 21:09:51 2018 +0100 [PSDK] Fix definition of INVALID_PROCESSTRACE_HANDLE as suggested by Thomas. #267 --- sdk/include/psdk/evntrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/include/psdk/evntrace.h b/sdk/include/psdk/evntrace.h index dbbc660963..7056f119fa 100644 --- a/sdk/include/psdk/evntrace.h +++ b/sdk/include/psdk/evntrace.h @@ -711,7 +711,7 @@ typedef struct _ENABLE_TRACE_PARAMETERS { PEVENT_FILTER_DESCRIPTOR EnableFilterDesc; } ENABLE_TRACE_PARAMETERS, *PENABLE_TRACE_PARAMETERS; -#define INVALID_PROCESSTRACE_HANDLE ((TRACEHANDLE)INVALID_HANDLE_VALUE) +#define INVALID_PROCESSTRACE_HANDLE ((TRACEHANDLE)(ULONG_PTR)INVALID_HANDLE_VALUE) #if defined(UNICODE) || defined(_UNICODE) >From W7U SDK rc: sdkinc.v7rc/Evntrace.h:93:typedef ULONG64 TRACEHANDLE, *PTRACEHANDLE; sdkinc.v7rc/Evntrace.h:1500:#define INVALID_PROCESSTRACE_HANDLE ((TRACEHANDLE)INVALID_HANDLE_VALUE) Did this break three of the build bots?

2 1

*PREVIEW* : ReactOS 1st-stage GUI installer testing on Windows
by Hermès BÉLUSCA-MAÏTO 07 Jan '18

07 Jan '18

Hello everyone, Lately I was continuing working on my setup_improvements branch: https://github.com/HBelusca/reactos/commits/setup_improvements (whose main purpose, I recall, is to share a maximum of installation code between our working 1st-stage text-mode usetup and our 1st-stage GUI-mode reactos.exe setup that needs to be implemented). The last results of this is that I am now able to install ReactOS files to a user-provided directory using the GUI-mode setup! As Im developing under Windows I tested the file-copying part of the installer (which is, at the time of writing, the latest part of installation code I has been able to share between the two installers) on Windows. You can see the demo here: https://i.imgur.com/xF97hv1.gifv The animated gif also demonstrates the capability of the installer to halt file copying if the user pops the installation-cancel confirmation dialog out; file-copying is resumed when the user does not want to cancel the installation, but it is stopped when the user really cancels the installation. And of course, the file-copying status is displayed with an animated progress-bar. I have worked out a bit the wizard transitions, but some work remains to be done, especially for the partitioning step (currently Im hardcoding in the GUI installer the disk & partition where I want the copy to take place). One can note in the animation that the preparation of the list of files to be copied seems to take a while: indeed, the shared installation code works exclusively with NT paths. However, when this shared code is used in the win32 GUI-mode installer, this code calls inside setupapi.dll functions to manage the installation file queue (in usetup on the contrary, it uses instead a file queue implementation that works directly with NT paths). As a consequence, I need to convert the NT paths back to Win32 ones before feeding them into the setupapi functions, and this is not trivial. I want to improve this conversion by caching some of the computed results. Enjoy! Best regards, Hermès P.S.: Please dont put that on Twitter since this is under heavy work-in-progress and this demo hasnt been done under ReactOS at all.

1 0

Creative sound cards drivers
by Javier Agustìn Fernàndez Arroyo 04 Jan '18

04 Jan '18

hwy guys, did you hear about this? Maybe toese can be included with ReactOS, they are open source! https://github.com/kxproject http://kxproject.com/index.php?language=en

1 0

Postponing December Status Meeting
by Colin Finck 04 Jan '18

04 Jan '18

Hi all! If we follow our usual schedule, the December Status Meeting would be today. With such a late announcement and many people still on holidays, I suggest postponing it to next Thursday, January 4, 2018. Time will be 19:00 UTC as always. I already asked on #reactos-dev and got some approvals, so consider this the official meeting invitation :) This also gives you one week from now for agenda proposals. Additionally, we have got some new contributors in the recent months. If you think you should join the meeting or know somebody who should join, please let me know in advance. See you all next year! Colin

1 1

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [SETUP] Remove FSDs which have broken dismount implementation. This avoids issues when these partitions are formatted to FAT for setup.
by 7th Element 18 Dec '17

18 Dec '17

Hi Pierre, Isn’t this change going to remove ability to boot from those FSs? BR, Peter > On 18 Dec 2017, at 0:16, Pierre Schweitzer <pierre(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=806cd16328799771b8939… > > commit 806cd16328799771b89397f5c51a3d46884bce0a > Author: Pierre Schweitzer <pierre(a)reactos.org> > AuthorDate: Sun Dec 17 23:13:56 2017 +0100 > > [SETUP] Remove FSDs which have broken dismount implementation. > This avoids issues when these partitions are formatted to FAT for setup. > > For now, this commit doesn't change anything, but once IopParseDevice hack > gets removed, this will make a difference! > > CORE-6305 > --- > boot/bootdata/txtsetup.sif | 2 -- > drivers/filesystems/btrfs/CMakeLists.txt | 2 +- > drivers/filesystems/ntfs/CMakeLists.txt | 2 +- > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/boot/bootdata/txtsetup.sif b/boot/bootdata/txtsetup.sif > index 3ea62974b5..822c19c8c8 100644 > --- a/boot/bootdata/txtsetup.sif > +++ b/boot/bootdata/txtsetup.sif > @@ -52,7 +52,6 @@ usbstor.sys=,,,,,,x,,,,,,4 > kbdhid.sys=,,,,,,,,,,,,4 > kbdclass.sys=,,,,,,x,,,,,,4 > l_intl.nls=,,,,,,,,,,,,2 > -ntfs.sys=,,,,,,,,,,,,4 > pci.sys=,,,,,,,,,,,,4 > scsiport.sys=,,,,,,x,,,,,,4 > storport.sys=,,,,,,x,,,,,,4 > @@ -69,7 +68,6 @@ ntdll.dll=,,,,,,,,,,,,2 > wmilib.sys=,,,,,,,,,,,,4 > ksecdd.sys=,,,,,,,,,,,,4 > mountmgr.sys=,,,,,,x,,,,,,4 > -btrfs.sys=,,,,,,x,,,,,,4 > reiserfs.sys=,,,,,,x,,,,,,4 > ffs.sys=,,,,,,x,,,,,,4 > udfs.sys=,,,,,,x,,,,,,4 > diff --git a/drivers/filesystems/btrfs/CMakeLists.txt b/drivers/filesystems/btrfs/CMakeLists.txt > index 65e61d255a..123c9f0522 100644 > --- a/drivers/filesystems/btrfs/CMakeLists.txt > +++ b/drivers/filesystems/btrfs/CMakeLists.txt > @@ -41,4 +41,4 @@ add_definitions(-D__KERNEL__) > set_module_type(btrfs kernelmodedriver) > target_link_libraries(btrfs rtlver ntoskrnl_vista zlib_solo wdmguid ${PSEH_LIB}) > add_importlibs(btrfs ntoskrnl hal) > -add_cd_file(TARGET btrfs DESTINATION reactos/system32/drivers NO_CAB FOR all) > +add_cd_file(TARGET btrfs DESTINATION reactos/system32/drivers FOR all) > diff --git a/drivers/filesystems/ntfs/CMakeLists.txt b/drivers/filesystems/ntfs/CMakeLists.txt > index 0b1af78947..5a193b449d 100644 > --- a/drivers/filesystems/ntfs/CMakeLists.txt > +++ b/drivers/filesystems/ntfs/CMakeLists.txt > @@ -25,4 +25,4 @@ set_module_type(ntfs kernelmodedriver) > target_link_libraries(ntfs ${PSEH_LIB}) > add_importlibs(ntfs ntoskrnl hal) > add_pch(ntfs ntfs.h SOURCE) > -add_cd_file(TARGET ntfs DESTINATION reactos/system32/drivers NO_CAB FOR all) > +add_cd_file(TARGET ntfs DESTINATION reactos/system32/drivers FOR all) > >

3 8

Small suggestion for the abandoned SVN mirror on GitHub
by Dmitry D. Chernov 17 Dec '17

17 Dec '17

Good day everyone. I'm talking about this repo: https://github.com/reactos/reactos-deprecated-gitsvn-dont-use To prevent pull-requesting to it I suggest to use new GitHub feature "archive this repository". To enable it, just open the "Settings" page and go to the bottom. "Archived" repos are marked as read-only and could not be pull-requested. It's also would be nice to disable unused "Projects" tab in this repo for the great justice of perfectionism. ___ Dmitry D. Chernov

4 5

ReactOS 0.4.7 to be released tomorrow, 6th December 2017 - Press Kit is online!
by Colin Finck 17 Dec '17

17 Dec '17

Hi all! With all release preparations done, we can finally give a release date for ReactOS 0.4.7: Tomorrow, Wednesday, 6th December 2017. During that day (European time), the release will be published. A Press Kit for ReactOS 0.4.7 is already available: https://sourceforge.net/projects/reactos/files/ReactOS/0.4.7/ReactOS-0.4.7-… Feel free to send it to interested parties to let them know about the upcoming release in advance. Best regards, Colin Finck

4 4

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [NTOS:MM] Fix NtFreeVirtualMemory() FreeType parameter checks. CORE-13126
by Alex Ionescu 16 Dec '17

16 Dec '17

I'm unsure how reducing the two explicit checks into a single one is a better decision. This is much less scalable and much less clear of what the caller did wrong. I'd like to see the old checks (correctly) restored. Best regards, Alex Ionescu On Fri, Dec 15, 2017 at 2:58 AM, Serge Gautherie < reactos-git_serge_171003(a)gautherie.fr> wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h= > 614ace03fa4ec1957f32727ab0975a98c858894d > > commit 614ace03fa4ec1957f32727ab0975a98c858894d > Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> > AuthorDate: Sat Dec 9 12:16:44 2017 +0100 > > [NTOS:MM] Fix NtFreeVirtualMemory() FreeType parameter checks. > CORE-13126 > --- > ntoskrnl/mm/ARM3/virtual.c | 20 +++++--------------- > 1 file changed, 5 insertions(+), 15 deletions(-) > > diff --git a/ntoskrnl/mm/ARM3/virtual.c b/ntoskrnl/mm/ARM3/virtual.c > index 0e5fe77a23..fc4ea2e6d2 100644 > --- a/ntoskrnl/mm/ARM3/virtual.c > +++ b/ntoskrnl/mm/ARM3/virtual.c > @@ -5108,21 +5108,11 @@ NtFreeVirtualMemory(IN HANDLE ProcessHandle, > PAGED_CODE(); > > // > - // Only two flags are supported > + // Only two flags are supported, exclusively. > // > - if (!(FreeType & (MEM_RELEASE | MEM_DECOMMIT))) > + if (FreeType != MEM_RELEASE && FreeType != MEM_DECOMMIT) > { > - DPRINT1("Invalid FreeType\n"); > - return STATUS_INVALID_PARAMETER_4; > - } > - > - // > - // Check if no flag was used, or if both flags were used > - // > - if (!((FreeType & (MEM_DECOMMIT | MEM_RELEASE))) || > - ((FreeType & (MEM_DECOMMIT | MEM_RELEASE)) == (MEM_DECOMMIT | > MEM_RELEASE))) > - { > - DPRINT1("Invalid FreeType combination\n"); > + DPRINT1("Invalid FreeType (0x%08lx)\n", FreeType); > return STATUS_INVALID_PARAMETER_4; > } > > @@ -5200,8 +5190,8 @@ NtFreeVirtualMemory(IN HANDLE ProcessHandle, > } > } > > - DPRINT("NtFreeVirtualMemory: Process 0x%p, Adress 0x%p, size 0x%x, > FreeType %x.\n", > - Process, PBaseAddress, PRegionSize, FreeType); > + DPRINT("NtFreeVirtualMemory: Process 0x%p, Address 0x%p, Size 0x%Ix, > FreeType 0x%08lx\n", > + Process, PBaseAddress, PRegionSize, FreeType); > > // > // Lock the address space > >

1 0

[ros-diffs] [reactos] 01/01: [SDK] pnp.idl: Add a reminder comment about removed Vista/+ functions. CORE-12580
by James Tabor 15 Dec '17

15 Dec '17

Hi, Let's try not removing (ZAPPING) API due to future use okay? Just #if it out with the correct __NTZYX__ thing. So if I wish to have VISTA or Server 201X, I can select it while running the configuration script. Do it this way so someone could select Server 2003 (Default now) later on. Same or better TEAM! Think about what will be needed later on. ZAPPING OUT! James

1 0

PineappleFund
by Alexander Shaposhnikov 14 Dec '17

14 Dec '17

Hi all! Recenly a new Reddit post came up on #reactos IRC: https://redd.it/7jj0oa. Interesting stuff. A person is giving away ~5000 BTC for charitable causes. We can apply via the website but it must be done by someone from ReactOS e.V. -- Cheers, Alexander Shaposhnikov

9 11

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev