Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [CRT] fix bug in _rotr implementation
by Jerome Gardou 28 Oct '17

28 Oct '17

Hmpf, somehow the change on my github profile was messed up. Sorry about that, the next commit should be under my real name. Jérôme Le 28/10/2017 à 10:28, zefklop a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=07c72955457267ee26f60… > > commit 07c72955457267ee26f6086e75c5595fbce76e06 > Author: zefklop <zefklop(a)users.noreply.github.com> > AuthorDate: Sat Oct 28 10:28:27 2017 +0200 > > [CRT] fix bug in _rotr implementation > --- > sdk/lib/crt/stdlib/rot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sdk/lib/crt/stdlib/rot.c b/sdk/lib/crt/stdlib/rot.c > index 825a76d3ed..7637a5e9b6 100644 > --- a/sdk/lib/crt/stdlib/rot.c > +++ b/sdk/lib/crt/stdlib/rot.c > @@ -38,7 +38,7 @@ unsigned int _rotr( unsigned int value, int shift ) > if ( shift < 0 ) > return _rotl(value,-shift); > > - if ( shift > max_bits<<3 ) > + if ( shift > max_bits ) > shift = shift % max_bits; > return (value >> shift) | (value << (max_bits-shift)); > } >

1 0

Status Meeting (October 2017)
by Giannis Adamopoulos 26 Oct '17

26 Oct '17

Hi all! Let me invite you to the monthly status meeting taking place today, October 26, 19:00 UTC. As of now we know that both Colin and Pierre will not be able to attend, or be able to control our IRC server so unless we get any further notice from either of them, the meeting will take place in #reactos-meeting in freenode. No agenda proposals have been submitted to me so far. You are welcome to suggest some points to discuss. One that I would like to propose is about the upcoming release that should be branched soon. Of course we will have our status reports. So please have them ready, so we get it done quickly! Giannis

3 2

JIRA up again - Do we still need FishEye?
by Colin Finck 16 Oct '17

16 Oct '17

Hi all! Our two Atlassian tools JIRA and FishEye have been unavailable for some hours again. I have brought JIRA back up, but FishEye has been eating RAM and CPU like crazy again. In my opinion, this is unacceptable for a tool that is just a simple commit browser to us. Also I don't have any time to constantly monitor it this weekend, so I'm leaving it shut down for now. With us having https://github.com/reactos/reactos/commits/master and https://git.reactos.org/?p=reactos.git;a=summary now, do we still need FishEye at all? If so, please tell me what features of it you would miss if it stays down. Maybe there are other alternatives. My last FishEye "performance" bug report took 3 months to resolve, and I'm reluctant to go the same route again for another such bug.. Cheers, Colin

3 2

Question about commits with no commit log, or commits with no files but just the log, on Git.
by Hermès BÉLUSCA - MAÏTO 16 Oct '17

16 Oct '17

‌Hello all,<br> <br> After having noticed https://github.com/reactos/reactos/commit/50ae5e7c5268222718174221366169e2b…<br> I am wondering whether it is possible to add mechanisms (like git pre-commit hooks) that check for, and<br> prevent potential problematic commits like, commits without commit log, or commits with no files (but with a log).<br> <br> Any ideas?<br> <br> Cheers,<br> Hermes

4 3

Testing Pull Requests
by Colin Finck 14 Oct '17

14 Oct '17

Hi all! Apart from basic build testing through AppVeyor and Travis-CI, you can now also run all regression tests for the code belonging to a Pull Request. Just log in to our BuildBot at https://build.reactos.org with your development account credentials (formerly "SVN credentials"), select a builder in the waterfall view and fill the field "Branch" in the "Force a Build" section. You have two options here: * "refs/pull/<ID>/head" Builds your branch, unmodified. That means, if you haven't kept your branch up to date with the main ReactOS repo, latest changes won't be included. * "refs/pull/<ID>/merge" Builds the changes of your branch merged to the main ReactOS repo. That means, latest changes in the main ReactOS repo will be included. Replace <ID> by the number of your Pull Request. As the resulting hash may be hard to predict, the "prepare source" step will now give detailed information about the latest commit included in your build: https://build.reactos.org/builders/Build%20GCCLin_x86/builds/19201/steps/pr… Have fun! Colin

3 3

GitHub Newbie Question
by Hermès BÉLUSCA - MAÏTO 10 Oct '17

10 Oct '17

<span style="font-family:arial,helvetica,sans-serif; font-size:12px">‌Hi all,<br> <br> I've a newbie question related to GitHub pull requests: How can one see whether commits pertaining to a pull request have both a valid full committer name and email set? So far I can only see the nicknames.<br> <br> Cheers,<br> Hermes</span>

3 2

Re: [ros-dev] GitHub Newbie Question
by hermes.belusca＠sfr.fr 10 Oct '17

10 Oct '17

<span style="font-family:arial,helvetica,sans-serif; font-size:12px">Oops yeah sorry, it was about "author name", not committer name. But you've understood my point.<br> Thanks!</span><br>   <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : gigaherz(a)gmail.com<br> A : hermes.belusca@sfr.fr,ros-dev@reactos.org<br> Envoyé: mardi 10 octobre 2017 12:06<br> Objet : Re: [ros-dev] GitHub Newbie Question<br>   <div class="gl_quoted">Open the commit URL, such as https://github.com/reactos/reactos/commit/44060c284194546703805453f3985ed2b…, but with .patch appended to the end. This shows the author name as part of the "From:" line. The commiter doens't matter since it will be set to whoever presses the merge button. On 10 October 2017 at 11:56, Hermès BÉLUSCA - MAÏTO wrote: > ‌Hi all, > > I've a newbie question related to GitHub pull requests: How can one see > whether commits pertaining to a pull request have both a valid full > committer name and email set? So far I can only see the nicknames. > > Cheers, > Hermes > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: Fix remaining text file line endings in the tree. (#18)
by Colin Finck 06 Oct '17

06 Oct '17

Sorry for the huge diff E-Mail to ros-diffs! I have just configured git_multimail.py to a maximum of 5000 lines to not let that happen again. We can again reduce the limit later on if it turns out to be still too much. Best regards, Colin Finck

1 0

Re: [ros-dev] ReactOS Repository migrated to GitHub
by Can Tasan 04 Oct '17

04 Oct '17

Congrats for switching into Github! Just a little question. Is there any way to return using revision numbers? Current hash-based commit tagging might be confusing, hard to find, not reflecting at-the-time state of development since we have relied on SVN for a long time. Also for bug reporting, revision numbers is more helpful. Secondly, for example, Wine don't (and probably won't) care for hashes as everyone out there uses release builds, and release period is just 2 weeks. That's not the case for ReactOS. In just a few commits big changes might occur, and everyone retests. 3 months? Avalanche! If it isn't viable, could we seek for another solution? (e.g timestamp...) Lastly, git.reactos.org is quite simple for watching the stream, and perfect! Best regards, Can

2 1

Re: [ros-dev] ReactOS Repository migrated to GitHub
by hermes.belusca＠sfr.fr 03 Oct '17

03 Oct '17

<span style="font-family: arial,helvetica,sans-serif; font-size: 12px;">Ahah!! Correct, you've a watchful eye!<br> Thank you very much!<br> <br> Hermès.‌</span> <div class="gl_quote" style="padding-top: 5px; margin-top: 20px;">De : magnusjjj(a)gmail.com<br> A : ros-dev(a)reactos.org<br> Envoyé: mardi 3 octobre 2017 20:09<br> Objet : Re: [ros-dev] ReactOS Repository migrated to GitHub<br>   <div class="gl_quoted"> <div dir="ltr">Are they not under the branches dropdown? Top left, three columns down? There is a handy drop down there. There are at least all the gsoc's, and a ton of other branches there? :). Check it out?</div> <div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2">  <table style="border-top-color: rgb(211, 212, 222); border-top-width: 1px; border-top-style: solid;"> <tbody> <tr> <td style="width: 55px; padding-top: 13px;"><a href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&ut…" target="_blank"><img width="46" height="29" style="width: 46px; height: 29px;" alt="" src="https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-anima…"></a></td> <td style="width: 470px; color: rgb(65, 66, 78); line-height: 18px; padding-top: 12px; font-family: Arial,Helvetica,sans-serif; font-size: 13px;">Virus-free. <a style="color: rgb(68, 83, 234);" href="https://www.avast.com/sig-email?utm_medium=email&utm_source=link&ut…" target="_blank">www.avast.com</a></td> </tr> </tbody> </table> </div> <div class="gmail_extra">  <div class="gmail_quote">2017-10-03 19:45 GMT+02:00 Hermès BÉLUSCA-MAÏTO <span dir="ltr"><<a href="mailto:hermes.belusca@sfr.fr" target="_blank">hermes.belusca(a)sfr.fr</a>></span>: <blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;">Thank you very much Colin !! \o/ \o/ \o/ \o/<br> <br> A little question, although: Where are our (experimental) branches now? :P<br> <br> Hermès<br> <br> > -----Message d'origine-----<br> > De : Ros-dev [mailto:<a href="mailto:ros-dev-bounces@reactos.org">ros-dev-bounces@<wbr>reactos.org</a>] De la part de Colin Finck<br> > Envoyé : mardi 3 octobre 2017 19:40<br> > À : <a href="mailto:ros-announce@reactos.org">ros-announce(a)reactos.org</a>; <a href="mailto:ros-general@reactos.org">ros-general(a)reactos.org</a>; 'ReactOS<br> > Development List'<br> > Objet : [ros-dev] ReactOS Repository migrated to GitHub <div class="HOEnZb"> <div class="h5">><br> > Today, the ReactOS Source Code has been migrated from a central Subversion<br> > instance to a decentralized Git repository. Together with that, ReactOS joins the<br> > list of projects using the popular GitHub service for developing software:<br> > <a href="https://github.com/reactos/reactos" target="_blank" rel="noreferrer">https://github.com/reactos/<wbr>reactos</a><br> > We expect that this move greatly improves the way we collaborate on ReactOS<br> > development and reduces the barriers for newcomers. Just fork our repository<br> > on GitHub, commit your changes and send us a Pull Request!<br> ><br> > Migrating a source code history of more than 20 years that had seen multiple<br> > version control systems was not a straightforward task.<br> > Deciding on a decentralized version control system has not been either.<br> > First discussions already started back in 2009, when neither Git nor Mercurial<br> > were able to fully convert a large SVN repository like ours and Git’s Windows<br> > support was still neglected. Things improved massively over the years, with<br> > GitHub and Git for Windows emerging as reliable tools for software<br> > development. But the ReactOS Project still took advantage of some Subversion<br> > features, so only a smooth migration using a two-way SVN-Git mirror was<br> > attempted in 2016. This failed miserably, however important lessons were<br> > learned for a future complete migration to Git. The tipping point was reached<br> > in early 2017 when a majority of ReactOS developers spoke out in favor of<br> > moving to Git. Finally, the ReactOS Hackfest in August offered a forum to try<br> > out things and discuss every little detail of the planned migration. And this is<br> > what got us here today!<br> ><br> > The development documentation is still in the process of being rewritten to<br> > account for the Git migration. You may currently find outdated information<br> > here and there. However, most of that is on the Wiki, so you are more than<br> > welcome to help us!<br> > The SVN Repository has been turned read-only and will be kept online for a<br> > while at the last revision r76032. Our Git mirror now mirrors the GitHub<br> > repository. If you have already been using our old Git mirror, please note that<br> > you have to do a fresh clone of our new repository (from either GitHub or the<br> > mirror) as the old and new ones are incompatible.<br> > JIRA continues to be used for bug tracking, BuildBot for continuous integration,<br> > and FishEye as a code browser.<br> ><br> > I would like to thank all the people who have helped with this migration, be it<br> > on IRC, the mailing lists or at the Hackfest! Special thanks also go to the KDE<br> > Project for their excellent svn-all-fast-export tool that was used for the<br> > conversion. If you are ever in a similar situation, have a look at my conversion<br> > scripts as well as the Git helpers for our infrastructure.<br> ><br> ><br> > Colin Finck<br> ><br> > ______________________________<wbr>_________________<br> > Ros-dev mailing list<br> > <a href="mailto:Ros-dev@reactos.org">Ros-dev(a)reactos.org</a><br> > <a href="http://www.reactos.org/mailman/listinfo/ros-dev" target="_blank" rel="noreferrer">http://www.reactos.org/<wbr>mailman/listinfo/ros-dev</a><br> <br> <br> ______________________________<wbr>_________________<br> Ros-dev mailing list<br> <a href="mailto:Ros-dev@reactos.org">Ros-dev(a)reactos.org</a><br> <a href="http://www.reactos.org/mailman/listinfo/ros-dev" target="_blank" rel="noreferrer">http://www.reactos.org/<wbr>mailman/listinfo/ros-dev</a></div> </div> </blockquote> </div> </div> <br> <br> <br> _______________________________________________<br> Ros-dev mailing list<br> Ros-dev(a)reactos.org<br> http://www.reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev