Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 17 Feb '09

17 Feb '09

Well, there should be some limit of the number of parentheses, you will probably not want to use them in the a + b * c expression.

2 1

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 17 Feb '09

17 Feb '09

> I personally feel consistent application of the style is also important, > and that there does not exist a reason to deviate from the established > coding style in this situation. I agree that it is good to follow the consistent coding style. The question is this style itself is good. I meant the abstract case of ((a = b) && (c = d)), not the concrete case of ((ConvKey == HashEntry->ConvKey) && (Length == Ncb->NameLength)).

2 1

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 17 Feb '09

17 Feb '09

Actually, no reasons were given to use extra parentheses *in this case*. Past mistakes do not justify future mistakes.

2 1

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

> This is just a one-off case of a silly programming error. Many such one-off cases were discovered, though not in your code. :)

1 0

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

Why this 'fix' is needed? For MSVC?

2 1

Re: [ros-dev] [ros-diffs] [arty] 39613: Fix loopback adapter locking and make traffic work consistently. Fix zero-address binding. Local tcp services should work now.
by Steven Edwards 16 Feb '09

16 Feb '09

Hi Arty! On Sun, Feb 15, 2009 at 4:52 PM, <arty(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=39613&view=rev > Log: > Fix loopback adapter locking and make traffic work consistently. > Fix zero-address binding. > Local tcp services should work now. I take this to mean telnetd should be talking on the network now? Hello remote process control and the 1980's! Thanks a lot of looking in to this. When I have time I am going to do further cleanup of telnetd and move it in to the ReactOS tree proper. Next on my list is a tftp server I found which I will attempt to get license clarification on, cleanup and add to ReactOS so that we can look in to using ReactOS tftpd to support kickstart like deployment with netboot. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 39622: - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests
by Timo Kreuzer 16 Feb '09

16 Feb '09

This is yet another time where SEH is misused in user mode. Yes, you can see from OpenRCE call chains that ms is using SEH in that function, too. But the way it's used is not a good idea. EXCEPTION_EXECUTE_HANDLER eats all exceptions, including guard pages, invalid opcodes, etc. That's probably not what you want. For everyone wanting to use SEH in user mode I suggest reading this article: http://blogs.msdn.com/oldnewthing/archive/2006/09/27/773741.aspx Thanks, Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon Feb 16 06:07:27 2009 > New Revision: 39622 > > URL: http://svn.reactos.org/svn/reactos?rev=39622&view=rev > Log: > - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests > > Modified: > trunk/reactos/lib/rtl/unicode.c > > Modified: trunk/reactos/lib/rtl/unicode.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/unicode.c?rev=3962… > ============================================================================== > --- trunk/reactos/lib/rtl/unicode.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/unicode.c [iso-8859-1] Mon Feb 16 06:07:27 2009 > @@ -1559,56 +1559,56 @@ > IN ULONG Length, > IN OUT PCHAR String) > { > - NTSTATUS Status = STATUS_SUCCESS; > - ULONG Radix; > - CHAR temp[65]; > - ULONGLONG v = Value->QuadPart; > - ULONG i; > - PCHAR tp; > - PCHAR sp; > - > - Radix = Base; > - if (Radix == 0) > - Radix = 10; > - > - if ((Radix != 2) && (Radix != 8) && > - (Radix != 10) && (Radix != 16)) > - return STATUS_INVALID_PARAMETER; > - > - tp = temp; > - while (v || tp == temp) > - { > - i = v % Radix; > - v = v / Radix; > - if (i < 10) > - *tp = i + '0'; > - else > - *tp = i + 'A' - 10; > - tp++; > - } > - > - if ((ULONG)((ULONG_PTR)tp - (ULONG_PTR)temp) > Length) > - return STATUS_BUFFER_OVERFLOW; > - > - //_SEH2_TRY > - { > - sp = String; > - while (tp > temp) > - *sp++ = *--tp; > - > - if((ULONG)((ULONG_PTR)sp - (ULONG_PTR)String) < Length) > - *sp = 0; > - } > -#if 0 > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - /* Get the error code */ > - Status = _SEH2_GetExceptionCode(); > - } > - _SEH2_END; > -#endif > - > - return Status; > + ULONGLONG Val = Value->QuadPart; > + NTSTATUS Status = STATUS_SUCCESS; > + CHAR Buffer[65]; > + CHAR Digit; > + ULONG Len; > + PCHAR Pos; > + > + if (Base == 0) Base = 10; > + > + if ((Base != 2) && (Base != 8) && > + (Base != 10) && (Base != 16)) > + { > + return STATUS_INVALID_PARAMETER; > + } > + > + Pos = &Buffer[64]; > + *Pos = '\0'; > + > + do > + { > + Pos--; > + Digit = Val % Base; > + Val = Val / Base; > + if (Digit < 10) > + *Pos = '0' + Digit; > + else > + *Pos = 'A' + Digit - 10; > + } > + while (Val != 0L); > + > + Len = &Buffer[64] - Pos; > + > + if (Len > Length) > + return STATUS_BUFFER_OVERFLOW; > + > + _SEH2_TRY > + { > + if (Len == Length) > + RtlCopyMemory(String, Pos, Len); > + else > + RtlCopyMemory(String, Pos, Len + 1); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Get the error code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > + > + return Status; > } > > /* > > >

1 0

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().
by Dmitry Gorbachev 16 Feb '09

16 Feb '09

> By reformatting my code and breaking ReactOS > 1) Coding Style and 2) Commit Rules? I'm not sure, what, exactly, it breaks?

2 1

[ros-diffs] [khornicek] 39617: - add more pixel formats
by James Tabor 16 Feb '09

16 Feb '09

Hi, I know this is in a branch, but~ WINAPI DdUnlock(LPDDHAL_UNLOCKDATA Unlock) { + /* Fixme for opengl hel emulations */ + HEL_OGL_STUB; +#if 0 /* Call win32k */ return NtGdiDdUnlock((HANDLE)Unlock->lpDDSurface->hDDSurface, (PDD_UNLOCKDATA)Unlock); +#endif } It is a direct call and this is correct. Why if it out? Don't add non standard functionality to the gdi interface unless this is a upgrade from XP. Thanks, James

2 1

RosBE-Unix 1.4 is out!
by Colin Finck 14 Feb '09

14 Feb '09

Hello everyone, A new release of RosBE-Unix is finally available. It mostly features updated build tools compatible to the versions used in RosBE-Windows 1.4 and initial multi-architecture support through additional RosBE-Unix packages (which still don't exist though :P) I highly recommend the update, because our previous binutils contains a critical bug in dlltool. (see http://sourceware.org/bugzilla/show_bug.cgi?id=9766 for details) Some components affected by that bug were our msvcrt*.dll and mapi32.dll. The new release is now available from SourceForge, just like RosBE-Windows (https://sourceforge.net/project/showfiles.php?group_id=6553&package_id=3084 58) Best regards, Colin

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev