Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] Ros-dev Digest, Vol 53, Issue 30

by Olaf Siejka

"Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8" I have a suggestion - we should limit the amount of people that are allowed to actually write the results to some designated people and let everyone pass the results to them.

15 years, 8 months

0.3.8 Test Season has started :-)

by Colin Finck

Hello everybody (and especially the testers), After nobody complained about branching 0.3.8 from trunk now, I took the initiative today and prepared the branch with our usual customizations and hacks. It's now again the time for application testing. Therefore I uploaded Boot CD and Live CD of the current branch to http://reactos.colinfinck.de/ Please test them, especially with the applications in Downloader, and write your results to http://www.reactos.org/wiki/index.php/Tests_for_0.3.8 I especially write this now, because we want the release to be ready some days before FOSDEM. Andrew wants to start burning the CDs for FOSDEM soon, so it would be great if we could get the entire release done till *next Monday*. Best regards, Colin

15 years, 8 months

[ros-diffs] [cfinck] 39188: Hack: Copy the toolbar image on our own instead of using CopyImage to hackfix the messed up toolbar graphics as it was done for previous releases.

by James Tabor

Hi! This is what I've been fighting (BITMAP) with! I should have read this in previous releases. Take note! Thanks, James --- branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] (original) +++ branches/ros-branch-0_3_8/reactos/dll/win32/comctl32/toolbar.c [iso-8859-1] Wed Jan 28 15:11:36 2009 @@ -2659,7 +2659,33 @@ TRACE("adding hInst=%p nID=%d nButtons=%d\n", bitmap->hInst, bitmap->nID, bitmap->nButtons); /* Add bitmaps to the default image list */ if (bitmap->hInst == NULL) /* a handle was passed */ - hbmLoad = CopyImage(ULongToHandle(bitmap->nID), IMAGE_BITMAP, 0, 0, 0); + { + BITMAP bmp; + HBITMAP hOldBitmapBitmap, hOldBitmapLoad; + HDC hdcImage, hdcBitmap; + + /* copy the bitmap before adding it so that the user's bitmap + * doesn't get modified. + */ + GetObjectW ((HBITMAP)bitmap->nID, sizeof(BITMAP), (LPVOID)&bmp); + + hdcImage = CreateCompatibleDC(0); + hdcBitmap = CreateCompatibleDC(0); + + /* create new bitmap */ + hbmLoad = CreateBitmap (bmp.bmWidth, bmp.bmHeight, bmp.bmPlanes, bmp.bmBitsPixel, NULL); + hOldBitmapBitmap = SelectObject(hdcBitmap, (HBITMAP)bitmap->nID); + hOldBitmapLoad = SelectObject(hdcImage, hbmLoad); + + /* Copy the user's image */ + BitBlt (hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, + hdcBitmap, 0, 0, SRCCOPY); + + SelectObject (hdcImage, hOldBitmapLoad); + SelectObject (hdcBitmap, hOldBitmapBitmap); + DeleteDC (hdcImage); + DeleteDC (hdcBitmap); + } else hbmLoad = CreateMappedBitmap(bitmap->hInst, bitmap->nID, 0, NULL, 0);

15 years, 8 months

winetest note

by Ged

I've been using the Winetests in Windows quite a lot recently, both XP and Vista, and I've noticed that a lot of the tests fail in Windows. For anyone using the Winetests in reactos to fix our code, it's worth testing if these functions pass or fail in Windows first as we might be breaking reactos to pass the winetests. Also, one of the problems I've noticed is that some tests fail on XP but pass in Vista, and vice versa. Does anyone know Wine's target OS? It seems that more tests are passing in Vista than XP these days, so maybe they've moved to a more recent target? I think the best way to move forward with this is to find out what version Wine target, fix any broken tests we come across and submit them to Wine. I don't envisage any problem with Wine accepting fixed test cases, even from the most hated of reactos devs. Anyway, I just wanted to make people aware, _don't blindly trust Winetests when fixing reactos_ Ged.

15 years, 8 months

Re: [ros-dev] [ros-diffs] [hyperion] 39111: Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable.

by Timo Kreuzer

If you are going to do more work on rbuild, I'd suggest doing it in a branch to avoid clean rebuilds every few revisions. Timo hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Mon Jan 26 08:26:15 2009 > New Revision: 39111 > > URL: http://svn.reactos.org/svn/reactos?rev=39111&view=rev > Log: > Begin moving rules out of modulehandler.cpp and into makefile include rules.mak, where they will be more readable and manageable. Currently implemented: target C compiler and target C++ compiler rules. Please do a clean build if possible. Testing with unusual output paths appreciated > >

15 years, 8 months

TEB

by James Tabor

Hi, The TEB in psdk/winternl.h does not match with the correct one in ndk/pstypes.h. Does anyone else see that as a problem or is it just me? If it is for wine, then it is wrong, need to implement it as it is in the SDK. Use it for the Tls fields only...... Thanks, James

15 years, 8 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 39040: Added notifications stuff to VCB

by Pierre SCHWEITZER

A general remark for this revision and r39033. FsRtlNotifyInitializeSync and CcInitializeCacheMap both raise exception in case of failure, instead of returning a status. Should we consider adding PSEH support and usage to the new driver? P. Schweitzer > Date: Fri, 23 Jan 2009 12:18:39 +0000 > To: ros-diffs(a)reactos.org > From: pschweitzer(a)svn.reactos.org > Subject: [ros-diffs] [pschweitzer] 39040: Added notifications stuff to VCB > > Author: pschweitzer > Date: Fri Jan 23 06:18:38 2009 > New Revision: 39040 > > URL: http://svn.reactos.org/svn/reactos?rev=39040&view=rev > Log: > Added notifications stuff to VCB > > Modified: > trunk/reactos/drivers/filesystems/fastfat_new/fat.c > trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h > _________________________________________________________________ Téléphonez gratuitement à tous vos proches avec Windows Live Messenger ! Téléchargez-le maintenant ! http://www.windowslive.fr/messenger/1.asp

15 years, 8 months

Use kernel types in include files?

by Jun Koi

Hi, I am working on a project to parse the Windows image file. To do that, I must understand the structure of some Windows components, like _EPROCESS. So I took some headers from ReactOS, and write *userland* code like below: ---- #include <pstypes.h> #include <stdio.h> int main() { printf("size of EPROCESS: %d\n", sizeof(struct _EPROCESS)); return 0; } ---- The I got the problem: g++ reported that _EPROCESS is incomplete. Clearly this means it doesnt see the structure _EPROCESS, so I took a closer look, and found that _EPROCESS is not defined in user-mode (NTOS_MODE_USER). I tried to fix it by putting #undef NTOS_MODE_USER in front of #include <pstypes>, but that doesnt help. Anybody please tell me if there is any way to fix this? I think I can fix that by modifying the original headers. but that is way too ugly. Many thanks, Jun

15 years, 8 months

Re: [ros-dev] [ros-diffs] [hyperion] 39010: modified tools/rbuild/module.cpp modified tools/rbuild/project.cpp modified tools/rbuild/project.dtd modified tools/rbuild/rbuild.h New per-project property allowwarnings overrides allowwarnings property of all modules in the project

by Timo Kreuzer

I thought it was made clear already... ReactOS code : no warnings, 3rd party code: allow warnings! This switch is of no use. Timo hyperion(a)svn.reactos.org schrieb: > Author: hyperion > Date: Thu Jan 22 05:55:12 2009 > New Revision: 39010 > > URL: http://svn.reactos.org/svn/reactos?rev=39010&view=rev > Log: > modified tools/rbuild/module.cpp > modified tools/rbuild/project.cpp > modified tools/rbuild/project.dtd > modified tools/rbuild/rbuild.h > New per-project property allowwarnings overrides allowwarnings property of all modules in the project > > Modified: > trunk/reactos/tools/rbuild/module.cpp > trunk/reactos/tools/rbuild/project.cpp > trunk/reactos/tools/rbuild/project.dtd > trunk/reactos/tools/rbuild/rbuild.h > > Modified: trunk/reactos/tools/rbuild/module.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/module.cpp?re… > ============================================================================== > --- trunk/reactos/tools/rbuild/module.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/module.cpp [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -452,6 +452,8 @@ > } > if ( att != NULL ) > allowWarnings = att->value == "true"; > + else if ( project.allowWarningsSet ) > + allowWarnings = project.allowWarnings; > else > allowWarnings = false; > > > Modified: trunk/reactos/tools/rbuild/project.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/project.cpp?r… > ============================================================================== > --- trunk/reactos/tools/rbuild/project.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/project.cpp [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -298,6 +298,11 @@ > assert(att); > makefile = Environment::GetAutomakeFile ( att->value ); > > + att = node->GetAttribute ( "allowwarnings", false ); > + allowWarningsSet = att != NULL; > + if ( att != NULL ) > + allowWarnings = att->value == "true"; > + > size_t i; > for ( i = 0; i < node->subElements.size (); i++ ) > { > > Modified: trunk/reactos/tools/rbuild/project.dtd > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/project.dtd?r… > ============================================================================== > --- trunk/reactos/tools/rbuild/project.dtd [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/project.dtd [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -137,6 +137,7 @@ > <!ATTLIST project > name (ReactOS|Project) #REQUIRED > makefile %Text; #REQUIRED > + allowwarnings (true|false) "false" > xmlns:xi %Text; #FIXED "http://www.w3.org/2001/XInclude" > > > > > Modified: trunk/reactos/tools/rbuild/rbuild.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/rbuild.h?rev=… > ============================================================================== > --- trunk/reactos/tools/rbuild/rbuild.h [iso-8859-1] (original) > +++ trunk/reactos/tools/rbuild/rbuild.h [iso-8859-1] Thu Jan 22 05:55:12 2009 > @@ -237,6 +237,8 @@ > std::map<std::string, Module*> modules; > IfableData non_if_data; > IfableData host_non_if_data; > + bool allowWarnings; > + bool allowWarningsSet; > > Project ( const Configuration& configuration, > const std::string& filename, > > >

15 years, 8 months

Re: [ros-dev] [ros-diffs] [sginsberg] 38998: - Revert most of 38953. This was a bad idea, sorry.

by Pierre SCHWEITZER

Will the changes with Wine code remain? Or will they be reverted and the diffs reduced/deleted? P. Schweitzer > Date: Wed, 21 Jan 2009 14:41:24 +0000 > To: ros-diffs(a)reactos.org > From: sginsberg(a)svn.reactos.org > Subject: [ros-diffs] [sginsberg] 38998: - Revert most of 38953. This was a bad idea, sorry. > > Author: sginsberg > Date: Wed Jan 21 08:41:23 2009 > New Revision: 38998 > > URL: http://svn.reactos.org/svn/reactos?rev=38998&view=rev > Log: > - Revert most of 38953. This was a bad idea, sorry. > > Modified: > trunk/reactos/dll/win32/advpack/advpack.rbuild > trunk/reactos/dll/win32/atl/atl.rbuild > trunk/reactos/dll/win32/avifil32/avifil32.rbuild > trunk/reactos/dll/win32/browseui/browseui.rbuild > trunk/reactos/dll/win32/cabinet/cabinet.rbuild > trunk/reactos/dll/win32/clusapi/clusapi.rbuild > trunk/reactos/dll/win32/comcat/comcat.rbuild > trunk/reactos/dll/win32/comctl32/comctl32.rbuild > trunk/reactos/dll/win32/comdlg32/comdlg32.rbuild > trunk/reactos/dll/win32/compstui/compstui.rbuild > trunk/reactos/dll/win32/credui/credui.rbuild > trunk/reactos/dll/win32/crypt32/crypt32.rbuild > trunk/reactos/dll/win32/cryptdll/cryptdll.rbuild > trunk/reactos/dll/win32/cryptnet/cryptnet.rbuild > trunk/reactos/dll/win32/cryptui/cryptui.rbuild > trunk/reactos/dll/win32/dbghelp/dbghelp.rbuild > trunk/reactos/dll/win32/dciman32/dciman32.rbuild > trunk/reactos/dll/win32/dwmapi/dwmapi.rbuild > trunk/reactos/dll/win32/fusion/fusion.rbuild > trunk/reactos/dll/win32/gdiplus/gdiplus.rbuild > trunk/reactos/dll/win32/glu32/glu32.rbuild > trunk/reactos/dll/win32/hhctrl.ocx/hhctrl.ocx.rbuild > trunk/reactos/dll/win32/hlink/hlink.rbuild > trunk/reactos/dll/win32/imm32/imm32.rbuild > trunk/reactos/dll/win32/inetmib1/inetmib1.rbuild > trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild > trunk/reactos/dll/win32/jscript/jscript.rbuild > trunk/reactos/dll/win32/localui/localui.rbuild > trunk/reactos/dll/win32/lz32/lz32.rbuild > trunk/reactos/dll/win32/mapi32/mapi32.rbuild > trunk/reactos/dll/win32/mlang/mlang.rbuild > trunk/reactos/dll/win32/mpr/mpr.rbuild > trunk/reactos/dll/win32/mshtml/mshtml.rbuild > trunk/reactos/dll/win32/msi/msi.rbuild > trunk/reactos/dll/win32/msimg32/msimg32.rbuild > trunk/reactos/dll/win32/mstask/mstask.rbuild > trunk/reactos/dll/win32/msvcrt20/msvcrt20.rbuild > trunk/reactos/dll/win32/msvfw32/msvfw32.rbuild > trunk/reactos/dll/win32/nddeapi/nddeapi.rbuild > trunk/reactos/dll/win32/netapi32/netapi32.rbuild > trunk/reactos/dll/win32/ntdsapi/ntdsapi.rbuild > trunk/reactos/dll/win32/objsel/objsel.rbuild > trunk/reactos/dll/win32/odbccp32/odbccp32.rbuild > trunk/reactos/dll/win32/ole32/ole32.rbuild > trunk/reactos/dll/win32/oleacc/oleacc.rbuild > trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild > trunk/reactos/dll/win32/oleaut32/oleaut32_ros.diff > trunk/reactos/dll/win32/oledlg/oledlg.rbuild > trunk/reactos/dll/win32/olepro32/olepro32.rbuild > trunk/reactos/dll/win32/pdh/pdh.rbuild > trunk/reactos/dll/win32/printui/printui.rbuild > trunk/reactos/dll/win32/rasapi32/rasapi32.rbuild > trunk/reactos/dll/win32/riched20/riched20.rbuild > trunk/reactos/dll/win32/riched32/riched32.rbuild > trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild > trunk/reactos/dll/win32/rsabase/rsabase.rbuild > trunk/reactos/dll/win32/rsaenh/rsaenh.rbuild > trunk/reactos/dll/win32/schannel/schannel.rbuild > trunk/reactos/dll/win32/sensapi/sensapi.rbuild > trunk/reactos/dll/win32/setupapi/setupapi.rbuild > trunk/reactos/dll/win32/sfc/sfc.rbuild > trunk/reactos/dll/win32/sfc_os/sfc_os.rbuild > trunk/reactos/dll/win32/shfolder/shfolder.rbuild > trunk/reactos/dll/win32/shlwapi/shlwapi.rbuild > trunk/reactos/dll/win32/spoolss/spoolss.rbuild > trunk/reactos/dll/win32/sxs/sxs.rbuild > trunk/reactos/dll/win32/syssetup/syssetup.rbuild > trunk/reactos/dll/win32/tapi32/tapi32.rbuild > trunk/reactos/dll/win32/twain_32/twain_32.rbuild > trunk/reactos/dll/win32/urlmon/urlmon.rbuild > trunk/reactos/dll/win32/usp10/usp10.rbuild > trunk/reactos/dll/win32/uxtheme/uxtheme.rbuild > trunk/reactos/dll/win32/version/version.rbuild > trunk/reactos/dll/win32/winfax/winfax.rbuild > trunk/reactos/dll/win32/winspool/winspool.rbuild > trunk/reactos/dll/win32/wintrust/wintrust.rbuild > trunk/reactos/dll/win32/wldap32/wldap32.rbuild > trunk/reactos/dll/win32/wtsapi32/wtsapi32.rbuild > _________________________________________________________________ Téléphonez gratuitement à tous vos proches avec Windows Live Messenger ! Téléchargez-le maintenant ! http://www.windowslive.fr/messenger/1.asp

15 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev