Ros-dev

ros-dev@reactos.org

5790 discussions

[ros-diffs] [tkreuzer] 38673: Inline wrappers user32 -> NtUser
by Dmitry Gorbachev 10 Jan '09

10 Jan '09

> Well that was a workaround, because of "static declaration follows non > static declaration". > Then it needs to be done differently. But I don't see any good solution > that doesn't require lot's of hacks atm, except disabling that warning. It's ok atm. Attribute gnu_inline can be used to get old inline semantics.

2 1

[ros-bugs] [Bug 2451] Firefox 1.5 won't minimize to taskbar.
by James Tabor 10 Jan '09

10 Jan '09

Hi All! Just letting everyone know that a partial fix has been found by Dmitry aka Lentin, it is Dmitry? Well, I updated the bug report and the patch works to a point. FF does try to minimize and there is a hook bug exposed. Yes, not everything is fixed, since we use wine code, this was the reason for the patch. It corrects most of the message bugs related to wine tests. So this patch is going in soon and we need to cleanup the related code. I have a synced User32 Mdi.c that might require this patch to work. Just about the rest of the changes needed are wine sync/ports to user32/win32k. I would hope that everyone can help Dmitry/Lentin out and fix the rest of the SetWindowPos bugs. Some window position code in User32 still needing to be updated.. ;^) Thanks, James Ref: http://www.reactos.org/bugzilla/show_bug.cgi?id=2451

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 38678: - Fix 3 wine tests for OpenFile function
by Alex Ionescu 10 Jan '09

10 Jan '09

There's a constant for this INVALID_HANDLE_VALUE... On 10-Jan-09, at 7:33 AM, dchapyshev(a)svn.reactos.org wrote: > case 0xFFFFFFFF: /* File does not exist */ Best regards, Alex Ionescu

1 0

[ros-diffs] [tkreuzer] 38673: Inline wrappers user32 -> NtUser
by Dmitry Gorbachev 10 Jan '09

10 Jan '09

Hi! Why to use extern inline there, FORCEINLINE macro uses static. Extern inline — GCC extension — does not work as needed in c99/gnu99 mode (non-inline functions are emitted as well). GCC documentation says it will be the default in the future.

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call to kernel space
by Alex Ionescu 10 Jan '09

10 Jan '09

I totally disagree with this commit. Best regards, Alex Ionescu On Fri, Jan 9, 2009 at 6:33 AM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Fri Jan 9 05:33:50 2009 > New Revision: 38663 > > URL: http://svn.reactos.org/svn/reactos?rev=38663&view=rev > Log: > - Cleanup user32, direct call to kernel space > > Modified: > trunk/reactos/dll/win32/user32/controls/button.c > trunk/reactos/dll/win32/user32/controls/combo.c > trunk/reactos/dll/win32/user32/controls/edit.c > trunk/reactos/dll/win32/user32/controls/icontitle.c > trunk/reactos/dll/win32/user32/controls/listbox.c > trunk/reactos/dll/win32/user32/controls/scrollbar.c > trunk/reactos/dll/win32/user32/controls/static.c > trunk/reactos/dll/win32/user32/misc/dde.c > trunk/reactos/dll/win32/user32/misc/ddeserver.c > trunk/reactos/dll/win32/user32/misc/desktop.c > trunk/reactos/dll/win32/user32/misc/misc.c > trunk/reactos/dll/win32/user32/misc/object.c > trunk/reactos/dll/win32/user32/misc/stubs.c > trunk/reactos/dll/win32/user32/misc/timer.c > trunk/reactos/dll/win32/user32/misc/winsta.c > trunk/reactos/dll/win32/user32/user32.def > trunk/reactos/dll/win32/user32/windows/accel.c > trunk/reactos/dll/win32/user32/windows/bitmap.c > trunk/reactos/dll/win32/user32/windows/caret.c > trunk/reactos/dll/win32/user32/windows/clipboard.c > trunk/reactos/dll/win32/user32/windows/cursor.c > trunk/reactos/dll/win32/user32/windows/dc.c > trunk/reactos/dll/win32/user32/windows/defwnd.c > trunk/reactos/dll/win32/user32/windows/dialog.c > trunk/reactos/dll/win32/user32/windows/draw.c > trunk/reactos/dll/win32/user32/windows/input.c > trunk/reactos/dll/win32/user32/windows/mdi.c > trunk/reactos/dll/win32/user32/windows/menu.c > trunk/reactos/dll/win32/user32/windows/message.c > trunk/reactos/dll/win32/user32/windows/messagebox.c > trunk/reactos/dll/win32/user32/windows/nonclient.c > trunk/reactos/dll/win32/user32/windows/paint.c > trunk/reactos/dll/win32/user32/windows/window.c > trunk/reactos/dll/win32/user32/windows/winpos.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/dll/win32/user32/controls/button.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/combo.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/edit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/listbox.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/controls/static.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > > Modified: trunk/reactos/dll/win32/user32/misc/dde.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.… > > Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddes… > > Modified: trunk/reactos/dll/win32/user32/misc/desktop.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/desk… > > Modified: trunk/reactos/dll/win32/user32/misc/misc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc… > > Modified: trunk/reactos/dll/win32/user32/misc/object.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/obje… > > Modified: trunk/reactos/dll/win32/user32/misc/stubs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stub… > > Modified: trunk/reactos/dll/win32/user32/misc/timer.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/time… > > Modified: trunk/reactos/dll/win32/user32/misc/winsta.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/wins… > > Modified: trunk/reactos/dll/win32/user32/user32.def > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.de… > > Modified: trunk/reactos/dll/win32/user32/windows/accel.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/a… > > Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/b… > > Modified: trunk/reactos/dll/win32/user32/windows/caret.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/cursor.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… > > Modified: trunk/reactos/dll/win32/user32/windows/dc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/dialog.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/draw.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… > > Modified: trunk/reactos/dll/win32/user32/windows/input.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/i… > > Modified: trunk/reactos/dll/win32/user32/windows/mdi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/menu.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/message.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/n… > > Modified: trunk/reactos/dll/win32/user32/windows/paint.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/p… > > Modified: trunk/reactos/dll/win32/user32/windows/window.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… > > Modified: trunk/reactos/dll/win32/user32/windows/winpos.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… > >

7 11

GIT mirror
by Aleksey Bragin 09 Jan '09

09 Jan '09

Since Arty just mentioned GIT, I think it's about time to uncover a ReactOS GIT mirror I've been setting up recent couple of weeks. It works pretty good so far, autoupdates every 10 minutes, so it stays quite up-to-date. URLs: git://git.reactos.org/ - for git cloning. http://git.reactos.org - for web viewing. As for branches, it was actually my main intention in using a DVCS, because SVN branches are greatly uncomfortable to develop anything because of the need to keep the branch up-to-date. But, to prevent any gossips, SVN stays as our main repository, and GIT mirror is just for exploration of new possibilities, and for comfortability of working with branches - if someone wants to try that out. Usual SVN branches are still permitted. WBR, Aleksey Bragin.

11 28

Re: [ros-dev] [ros-diffs] [mjmartin] 38659: - Run process notification routines after successfully creating process.
by Alex Ionescu 09 Jan '09

09 Jan '09

Umm... Best regards, Alex Ionescu On Fri, Jan 9, 2009 at 1:13 AM, <mjmartin(a)svn.reactos.org> wrote: > Author: mjmartin > Date: Fri Jan 9 00:13:14 2009 > New Revision: 38659 > > URL: http://svn.reactos.org/svn/reactos?rev=38659&view=rev > Log: > - Run process notification routines after successfully creating process. > > Modified: > trunk/reactos/ntoskrnl/ps/process.c > > Modified: trunk/reactos/ntoskrnl/ps/process.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/process.c?rev=… > > ============================================================================== > --- trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] Fri Jan 9 00:13:14 > 2009 > @@ -822,6 +822,9 @@ > } > _SEH2_END; > > + /* Run the Notification Routines */ > + PspRunCreateProcessNotifyRoutines(Process, TRUE); > + > CleanupWithRef: > /* > * Dereference the process. For failures, kills the process and does > >

1 0

Cache / Memory Manager / FileSystemDrivers
by Aleksey Bragin 08 Jan '09

08 Jan '09

Hello, I recently spent some time experimenting with various Cc rewrites we have in our tree, and before that I extensively tested our fastfat driver in a real NT environment (MS Windows 2003). The conclusion of the above work is that our fastfat driver either needs serious bugfixing, or a rewrite is needed. It corrupts directory tables in a real NT, leads to unusual behaviour of cc- rewrite branch, and may have side effects on arty's newcc. Before this is done (bugfixing or rewriting, developing and testing against a Windows 2003 at least, not ReactOS), it's meaningless to continue any other work on Cc and related Mm parts. WBR, Aleksey Bragin.

9 14

[ros-diffs] [hyperion] 38621: PSEH can't make code exception-safe (yet). Add explicit "volatile"s where it might be necessary
by Dmitry Gorbachev 07 Jan '09

07 Jan '09

Maybe better to use a macro, something like _SEH2_VOLATILE, instead of a plain "volatile"?

1 0

[ros-diffs] [jimtabor] 38590: - Patch by Michael Martin: Fix for Get/Set CallProc.
by James Tabor 06 Jan '09

06 Jan '09

Hi all! Here is the test program provided by BugBoy. It also shows another bug, see bug 3971. Please test before and after the patch. Thanks, James PS Good Job, Michael!

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev