Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [dgorbachev] 27174: - Hackish solution of issue #2062. - Turn off title change, as it can cause a deadlock.
by Hervé Poussineau 15 Jun '07

15 Jun '07

Hi, > -----Message d'origine----- > De : ros-diffs-bounces(a)reactos.org > [mailto:ros-diffs-bounces@reactos.org] De la part de > dgorbachev(a)svn.reactos.org > Envoyé : jeudi 14 juin 2007 18:42 > À : ros-diffs(a)reactos.org > Objet : [ros-diffs] [dgorbachev] 27174: - Hackish solution of > issue #2062. - Turn off title change, as it can cause a deadlock. > > Author: dgorbachev > Date: Thu Jun 14 20:41:55 2007 > New Revision: 27174 > > URL: http://svn.reactos.org/svn/reactos?rev=27174&view=rev > Log: > - Hackish solution of issue #2062. > - Turn off title change, as it can cause a deadlock. > > Modified: > trunk/reactos/subsystems/win32/csrss/win32csr/conio.c > trunk/reactos/subsystems/win32/csrss/win32csr/dllmain.c > trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c > Why hiding the real cause of bug 2062 by a hack, as you already did in r27107 for bug 2151? See desktop icons in explorer bar. They are not correct and I know when it appeared and I known how to hack a solution. But I won't do it because I don't want to hide the real problem. IMO, you should do the same thing and search the root problem or leave the effect visible, so it won't be forgotten. If you really need to add a hack in the code, please add a comment in the C code linking to bugzilla, and add a comment in BZ saying "hackish solution committed in rXXXXX" Hervé

2 1

(no subject)
by Cam 15 Jun '07

15 Jun '07

Way to go devs! Device manager finally works!

1 0

Re: [ros-dev] Smaller SVN REL ISO?
by carlo.bramix 11 Jun '07

11 Jun '07

Unfortunately, I'm not able to compile myself. So I download the SVN ISO images for testing. I was just wondering if it could be possible to reduce a bit my download times by including that flag into the REL builds. I also agree that it's better to leave the DEB builds without that flag. Thanks anyways, if it's not possible I can still download compressed ISO files at their current sizes. Sincerely, Carlo Bramini ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ReactOS Development List" ros-dev(a)reactos.org Cc : Date : Mon, 11 Jun 2007 14:28:37 +0400 Subject : Re: [ros-dev] Smaller SVN REL ISO? > It is possible to compile with this flag, but you need to build it > yourself then. Official ISOs are compiled with leanandmean set to no. > > > WBR, > Aleksey Bragin. > > On Jun 11, 2007, at 1:06 PM, carlo.bramix wrote: > > > Is the SVN REL Live CD compiled with "set ROS_LEAN_AND_MEAN = yes"? > > If not, is it possible to compile it with this flag? > > For other purposes beside the normal user testing, we have the SVN > > DEB Live CD image. > > > > Sincerely, > > > > LDChen > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

Re: [ros-dev] Smaller SVN REL ISO?
by Aleksey Bragin 11 Jun '07

11 Jun '07

It is possible to compile with this flag, but you need to build it yourself then. Official ISOs are compiled with leanandmean set to no. WBR, Aleksey Bragin. On Jun 11, 2007, at 1:06 PM, carlo.bramix wrote: > Is the SVN REL Live CD compiled with "set ROS_LEAN_AND_MEAN = yes"? > If not, is it possible to compile it with this flag? > For other purposes beside the normal user testing, we have the SVN > DEB Live CD image. > > Sincerely, > > LDChen

1 0

Smaller SVN REL ISO?
by carlo.bramix 11 Jun '07

11 Jun '07

Is the SVN REL Live CD compiled with "set ROS_LEAN_AND_MEAN = yes"? If not, is it possible to compile it with this flag? For other purposes beside the normal user testing, we have the SVN DEB Live CD image. Sincerely, LDChen ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 27107: Fix issue #2151.
by Thomas Weidenmueller 11 Jun '07

11 Jun '07

Do you even know what you're doing? I've seen many commits where you call something a FIX and then just comment code out and add another FIXME.... dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Sun Jun 10 15:11:05 2007 > New Revision: 27107 > > URL: http://svn.reactos.org/svn/reactos?rev=27107&view=rev > Log: > Fix issue #2151. > > Modified: > trunk/reactos/ntoskrnl/mm/sysldr.c > > Modified: trunk/reactos/ntoskrnl/mm/sysldr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/sysldr.c?rev=2… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/sysldr.c (original) > +++ trunk/reactos/ntoskrnl/mm/sysldr.c Sun Jun 10 15:11:05 2007 > @@ -1767,7 +1767,7 @@ > NtHeader->OptionalHeader.AddressOfEntryPoint); > LdrEntry->SizeOfImage = DriverSize; > LdrEntry->CheckSum = NtHeader->OptionalHeader.CheckSum; > - LdrEntry->SectionPointer = LdrEntry; > + LdrEntry->SectionPointer = NULL; // ? > > /* Now write the DLL name */ > LdrEntry->BaseDllName.Buffer = (PVOID)(LdrEntry + 1); > > >

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 26483: Undo r26482 change, waste more stack space.
by Alex Ionescu 07 Jun '07

07 Jun '07

Perhaps you could try convincing the GCC folks to actually properly support declspec_align like MSVC does, instead of claiming to support it, but actually ignoring it. Then you could also convince them to support SEH, PDBs, STDCALL-default calling convention, etc ;) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: April-24-07 1:06 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 26483: Undo r26482 change, waste more stack space. Author: dgorbachev Date: Tue Apr 24 09:05:49 2007 New Revision: 26483 URL: http://svn.reactos.org/svn/reactos?rev=26483&view=rev Log: Undo r26482 change, waste more stack space. Modified: trunk/reactos/ntoskrnl/include/internal/ex.h Modified: trunk/reactos/ntoskrnl/include/internal/ex.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ex.h (original) +++ trunk/reactos/ntoskrnl/include/internal/ex.h Tue Apr 24 09:05:49 2007 @@ -106,9 +106,15 @@ // #ifdef __GNUC__ -#define DEFINE_WAIT_BLOCK(x) \ - PEX_PUSH_LOCK_WAIT_BLOCK x = __builtin_alloca(sizeof(EX_PUSH_LOCK_WAIT_BLOCK)); - +#define DEFINE_WAIT_BLOCK(x) \ + struct _AlignHack \ + { \ + UCHAR Hack[15]; \ + EX_PUSH_LOCK_WAIT_BLOCK UnalignedBlock; \ + } WaitBlockBuffer; \ + PEX_PUSH_LOCK_WAIT_BLOCK x = (PEX_PUSH_LOCK_WAIT_BLOCK) \ + ((ULONG_PTR)&WaitBlockBuffer.UnalignedBlock &~ 0xF); + #else // @@ -116,8 +122,8 @@ // local variable (the actual pointer) away, so we don't take any perf hit // by doing this. // -#define DEFINE_WAIT_BLOCK(x) \ - EX_PUSH_LOCK_WAIT_BLOCK WaitBlockBuffer; \ +#define DEFINE_WAIT_BLOCK(x) \ + EX_PUSH_LOCK_WAIT_BLOCK WaitBlockBuffer; \ PEX_PUSH_LOCK_WAIT_BLOCK x = &WaitBlockBuffer; #endif

11 19

Re: [ros-dev] About translation
by Aleksey 06 Jun '07

06 Jun '07

Hi Lucio, I must say, that there were a lot of efforts to get our tools working as easy as possible. Even a global login system was introduced way back so that you don't need to create an account for wiki, for bugzilla, for forum, for wiki, for the main website - you just create one. A lot of time was spent in order to do this (every piece of software needed to be customised - Ge and Klemens put a lot of their personal time into this). I will answer between the lines below so it makes better sense. ----- Original Message ----- From: "Lucio Diaz" <reactos_translate(a)yahoo.es> To: <ros-dev(a)reactos.org> Sent: Tuesday, April 17, 2007 2:08 AM Subject: [ros-dev] About translation -= skip =- > -Many like me can install SVN, and get the source > code, but never have made a patch, or even used > bugzilla(and probably wont have the time). If a contributor has SO small time that he can't even submit his work to a bugzilla or, at least, send a patch to a relevant person (the same language native speaker developer or another translator who has more time), then it's better to wait when he/she has more free time to contribute. -= skip =- > files, but sending them to bugzilla... i dont know how > to send them to bugzilla, i dont have a bugzilla > acount, it was tiring trying to find someone to send > the files, and i dont have the time or will to learn > bugzilla. That shows you really did not even slightly investigated how the website works. And instead you're proposing a whole workflow for developers, so they mandatory spent a few hours per week maintaining all the stuff you. During that 2 years you should have spent just a bit of time, even 20 minutes, to overview our website and systems we have there, and another 20 minutes to read online manuals/help for them. Excuses like "I didn't have time" hardly apply here. WBR, Aleksey Bragin.

3 2

RosBE Chatroom
by Daniel Reimer 29 May '07

29 May '07

Hi, I set up a Chatroom for RosBE (Windows/Linux) specific questions. Its on Freenode and is called #reactos-rosbe. I dont know if its so useful, but I was bored and thought this could be useful. Bye.

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 26893: Do not free the string twice.
by Aleksey Bragin 25 May '07

25 May '07

Actually, I removed the hack from IopCreateDriver, and added a loop to prevent creation of drivers with the same name (which actually have no impact on the servicekeynode). What is the real cause of a double free? And which hack are you referring to in IopCreateDriver? WBR, Aleksey Bragin. On May 25, 2007, at 9:10 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Fri May 25 21:10:11 2007 > New Revision: 26893 > > URL: http://svn.reactos.org/svn/reactos?rev=26893&view=rev > Log: > Do not free the string twice. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/driver.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/ > iomgr/driver.c?rev=26893&r1=26892&r2=26893&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Fri May 25 21:10:11 2007 > @@ -79,12 +79,14 @@ > ExFreePool(DriverObject->DriverName.Buffer); > } > > +#if 0 /* See a bit of hack in IopCreateDriver */ >

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev