Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [dgorbachev] 27107: Fix issue #2151.

by Thomas Weidenmueller

Do you even know what you're doing? I've seen many commits where you call something a FIX and then just comment code out and add another FIXME.... dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Sun Jun 10 15:11:05 2007 > New Revision: 27107 > > URL: http://svn.reactos.org/svn/reactos?rev=27107&view=rev > Log: > Fix issue #2151. > > Modified: > trunk/reactos/ntoskrnl/mm/sysldr.c > > Modified: trunk/reactos/ntoskrnl/mm/sysldr.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/sysldr.c?rev=2… > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/sysldr.c (original) > +++ trunk/reactos/ntoskrnl/mm/sysldr.c Sun Jun 10 15:11:05 2007 > @@ -1767,7 +1767,7 @@ > NtHeader->OptionalHeader.AddressOfEntryPoint); > LdrEntry->SizeOfImage = DriverSize; > LdrEntry->CheckSum = NtHeader->OptionalHeader.CheckSum; > - LdrEntry->SectionPointer = LdrEntry; > + LdrEntry->SectionPointer = NULL; // ? > > /* Now write the DLL name */ > LdrEntry->BaseDllName.Buffer = (PVOID)(LdrEntry + 1); > > >

17 years, 3 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 26483: Undo r26482 change, waste more stack space.

by Alex Ionescu

Perhaps you could try convincing the GCC folks to actually properly support declspec_align like MSVC does, instead of claiming to support it, but actually ignoring it. Then you could also convince them to support SEH, PDBs, STDCALL-default calling convention, etc ;) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: April-24-07 1:06 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 26483: Undo r26482 change, waste more stack space. Author: dgorbachev Date: Tue Apr 24 09:05:49 2007 New Revision: 26483 URL: http://svn.reactos.org/svn/reactos?rev=26483&view=rev Log: Undo r26482 change, waste more stack space. Modified: trunk/reactos/ntoskrnl/include/internal/ex.h Modified: trunk/reactos/ntoskrnl/include/internal/ex.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ex.h (original) +++ trunk/reactos/ntoskrnl/include/internal/ex.h Tue Apr 24 09:05:49 2007 @@ -106,9 +106,15 @@ // #ifdef __GNUC__ -#define DEFINE_WAIT_BLOCK(x) \ - PEX_PUSH_LOCK_WAIT_BLOCK x = __builtin_alloca(sizeof(EX_PUSH_LOCK_WAIT_BLOCK)); - +#define DEFINE_WAIT_BLOCK(x) \ + struct _AlignHack \ + { \ + UCHAR Hack[15]; \ + EX_PUSH_LOCK_WAIT_BLOCK UnalignedBlock; \ + } WaitBlockBuffer; \ + PEX_PUSH_LOCK_WAIT_BLOCK x = (PEX_PUSH_LOCK_WAIT_BLOCK) \ + ((ULONG_PTR)&WaitBlockBuffer.UnalignedBlock &~ 0xF); + #else // @@ -116,8 +122,8 @@ // local variable (the actual pointer) away, so we don't take any perf hit // by doing this. // -#define DEFINE_WAIT_BLOCK(x) \ - EX_PUSH_LOCK_WAIT_BLOCK WaitBlockBuffer; \ +#define DEFINE_WAIT_BLOCK(x) \ + EX_PUSH_LOCK_WAIT_BLOCK WaitBlockBuffer; \ PEX_PUSH_LOCK_WAIT_BLOCK x = &WaitBlockBuffer; #endif

17 years, 3 months

Re: [ros-dev] About translation

by Aleksey

Hi Lucio, I must say, that there were a lot of efforts to get our tools working as easy as possible. Even a global login system was introduced way back so that you don't need to create an account for wiki, for bugzilla, for forum, for wiki, for the main website - you just create one. A lot of time was spent in order to do this (every piece of software needed to be customised - Ge and Klemens put a lot of their personal time into this). I will answer between the lines below so it makes better sense. ----- Original Message ----- From: "Lucio Diaz" <reactos_translate(a)yahoo.es> To: <ros-dev(a)reactos.org> Sent: Tuesday, April 17, 2007 2:08 AM Subject: [ros-dev] About translation -= skip =- > -Many like me can install SVN, and get the source > code, but never have made a patch, or even used > bugzilla(and probably wont have the time). If a contributor has SO small time that he can't even submit his work to a bugzilla or, at least, send a patch to a relevant person (the same language native speaker developer or another translator who has more time), then it's better to wait when he/she has more free time to contribute. -= skip =- > files, but sending them to bugzilla... i dont know how > to send them to bugzilla, i dont have a bugzilla > acount, it was tiring trying to find someone to send > the files, and i dont have the time or will to learn > bugzilla. That shows you really did not even slightly investigated how the website works. And instead you're proposing a whole workflow for developers, so they mandatory spent a few hours per week maintaining all the stuff you. During that 2 years you should have spent just a bit of time, even 20 minutes, to overview our website and systems we have there, and another 20 minutes to read online manuals/help for them. Excuses like "I didn't have time" hardly apply here. WBR, Aleksey Bragin.

17 years, 3 months

RosBE Chatroom

by Daniel Reimer

Hi, I set up a Chatroom for RosBE (Windows/Linux) specific questions. Its on Freenode and is called #reactos-rosbe. I dont know if its so useful, but I was bored and thought this could be useful. Bye.

17 years, 4 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 26893: Do not free the string twice.

by Aleksey Bragin

Actually, I removed the hack from IopCreateDriver, and added a loop to prevent creation of drivers with the same name (which actually have no impact on the servicekeynode). What is the real cause of a double free? And which hack are you referring to in IopCreateDriver? WBR, Aleksey Bragin. On May 25, 2007, at 9:10 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Fri May 25 21:10:11 2007 > New Revision: 26893 > > URL: http://svn.reactos.org/svn/reactos?rev=26893&view=rev > Log: > Do not free the string twice. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/driver.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/ > iomgr/driver.c?rev=26893&r1=26892&r2=26893&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Fri May 25 21:10:11 2007 > @@ -79,12 +79,14 @@ > ExFreePool(DriverObject->DriverName.Buffer); > } > > +#if 0 /* See a bit of hack in IopCreateDriver */ >

17 years, 4 months

[ros-diffs] [jimtabor] 26877: - Fixed arithmetic semantics.

by jimtabor

Hi, Here is a test program. Thanks, James #include <stdio.h> #include <stdbool.h> #include <math.h> #include <float.h> //#define APIENTRY __stdcall #define APIENTRY //#define FASTCALL __fastcall #define FASTCALL #ifdef __GNUC__ #define FLOAT_TO_INT(in,out) \ __asm__ __volatile__ ("fistpl %0" : "=m" (out) : "t" (in) : "st"); #else #define FLOAT_TO_INT(in,out) \ __asm fld in \ __asm fistp out #endif /* the following deal with IEEE single-precision numbers */ #define EXCESS 126L #define SIGNBIT 0x80000000L #define SIGN(fp) ((fp) & SIGNBIT) #define EXP(fp) (((fp) >> 23L) & 0xFF) #define MANT(fp) ((fp) & 0x7FFFFFL) #define PACK(s,e,m) ((s) | ((e) << 23L) | (m)) typedef union // float_long { float f; unsigned long l; char c[4]; } gxf_long; #ifdef _X86_ typedef long FLOATL; #else /* !_X86_ */ typedef float FLOATL; #endif typedef struct _FLOATOBJ { unsigned long ul1; unsigned long ul2; } FLOATOBJ, *PFLOATOBJ; typedef struct _EFLOAT_S { long lMant; long lExp; } EFLOAT_S; //// //// void FASTCALL EF_Negate(EFLOAT_S * efp) { efp->lMant = -efp->lMant; } long FASTCALL EFtoF( EFLOAT_S * efp) { long Mant, Exp, Sign = 0; if (!efp->lMant) return 0; printf("EFtoF %x : %x\n", efp->lMant, efp->lExp); Mant = efp->lMant; Exp = efp->lExp; Sign = SIGN(efp->lMant); //// M$ storage emulation if( Sign ) Mant = -Mant; Mant = ((Mant & 0x3fffffff)>>7); Exp += (EXCESS-1); //// Mant = MANT(Mant); return PACK(Sign, Exp, Mant); } void FASTCALL FtoEF( EFLOAT_S * efp, FLOATL f) { long Mant, Exp, Sign = 0; gxf_long worker; printf("FtoEF\n"); #ifdef _X86_ worker.l = f; // It's a float stored in a long. #else worker.f = f; #endif Exp = EXP(worker.l); Mant = MANT(worker.l); if (SIGN(worker.l)) Sign = -1; //// M$ storage emulation Mant = ((Mant << 7) | 0x40000000); Mant ^= Sign; // invert/mask it Mant -= Sign; // sub it Exp -= (EXCESS-1); //// efp->lMant = Mant; efp->lExp = Exp; } void APIENTRY FLOATOBJ_Neg ( PFLOATOBJ pf ) { EFLOAT_S * efp = (EFLOAT_S *)pf; EF_Negate(efp); } long APIENTRY FLOATOBJ_GetFloat ( PFLOATOBJ pf ) { EFLOAT_S * efp = (EFLOAT_S *)pf; return EFtoF(efp); } void APIENTRY FLOATOBJ_SetFloat( PFLOATOBJ pf, FLOATL f ) { EFLOAT_S * efp = (EFLOAT_S *)pf; FtoEF( efp, f); } long APIENTRY FLOATOBJ_GetLong( PFLOATOBJ pf ) { EFLOAT_S * efp = (EFLOAT_S *)pf; gxf_long f; long l; f.l = EFtoF( efp ); FLOAT_TO_INT(f.f, l); // Let FPP handle it the fasty haxy way. return l; } void APIENTRY FLOATOBJ_SetLong( PFLOATOBJ pf, long l ) { EFLOAT_S * efp = (EFLOAT_S *)pf; gxf_long f; f.f = (float) l; // Convert it now. #ifdef _X86_ FtoEF( efp, f.l ); #else FtoEF( efp, f.f ); #endif } long FT_FixedFromFloat(float f) { short value = f; unsigned short fract = (f - value) * 0xFFFF; return (long)((long)value << 16 | (unsigned long)fract); } double F2F(PFLOATOBJ f) { printf("F2F --> %x : %x\n", f->ul1, f->ul2); if(SIGN(f->ul1)) // negate mant return (double) -(-f->ul1 * pow(2,(double)f->ul2-32)); else return (double) f->ul1 * pow(2,(double)f->ul2-32); } void Test_It(float fx) { FLOATOBJ pf; gxf_long f; f.f = fx; printf("Start 1 %f\n", f.f); printf(" 2 %x\n", f.l); #ifdef _X86_ FLOATOBJ_SetFloat( &pf, f.l ); #else FLOATOBJ_SetFloat( &pf, f.f ); #endif // FLOATOBJ_Neg ( &pf ); f.l = FLOATOBJ_GetFloat ( &pf ); printf("Fin 1 %f\n",f.f); printf("Fin 2 %x\n",f.l); printf("F2F --> %f\n\n",F2F( &pf )); } // // gcc -Os fpms.c -o f -lm // or // gcc -Os -D_X86_ fpms.c -o f -lm // main() { gxf_long f; f.f = 1.0; Test_It(f.f); f.f = -1.0; Test_It(f.f); f.f = 2.0; Test_It(f.f); f.f = -2.0; Test_It(f.f); f.f = 1.5; Test_It(f.f); f.f = -1.5; Test_It(f.f); f.f = 1235.0; Test_It(f.f); f.f = -1235.0; Test_It(f.f); f.f = 1235678.9; // Max it Test_It(f.f); f.f = -1235678.9; Test_It(f.f); }

17 years, 4 months

Suggestion for making things a bit smaller

by carlo.bramix

When building the release versions of executables, DLLs, etc, I would suggest to add the "-s" switch to the linker flags. It will do stripping automatically and release-mode objects will be a bit smaller. Alternatively, we could "strip -s file.exe" but just adding the flag would be much simpler. Sincerely, Carlo Bramini. ------------------------------------------------------ Passa a Infostrada. ADSL e Telefono senza limiti e senza canone Telecom http://click.libero.it/infostrada

17 years, 4 months

Re: [ros-dev] QEMU support broken!!!

by carlo.bramix

>From livecd-26861-rel it runs again under QEMU. Last tested image is livecd-26871-rel. Great job! Sincerely, Carlo Bramini. ---------- Initial Header ----------- >From : ros-dev-bounces(a)reactos.org To : "ros-dev" ros-dev(a)reactos.org Cc : Date : Fri, 11 May 2007 17:21:55 +0200 Subject : Re: [ros-dev] QEMU support broken!!! > I just wanted to tell you that I downloaded and tested livecd-26700-rel.7z and it doesn't work yet. > > Sincerely, > > Carlo Bramini > > ---------- Initial Header ----------- > > >From : ros-dev-bounces(a)reactos.org > To : "ReactOS Development List" ros-dev(a)reactos.org > Cc : > Date : Fri, 11 May 2007 07:16:05 +0000 > Subject : Re: [ros-dev] QEMU support broken!!! > > > I also have a problem with booting LiveCD. > > Bugcheck in cmcontrl.c, line 151. > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > ------------------------------------------------------ > Passa a Infostrada. ADSL e Telefono senza limiti e senza canone Telecom > http://click.libero.it/infostrada > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ------------------------------------------------------ Passa a Infostrada. ADSL e Telefono senza limiti e senza canone Telecom http://click.libero.it/infostrada

17 years, 4 months

Re: [ros-dev] revision 26772, Mon May 14 03:18:42 2007 UTC

by jimtabor

Hi! > It should probably be > + Exp -= (1 - EXCESS); > in EFtoF() and > + Exp += (1 - EXCESS); > in FtoEF(). The other way round. > > No, this would break compatibility. The way to verify this. Write a driver, install it and send a packet to it, so to activate the test. Have the driver dump to WinDbg. > Suggestion to make it a little clearer: > #define BIAS 127 > Exp -+= (BIAS - 2); I know about the IEEE bias. I'm just using my old 68k code that I'm comfortable with. I'll change this later with the Dc handle stuff I'm still testing. Thanks, James

17 years, 4 months

Re: [ros-dev] [ekohl] 26843: Update WIDL to rev 20070519.

by Aleksey Bragin

Hi, 2nd stage shows "Enable UsermodePnP failed", which doesn't appear with older WIDL. WBR, Aleksey Bragin. On May 20, 2007, at 3:02 AM, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sun May 20 03:02:35 2007 > New Revision: 26843 > > URL: http://svn.reactos.org/svn/reactos?rev=26843&view=rev > Log: > Update WIDL to rev 20070519. >

17 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev