Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Notepad-Icon is from Windows Vista!
by theUser BL 01 May '07

01 May '07

Hi! Your actual ROS-Notepad Icons is absolutly the same like that on Windows-Vista. On March 2006 there was already something like that, there you used a WinXP-notepad-icon, what I sayd at http://www.reactos.org/pipermail/ros-dev/2006-March/007932.html The new icon, what you then choosed looks very like MS-Windows, but it wasn't a icon from Windows until WinXP. But now I have looked at Windows Vista (in a Virtual machine and on real hardware in an Internetcafé which I know) and there I see, that the ROS-notepad icon and the Windows-Vista Notepad icon are completely the same! But, existing at first the Vista icon or at first the ROS-icon??? What me wonder is, that the icon was in ROS before the first betas of Vista where out... And btw: For all the people who have still not seen Vista: It is the biggest crap I have ever seen. I hope ROS 1.0 looks more like WinXP then like Vista. - In Vista you can not run DOS-programs. But in C:\windows\system32 there are files like edit.com and edlin.exe. But if you want to run it, there comes a window: That there eixting a problem with this programs. If you want to continue or abort. If I choose contine, then Vista hangs up. - The german version of Windows have also the English-Filenames: C:\Program Files\ C:\User\ .. which you can easily see in the command-window (dos-box). but the Explorer shows for the user translated names like C:\Programme\ C:\Benutzer\ and there is a a possibility, if you are in such a directory to see in the address-field of the explorer the real directory name. But at first you see the wrong one. - The games like minesweeper wants D3D hardware-driver, to run fast enough. - the happy colors of XP don´t existing there. All is in black. Black here, black there. The only other look and feel is the look of Win2000. - The icons on the desktop are all very big, for me too big. In the explorer on the other side the icons are per default small, that you can´t see what a symbol it is ... 16x16 or so icons. - If you have a 64bit Windows you can not see, which programs are 32bit and whgich 64 bit. In the name it stand there if you run it. There stands in the "about"-window something like "I am a 64 bit window program". But you can also develop a 32bit window program, which says, that it is 64bit. You can not see, if it is right or not. With Linux - on the other side -, the command "file" do not show only information about the Linux-format files, if you have a 32bit or 64bit program, it shows also, if you have a 32bit or 64bit Windows *.exe file. Additional it says if the *.exe-file is completly of native-code (so, that WINE could run it for example), if it is completly .net-code (so that Mono could run it on Linux for example) or if it include native and .net code mixed like some developer do it with Visual C++.net / managed C++. There you can mix native and .net code and neither WINE nor Mono can run this files. The games of Vista are such files with mixed code. Windows XP is _much_ better then Windows Vista!! Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

4 3

Re: [ros-dev] [ros-diffs] [gedmurphy] 26616: quick hack to make sysdm.cpl open our standalone device manager it's a democracy : http://www.reactos.org/forum/viewtopic.php?t=3835
by Alex Ionescu 01 May '07

01 May '07

You don't run a software engineering project by user-based democracy. Doing that is called Microsoft. Listening to your developers and internal vision while ignoring users is called Apple. Which makes the more user-friendly product? Best regards, Alex Ionescu -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of gedmurphy(a)svn.reactos.org Sent: May-01-07 12:25 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [gedmurphy] 26616: quick hack to make sysdm.cpl open our standalone device manager it's a democracy : http://www.reactos.org/forum/viewtopic.php?t=3835 Author: gedmurphy Date: Tue May 1 20:25:26 2007 New Revision: 26616 URL: http://svn.reactos.org/svn/reactos?rev=26616&view=rev Log: quick hack to make sysdm.cpl open our standalone device manager it's a democracy : http://www.reactos.org/forum/viewtopic.php?t=3835 Modified: trunk/reactos/dll/cpl/sysdm/hardware.c Modified: trunk/reactos/dll/cpl/sysdm/hardware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/hardware.c?r… ============================================================================== --- trunk/reactos/dll/cpl/sysdm/hardware.c (original) +++ trunk/reactos/dll/cpl/sysdm/hardware.c Tue May 1 20:25:26 2007 @@ -14,6 +14,10 @@ BOOL LaunchDeviceManager(HWND hWndParent) { +/* hack for ROS to start our devmgmt until we have mmc */ +#ifdef __REACTOS__ + return ((INT)ShellExecuteW(NULL, L"open", L"devmgmt.exe", NULL, NULL, SW_SHOWNORMAL) > 32); +#else HMODULE hDll; PDEVMGREXEC DevMgrExec; BOOL Ret; @@ -33,6 +37,7 @@ Ret = DevMgrExec(hWndParent, hApplet, NULL /* ??? */, SW_SHOW); FreeLibrary(hDll); return Ret; +#endif /* __REACTOS__ */ } /* Property page dialog callback */

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 26608: - Fix infinite loop. - Add debug msg.
by Alex Ionescu 01 May '07

01 May '07

You CANNOT return from PSEH! You must use SEH_LEAVE or the newest SHE construct that KJK added (forgot what he called it, check commit logs). -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: May-01-07 4:53 AM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 26608: - Fix infinite loop. - Add debug msg. Author: dgorbachev Date: Tue May 1 12:52:59 2007 New Revision: 26608 URL: http://svn.reactos.org/svn/reactos?rev=26608&view=rev Log: - Fix infinite loop. - Add debug msg. Modified: trunk/reactos/ntoskrnl/ke/i386/exp.c Modified: trunk/reactos/ntoskrnl/ke/i386/exp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/exp.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/exp.c (original) +++ trunk/reactos/ntoskrnl/ke/i386/exp.c Tue May 1 12:52:59 2007 @@ -980,7 +980,9 @@ /* Set EIP to the User-mode Dispatcher */ TrapFrame->Eip = (ULONG)KeUserExceptionDispatcher; - _SEH_LEAVE; + + /* Dispatch exception to user-mode */ + return; } _SEH_EXCEPT(KiCopyInformation) { @@ -1000,9 +1002,6 @@ } } _SEH_END; - - /* Dispatch exception to user-mode */ - return; } /* Try second chance */ @@ -1018,6 +1017,7 @@ } /* 3rd strike, kill the process */ + DPRINT1("Kill the process\n"); ZwTerminateProcess(NtCurrentProcess(), ExceptionRecord->ExceptionCode); KeBugCheckEx(KMODE_EXCEPTION_NOT_HANDLED, ExceptionRecord->ExceptionCode,

1 0

Bug into log10 function.
by carlo.bramix 30 Apr '07

30 Apr '07

While I was doing the final tests with ReactOS Calc before releasing the new version, I discovered that it didn't work because a bug into log10 function. This happens because the two operands are swapped into: \ReactOS-0.3.1\lib\crt\math\i386\log10_asm.s I attached the patch. Sincerely, Carlo Bramini. ------------------------------------------------------ Leggi GRATIS le tue mail con il telefonino i-mode di Wind http://i-mode.wind.it/

3 2

Uniform Driver Interface
by Jerry 30 Apr '07

30 Apr '07

http://udi.certek.cc/ >From what I can tell the example source code of this project is BSD (new). Should we add this driver interface to ReactOS? Why or why not? How could this be implemented while keeping compatibility with native NT drivers and not have it ROS specific?

1 0

Problem with out current NtGdiExtGetObjectW implementation
by Timo Kreuzer 30 Apr '07

30 Apr '07

Hi, although I like the way NtGdiExtGetObjectW is using the union, we will get a problem with it. We don't know how many styles an extpen has, so we cannot statically allocate a kmode buffer that is big enough. I can currently think of 3 possible solutions: 1. Add a big additional hack for GDI_OBJECT_TYPE_EXTPEN in NtGdiExtGetObjectW, that will copy the styles, wich seems to be a bad idea. 2. Use the old method of first calling IntGdiExtGetObjectW to get the needed buffer size then allocate a kernelmode buffer then call IntGdiExtGetObjectW again to tranfer the data then copy to usermode. This is slower and needs extra memory. 3. Move the copying to usermode to the XXX_GetObject functions. This would remove the need for an extra kernelmode buffer and we wouldn't really need IntGdiExtGetObjectW anymore. But it doesn't match the rest of our call chain design. Comments appreciated. Timo

4 5

CUnit
by theUser BL 29 Apr '07

29 Apr '07

Hi! Which testing-framefork do ReactOS use? I have seen, that CUnit for example outputs the result in a nice html-format: http://cunit.sourceforge.net/ss_automated.html Looks similar to the output of GNU Classpath (which trys to rewrite Java): http://builder.classpath.org/japi/jdk15-generics.html But GNU Classpath uses JUnit. And ReactOS is written in C, so in this case CUnit would be better. Existing for ReactOS also a side like this, where everytime stands, which test are passed and which not? Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 26565: BRUSH_GetObject: - return sizeof(LOBRUSH) not BRUSHOBJ - don't return 0 on too small usermode buffer NtGdiExtGetObjectW: - remove unnecessary hacks - no need to align usermode buffer to words - add ENUMLOGFONTEXDVW, wich
by Alex Ionescu 29 Apr '07

29 Apr '07

Why did you randomly remove the hacks I added and call them useless? They're in Windows code, a checked GDI Server even prints out the size too big message! And why rename my variables? I don't really see the need to re-format code. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: April-28-07 5:53 PM To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 26565: BRUSH_GetObject: - return sizeof(LOBRUSH) not BRUSHOBJ - don't return 0 on too small usermode buffer NtGdiExtGetObjectW: - remove unnecessary hacks - no need to align usermode buffer to words - add ENUMLOGFONTEXDVW, wich shou Author: tkreuzer Date: Sun Apr 29 01:53:06 2007 New Revision: 26565 URL: http://svn.reactos.org/svn/reactos?rev=26565&view=rev Log: BRUSH_GetObject: - return sizeof(LOBRUSH) not BRUSHOBJ - don't return 0 on too small usermode buffer NtGdiExtGetObjectW: - remove unnecessary hacks - no need to align usermode buffer to words - add ENUMLOGFONTEXDVW, wich should be the biggest structure needed more fixes for fonts and extpens needed in the corresponding subfunctions, but all of my other tests pass now. Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c trunk/reactos/subsystems/win32/win32k/objects/dc.c Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/brush.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/brush.c Sun Apr 29 01:53:06 2007 @@ -52,9 +52,8 @@ INT FASTCALL BRUSH_GetObject (PGDIBRUSHOBJ BrushObject, INT Count, LPLOGBRUSH Buffer) { - if( Buffer == NULL ) return sizeof(BRUSHOBJ); + if( Buffer == NULL ) return sizeof(LOGBRUSH); if (Count == 0) return 0; - if ((UINT)Count < sizeof(BRUSHOBJ)) return 0; /* Set colour */ Buffer->lbColor = BrushObject->BrushAttr.lbColor; @@ -106,7 +105,7 @@ */ /* FIXME */ - return sizeof(BRUSHOBJ); + return sizeof(LOGBRUSH); } Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dc.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dc.c Sun Apr 29 01:53:06 2007 @@ -1817,92 +1817,44 @@ OUT LPVOID lpBuffer) { INT iRetCount = 0; - INT iObjectType; - INT cbRealCount = cbCount; + INT cbCopyCount; union { - BITMAP bmpObject; - DIBSECTION disObject; - LOGPEN lgpObject; - LOGBRUSH lgbObject; - LOGFONTW lgfObject; - EXTLOGFONTW elgfObject; + BITMAP bitmap; + DIBSECTION dibsection; + LOGPEN logpen; + LOGBRUSH logbrush; + LOGFONTW logfontw; + EXTLOGFONTW extlogfontw; + ENUMLOGFONTEXDVW enumlogfontexdvw; } Object; - // - // Get the object type - // - iObjectType = GDIOBJ_GetObjectType(hGdiObj); - - // - // Check if the given size is too large - // - if (cbCount > sizeof(Object)) - { - // - // Normalize to the largest supported object size - // - DPRINT1("cbCount too big!\n"); - cbCount = sizeof(Object); - } - - // - // Check if this is a brush - // - if (iObjectType == GDI_OBJECT_TYPE_BRUSH) - { - // - // Windows GDI Hack: Manually correct the size - // - cbCount = sizeof(LOGBRUSH); - } - - // + // Normalize to the largest supported object size + cbCount = min((UINT)cbCount, sizeof(Object)); + // Now do the actual call - // iRetCount = IntGdiGetObject(hGdiObj, cbCount, lpBuffer ? &Object : NULL); - - // - // Check if this is a brush - // - if (iObjectType == GDI_OBJECT_TYPE_BRUSH) - { - // - // Fixup the size to account for our previous fixup - // - cbCount = min(cbCount, cbRealCount); - } - - // - // Make sure we have a buffer and a return size - // - if ((iRetCount) && (lpBuffer)) - { - // + cbCopyCount = min((UINT)cbCount, (UINT)iRetCount); + + // Make sure we have a buffer and a copy size + if ((cbCopyCount) && (lpBuffer)) + { // Enter SEH for buffer transfer - // _SEH_TRY { - // // Probe the buffer and copy it - // - ProbeForWrite(lpBuffer, min(cbCount, cbRealCount), sizeof(WORD)); - RtlCopyMemory(lpBuffer, &Object, min(cbCount, cbRealCount)); + ProbeForWrite(lpBuffer, cbCopyCount, 1); + RtlCopyMemory(lpBuffer, &Object, cbCopyCount); } _SEH_HANDLE { - // // Clear the return value. // Do *NOT* set last error here! - // iRetCount = 0; } _SEH_END; } - - // // Return the count - // return iRetCount; }

1 0

[ros-diffs] [tkreuzer] 26564: GetNonFontObject: - OBJECTTYPE_META_DC does not SetLastError() - beautify the code a little
by James Tabor 29 Apr '07

29 Apr '07

Hi! switch(dwType) { + case GDI_OBJECT_TYPE_PEN: //Check the structures and see if A & W are the same. + case GDI_OBJECT_TYPE_EXTPEN: + case GDI_OBJECT_TYPE_BRUSH: // Mixing Apples and Oranges? + case GDI_OBJECT_TYPE_BITMAP: + case GDI_OBJECT_TYPE_PALETTE: + return NtGdiExtGetObjectW(hGdiObj, cbSize, lpBuffer); + case GDI_OBJECT_TYPE_DC: case GDI_OBJECT_TYPE_REGION: case GDI_OBJECT_TYPE_METAFILE: case GDI_OBJECT_TYPE_ENHMETAFILE: case GDI_OBJECT_TYPE_EMF: - case GDI_OBJECT_TYPE_METADC: SetLastError(ERROR_INVALID_HANDLE); - return 0; This is wrong,,, you can not call NtGdiExtGetObjectW first before faulting on GDI_OBJECT_TYPE_DC. http://msdn2.microsoft.com/en-us/library/ms533268.aspx Normal DC's do not pass to kernel space. Please RTFM. Thanks, James

3 5

Re: [ros-dev] [ros-diffs] [tkreuzer] 26559: winetsts build fix - add needed #includes to test.h - add windef.h including psdk/windef.h
by Steven Edwards 29 Apr '07

29 Apr '07

Why can't use change the include path to use the normal windef.h? On 4/28/07, tkreuzer(a)svn.reactos.org <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Sat Apr 28 12:58:18 2007 > New Revision: 26559 > > URL: http://svn.reactos.org/svn/reactos?rev=26559&view=rev > Log: > winetsts build fix > - add needed #includes to test.h > - add windef.h including psdk/windef.h > > Added: > trunk/reactos/include/reactos/wine/windef.h > Modified: > trunk/reactos/include/reactos/wine/test.h > > Modified: trunk/reactos/include/reactos/wine/test.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/test.… > ============================================================================== > --- trunk/reactos/include/reactos/wine/test.h (original) > +++ trunk/reactos/include/reactos/wine/test.h Sat Apr 28 12:58:18 2007 > @@ -25,6 +25,8 @@ > #include <stdlib.h> > #include <windef.h> > #include <winbase.h> > +#include <wingdi.h> > +#include <winreg.h> > > #ifdef __WINE_WINE_LIBRARY_H > #error wine/library.h should not be used in Wine tests > > Added: trunk/reactos/include/reactos/wine/windef.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/winde… > ============================================================================== > --- trunk/reactos/include/reactos/wine/windef.h (added) > +++ trunk/reactos/include/reactos/wine/windef.h Sat Apr 28 12:58:18 2007 > @@ -1,0 +1,3 @@ > +#include "../../psdk/windef.h" > + > + > > > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev