turner(a)svn.reactos.org wrote:
> + bc->raw_params = malloc(_tcslen(param));
> + _tcscpy(bc->raw_params,param);
Please check the docs, I don't have access to any at the moment, but if I
recall correctly both strlen and wcslen return the number of chars, not
including the '/0'.
This will therefore mean we miss off the '/0' for ASCII builds and only have
half the required space for unicode builds.
Ged.
Aleksey Bragin wrote:
>
> But it's a nice excuse to raise traffic in [ros-dev] !
> :-)
People love a good soap opera.
Although we're still no closer to solving the issue ;)
Ged.
Alex Ionescu wrote:
>
> Like I said, PROGRAMMER implies the person who wrote this
> file, not the
> programmer of the entire project (I don't see why you'd think that...
> just because my name is in lib\rtl\foo.c doesn't mean I wrote
> *all* the kernel).
I don't. Maybe I'm missing something here, but looking at the diff the code
was already in sol.rc.
This code was moved into En.rc, then a copy was taken of En.rc and named as
De.rc, and translated into German
So if 2 copies were made of existing code in sol.rc, and one of these copies
was translated, all the original code still remains (with the exception of
the translations). Thus, the programmer who wrote the original code is still
the programmer.
It's similar to me taking lib\rtl\foo.c splitting it into 2 files and naming
myself as the programmer.
As I said though, I might have something wrong here.
Ged.