Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Hello list!
by Michele Cicciotti 08 Jul '06

08 Jul '06

I thought I might share my current progress on my Google Summer of Code project with this lovely project... Briefly, I don't have a lot of code but, I believe, a pretty solid design & a well laid down plan. Here is a writeup I have made about it on my PlanetSoC 2006 blog: <http://2006.planet-soc.com/node/361> It's quite long, so I hope you understand why this here post is so short :-) I'd love any kind of comment on it See you all soon(er)!

2 1

Status of xen port?
by Pablo Menichini 08 Jul '06

08 Jul '06

Hi, I look at xen port and it hasn't been touch in a year. Is it possible to port reactos to xen or is the kernel not mature enought? If it's possible, how long can it take to have a bare minimum port? Thanks, Pablo

3 2

Must read for all ReactOS devs: Status Report requests
by Aleksey Bragin 05 Jul '06

05 Jul '06

Hello, in the process of writing a ReactOS quarterly Status Report, I need every ReactOS Developer (with some exceptions to passive developers too) to write me a private email, stating what they have been doing recently, what they plan to do in near future (near future == 6 months), and what did you achieve from the last status report (january 1st) -- I suppose this will be your favorite section, because it actually gives every developer a chance to show his most prominent work, and make others be proud of it. These emails must be sent as soon as possible, but preferably not later than Wednesday, 5th of July, 2006. If you are really late and did not warn me, you risk not being included into this issue of Status Report. Thank you, With the best regards, Aleksey Bragin ReactOS Project Coordinator

2 1

Re: [ros-dev] [ros-diffs] [winesync] 22829: Autosyncing with Wine
by Murphy, Ged (Bolton) 04 Jul '06

04 Jul '06

winesync(a)svn.reactos.org wrote: > > + <library>ntdll</library> > <file>mpr_main.c</file> > + <library>ntdll</library> > <file>multinet.c</file> > + <library>ntdll</library> > <file>nps.c</file> > + <library>ntdll</library> > <file>pwcache.c</file> > + <library>ntdll</library> > <file>wnet.c</file> > + <library>ntdll</library> The script is still dropping in multiple instances of ntdll. Plus, is anyone checking / testing the syncs with the regression tests? Ged.

2 1

[ros-diffs] [jimtabor] 22840: - CreateWindowExa/W
by James Tabor 04 Jul '06

04 Jul '06

- CreateWindowExA/W - Consolidated both A & W to User32CreateWindowEx and added a Unicode bool to help differenceate between them. Thanks, James

1 0

revert Revision: 22742
by Magnus Olsen 02 Jul '06

02 Jul '06

Revert this change it is incorrect change u have made. I told u do not change it and it is not a bug in the apps, you are hidding the real bug with this that u did found with your consle apps calc and other apps working in ros. revert this changes as ASAP DS_SHELLLFONT is a EXSTYLE EXSTYLE DS_SHELLFONT have same value as EXSTYLE WS_EX_TOPMOST | WS_EX_MDICHILD and posible some others types as well. Revision: 22742 Author: janderwald Date: 20:04:00, den 1 juli 2006 Message: * DS_SHELLFONT is an style not an EXSTYLE. ---- Modified : /trunk/reactos/base/applications/calc/Cz.rc Modified : /trunk/reactos/base/applications/calc/De.rc Modified : /trunk/reactos/base/applications/calc/En.rc Modified : /trunk/reactos/base/applications/calc/Es.rc Modified : /trunk/reactos/base/applications/calc/Fr.rc Modified : /trunk/reactos/base/applications/calc/Hu.rc Modified : /trunk/reactos/base/applications/calc/It.rc Modified : /trunk/reactos/base/applications/calc/Ja.rc Modified : /trunk/reactos/base/applications/calc/Nl.rc Modified : /trunk/reactos/base/applications/calc/Pt.rc Modified : /trunk/reactos/base/applications/calc/Ru.rc Modified : /trunk/reactos/base/applications/calc/Sv.rc Modified : /trunk/reactos/base/applications/calc/Uk.rc Modified : /trunk/reactos/base/applications/control/control.c Modified : /trunk/reactos/base/applications/games/solitaire/de.rc Modified : /trunk/reactos/base/applications/games/solitaire/en.rc Modified : /trunk/reactos/base/applications/games/winemine/De.rc Modified : /trunk/reactos/base/applications/games/winemine/En.rc Modified : /trunk/reactos/base/applications/games/winemine/Fr.rc Modified : /trunk/reactos/base/applications/games/winemine/Nl.rc Modified : /trunk/reactos/base/applications/games/winemine/Pl.rc Modified : /trunk/reactos/base/applications/getfirefox/De.rc Modified : /trunk/reactos/base/applications/getfirefox/En.rc Modified : /trunk/reactos/base/applications/getfirefox/Fr.rc Modified : /trunk/reactos/base/applications/getfirefox/Hu.rc Modified : /trunk/reactos/base/applications/getfirefox/Nl.rc Modified : /trunk/reactos/base/applications/getfirefox/Ru.rc Modified : /trunk/reactos/base/applications/getfirefox/Sv.rc Modified : /trunk/reactos/base/applications/getfirefox/Uk.rc Modified : /trunk/reactos/base/applications/ibrowser/De.rc Modified : /trunk/reactos/base/applications/ibrowser/En.rc Modified : /trunk/reactos/base/applications/ibrowser/Nl.rc Modified : /trunk/reactos/base/applications/imagesoft/En.rc Modified : /trunk/reactos/base/applications/msconfig/De.rc Modified : /trunk/reactos/base/applications/msconfig/En.rc Modified : /trunk/reactos/base/applications/msconfig/Fr.rc Modified : /trunk/reactos/base/applications/msconfig/Hu.rc Modified : /trunk/reactos/base/applications/msconfig/Nl.rc Modified : /trunk/reactos/base/applications/msconfig/No.rc Modified : /trunk/reactos/base/applications/notepad/res/Cs.rc Modified : /trunk/reactos/base/applications/notepad/res/Da.rc Modified : /trunk/reactos/base/applications/notepad/res/De.rc Modified : /trunk/reactos/base/applications/notepad/res/En.rc Modified : /trunk/reactos/base/applications/notepad/res/Es.rc Modified : /trunk/reactos/base/applications/notepad/res/Fi.rc Modified : /trunk/reactos/base/applications/notepad/res/Fr.rc Modified : /trunk/reactos/base/applications/notepad/res/Gr.rc Modified : /trunk/reactos/base/applications/notepad/res/Hu.rc Modified : /trunk/reactos/base/applications/notepad/res/It.rc Modified : /trunk/reactos/base/applications/notepad/res/Ja.rc Modified : /trunk/reactos/base/applications/notepad/res/Nl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pl.rc Modified : /trunk/reactos/base/applications/notepad/res/Pt.rc Modified : /trunk/reactos/base/applications/notepad/res/Ru.rc Modified : /trunk/reactos/base/applications/notepad/res/Si.rc Modified : /trunk/reactos/base/applications/notepad/res/Sk.rc Modified : /trunk/reactos/base/applications/notepad/res/Sv.rc Modified : /trunk/reactos/base/applications/notepad/res/Th.rc Modified : /trunk/reactos/base/applications/notepad/res/Uk.rc Modified : /trunk/reactos/base/applications/notepad/res/Wa.rc Modified : /trunk/reactos/base/applications/notepad/res/Zh.rc Modified : /trunk/reactos/base/applications/regedit/Cz.rc Modified : /trunk/reactos/base/applications/regedit/De.rc Modified : /trunk/reactos/base/applications/regedit/En.rc Modified : /trunk/reactos/base/applications/regedit/Es.rc Modified : /trunk/reactos/base/applications/regedit/Fr.rc Modified : /trunk/reactos/base/applications/regedit/Hu.rc Modified : /trunk/reactos/base/applications/regedit/It.rc Modified : /trunk/reactos/base/applications/regedit/Ja.rc Modified : /trunk/reactos/base/applications/regedit/Nl.rc Modified : /trunk/reactos/base/applications/regedit/Pl.rc Modified : /trunk/reactos/base/applications/regedit/Pt.rc Modified : /trunk/reactos/base/applications/regedit/Ru.rc Modified : /trunk/reactos/base/applications/regedit/Si.rc Modified : /trunk/reactos/base/applications/regedit/Sv.rc Modified : /trunk/reactos/base/applications/reporterror/Ja.rc Modified : /trunk/reactos/base/applications/reporterror/Nl.rc Modified : /trunk/reactos/base/applications/reporterror/de.rc Modified : /trunk/reactos/base/applications/reporterror/dk.rc Modified : /trunk/reactos/base/applications/reporterror/en.rc Modified : /trunk/reactos/base/applications/reporterror/hu.rc Modified : /trunk/reactos/base/applications/reporterror/ru.rc Modified : /trunk/reactos/base/applications/reporterror/sv.rc Modified : /trunk/reactos/base/applications/screensavers/matrix/matrix.rc Modified : /trunk/reactos/base/applications/servman/De.rc Modified : /trunk/reactos/base/applications/servman/En.rc Modified : /trunk/reactos/base/applications/servman/Ru.rc Modified : /trunk/reactos/base/applications/sndvol32/Cz.rc Modified : /trunk/reactos/base/applications/sndvol32/De.rc Modified : /trunk/reactos/base/applications/sndvol32/En.rc Modified : /trunk/reactos/base/applications/sndvol32/Fr.rc Modified : /trunk/reactos/base/applications/sndvol32/Hu.rc Modified : /trunk/reactos/base/applications/sndvol32/Ja.rc Modified : /trunk/reactos/base/applications/sndvol32/Nl.rc Modified : /trunk/reactos/base/applications/sndvol32/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Cz.rc Modified : /trunk/reactos/base/applications/taskmgr/De.rc Modified : /trunk/reactos/base/applications/taskmgr/Dk.rc Modified : /trunk/reactos/base/applications/taskmgr/En.rc Modified : /trunk/reactos/base/applications/taskmgr/Es.rc Modified : /trunk/reactos/base/applications/taskmgr/Fr.rc Modified : /trunk/reactos/base/applications/taskmgr/Hu.rc Modified : /trunk/reactos/base/applications/taskmgr/Ja.rc Modified : /trunk/reactos/base/applications/taskmgr/Nl.rc Modified : /trunk/reactos/base/applications/taskmgr/Sv.rc Modified : /trunk/reactos/base/applications/taskmgr/Uk.rc Modified : /trunk/reactos/base/applications/winefile/Sv.rc Modified : /trunk/reactos/base/applications/winefile/cs.rc Modified : /trunk/reactos/base/applications/winefile/de.rc Modified : /trunk/reactos/base/applications/winefile/en.rc Modified : /trunk/reactos/base/applications/winefile/es.rc Modified : /trunk/reactos/base/applications/winefile/fr.rc Modified : /trunk/reactos/base/applications/winefile/hu.rc Modified : /trunk/reactos/base/applications/winefile/it.rc Modified : /trunk/reactos/base/applications/winefile/nl.rc Modified : /trunk/reactos/base/applications/winefile/pl.rc Modified : /trunk/reactos/base/applications/winefile/pt.rc Modified : /trunk/reactos/base/applications/winefile/ru.rc Modified : /trunk/reactos/base/applications/winefile/si.rc Modified : /trunk/reactos/base/applications/winefile/zh.rc Modified : /trunk/reactos/base/applications/wordpad/En.rc

2 2

Re: [ros-dev] [ros-diffs] [greatlrd] 22718: Small clean up 1. Remove goto in the code, goto is slow and should be avoid. 2. reformat for adding {} around some code. 3. remove some NULL check after I did remove goto that is not longer need it.
by Saveliy Tretiakov 30 Jun '06

30 Jun '06

I don't like your changes to main(), you added a lot of code dublication, made it harder to read and maintain. This is repeated three times: DeleteCriticalSection(&LogListCs); // Close all log files. for(pLogf = LogListHead; pLogf; pLogf = ((PLOGFILE)pLogf)->Next) { LogfClose(pLogf); } HeapDestroy(MyHeap); greatlrd(a)svn.reactos.org wrote: > Author: greatlrd > Date: Fri Jun 30 20:42:21 2006 > New Revision: 22718 > > URL: http://svn.reactos.org/svn/reactos?rev=22718&view=rev > Log: > Small clean up > 1. Remove goto in the code, goto is slow and should be avoid. > 2. reformat for adding {} around some code. > 3. remove some NULL check after I did remove goto that is not longer need it. > > > Modified: > trunk/reactos/base/services/eventlog/eventlog.c > > Modified: trunk/reactos/base/services/eventlog/eventlog.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/eve… > ============================================================================== > --- trunk/reactos/base/services/eventlog/eventlog.c (original) > +++ trunk/reactos/base/services/eventlog/eventlog.c Fri Jun 30 20:42:21 2006 > @@ -61,7 +61,7 @@ > DWORD MaxValueLen, ValueLen, Type, ExpandedLen; > WCHAR *Buf = NULL, *Expanded = NULL; > LONG Result; > - BOOL ret = FALSE; > + BOOL ret = TRUE; > PLOGFILE pLogf; > > DPRINT("LoadLogFile: %S\n", LogName); > @@ -88,12 +88,14 @@ > if(Result != ERROR_SUCCESS) > { > DPRINT1("RegQueryValueEx failed: %d\n", GetLastError()); > - goto cleanup; > + HeapFree(MyHeap, 0, Buf); > + return FALSE; > } > if(Type != REG_EXPAND_SZ && Type != REG_SZ) > { > DPRINT1("%S\\File - value of wrong type %x.\n", LogName, Type); > - goto cleanup; > + HeapFree(MyHeap, 0, Buf); > + return FALSE; > } > > ExpandedLen = ExpandEnvironmentStrings(Buf, NULL, 0); > @@ -102,7 +104,8 @@ > if(!Expanded) > { > DPRINT1("Can't allocate heap!\n"); > - goto cleanup; > + HeapFree(MyHeap, 0, Buf); > + return FALSE; > } > > ExpandEnvironmentStrings(Buf, Expanded, ExpandedLen); > @@ -114,14 +117,11 @@ > if(pLogf == NULL) > { > DPRINT1("Failed to create %S!\n", Expanded); > - goto cleanup; > - } > - > - ret = TRUE; > - > -cleanup: > + ret = FALSE; > + } > + > HeapFree(MyHeap, 0, Buf); > - if(Expanded) HeapFree(MyHeap, 0, Expanded); > + HeapFree(MyHeap, 0, Expanded); > return ret; > } > > @@ -129,8 +129,7 @@ > { > LONG result; > DWORD MaxLognameLen, LognameLen; > - WCHAR *Buf = NULL; > - BOOL ret = FALSE; > + WCHAR *Buf = NULL; > INT i; > > RegQueryInfoKey(eventlogKey, NULL, NULL, NULL, NULL, &MaxLognameLen, > @@ -143,7 +142,7 @@ > if(!Buf) > { > DPRINT1("Error: can't allocate heap!\n"); > - return ret; > + return FALSE; > } > > i = 0; > @@ -159,7 +158,8 @@ > if(result != ERROR_SUCCESS) > { > DPRINT1("Failed to open %S key.\n", Buf); > - goto cleanup; > + HeapFree(MyHeap, 0, Buf); > + return FALSE; > } > > if(!LoadLogFile(SubKey, Buf)) > @@ -171,18 +171,14 @@ > i++; > } > > - ret = TRUE; > - > -cleanup: > HeapFree(MyHeap, 0, Buf); > - return ret; > + return TRUE; > } > > INT main() > { > WCHAR LogPath[MAX_PATH]; > - PLOGFILE pLogf; > - INT RetCode = 0; > + PLOGFILE pLogf; > LONG result; > HKEY elogKey; > > @@ -193,8 +189,15 @@ > if(MyHeap==NULL) > { > DPRINT1("FATAL ERROR, can't create heap.\n"); > - RetCode = 1; > - goto bye_bye; > + > + DeleteCriticalSection(&LogListCs); > + // Close all log files. > + for(pLogf = LogListHead; pLogf; pLogf = ((PLOGFILE)pLogf)->Next) > + { > + LogfClose(pLogf); > + } > + > + return 1; > } > > GetWindowsDirectory(LogPath, MAX_PATH); > @@ -214,8 +217,17 @@ > if(result != ERROR_SUCCESS) > { > DPRINT1("Fatal error: can't open eventlog registry key.\n"); > - RetCode = 1; > - goto bye_bye; > + > + DeleteCriticalSection(&LogListCs); > + > + // Close all log files. > + for(pLogf = LogListHead; pLogf; pLogf = ((PLOGFILE)pLogf)->Next) > + { > + LogfClose(pLogf); > + } > + > + HeapDestroy(MyHeap); > + return 1; > } > > LoadLogFiles(elogKey); > @@ -223,16 +235,16 @@ > > StartServiceCtrlDispatcher(ServiceTable); > > -bye_bye: > DeleteCriticalSection(&LogListCs); > > // Close all log files. > for(pLogf = LogListHead; pLogf; pLogf = ((PLOGFILE)pLogf)->Next) > + { > LogfClose(pLogf); > + } > > - if(MyHeap) HeapDestroy(MyHeap); > - > - return RetCode; > + HeapDestroy(MyHeap); > + return 0; > } > > VOID EventTimeToSystemTime(DWORD EventTime, > > > >

3 2

unsubscribe
by Arun Bellatti (RBIN/ECM4) 30 Jun '06

30 Jun '06

Hello All, Please unsubscribe me from this group Regards Arum

1 0

Re: [ros-dev] [ros-diffs] [janderwald] 22698: * fix resource inconsistency (pointed out by Lohnegrim) * halfplemented reading console options
by Thomas Weidenmueller 29 Jun '06

29 Jun '06

> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/console/options.… > ============================================================================== > --- trunk/reactos/dll/win32/console/options.c (original) > +++ trunk/reactos/dll/win32/console/options.c Fri Jun 30 00:19:26 2006 > @@ -10,6 +10,10 @@ > #include "console.h" > > > +ConsoleInfo g_ConsoleInfo; Don't use a global variable for this. - Thomas

1 0

Re: [ros-dev] [ros-diffs] [turner] 22683: expand %* to batch file params. b ug: #1629
by Murphy, Ged (Bolton) 29 Jun '06

29 Jun '06

Brandon Turner wrote: > Index: batch.c > =================================================================== > --- batch.c (revision 22683) > +++ batch.c (working copy) > @@ -275,8 +275,17 @@ > // > // Allocate enough memory to hold the params and copy them over > without modifications > // > - bc->raw_params = malloc(_tcslen(param)); > - _tcscpy(bc->raw_params,param); > + bc->raw_params = malloc((_tcslen(param)+1) * sizeof(TCHAR)); > + if (bc->raw_params != NULL) > + { > + memset (bc->raw_params, 0, _tcslen(bc->raw_params) * > sizeof(TCHAR)); > + _tcscpy(bc->raw_params,param); > + } > + else > + { > + error_out_of_memory(); > + return FALSE; > + } > > #ifdef _DEBUG > DebugPrintf (_T("Batch: returns TRUE\n")); > > > look better? > > Brandon Yeah :) Ged.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev