Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [janderwald] 22698: * fix resource inconsistency (pointed out by Lohnegrim) * halfplemented reading console options
by Thomas Weidenmueller 29 Jun '06

29 Jun '06

> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/console/options.… > ============================================================================== > --- trunk/reactos/dll/win32/console/options.c (original) > +++ trunk/reactos/dll/win32/console/options.c Fri Jun 30 00:19:26 2006 > @@ -10,6 +10,10 @@ > #include "console.h" > > > +ConsoleInfo g_ConsoleInfo; Don't use a global variable for this. - Thomas

1 0

Re: [ros-dev] [ros-diffs] [turner] 22683: expand %* to batch file params. b ug: #1629
by Murphy, Ged (Bolton) 29 Jun '06

29 Jun '06

Brandon Turner wrote: > Index: batch.c > =================================================================== > --- batch.c (revision 22683) > +++ batch.c (working copy) > @@ -275,8 +275,17 @@ > // > // Allocate enough memory to hold the params and copy them over > without modifications > // > - bc->raw_params = malloc(_tcslen(param)); > - _tcscpy(bc->raw_params,param); > + bc->raw_params = malloc((_tcslen(param)+1) * sizeof(TCHAR)); > + if (bc->raw_params != NULL) > + { > + memset (bc->raw_params, 0, _tcslen(bc->raw_params) * > sizeof(TCHAR)); > + _tcscpy(bc->raw_params,param); > + } > + else > + { > + error_out_of_memory(); > + return FALSE; > + } > > #ifdef _DEBUG > DebugPrintf (_T("Batch: returns TRUE\n")); > > > look better? > > Brandon Yeah :) Ged.

1 0

Re: [ros-dev] [ros-diffs] [turner] 22683: expand %* to batch file params. b ug: #1629
by Murphy, Ged (Bolton) 29 Jun '06

29 Jun '06

turner(a)svn.reactos.org wrote: > + bc->raw_params = malloc(_tcslen(param)); > + _tcscpy(bc->raw_params,param); Please check the docs, I don't have access to any at the moment, but if I recall correctly both strlen and wcslen return the number of chars, not including the '/0'. This will therefore mean we miss off the '/0' for ASCII builds and only have half the required space for unicode builds. Ged.

3 2

Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried r eally hard, I really did, but I could not find even the word "copy", muc h less "copy right". - Lesson Two: What do
by Murphy, Ged (Bolton) 28 Jun '06

28 Jun '06

Aleksey Bragin wrote: > > But it's a nice excuse to raise traffic in [ros-dev] ! > :-) People love a good soap opera. Although we're still no closer to solving the issue ;) Ged.

1 0

28 Jun '06

Alex Ionescu wrote: > > Like I said, PROGRAMMER implies the person who wrote this > file, not the > programmer of the entire project (I don't see why you'd think that... > just because my name is in lib\rtl\foo.c doesn't mean I wrote > *all* the kernel). I don't. Maybe I'm missing something here, but looking at the diff the code was already in sol.rc. This code was moved into En.rc, then a copy was taken of En.rc and named as De.rc, and translated into German So if 2 copies were made of existing code in sol.rc, and one of these copies was translated, all the original code still remains (with the exception of the translations). Thus, the programmer who wrote the original code is still the programmer. It's similar to me taking lib\rtl\foo.c splitting it into 2 files and naming myself as the programmer. As I said though, I might have something wrong here. Ged.

3 2

Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried r eally hard, I really did, but I could not find even the word "copy", much less "copy right". - Lesson Two: What do yo
by Murphy, Ged (Bolton) 27 Jun '06

27 Jun '06

Alex Ionescu wrote: > Probably because on the IRC channel you went all "hahah!! LOL @ > EmuandCo!!!" which I found extremly disrespectful attitude It has nothing to do with a disrespectful attitude. It's because I thought is was funny / cheeky, which I still agree with. People know me better than that. Can we save the cattiness for IRC please.

1 0

Resource headers
by Murphy, Ged (Bolton) 27 Jun '06

27 Jun '06

Daniel Reimer wrote: > I did not want to cause problems with that... I know, which is why I didn't want to drag this through the mud. Anyway, now as we're on the topic, we might as well try and resolve it. So, should we be adding headers to resource file? If yes, what info should be in there. It's clear that the translator and programmer should be separate headings. My personal view is that we should leave headers out of resource files. If translators wanted to add their mark, then a line should be added at the top of the file saying /* translated by FOO */ Ged.

2 1

Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried r eally hard, I really did, but I could not find even the word "copy", much less "copy right". - Lesson Two: What do yo
by Murphy, Ged (Bolton) 27 Jun '06

27 Jun '06

Whether headers are added or not, my point was simply that a translator shouldn't put himself into the header as the programmer. It's a little discourteous to the actual programmer (although most devs won't actually care), and it creates a false piece of information. Consider the following scenario: foo: Hi. one of the buttons is sending the wrong message in the German dialog. Can you fix it please bar: Sorry, I'm not a programmer foo: But it has your name as the programmer in the header... Perhaps if translators want to be named in resource files, and we feel a need to put headers in all our resource files too (which I think is a bit overkill, they should be kept in the main code only) we could include an extra line for TRANSLATOR: Anyway, it wasn't my intention to drag this through ros-dev. -----Original Message----- From: Peter Dolding [mailto:oiaohm@bluebottle.com] Sent: 27 June 2006 14:27 To: ReactOS Development List Subject: Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried really hard, I really did, but I could not find even the word "copy", much less "copy right". - Lesson Two: What do yo Sorry to stick my nose in here. Two critical points have been missed. Fine in this case since the code was declare public domain. Other cases it will not be fine. The new alterations started under a new copyright. Can override public domain. If it was a GPL licence even a BSD licence how can you say it up the creek without a paddle. If a document was created by X person then altered by Y. X persons copyright still stands until what time it becomes public domain. Even that Y holds copyright on the alterations so is also allowed a credit mark under the most country's. Personally think both have stuffed up minorly. Note strange I could not find the files in the Reactos tree. Its also a fault I find with MSVS it does not licence tag the .rc files. It would make job simpler. If there is no simpler code as all between the .rc files it would be fine. I totally don't expect that. The lines I would normally add are. /* From project Solitaire That was under license: Freeware, permission to use under Public Domain based on <filename> By Daniel "EmuandCo" Reimer (reimer.daniel(a)freenet.de) New content licensed under <GPL Reactos as per above> Translation/Alterations by <list people here><< People to track down to prove that the license change was done under permitted grounds ie new content. */ Now the file has two licences ie GPL alterations and Public domain content. If person takes the new content they are stuffed. But a person could return it to public domain if the remove the content we have altered. The other option is just to over license it since its public domain and it part of a new work. Its still a good idea to leave a marker in case of future audits. If someone comes along and said hey your file looks like ours. And we have markers can quickly say hey did you acquire that file from there. Yes I know its large. It gets more complex with BSD and GPL. Its all about tracking. GPL master copyrighter stays. No option to relicense is given. Alteration by the Reactos team or author marks is all that could be added. BSD can be overlicened as long as the old BSD header with first copyright holder stays and the new license is not incomparable with BSD. Playing with these things can turn into breach of copyright very quickly. Murphy, Ged (Bolton) wrote: > This is still James' code, it's just been moved out of sol.rc and into a > separate file. > My point was, if someone translated my code and named themselves as the > programmer (ok, not using the word copyright) it would p!ss me off a little > bit. > > I wasn't having a go at anyone, my commit message was entirely civil and > just correcting something which seemed wrong to me. God only knows why > you've taken offence, or needed to revert to belittling. > > Apologies to EmuandCo, this is not aimed at you. > > > -----Original Message----- > From: ion(a)svn.reactos.org [mailto:ion@svn.reactos.org] > Sent: 27 June 2006 00:50 > To: ros-diffs(a)reactos.org > Subject: [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits because > your eyes are inventing the word "copyright". I tried really hard, I really > did, but I could not find even the word "copy", much less "copyright". - > Lesson Two: What do you know! En and D > > > Author: ion > Date: Tue Jun 27 03:50:03 2006 > New Revision: 22649 > > URL: http://svn.reactos.org/svn/reactos?rev=22649&view=rev > Log: > - Lesson One: Don't revert commits because your eyes are inventing the word > "copyright". I tried really hard, I really did, but I could not find even > the word "copy", much less "copyright". > - Lesson Two: What do you know! En and De.rc actually *are* our files, not > James Brown's (his is sol.rc, which hasn't been altered with a ROS Header). > - Lesson Three: It is official (voted) ROS Policy that all ROS files have a > header. Reverting this header violated it. > > Modified: > trunk/reactos/base/applications/games/solitaire/de.rc > trunk/reactos/base/applications/games/solitaire/en.rc > > Modified: trunk/reactos/base/applications/games/solitaire/de.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol > itaire/de.rc?rev=22649&r1=22648&r2=22649&view=diff > ============================================================================ > == > --- trunk/reactos/base/applications/games/solitaire/de.rc (original) > +++ trunk/reactos/base/applications/games/solitaire/de.rc Tue Jun 27 > 03:50:03 2006 > @@ -1,3 +1,10 @@ > +/* > + * PROJECT: Solitaire > + * LICENSE: Freeware, permission to use under Public Domain > + * FILE: base/applications/games/solitaire/de.rc > + * PURPOSE: German Language File for Solitaire > + * PROGRAMMERS: Daniel "EmuandCo" Reimer (reimer.daniel(a)freenet.de) > + */ > #include "resource.h" > > #define APSTUDIO_READONLY_SYMBOLS > > Modified: trunk/reactos/base/applications/games/solitaire/en.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol > itaire/en.rc?rev=22649&r1=22648&r2=22649&view=diff > ============================================================================ > == > --- trunk/reactos/base/applications/games/solitaire/en.rc (original) > +++ trunk/reactos/base/applications/games/solitaire/en.rc Tue Jun 27 > 03:50:03 2006 > @@ -1,3 +1,10 @@ > +/* > + * PROJECT: Solitaire > + * LICENSE: Freeware, permission to use under Public Domain > + * FILE: base/applications/games/solitaire/en.rc > + * PURPOSE: English Language File for Solitaire > + * PROGRAMMERS: Daniel "EmuandCo" Reimer (reimer.daniel(a)freenet.de) > + */ > #include "resource.h" > > #define APSTUDIO_READONLY_SYMBOLS > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

3 2

Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried really hard, I really did, but I could not find even the word "copy", much less "copy right". - Lesson Two: What do you know! En a
by Murphy, Ged (Bolton) 27 Jun '06

27 Jun '06

This is still James' code, it's just been moved out of sol.rc and into a separate file. My point was, if someone translated my code and named themselves as the programmer (ok, not using the word copyright) it would p!ss me off a little bit. I wasn't having a go at anyone, my commit message was entirely civil and just correcting something which seemed wrong to me. God only knows why you've taken offence, or needed to revert to belittling. Apologies to EmuandCo, this is not aimed at you. -----Original Message----- From: ion(a)svn.reactos.org [mailto:ion@svn.reactos.org] Sent: 27 June 2006 00:50 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits because your eyes are inventing the word "copyright". I tried really hard, I really did, but I could not find even the word "copy", much less "copyright". - Lesson Two: What do you know! En and D Author: ion Date: Tue Jun 27 03:50:03 2006 New Revision: 22649 URL: http://svn.reactos.org/svn/reactos?rev=22649&view=rev Log: - Lesson One: Don't revert commits because your eyes are inventing the word "copyright". I tried really hard, I really did, but I could not find even the word "copy", much less "copyright". - Lesson Two: What do you know! En and De.rc actually *are* our files, not James Brown's (his is sol.rc, which hasn't been altered with a ROS Header). - Lesson Three: It is official (voted) ROS Policy that all ROS files have a header. Reverting this header violated it. Modified: trunk/reactos/base/applications/games/solitaire/de.rc trunk/reactos/base/applications/games/solitaire/en.rc Modified: trunk/reactos/base/applications/games/solitaire/de.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol itaire/de.rc?rev=22649&r1=22648&r2=22649&view=diff ============================================================================ == --- trunk/reactos/base/applications/games/solitaire/de.rc (original) +++ trunk/reactos/base/applications/games/solitaire/de.rc Tue Jun 27 03:50:03 2006 @@ -1,3 +1,10 @@ +/* + * PROJECT: Solitaire + * LICENSE: Freeware, permission to use under Public Domain + * FILE: base/applications/games/solitaire/de.rc + * PURPOSE: German Language File for Solitaire + * PROGRAMMERS: Daniel "EmuandCo" Reimer (reimer.daniel(a)freenet.de) + */ #include "resource.h" #define APSTUDIO_READONLY_SYMBOLS Modified: trunk/reactos/base/applications/games/solitaire/en.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol itaire/en.rc?rev=22649&r1=22648&r2=22649&view=diff ============================================================================ == --- trunk/reactos/base/applications/games/solitaire/en.rc (original) +++ trunk/reactos/base/applications/games/solitaire/en.rc Tue Jun 27 03:50:03 2006 @@ -1,3 +1,10 @@ +/* + * PROJECT: Solitaire + * LICENSE: Freeware, permission to use under Public Domain + * FILE: base/applications/games/solitaire/en.rc + * PURPOSE: English Language File for Solitaire + * PROGRAMMERS: Daniel "EmuandCo" Reimer (reimer.daniel(a)freenet.de) + */ #include "resource.h" #define APSTUDIO_READONLY_SYMBOLS

4 3

Re: [ros-dev] [ros-diffs] [greatlrd] 22614: fixing link for explo rer and regedit thanks apal for the patch see bug 1626
by Murphy, Ged (Bolton) 26 Jun '06

26 Jun '06

Thomas Weidenmueller wrote > > Ged Murphy wrote: > > IMO, this change is wrong and should be reverted. > > Yes, this change is wrong and should be reverted. Search paths aren't > correctly supported at the moment, that's why it doesn't > always find the > executables... Might be worth dropping into the 0.3 branch though as a quick fix if the real issue isn't solved before RC2. Ged.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev