Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

CD Logo
by David Johnson 07 Jun '06

07 Jun '06

Any thoughts? -- Dave Johnson http://www.davefilms.us DaveFILMS(r) http://thevoicezone.us The Voice Zone™ Voice Talent Writer, Producer, Director Independent Audio Theater Producer http://www.perditioncity.us voiceoverjobs(a)gmail.com Member of the Darker Projects team. http://www.darkerprojects.com ShadoeWorld.com Correspondent ---------------------------------------------------------- Tired of a proprietary Windows on your computer ? Use free ReactOS instead ( http://www.reactos.org )

5 9

Target Hardware
by David Johnson 06 Jun '06

06 Jun '06

I would like to propose a target hardware list. Like a type of motherboard that should be used. Sound card and video card. Thoughts? -- Dave Johnson http://www.davefilms.us DaveFILMS(r) http://thevoicezone.us The Voice Zone™ Voice Talent Writer, Producer, Director Independent Audio Theater Producer http://www.perditioncity.us voiceoverjobs(a)gmail.com Member of the Darker Projects team. http://www.darkerprojects.com ShadoeWorld.com Correspondent ---------------------------------------------------------- Tired of a proprietary Windows on your computer ? Use free ReactOS instead ( http://www.reactos.org )

3 2

Trunk Foobared
by Alex Ionescu 06 Jun '06

06 Jun '06

Hi, I am aware that I broke trunk. This is because I've removed the code in ObReferenceObjectByHandle which allowed GENERIC access masks to be converted. This API does NOT support GENERIC access masks and converting to them was incorrect, however, as always, plenty of code in ROS abused the system and calls this API incorrectly. Although ObOpenObjectByName should return a handle and IoCreateFile should be done with it, because parsing is broken (so it creeps up again!), we try to re-reference it by handle to get its pointer... however, this attempt is made with the current AccessMode, which happens to be User, and if the AccessMask was GENERIC... we fail. ObOpenObjectByName is made to be used with GENERIC access masks so that's really not a problem. Hopefully the I/O File stuff is the only place where this happens, so I will implement a simple hack - call ObReferenceObjectByHandle with a KernelMode parameter so that access checks are skipped (we've already done them in ObOpenObjectByName anyways!). Best regards, Alex Ionescu

1 1

Policy question
by Myria 06 Jun '06

06 Jun '06

Should ReactOS copy unnecessary restrictions that Windows has? The example I'm thinking of is NtSetLdtEntries. In Windows NT (and currently ReactOS as well), this function will not let you create an LDT entry whose limit is above the user/kernel barrier. This restriction sounds like it was made with security in mind, but it doesn't affect security. The processor's page table will already block access to kernel memory no matter what selector you use. After all, the default user CS and DS already have a limit of FFFFFFFF. Should such a problem be fixed? Fireball said "no, unless some 3rd party app or driver depends on them" when I asked about whether such restrictions should be copied. Pretty much the only thing using NtSetLdtEntries is NTVDM, and this restriction already causes some DOS programs to break that would otherwise work. (Such programs are usually setting selectors that wrap the address space.) Melissa

3 5

ULONG vs. SIZE_T
by Myria 05 Jun '06

05 Jun '06

I've noticed that in the ReactOS source code, there are many places where a parameter or structure is ULONG when it should really be SIZE_T. Using ULONG instead of SIZE_T is not portable. It will be difficult to port ReactOS to x64 and Itanium in the future because of this. I think the project should stop the bleeding by requiring all new code to make proper use of ULONG versus SIZE_T. This does mean going against the documentation of native syscalls on the Internet, but it must be done sometime. Of course, I'm not really part of the project... Melissa

3 2

X-Chat 2
by James Tabor 05 Jun '06

05 Jun '06

Hi all Could be all based on wine patches, I can no longer get xchat 2 and the new one to run. I noticed it can not find the lib directory in the launch directory. Wine has this problem too. Also when installing the new X-Chat 2 from http://www.silverex.org/download/xchat-2.6.2-1.exe, It installs the Font to C:\ReactOS\Fonts not C:\ReactOS\media\fonts. I had to create C:\ReactOS\Fonts so I can have a clean install. I tested my GGO patch and the SVN and the result are the same. Okay, wine does this too, I tested it. (dll/ntdll/ldr/utils.c:2019) Failed to create or open dll section of 'libgtk-win 32-2.0-0.dll' (Status c0000135) (dll/ntdll/ldr/utils.c:1347) failed to load libgtk-win32-2.0-0.dll (dll/ntdll/ldr/utils.c:1812) failed to load libgtk-win32-2.0-0.dll (dll/ntdll/ldr/utils.c:1934) LdrFixupImports() failed for xchat.EXE (dll/ntdll/ldr/startup.c:485) Failed to initialize image Then do it from lib, "..\xchat" (dll/ntdll/ldr/utils.c:2019) Failed to create or open dll section of 'pango-1.8.2/lib/pango/1.4.0/modules/pango-basic-win32.dll"' (Status c0000135) You will get a popup. This has been a problem for years! Thanks, James

1 0

Break in 22232
by James Tabor 05 Jun '06

05 Jun '06

Hi, I'm getting this with Mozilla, Firefox and SeaMonkey. KeBugCheck at ntoskrnl/cm/regobj.c:528 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. Technical information: *** STOP: 0x00000051 (0x00000000,0x00000000,0x00000000,0x00000000) Frames: <ntoskrnl.exe:1d50 (ntoskrnl/ke/bug.c:493 (KeBugCheckEx))> <ntoskrnl.exe:1d67 (ntoskrnl/ke/bug.c:514 (KeBugCheck))> <ntoskrnl.exe:129c6 (ntoskrnl/cm/regobj.c:528 (CmiObjectDelete))> <ntoskrnl.exe:52c6b (ntoskrnl/ob/oblife.c:151 (ObpDeleteObject))> <ntoskrnl.exe:1290c (ntoskrnl/cm/regobj.c:523 (CmiObjectDelete))> <ntoskrnl.exe:52c6b (ntoskrnl/ob/oblife.c:151 (ObpDeleteObject))> <ntoskrnl.exe:50f4c (ntoskrnl/ob/obhandle.c:153 (ObpDecrementHandleCount))> <ntoskrnl.exe:510b0 (ntoskrnl/ob/obhandle.c:244 (ObpDeleteHandle))> <ntoskrnl.exe:52166 (ntoskrnl/ob/obhandle.c:1125 (NtClose))> <ntoskrnl.exe:66527 (ntoskrnl/ke/i386/trap.s:306 (KiFastCallEntry))> <ADVAPI32.dll:7dd9 (dll/win32/advapi32/reg/reg.c:1178 (RegDeleteKeyA))> All three are the same, James

1 0

0.3.0 RC1 problems
by Brandon Turner 05 Jun '06

05 Jun '06

I cant seem to make a stable qemu install for the release, wmare works fine though. On the first boot to the installed desktop, it just shuts down after about 1 sec. I usually see the device wizard pop up for a sec and then it just turns off. Anyone else having thse problems? Any hints? Brandon

2 1

Patches: A couple of Spelling Fixes
by Neil Blackburn 05 Jun '06

05 Jun '06

Hi! I submitted a couple of patches to Bugzilla Bug 1555. Can someone please commit the patches for me. Thanks.

2 1

Re: [ros-dev] [ros-diffs] [greatlrd] 22195: make malloc, calloc and some other function return NULL if size is 0
by Royce Mitchell III 04 Jun '06

04 Jun '06

greatlrd(a)svn.reactos.org wrote: >@@ -52,6 +55,9 @@ > */ > void* calloc(size_t _nmemb, size_t _size) > { >+ if ( _size == 0) >+ return NULL; >+ > return HeapAlloc(hHeap, HEAP_ZERO_MEMORY, ROUND_SIZE(_nmemb*_size) ); > } > > What if _nmemb is zero? > >@@ -60,6 +66,9 @@ > */ > void* realloc(void* _ptr, size_t _size) > { >+ if ( _size == 0) >+ return NULL; >+ > if (!_ptr) return malloc(_size); > if (_size) return HeapReAlloc(hHeap, 0, _ptr, ROUND_SIZE(_size)); > free(_ptr); >@@ -71,6 +80,9 @@ > */ > > umm... shouldn't we call free() if we're going to return NULL because size is 0? Also, the free() at the bottom is never called now. > void* _expand(void* _ptr, size_t _size) > { >+ if ( _size == 0) >+ return NULL; >+ > return HeapReAlloc(hHeap, HEAP_REALLOC_IN_PLACE_ONLY, _ptr, ROUND_SIZE(_size)); > } > > Again, shouldn't we free the existing buffer if we're returning NULL because size is 0?

7 11

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev