> From: navaraf(a)svn.reactos.com
>
> Don't make cells smaller than they are.
Wow. Isn't it time we factor out the common code in cm, mkhive and freeldr
and put it in a static library?
GvG
navaraf(a)svn.reactos.com wrote:
> Don't make cells smaller than they are.
> Modified: trunk/reactos/ntoskrnl/cm/regfile.c
>
> ------------------------------------------------------------------------
> *Modified: trunk/reactos/ntoskrnl/cm/regfile.c*
> --- trunk/reactos/ntoskrnl/cm/regfile.c 2005-11-26 13:26:48 UTC (rev 19635)
> +++ trunk/reactos/ntoskrnl/cm/regfile.c 2005-11-26 15:21:44 UTC (rev 19636)
> @@ -3431,7 +3431,7 @@
>
> RtlZeroMemory(*Cell,
> CellSize);
>
> - ((PCELL_HEADER) (*Cell))->CellSize = -CellSize;
>
> + ((PCELL_HEADER) (*Cell))->CellSize *= -1;
>
> }
>
> return STATUS_SUCCESS;
>
This change is wrong. Possible we have split the cell. In this case, we
have to set the new cell size.
- Hartmut
> From: chorns(a)svn.reactos.com
>
> Speed up compilation of ntoskrnl
Hmm, an unexpected consequence is that we can no longer enable DPRINTs per
file by removing the "#define NDEBUG" statement. At the moment, the first
source files included by io.c and cc.c (resp io/adapter.c and cc/cacheman.c)
don't define NDEBUG before including debug.h. As a result, all DPRINTs in
every file included by io.c/cc.c are enabled.
GvG
sgasiorek(a)svn.reactos.com wrote:
> + wprintf(PML_TransError(error, (WCHAR*)errbuf, sizeof(errbuf)/sizeof(WCHAR)));
This typecast is kind of useless...
- Thomas
Hi!
sgasiorek(a)svn.reactos.com wrote:
> - changed name of package library to package.dll
> - fixed PML_TransError function (possibly fixes bug 730)
>
>
>
> Added files:
> trunk/rosapps/packmgr/lib/package.xml
>
> Updated files:
> trunk/rosapps/packmgr/cmd-line/rosget.xml
> trunk/rosapps/packmgr/directory.xml
> trunk/rosapps/packmgr/gui/main.c
> trunk/rosapps/packmgr/gui/packmgr.xml
> trunk/rosapps/packmgr/lib/es.rc
> trunk/rosapps/packmgr/lib/main.cpp
> trunk/rosapps/packmgr/lib/package.cpp
> trunk/rosapps/packmgr/lib/package.h
> trunk/rosapps/packmgr/lib/package.hpp
>
> Deleted files:
> trunk/rosapps/packmgr/lib/packlib.xml
>
[CC] modules/rosapps/packmgr/cmd-line/main.c
modules/rosapps/packmgr/cmd-line/main.c: In function `SetStatus':
modules/rosapps/packmgr/cmd-line/main.c:123: error: too few arguments to function `PML_TransError'
modules/rosapps/packmgr/cmd-line/main.c: In function `Install':
modules/rosapps/packmgr/cmd-line/main.c:139: error: too few arguments to function `PML_TransError'
modules/rosapps/packmgr/cmd-line/main.c:162: error: too few arguments to function `PML_TransError'
modules/rosapps/packmgr/cmd-line/main.c: In function `Show':
modules/rosapps/packmgr/cmd-line/main.c:186: error: too few arguments to function `PML_TransError'
make[1]: *** [obj-i386/modules/rosapps/packmgr/cmd-line/main.o] Error 1
Thanks,
James
No, the Shutdown/Restart and Log Off portions are in need of a
re-write, AFAIK. Since Local User Accounts are not implemented yet, we
cannot "Log Off" per se on ReactOS just yet.
On 11/25/05, Alex Buell <alex.buell(a)munted.org.uk> wrote:
> Has someone confused the Log off menu item with the Shutdown menu item?
> When logging off, it reboots. Is this intended?
>
> --
> http://www.munted.org.uk
>
> Anyone that thinks an imaginary deity is going to protect them against
> earthquakes and hurricanes needs psychiatric help.
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
--
"I had a handle on life, but then it broke"
anybody have a problem with me changing Tab+K to Esc+K.
I was working in command prompt and accidentally hit the combo when
using tab completion.
Thanks
> From: greatlrd(a)svn.reactos.com
>
> implement addbuffer to waveTheard. it can play wave one time
> if it is same file in windows
I guess you forgot to commit a header file:
[CC] lib/mmdrv/wave.c
lib/mmdrv/wave.c: In function `waveThread':
lib/mmdrv/wave.c:94: error: syntax error before '*' token
lib/mmdrv/wave.c:99: error: `pHdrSearching' undeclared (first use in this
function)
lib/mmdrv/wave.c:99: error: (Each undeclared identifier is reported only
once
lib/mmdrv/wave.c:99: error: for each function it appears in.)
lib/mmdrv/wave.c:116: warning: implicit declaration of function `waveStart'
GvG