Ros-dev

ros-dev@reactos.org

5788 discussions

crash in usetup if an allocation size is given for a call to NtCreateFile

by Hartmut Birr

Hi, I've done some little changes in usetup for optimisation. One thing is the decompressing of files from a cabinet container. If the destination file exist, it is created with the create disposition FILE_OVERWRITE and without a pointer to the allocation size. If I add an allocation size pointer (cabinet.c.diff), usetup does crash after copying of all files and creating the registry. (ntoskrnl\ke\exception.c:94) KiRaiseException (ntoskrnl\ke\i386\exp.c:1306) Unhandled UserMode exception, terminating thread Exception: -1160049408(0) Processor: 0 CS:EIP 1b:12000 ????? cr2 66f924 cr3 56a000 Proc: 8094a1f0 Pid: 5c <smss.exe> Thrd: 80954088 Tid: 60 DS 23 ES 23 FS 3b GS 0 EAX: 00012000 EBX: 00000001 ECX: 0066fc18 EDX: 7c90a479 EBP: 0066ff54 ESI: 00000004 ESP: 807ebd64 EDI: 0066fc28 EFLAGS: 00000216 Frames: <smss.exe:741b> subsys/system/usetup/console.c:660 <smss.exe:19c41> subsys/system/usetup/usetup.c:3321 <smss.exe:1a65e> subsys/system/usetup/usetup.c:3781 <0> The address of the crash has nothing to do with the decompressing of the install files. If I change IoCreateFile file a little bit, that the allocation size pointer isn't read (file.c.diff), usetup didn't crash. Has someone an idea what is wrong? - Hartmut Index: subsys/system/usetup/cabinet.c =================================================================== --- subsys/system/usetup/cabinet.c (Revision 18300) +++ subsys/system/usetup/cabinet.c (Arbeitskopie) @@ -859,6 +859,7 @@ UnicodeString.Buffer = DestName + wcslen( DestName ); UnicodeString.Length = 0; RtlAnsiStringToUnicodeString( &UnicodeString, &AnsiString, FALSE ); + MaxDestFileSize.QuadPart = Search->File->FileSize; /* Create destination file, fail if it already exists */ RtlInitUnicodeString(&UnicodeString, @@ -884,7 +885,7 @@ 0); if (!NT_SUCCESS(NtStatus)) { - DPRINT("NtCreateFile() failed (%S) (%x).\n", DestName, NtStatus); + DPRINT1("NtCreateFile() failed (%S) (%x).\n", DestName, NtStatus); /* If file exists, ask to overwrite file */ if (OverwriteHandler == NULL || OverwriteHandler(Search->File, DestName)) @@ -894,7 +895,7 @@ GENERIC_READ | GENERIC_WRITE | SYNCHRONIZE, &ObjectAttributes, &IoStatusBlock, - NULL, + &MaxDestFileSize, FILE_ATTRIBUTE_NORMAL, 0, FILE_OVERWRITE, @@ -903,7 +904,7 @@ 0); if (!NT_SUCCESS(NtStatus)) { - DPRINT("NtCreateFile() failed 2 (%S) (%x).\n", DestName, NtStatus); + DPRINT1("NtCreateFile() failed 2 (%S) (%x).\n", DestName, NtStatus); return CAB_STATUS_CANNOT_CREATE; } } @@ -913,7 +914,6 @@ return CAB_STATUS_FILE_EXISTS; } } - MaxDestFileSize.QuadPart = Search->File->FileSize; NtStatus = NtCreateSection(&DestFileSection, SECTION_ALL_ACCESS, 0, @@ -964,7 +964,10 @@ } else { +// memcpy(&FileBasic.CreationTime, &FileTime, sizeof(FILETIME)); memcpy(&FileBasic.LastAccessTime, &FileTime, sizeof(FILETIME)); +// memcpy(&FileBasic.LastWriteTime, &FileTime, sizeof(FILETIME)); +// memcpy(&FileBasic.ChangeTime, &FileTime, sizeof(FILETIME)); NtStatus = NtSetInformationFile(DestFile, &IoStatusBlock, @@ -1050,6 +1053,7 @@ Status = CAB_STATUS_SUCCESS; UnmapDestFile: NtUnmapViewOfSection(NtCurrentProcess(), DestFileBuffer); +// NtFlushBuffersFile(DestFile, &IoStatusBlock); CloseDestFileSection: NtClose(DestFileSection); CloseDestFile: Index: ntoskrnl/io/file.c =================================================================== --- ntoskrnl/io/file.c (Revision 18300) +++ ntoskrnl/io/file.c (Arbeitskopie) @@ -787,7 +787,11 @@ sizeof(ULONG)); if(AllocationSize != NULL) { - SafeAllocationSize = ProbeForReadLargeInteger(AllocationSize); + ProbeForRead(AllocationSize, + sizeof(LARGE_INTEGER), + sizeof(ULONG)); + SafeAllocationSize.QuadPart = 0 /* AllocationSize->QuadPart */; +// SafeAllocationSize = ProbeForReadLargeInteger(AllocationSize); } else SafeAllocationSize.QuadPart = 0;

19 years, 3 months

RE: [ros-svn] [turner] 18402: set to eol-style native ;)

by Casper Hornstrup

Open C:\Documents and Settings\...\Application Data\Subversion\config. Make sure the following is in there: [miscellany] enable-auto-props = yes [auto-props] *.c = svn:eol-style=native *.h = svn:eol-style=native *.S = svn:eol-style=native *.sh = svn:eol-style=native;svn:executable *.rc = svn:eol-style=native *.mc = svn:eol-style=native *.asm = svn:eol-style=native *.cpp = svn:eol-style=native *.cxx = svn:eol-style=native *.txt = svn:eol-style=native *.xml = svn:eol-style=native *.ini = svn:eol-style=native *.inf = svn:eol-style=native *.def = svn:eol-style=native *.dsp = svn:eol-style=CRLF *.dsw = svn:eol-style=CRLF *.gif = svn:mime-type=image/gif *.png = svn:mime-type=image/png *.jpg = svn:mime-type=image/jpeg *.bmp = svn:mime-type=application/octet-stream *.ico = svn:mime-type=application/octet-stream *.ttf = svn:mime-type=application/octet-stream *.nls = svn:mime-type=application/octet-stream *.mp3 = svn:mime-type=application/octet-stream *.wav = svn:mime-type=application/octet-stream Makefile = svn:eol-style=native DON'T add: * = svn:eol-style=native or Magic Things (TM) will happen ;-) Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.org [mailto:ros-svn-bounces@reactos.org] On Behalf Of > turner(a)svn.reactos.com > Sent: 10. oktober 2005 21:09 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [turner] 18402: set to eol-style native ;) > > set to eol-style native ;) > > > Updated files: > trunk/reactos/subsys/system/cmd/readme2.txt > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-svn

19 years, 3 months

Re: [ros-diffs] [gdalsnes] 18403: alloc multiple of 16 bytes

by Alex Ionescu

gdalsnes(a)svn.reactos.com wrote: > alloc multiple of 16 bytes > Modified: trunk/reactos/lib/crt/stdlib/malloc.c > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/crt/stdlib/malloc.c* > --- trunk/reactos/lib/crt/stdlib/malloc.c 2005-10-10 19:08:57 UTC (rev 18402) > +++ trunk/reactos/lib/crt/stdlib/malloc.c 2005-10-10 20:18:07 UTC (rev 18403) > @@ -25,6 +25,10 @@ > #include <stdlib.h> > #include <malloc.h> > > > + > +/* fixme: should have this in common header */ > +#define ROUND_UP(a,b) ((a + (b-1)) & ~(b-1)) > helper.s > + > > extern HANDLE hHeap; > > /* > @@ -32,7 +36,7 @@ > > */ > void* malloc(size_t _size) > { > > - return HeapAlloc(hHeap, HEAP_ZERO_MEMORY, _size); > > + return HeapAlloc(hHeap, 0, ROUND_UP(_size, 16)); > > } > > /* > @@ -48,7 +52,7 @@ > > */ > void* calloc(size_t _nmemb, size_t _size) > { > > - return HeapAlloc(hHeap, HEAP_ZERO_MEMORY, _nmemb*_size); > > + return HeapAlloc(hHeap, HEAP_ZERO_MEMORY, ROUND_UP(_nmemb*_size, 16) ); > > } > > /* > @@ -57,8 +61,8 @@ > > void* realloc(void* _ptr, size_t _size) > { > if (!_ptr) > > - return HeapAlloc(hHeap, 0, _size); > - return HeapReAlloc(hHeap, 0, _ptr, _size); > > + return HeapAlloc(hHeap, 0, ROUND_UP(_size, 16)); > + return HeapReAlloc(hHeap, 0, _ptr, ROUND_UP(_size, 16)); > > } > > /* > @@ -66,7 +70,7 @@ > > */ > void* _expand(void* _ptr, size_t _size) > { > > - return HeapReAlloc(hHeap, HEAP_REALLOC_IN_PLACE_ONLY, _ptr, _size); > > + return HeapReAlloc(hHeap, HEAP_REALLOC_IN_PLACE_ONLY, _ptr, ROUND_UP(_size, 16)); > > } > > /* > Ever heard of HEAP_ALIGN_16? Best regards, Alex Ionescu

19 years, 3 months

Re: [ros-svn] [gdalsnes] 18404: alloc at minimum 16 bytes (spotted by WaxDragon)

by Alex Ionescu

gdalsnes(a)svn.reactos.com wrote: > alloc at minimum 16 bytes (spotted by WaxDragon) > realloc should free passed mem if new size is 0 > > > Updated files: > trunk/reactos/lib/crt/stdlib/malloc.c > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-svn > > This fixes the bug in windres, right? Best regards, Alex Ionescu

19 years, 3 months

RE: 18273: create some start menu entries for notepad, regedit and winefile

by Ge van Geldorp

> From: mf(a)svn.reactos.com > > create some start menu entries for notepad, regedit and winefile Do we really need/want the winefile link on the desktop? Especially since it is also present in the start menu now. If I recall correctly, the Command Prompt was put on the desktop 'cause at the time it was the only viable way to start programs, I think maybe even the Command Prompt link could go from the desktop now. Gé van Geldorp.

19 years, 3 months

some thoughts

by D. Hazelton

I've been thinking about a chat I had with Alex Ionescu about the "userspace driver framework" that MS has put in Windows Vista for a couple of days now. Mostly I was trying to think of how they could create a secure system where the drivers could live outside the kernel and still manage to do the job of providing clean access to the hardware. I was doing this because I am just starting to take a look at the ReactOS code with an eye towards helping on the project. That being the case I decided to see if I could find a spot where I could fit my skills into the project. While I'm more geared towards fixing bugs or filling out places marked "TODO" the thought of userspace drivers - or rather, just the thought that such a system would allow for drivers that could die and not take the system with them - has caught my interest. At the current time the only way I can see this being done is by using the HAL to abstract all hardware and providing an API that, via the HAL, will allow for _AUTHENTICATED_ programs (aka drivers) to register themselves with the kernel and provide access to said devices. The access itself would best be handled by the drivers registering an interface that programs can use to call directly into the driver. This just leaves me with a simple problem to solve - should the interface be a COM/COM+ interface (or it's primitive, since I don't think anyone wants the lag having COM/COM+ in the kernel would cause) or should it be something simpler, like a UFS path ? DRH (if the PGP signature looks bad, the list probably modified the mail)

19 years, 3 months

Installation Error

by Brandon Turner

After copying the files over in stage 1 installer i get the error "Failed to create regisrty hives". This is off a clean build i am doing(RosBE), same result when i download a iso from sin. any advice? Brandon

19 years, 3 months

ping: maximum length value

by Emanuele Aliberti

NT 5.1/SP2: maximum length = 65500 ROS: maximum length = 65519 -- :Emanuele Aliberti

19 years, 3 months

VOTE: List loop macros in ntoskrnl?

by Thomas Weidenmueller

As according to our voting rules, any permanent developer may vote on this for one week as of now. Should the flow control macros for looping double linked lists be allowed in ntoskrnl? [ ] Yes [ ] No More on voting can be found at: http://www.reactos.com/wiki/index.php/Voting

19 years, 3 months

LinuxWorld report

by Ge van Geldorp

Just a quick report from LinuxWorld London. We've just finished the first day of the exhibition, lots of interest. What surprised me a bit was that the general awareness about the project was somewhat lower than last year in Frankfurt. I guess that 80-90% of the people we spoke last year had already heard about the project, that percentage was a lot lower here (more around 30%). Another pleasant surprise was the stability of the system. We ran it on an old laptop with a few applications: Quake 1, WinZip, IrfanView, AbiWord. On demand we showed some other apps like regedit, notepad, task manager. The system froze one time when a visitor played around with it, other than that no problems at all. Not a single kernel crash. We had to Tab-K to force a kernel check to show the BSOD to a visitor. I say let's bring out r18189 (I think...) as 0.2.8 (j/k). People were reacting very nicely. It was nice to see them picking up a flyer rather uninterestedly, start to read, and then suddenly turn back to watch the demo when they realized what the project was all about. Ge van Geldorp.

19 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev