Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-svn] [ion] 18183: - KeRundownThread:
by Witukind 02 Oct '05

02 Oct '05

On Sat, 1 Oct 2005 09:50:08 +0200 <ion(a)svn.reactos.com> wrote: >> which means the mutant has been already freed). omfg! we're all going to die!!! ;)

1 0

Re: [ros-svn] [ion] 18202: - Small semaphore code simplification/optimization.
by Hartmut Birr 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >- Small semaphore code simplification/optimization. > > >Updated files: >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/sem.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Have you tried to compile sem.c before you did commit? - Hartmut

2 1

Plug and Play status - Device installation
by Hervé Poussineau 02 Oct '05

02 Oct '05

Hello, Since some weeks/months, I've done some work in setupapi.dll. I'm now able to install devices using provided .inf files, ie copy needed files and create registry entries. Syntax: rundll32.exe newdev.dll,DevInstall [InstanceID] where InstanceID is something like ACPI\PNP0501\1 or PCI\VEN_8086&DEV_7112&SUBSYS_00000000&REV_01\3&61aaa01&0&3A However, I've still some bugs and some missing features: - OpenSCManagerW freezes ReactOS [1] - CreateServiceW is unimplemented [2] - Service image path provided to CreateServiceW looks like "C:\ReactOS\System32\drivers\driver.sys", instead of "System32\drivers\driver.sys" [3] - You have no way to use a .inf file which is not in ReactOS\Inf directory [4] - Files to be copied are always searched in ReactOS\Inf directory (so they can't be found) [5] - Files to be copied need to be already decompressed (ie not in a .cab file) [6] - A reboot is needed before being able to use the newly installed device [7] - Having multiple times a same device is not supported, if the bus driver can't provide a unique DeviceID [8] - Last, but not least, device installation is not started automatically when a new device is found/plugged [9] [1] See bug #826: http://www.reactos.org/bugzilla/show_bug.cgi?id=826 [2] In lib/advapi32/service/scm.c. It needs to call umpnpmgr.exe by RPC, as in OpenServiceW implementation [3] In lib/setupapi/dirid.c: the value returned by create_system_dirid() is always a full path [4] It's due to missing functionnality in newdev.dll (lib/newdev/*), which should ask the user when no driver is found [5] In lib/setupapi/queue.c. If a file can't be found, SetupCommitFileQueueW should ask the user where to find the file [6] We need to support the [SourceDisksNames] section in .inf files [7] Maybe calling IoInvalidateDeviceRelations() at the end of SetupDiInstallDevice (lib/setupapi/devinst.c) would be enough [8] We need to generate a ParentIdPrefix entry in registry in some(?) cases [9] I suppose it should be initiated by umpnpmgr.exe, when it sees a device for the first time Hervé PS: If someone is interested to work on one of this parts, please answer this email

2 1

Re: [ros-diffs] [weiden] 18213: minor changes (mostly formatting)
by Hartmut Birr 02 Oct '05

02 Oct '05

weiden(a)svn.reactos.com wrote: >minor changes (mostly formatting) > >Modified: trunk/reactos/lib/hid/hid.c >Modified: trunk/reactos/lib/shellext/slayer/slayer.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/hid/hid.c* > >--- trunk/reactos/lib/hid/hid.c 2005-10-02 12:27:54 UTC (rev 18212) >+++ trunk/reactos/lib/hid/hid.c 2005-10-02 12:46:49 UTC (rev 18213) >@@ -368,8 +368,8 @@ > > HidD_Hello(OUT PCHAR Buffer, > IN ULONG BufferLength) > { > > >- const PCHAR HelloString = "Hello\n"; >- ULONG StrSize = (lstrlenA(HelloString) + 1) * sizeof(CHAR); > > >+ const CHAR HelloString[] = "Hello\n"; >+ ULONG StrSize = sizeof(HelloString) + sizeof(HelloString[0]); > > > > if(BufferLength > 0) > { > > > ------------------------------------------------------------------------ Hi, sizeof(HelloString) does already contain the terminating NULL. - Hartmut

2 1

Re: [ros-svn] [ion] 18201: - Add RtlSetProcessCritical
by Hartmut Birr 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >- Add RtlSetProcessCritical >- Some fixes. > > >Updated files: >trunk/reactos/include/ndk/ketypes.h >trunk/reactos/include/ndk/pstypes.h >trunk/reactos/include/ndk/rtlfuncs.h >trunk/reactos/include/ndk/rtltypes.h >trunk/reactos/include/ndk/umtypes.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Hi, the header changes breaks compiling for me: gcc -c boot\freeldr\freeldr\cache\blocklist.c -o .\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o -nostdlib -ffreestanding -fno-builtin -fno-inline -fno-zero-initialized-in-bss -Os -Iboot\freeldr\freeldr\include -Iboot\freeldr\freeldr\cache -Intoskrnl\include -D__USE_W32API -DDEBUG -Iinclude -Iinclude\reactos -Iinclude\libs -Iinclude\drivers -Iinclude\subsys -Iw32api\include -Iw32api\include\ddk -D_M_IX86 -DDBG -Wall -Os -Wno-strict-aliasing -ftracer -momit-leaf-frame-pointer -mpreferred-stack-boundary=2 -Wpointer-arith -g -pipe In file included from include/ndk/psfuncs.h:13, from include/ndk/ntndk.h:34, from boot/freeldr/freeldr/include/freeldr.h:24, from boot\freeldr\freeldr\cache\blocklist.c:21: include/ndk/pstypes.h:627: error: syntax error before 'PHANDLE_TABLE' include/ndk/pstypes.h:627: warning: no semicolon at end of struct or union include/ndk/pstypes.h:628: warning: type defaults to 'int' in declaration of 'Token' include/ndk/pstypes.h:628: warning: data definition has no type or storage class include/ndk/pstypes.h:655: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:668: error: syntax error before 'PrefetchTrace' include/ndk/pstypes.h:668: warning: type defaults to 'int' in declaration of 'PrefetchTrace' include/ndk/pstypes.h:668: warning: data definition has no type or storage class include/ndk/pstypes.h:718: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:730: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:745: error: syntax error before '}' token include/ndk/pstypes.h:745: warning: type defaults to 'int' in declaration of 'EPROCESS' include/ndk/pstypes.h:745: warning: data definition has no type or storage class _make: *** [.\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o] Error 1 - Hartmut

1 0

Re: [ros-svn] [ion] 18118: - Some NDK fixes when compiling with PSDK.
by Emanuele Aliberti 02 Oct '05

02 Oct '05

ion(a)svn.reactos.com wrote: >Deleted files: >trunk/reactos/include/subsys/csr/protocol.h >trunk/reactos/subsys/csr/args.c >trunk/reactos/subsys/csr/csr.h >trunk/reactos/subsys/csr/csrsrv/debug.c >trunk/reactos/subsys/csr/csrsrv/dllmain.c > > Well, a bit unfair deleting header files etc. and leaving the subtree not compilable. My working copy depends on those very files. Disabling compilation of csr also forces me to disable the vms module: not a great loss, but we had only two left: os2 and posix are broken. Keeping the whole modules compilable should be a goal, even if they are minimal subsystems (if ROS is just Win32, well, let's rename it back "FreeWin95"). -- :Emanuele Aliberti

2 2

svn: how do I restore a deleted file?
by Emanuele Aliberti 02 Oct '05

02 Oct '05

How do I restore a file deleted at revision xyz? -- :Emanuele Aliberti

2 2

another macro: OPTHDROFFSET
by vit-ros＠att.net 01 Oct '05

01 Oct '05

Hi, I found the OPTHDROFFSET not very useful. I would rather use something lighter like: (PIMAGE_NT_HEADERS)((PBYTE)a + ((PIMAGE_DOS_HEADER)a)->e_lfanew)) , same as RtlImageNtHeader() May i ask someone with write access to remove it?

2 1

Website
by Rick Langschultz 01 Oct '05

01 Oct '05

Hey everyone, The website looks great. Props to the creators and website admin... Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

8 8

Re: [ros-svn] [ea] 18180: Fix build.
by Thomas Weidenmueller 30 Sep '05

30 Sep '05

ea(a)svn.reactos.com wrote: > Fix build. Oops, sorry about that... Thanks for fixing it. -Thomas

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev