Ros-dev

ros-dev@reactos.org

1 participants
5791 discussions

Subsystems, how to write one
by crashfourit 29 Sep '05

29 Sep '05

What are the relevent ReactOS API calls for building a dynamicly loadable subsystem? I'm asking this because I can't find the API documentation on the website. (I looks more like the documentation is not yet completed.) Other questions relevent to this: How do I register a new executible file format? I.E. coff. How do I register a new interrupt vector(s). What are the API to control v86 prosses? If y'all want to know what subsystem I want to write, it is DOS. This is because I'm more familar with programing in DOS.

2 2

New website
by Ge van Geldorp 28 Sep '05

28 Sep '05

Thursday afternoon (UTC) the website will be unavailable for some time. We're going to make the switch to the new website design then. At the same time, we're moving to www.reactos.org as the primary name for the website, with www.reactos.com being an alias (you'll be redirected automatically to www.reactos.org if you use the old name). The mailing lists are also going to be moved from reactos.com to reactos.org, so if you have filtering in place please take this into account. Many thanks to Michael Wirth and especially Klemens Friedl who put a lot of effort in the new site. Gé van Geldorp.

1 0

Re: [ros-diffs] [gdalsnes] 18113: -reorder InsertXscendingOrder macro argument order and update uses
by Hartmut Birr 27 Sep '05

27 Sep '05

gdalsnes(a)svn.reactos.com wrote: > *Modified: trunk/reactos/include/reactos/helper.h* > >--- trunk/reactos/include/reactos/helper.h 2005-09-26 22:06:31 UTC (rev 18112) >+++ trunk/reactos/include/reactos/helper.h 2005-09-26 22:57:48 UTC (rev 18113) >@@ -18,17 +18,21 @@ > > #define EXPORTED __declspec(dllexport) > #define IMPORTED __declspec(dllimport) > > > >-/* iterate through the list using a list entry */ > > >+/* iterate through the list using a list entry. >+ * elem is set to NULL if the list is run thru without breaking out or if list is empty. >+ */ > > > #define LIST_FOR_EACH(elem, list, type, field) \ > for ((elem) = CONTAINING_RECORD((list)->Flink, type, field); \ > > >- &(elem)->field != (list); \ > > >+ &(elem)->field != (list) || (elem = NULL); \ > > > (elem) = CONTAINING_RECORD((elem)->field.Flink, type, field)) > > > Hi, IMHO, this is very bad code. You use a macro to hide a 'for' loop, and later in the source you use a 'break', 'continue' or 'goto' statement to leave the loop or to bypass some code. /* Find entry with SortKey greater than or equal to the passed-in SortKey */ LIST_FOR_EACH(ReturnEntry, &DeviceQueue->DeviceListHead, KDEVICE_QUEUE_ENTRY, DeviceListEntry) { /* Check if keys match */ if (ReturnEntry->SortKey >= SortKey) { /* We found it, so just remove it */ RemoveEntryList(&ReturnEntry->DeviceListEntry); break; } } Such a source is simply unreadable. - Hartmut

3 3

Re: [ros-diffs] [navaraf] 18070: Revert r18064 and correctly set the cell size for hash cells.
by Hartmut Birr 26 Sep '05

26 Sep '05

navaraf(a)svn.reactos.com wrote: >Revert r18064 and correctly set the cell size for hash cells. > >Modified: trunk/reactos/ntoskrnl/cm/regfile.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/ntoskrnl/cm/regfile.c* > >--- trunk/reactos/ntoskrnl/cm/regfile.c 2005-09-25 20:46:28 UTC (rev 18069) >+++ trunk/reactos/ntoskrnl/cm/regfile.c 2005-09-25 20:54:40 UTC (rev 18070) >@@ -3033,6 +3033,7 @@ > > else > { > ASSERT(SubKeyCount <= 0xffff); /* should really be USHORT_MAX or similar */ > > >+ NewHashBlock->CellSize = -NewHashSize; > > > NewHashBlock->Id = REG_HASH_TABLE_CELL_ID; > NewHashBlock->HashTableSize = (USHORT)SubKeyCount; > *HashBlock = NewHashBlock; > > Are you sure that this change is correct? I'm not able to install reactos on real hardware. Reactos hangs within CmInitHives at the first boot after the second stage setup. The same boot cd works in qemu. - Hartmut

1 0

Re: [ros-diffs] [ion] 18082: - Fix a bug in CSR Capture APIs
by Thomas Weidenmueller 26 Sep '05

26 Sep '05

ion(a)svn.reactos.com wrote: > + CsrCaptureMessageBuffer(CaptureBuffer, > + NULL, > + Size, > + (PVOID*)&Request.Data.PeekConsoleInputRequest.InputRecord); The last parameter passed to CsrCaptureMessageBuffer in your changes looks horribly wrong. The typecast hides the bug and shouldn't be necessary, the compiler would've warned you that this is most likely wrong. - Thomas

2 2

Re: [ros-diffs] [npwoods] 18056: Lightweight sync with WINE regedit; imported obvious changes such as const correctness, TCHAR string usage etc
by Thomas Weidenmueller 26 Sep '05

26 Sep '05

npwoods(a)svn.reactos.com wrote: > + if (hRootKey == HKEY_DYN_DATA) return _T("HKEY_DYN_DATA"); This key doesn't exist on NT... ;) - Thomas

3 3

Re: [ros-svn] [ea] 18050: Required for binary compatibility with MS KERNEL32.DLL.
by KJKHyperion 25 Sep '05

25 Sep '05

ea(a)svn.reactos.com wrote: >Required for binary compatibility with MS KERNEL32.DLL. > >NOTE >Filip and I still don't understand why KERNEL32 calls twice CsrConnectToServer. >A possible explanation is because the Win32 server is a dual server: gui+console. > > yes. It connects to subsystems 1 and 2. In general, all CSR calls made by kernel32.dll are easily identifiable as calls to either subsystem from their code (the subsystem code is in the upper 16 bits). The GUI subsystem's functions, if you were wondering, are: SrvExitWindowsEx SrvEndTask SrvLogon SrvRegisterServicesProcess SrvActivateDebugger SrvGetThreadConsoleDesktop SrvDeviceEvent SrvRegisterLogonProcess SrvCreateSystemThreads SrvRecordShutdownReason

3 2

Re: [ros-svn] [ea] 18050: Required for binary compatibility with MS KERNEL32.DLL.
by Alex Ionescu 25 Sep '05

25 Sep '05

ea(a)svn.reactos.com wrote: >Required for binary compatibility with MS KERNEL32.DLL. > > > I don't understand this change; it is incorrect. MS kernel32.dll sends the name of the port. Best regards, Alex Ionescu

2 2

Re: [ros-svn] [ea] 18050: Required for binary compatibility with MS KERNEL32.DLL.
by Alex Ionescu 25 Sep '05

25 Sep '05

1 0

Re: [ros-diffs] [navaraf] 18043: Add TestAlert check to NtContinue.
by Hartmut Birr 25 Sep '05

25 Sep '05

navaraf(a)svn.reactos.com wrote: >Add TestAlert check to NtContinue. > >Modified: trunk/reactos/ntoskrnl/ps/i386/continue.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/ntoskrnl/ps/i386/continue.c* > >--- trunk/reactos/ntoskrnl/ps/i386/continue.c 2005-09-25 09:22:22 UTC (rev 18042) >+++ trunk/reactos/ntoskrnl/ps/i386/continue.c 2005-09-25 09:23:05 UTC (rev 18043) >@@ -80,6 +80,11 @@ > > KeLowerIrql(oldIrql); > } > > > >+ if (TestAlert) >+ { >+ KeTestAlertThread(TrapFrame->PreviousMode); >+ } >+ > > > /* Restore the user context */ > Thread->TrapFrame = PrevTrapFrame; > __asm__("mov %%ebx, %%esp;\n" "jmp _KiServiceExit": : "b" (TrapFrame)); > > You know, that ps\i386\continue.c is not longer used. The code was moved to ke\i386\syscall.S. - Hartmut

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev