Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [ekohl] 73433: [SERVICES] Create a new environment block when a service process is started. Patch by Hermès BÉLUSCA - MAÏTO. CORE-12414

by Ged Murphy

This leaks if ImpersonateLoggedOnUser fails and the environment block is non-null -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of ekohl(a)svn.reactos.org Sent: 06 December 2016 17:30 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [ekohl] 73433: [SERVICES] Create a new environment block when a service process is started. Patch by Hermès BÉLUSCA - MAÏTO. CORE-12414 + if (Service->lpImage->hToken) + { + /* User token: Run the service under the user account */ + + if (!CreateEnvironmentBlock(&lpEnvironment, Service->lpImage->hToken, FALSE)) + { + /* We failed, run the service with the current environment */ + DPRINT1("CreateEnvironmentBlock() failed with error %d, service '%S' will run with the current environment.\n", + Service->lpServiceName, GetLastError()); + lpEnvironment = NULL; + } + + /* Impersonate the new user */ + if (!ImpersonateLoggedOnUser(Service->lpImage->hToken)) + { + dwError = GetLastError(); + DPRINT1("ImpersonateLoggedOnUser() failed with error %d\n", GetLastError()); + return dwError; + }

8 years, 6 months

From this moment PVS-Studio is free of charge for opensource projects

by Alexander Rechitskiy

8 years, 6 months

Invitation to join ReactOS Deutschland e.V.

by Colin Finck

Hi all, This invitation is long overdue: Back in 2009 when our German foundation ReactOS Deutschland e.V. was established, it was merely the legal entity to handle the small amount of incoming donations. Today, things have drastically changed: Our fundraising campaign in 2014 as well as the successful website relaunch and 0.4 release brought us many more funds. By establishing scholarships and contracting IT freelancers, ReactOS Deutschland e.V. is actively funding the actual ReactOS development. Apart from that, it is sponsoring and planning the presentation of ReactOS on popular Open-Source exhibitions. Furthermore, we have created an English translation of our Articles of Association/Charter and moved to English reports a while ago. This finally allows non-German members to join. Therefore, I'm inviting all active ReactOS developers to join ReactOS Deutschland e.V. as active members. Needless to say, active members don't pay any membership fees and have full voting rights at our General Assembly. We usually have such a General Assembly every year and this is basically your only duty: Attend the General Assemblies so that decisions are backed by a strong majority. The only exception I have to make is that the members candidating for the Board need to be German speakers to communicate with the authorities. This is necessary from time to time. You find the Articles of Association as well as all annual reports on our website https://ev.reactos.org To become an active member, simply fill out the application at https://ev.reactos.org/files/Membership_Application.pdf and send it to me via mail. You can cross out the "Direct Debit Authorization", this part is only relevant for supporting members. Unfortunately, we're bound to snail mail and can't do applications electronically, because I need a real signature and proof of your application for the authorities. Looking forward to your applications! :) Cheers, Colin

8 years, 7 months

We can sell ReactOS CD on https://www.osdisc.com/affiliate

by Alexander Rechitskiy

8 years, 7 months

Re: [ros-dev] [ros-diffs] [hbelusca] 73233: [LSASRV] - No need to hardcode the name of the dll in the GetModuleHandleW call; - Use ARRAYSIZE instead of hardcoding string buffer sizes; - When initializing the "Network Sid", ...

by Thomas Faber

On 2016-11-14 17:19, hbelusca(a)svn.reactos.org wrote: > - hInstance = GetModuleHandleW(L"lsasrv.dll"); > + hInstance = GetModuleHandleW(NULL); Those are not equivalent at all.

8 years, 7 months

Re: [ros-dev] [ros-diffs] [mjansen] 73180: [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049

by Thomas Faber

APITests should be named after a function. And in particular, they can't be named the same as a Wine test for the same module. This is currently causing result submission on Testbot to fail, so please rename this test. On 2016-11-09 23:13, mjansen(a)svn.reactos.org wrote: > Author: mjansen > Date: Wed Nov 9 22:13:26 2016 > New Revision: 73180 > > URL: http://svn.reactos.org/svn/reactos?rev=73180&view=rev > Log: > [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049 > > Added: > trunk/rostests/apitests/shell32/shlexec.cpp (with props) > Modified: > trunk/rostests/apitests/shell32/CMakeLists.txt > trunk/rostests/apitests/shell32/testlist.c

8 years, 7 months

Re: [ros-dev] [ros-diffs] [phater] 73095: [TCPIP] Copy back unicast IP if broadcast is specified for listen. CORE-12152

by Thomas Faber

On 2016-11-02 12:24, phater(a)svn.reactos.org wrote: > + /* Check if we had an unspecified address */ > + if (Connection->AddressFile->Address.Address.IPv4Address != bindaddr.addr) > + { > + /* We did, so we need to copy back the address */ > + Connection->AddressFile->Address.Address.IPv4Address = bindaddr.addr; > + } Seems like you could shorten this to just the assignment?

8 years, 7 months

Re: [ros-dev] [ros-builds] Build GCCLin_x86: build failed

by Jerome Gardou

Someone's got to help me. I can't figure out how to make this thing patch the rostests directory. Le 31/10/2016 à 11:15, buildbot(a)reactos.org a écrit : > The Buildbot has detected a failed build on builder Build GCCLin_x86 while building ReactOS. > Full details are available at: > https://build.reactos.org/builders/Build%20GCCLin_x86/builds/16201 > > Buildbot URL: https://build.reactos.org/ > > Buildslave for this Build: HotelLux > > Build Reason: A build was forced by 'jgardou <jgardou@localhost>': Test ROSTESTS-155 > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed patching > > sincerely, > -The Buildbot > > > > >

8 years, 8 months

Re: [ros-dev] [ros-diffs] [hbelusca] 73078: [BTRFS]: Fix compilation with MSVC too, as we don't have the 'FileFsSectorSizeInformation' FS information class in our headers (this is some Win8+ stuff). CORE-12223 #comment MSVC...

by Thomas Faber

And what's wrong with just adding it to our headers? On 2016-10-30 15:14, hbelusca(a)svn.reactos.org wrote: > Author: hbelusca > Date: Sun Oct 30 14:14:27 2016 > New Revision: 73078 > > URL: http://svn.reactos.org/svn/reactos?rev=73078&view=rev > Log: > [BTRFS]: Fix compilation with MSVC too, as we don't have the 'FileFsSectorSizeInformation' FS information class in our headers (this is some Win8+ stuff). > CORE-12223 #comment MSVC compilation fixed in r73078 ('FileFsSectorSizeInformation' absent in our headers). > > Modified: > trunk/reactos/drivers/filesystems/btrfs/btrfs.c > > Modified: trunk/reactos/drivers/filesystems/btrfs/btrfs.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/btrfs/… > ============================================================================== > --- trunk/reactos/drivers/filesystems/btrfs/btrfs.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/btrfs/btrfs.c [iso-8859-1] Sun Oct 30 14:14:27 2016 > @@ -716,7 +716,8 @@ > Status = overflow ? STATUS_BUFFER_OVERFLOW : STATUS_SUCCESS; > break; > } > - > + > +#ifndef __REACTOS__ > #ifdef _MSC_VER // not in mingw yet > case FileFsSectorSizeInformation: > { > @@ -739,6 +740,7 @@ > break; > } > #endif > +#endif /* __REACTOS__ */ > > default: > Status = STATUS_INVALID_PARAMETER; > >

8 years, 8 months

Status Meeting (October 2016)

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place today, 27th of October, 19:00 UTC. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. Alternatively we'll do it in #reactos-meeting on Freenode, depending on our admins mood. Please send agenda proposals to me before the meeting so we don't waste time trying to setup the agenda directly during the meeting. Regards, Aleksey Bragin

8 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev