Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Re: [ros-dev] KD trace during ROS installation
by Love Nystrom 27 Sep '16

27 Sep '16

Thanks Thomas, Yes and No... I added Options=/DEBUG /DEBUGPORT=COM2 /BAUDRATE=115200 /SOS / KDSERIAL which ended up on the BootCD all right, but it seems KD is never brought in, or doesn't use the settings from freeldr.ini on the BootCD, so no trace :/ (Ok, /SOS was perhaps a bit over the top, but anyway.) Do you know where the source is for what becomes 'freeldr.ini' on the HD after installation? If I can modify that, I can at least get a trace on the later phases of installation, after ROS boots from HD. Then I might get a hint on why the Wine Gecko installer is broken. (It waits forever for whatever it might be.. Lucky it can be canceled.) Speaking of which, shouldn't the Wine Gecko installer be included in the RosApps list so one can install it later? ATM it isn't. Best Regards L. On 2016-09-27 19.00, Thomas Faber <thomas.faber(a)reactos.org> wrote: > You should be able to simply add an > Options=... > line to the [Setup] section in boot/bootdata/bootcd.ini to modify > the setup's freeldr options. That file becomes freeldr.ini in the root > dir of the BootCD. > > > On 2016-09-27 12:21, Love Nystrom wrote: >> >Good afternoon gentlemen.. >> > >> >Can anyone tell me at what point during ROS installation KD becomes >> >operative? >> >And if there is a way to change the default KD COM port from COM1 to COM2 >> >in order to trace KD output during installation? >> > >> >(I run my ROS tests on VMware with a com0com connection from ReactOS COM2 >> >to my host machine, which works fine after install is complete and I can >> >edit freeldr.ini, >> >but I'd like to be able to collect KD output during installation as well.) >> > >> >(COM1 is not an option, since it's a physical port on both host and guest.) >> > >> >Do I have to patch KD itself ? >> > >> >Best Regards >> >L. -- There is one thing stronger than all the armies in the world, and that's an idea whose time has come. [Victor Hugo]

1 0

KD trace during ROS installation
by Love Nystrom 27 Sep '16

27 Sep '16

Good afternoon gentlemen.. Can anyone tell me at what point during ROS installation KD becomes operative? And if there is a way to change the default KD COM port from COM1 to COM2 in order to trace KD output during installation? (I run my ROS tests on VMware with a com0com connection from ReactOS COM2 to my host machine, which works fine after install is complete and I can edit freeldr.ini, but I'd like to be able to collect KD output during installation as well.) (COM1 is not an option, since it's a physical port on both host and guest.) Do I have to patch KD itself ? Best Regards L.

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded sanity checks
by Love Nystrom 26 Sep '16

26 Sep '16

Agreed.. When the assignment and assert are separated by a call of X distance, the assert is certainly warranted. Just not as it stands in ke_x.h Perhaps you could factorize as suggested, Dmitri? Best regards L. On 2016-09-26 10.28, ros-dev-request(a)reactos.org wrote: > Rationale is simple: > > The real headers contain a KeEnterCriticalRegionThread function, which > has this assert, and a KeEnterCriticalRegion function, which calls > that function with KeGetCurrentThread() at input. This is an > optimization such that if you already have the current thread of > interest somewhere, you can call KeEnterCriticalRegionThread and avoid > reading from FS or GS again. ReactOS combines these two functions in > one, and as such the ASSERT appears pointless. Factoring the functions > would've been the correct approach -- not removing the ASSERT. > > Best regards, > Alex Ionescu -- There is one thing stronger than all the armies in the world, and that's an idea whose time has come. [Victor Hugo]

1 0

Re: [ros-dev] Ros-dev Digest, Vol 145, Issue 16
by Love Nystrom 26 Sep '16

26 Sep '16

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded sanity checks
by Alex Ionescu 26 Sep '16

26 Sep '16

Rationale is simple: The real headers contain a KeEnterCriticalRegionThread function, which has this assert, and a KeEnterCriticalRegion function, which calls that function with KeGetCurrentThread() at input. This is an optimization such that if you already have the current thread of interest somewhere, you can call KeEnterCriticalRegionThread and avoid reading from FS or GS again. ReactOS combines these two functions in one, and as such the ASSERT appears pointless. Factoring the functions would've been the correct approach -- not removing the ASSERT. Best regards, Alex Ionescu On Sun, Sep 25, 2016 at 8:13 PM, Love Nystrom <love.nystrom(a)gmail.com> wrote: > I don't want to trod on anyone's tail, but > assigning _Thread = KeGetCurrentThread(), and > then asserting _Thread == KeGetCurrentThread() > on the next line does seem excessively myopic, yes ? > > Unless you expect KeGetCurrentThread() to be fubar > and return rand(), in which case the assert should be removed > when KeGetCurrentThread() gets it's head on straight. > > As to the talent, or lack thereof, of MS programmers, > we might talk about it if we ever have a table with some > beer on it between us. > > They're not *all* wrong.. no ;) > L. > > On 2016-09-24 23.23, ros-dev-request(a)reactos.org wrote: > > Subject: > Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded > sanity checks > > From: > Alex Ionescu <ionucu(a)videotron.ca> <ionucu(a)videotron.ca> > > Date: > 2016-09-24 21.29 > > To: > ReactOS Development List <ros-dev(a)reactos.org> <ros-dev(a)reactos.org> > > CC: > Linda Wang <ros-diffs(a)reactos.org> <ros-diffs(a)reactos.org> > > Thanks for removing stuff that exists in the NT kernel as sanity > checks -- the entire MS dev team must be wrong, thanks for correcting > them all :) > > Make sure not to ask "anyone can explain these checks? they seem > useless to me" when removing stuff like this. > Best regards, > Alex Ionescu > > > On Sat, Sep 24, 2016 at 2:30 AM, <dchapyshev(a)svn.reactos.org> <dchapyshev(a)svn.reactos.org> wrote: > > > Author: dchapyshev> Date: Sat Sep 24 09:30:06 2016> New Revision: 72787>> URL: http://svn.reactos.org/svn/reactos?rev=72787&view=rev> Log:> [NTOSKRNL] Remove unneeded sanity checks>> Modified:> trunk/reactos/ntoskrnl/include/internal/ke_x.h>> Modified: trunk/reactos/ntoskrnl/include/internal/ke_x.h> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/…> ==============================================================================> --- trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] (original)> +++ trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] Sat Sep 24 09:30:06 2016> @@ -25,7 +25,6 @@> \> /* Sanity checks */ \> ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \> - ASSERT(_Thread == KeGetCurrentThread()); \> ASSERT((_Thread->SpecialApcDisable <= 0) && \> (_Thread->SpecialApcDisable != -32768)); \> \> @@ -42,7 +41,6 @@> \> /* Sanity checks */ \> ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \> - ASSERT(_Thread == KeGetCurrentThread()); \> ASSERT(_Thread->SpecialApcDisable < 0); \> \> /* Leave region and check if APCs are OK now */ \> @@ -66,7 +64,6 @@> PKTHREAD _Thread = KeGetCurrentThread(); \> \> /* Sanity checks */ \> - ASSERT(_Thread == KeGetCurrentThread()); \> ASSERT((_Thread->KernelApcDisable <= 0) && \> (_Thread->KernelApcDisable != -32768)); \> \> @@ -82,7 +79,6 @@> PKTHREAD _Thread = KeGetCurrentThread(); \> \> /* Sanity checks */ \> - ASSERT(_Thread == KeGetCurrentThread()); \> ASSERT(_Thread->KernelApcDisable < 0); \> \> /* Enable Kernel APCs */ \>> > > > -- > There is one thing stronger than all the armies in the world, > and that's an idea whose time has come. [Victor Hugo] > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > >

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded sanity checks
by Love Nystrom 26 Sep '16

26 Sep '16

I don't want to trod on anyone's tail, but assigning _Thread = KeGetCurrentThread(), and then asserting _Thread == KeGetCurrentThread() on the next line does seem excessively myopic, yes ? Unless you expect KeGetCurrentThread() to be fubar and return rand(), in which case the assert should be removed when KeGetCurrentThread() gets it's head on straight. As to the talent, or lack thereof, of MS programmers, we might talk about it if we ever have a table with some beer on it between us. They're not *all* wrong.. no ;) L. On 2016-09-24 23.23, ros-dev-request(a)reactos.org wrote: > Subject: > Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove > unneeded sanity checks > From: > Alex Ionescu <ionucu(a)videotron.ca> > Date: > 2016-09-24 21.29 > > To: > ReactOS Development List <ros-dev(a)reactos.org> > CC: > Linda Wang <ros-diffs(a)reactos.org> > > > Thanks for removing stuff that exists in the NT kernel as sanity > checks -- the entire MS dev team must be wrong, thanks for correcting > them all:) > > Make sure not to ask "anyone can explain these checks? they seem > useless to me" when removing stuff like this. > Best regards, > Alex Ionescu > > > On Sat, Sep 24, 2016 at 2:30 AM,<dchapyshev(a)svn.reactos.org> wrote: >> >Author: dchapyshev >> >Date: Sat Sep 24 09:30:06 2016 >> >New Revision: 72787 >> > >> >URL:http://svn.reactos.org/svn/reactos?rev=72787&view=rev >> >Log: >> >[NTOSKRNL] Remove unneeded sanity checks >> > >> >Modified: >> > trunk/reactos/ntoskrnl/include/internal/ke_x.h >> > >> >Modified: trunk/reactos/ntoskrnl/include/internal/ke_x.h >> >URL:http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/inter… >> >============================================================================== >> >--- trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] (original) >> >+++ trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] Sat Sep 24 09:30:06 2016 >> >@@ -25,7 +25,6 @@ >> > \ >> > /* Sanity checks */ \ >> > ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \ >> >- ASSERT(_Thread == KeGetCurrentThread()); \ >> > ASSERT((_Thread->SpecialApcDisable <= 0) && \ >> > (_Thread->SpecialApcDisable != -32768)); \ >> > \ >> >@@ -42,7 +41,6 @@ >> > \ >> > /* Sanity checks */ \ >> > ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \ >> >- ASSERT(_Thread == KeGetCurrentThread()); \ >> > ASSERT(_Thread->SpecialApcDisable < 0); \ >> > \ >> > /* Leave region and check if APCs are OK now */ \ >> >@@ -66,7 +64,6 @@ >> > PKTHREAD _Thread = KeGetCurrentThread(); \ >> > \ >> > /* Sanity checks */ \ >> >- ASSERT(_Thread == KeGetCurrentThread()); \ >> > ASSERT((_Thread->KernelApcDisable <= 0) && \ >> > (_Thread->KernelApcDisable != -32768)); \ >> > \ >> >@@ -82,7 +79,6 @@ >> > PKTHREAD _Thread = KeGetCurrentThread(); \ >> > \ >> > /* Sanity checks */ \ >> >- ASSERT(_Thread == KeGetCurrentThread()); \ >> > ASSERT(_Thread->KernelApcDisable < 0); \ >> > \ >> > /* Enable Kernel APCs */ \ >> > >> > -- There is one thing stronger than all the armies in the world, and that's an idea whose time has come. [Victor Hugo]

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded sanity checks
by Alex Ionescu 26 Sep '16

26 Sep '16

There are no disadvantages. Someone though it would be fun to remove useful assertions because they don't really understand them. Best regards, Alex Ionescu On Sat, Sep 24, 2016 at 9:23 AM, Michael Fritscher <michael(a)fritscher.net> wrote: > Hi, > > hmm, what are disadvantages of these checks? If MS uses them as well these > shouldn't break anything. > > Perfomancewise there shouldn't be a difference, and in release builds they > are disabled anyways, aren't they? > > I only want to get a better unterstanding ;-) > > Best regards, > Michael > >> Thanks for removing stuff that exists in the NT kernel as sanity >> checks -- the entire MS dev team must be wrong, thanks for correcting >> them all :) >> >> Make sure not to ask "anyone can explain these checks? they seem >> useless to me" when removing stuff like this. >> Best regards, >> Alex Ionescu >> >> >> On Sat, Sep 24, 2016 at 2:30 AM, <dchapyshev(a)svn.reactos.org> wrote: >>> Author: dchapyshev >>> Date: Sat Sep 24 09:30:06 2016 >>> New Revision: 72787 >>> >>> URL: http://svn.reactos.org/svn/reactos?rev=72787&view=rev >>> Log: >>> [NTOSKRNL] Remove unneeded sanity checks >>> >>> Modified: >>> trunk/reactos/ntoskrnl/include/internal/ke_x.h >>> >>> Modified: trunk/reactos/ntoskrnl/include/internal/ke_x.h >>> URL: >>> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… >>> ============================================================================== >>> --- trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] >>> (original) >>> +++ trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] Sat >>> Sep 24 09:30:06 2016 >>> @@ -25,7 +25,6 @@ >>> \ >>> /* Sanity checks */ >>> \ >>> ASSERT(KeGetCurrentIrql() <= APC_LEVEL); >>> \ >>> - ASSERT(_Thread == KeGetCurrentThread()); >>> \ >>> ASSERT((_Thread->SpecialApcDisable <= 0) && >>> \ >>> (_Thread->SpecialApcDisable != -32768)); >>> \ >>> \ >>> @@ -42,7 +41,6 @@ >>> \ >>> /* Sanity checks */ >>> \ >>> ASSERT(KeGetCurrentIrql() <= APC_LEVEL); >>> \ >>> - ASSERT(_Thread == KeGetCurrentThread()); >>> \ >>> ASSERT(_Thread->SpecialApcDisable < 0); >>> \ >>> \ >>> /* Leave region and check if APCs are OK now */ >>> \ >>> @@ -66,7 +64,6 @@ >>> PKTHREAD _Thread = KeGetCurrentThread(); >>> \ >>> \ >>> /* Sanity checks */ >>> \ >>> - ASSERT(_Thread == KeGetCurrentThread()); >>> \ >>> ASSERT((_Thread->KernelApcDisable <= 0) && >>> \ >>> (_Thread->KernelApcDisable != -32768)); >>> \ >>> \ >>> @@ -82,7 +79,6 @@ >>> PKTHREAD _Thread = KeGetCurrentThread(); >>> \ >>> \ >>> /* Sanity checks */ >>> \ >>> - ASSERT(_Thread == KeGetCurrentThread()); >>> \ >>> ASSERT(_Thread->KernelApcDisable < 0); >>> \ >>> \ >>> /* Enable Kernel APCs */ >>> \ >>> >>> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev

2 1

Re :[ros-bugs] [jira] (CORE-12020) We're not able to perform DPH test runs anymore
by Sylvain Petreolle 25 Sep '16

25 Sep '16

Don't change code when runtime conditions evolve.Just give more RAM to the bot and it's over. Envoyé depuis Yahoo Mail pour Android Le jeu. j sept. PM à 18:01, Thomas Faber (JIRA)<noreply(a)reactos.org> a écrit : [ https://jira.reactos.org/browse/CORE-12020?page=com.atlassian.jira.plugin.s… ] Thomas Faber commented on CORE-12020: ------------------------------------- First stage is extremely heavy on memory due to inf parsing. One thing that helped in a similar situation was to separate caroots.inf from registry.inf and have it parsed separately. We should probably do that in trunk... > We're not able to perform DPH test runs anymore > ----------------------------------------------- > > Key: CORE-12020 > URL: https://jira.reactos.org/browse/CORE-12020 > Project: Core ReactOS > Issue Type: Bug > Reporter: Amine Khaldi > Assignee: Bug Zilla > Labels: REGRESSION > > https://build.reactos.org/builders/Test%20KVM/builds/15147/steps/test/logs/… > https://jira.reactos.org/secure/attachment/37125/ was used with patchbot. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira _______________________________________________ Ros-bugs mailing list Ros-bugs(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-bugs

1 0

Re: [ros-dev] [ros-diffs] [cwittich] 72792: [CRYPTNET] disable broken code
by Thomas Faber 25 Sep '16

25 Sep '16

Could you elaborate on what makes it broken? Link to a bug perhaps? On 2016-09-24 13:39, cwittich(a)svn.reactos.org wrote: > Author: cwittich > Date: Sat Sep 24 11:39:17 2016 > New Revision: 72792 > > URL: http://svn.reactos.org/svn/reactos?rev=72792&view=rev > Log: > [CRYPTNET] disable broken code > > Modified: > trunk/reactos/dll/win32/cryptnet/cryptnet_main.c > > Modified: trunk/reactos/dll/win32/cryptnet/cryptnet_main.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptnet/cryptne… > ============================================================================== > --- trunk/reactos/dll/win32/cryptnet/cryptnet_main.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/cryptnet/cryptnet_main.c [iso-8859-1] Sat Sep 24 11:39:17 2016 > @@ -1025,6 +1025,7 @@ > components.dwUrlPathLength + 1); > hFile = CreateFileW(path, GENERIC_READ, FILE_SHARE_READ, > NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); > +#ifndef __REACTOS__ > if (hFile == INVALID_HANDLE_VALUE) > { > /* Try again on the current drive */ > @@ -1049,6 +1050,7 @@ > } > } > } > +#endif > if (hFile != INVALID_HANDLE_VALUE) > { > if ((ret = CRYPT_GetObjectFromFile(hFile, pObject))) > >

3 6

Re: [ros-dev] [ros-diffs] [dchapyshev] 72787: [NTOSKRNL] Remove unneeded sanity checks
by Alex Ionescu 24 Sep '16

24 Sep '16

Thanks for removing stuff that exists in the NT kernel as sanity checks -- the entire MS dev team must be wrong, thanks for correcting them all :) Make sure not to ask "anyone can explain these checks? they seem useless to me" when removing stuff like this. Best regards, Alex Ionescu On Sat, Sep 24, 2016 at 2:30 AM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Sat Sep 24 09:30:06 2016 > New Revision: 72787 > > URL: http://svn.reactos.org/svn/reactos?rev=72787&view=rev > Log: > [NTOSKRNL] Remove unneeded sanity checks > > Modified: > trunk/reactos/ntoskrnl/include/internal/ke_x.h > > Modified: trunk/reactos/ntoskrnl/include/internal/ke_x.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… > ============================================================================== > --- trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] Sat Sep 24 09:30:06 2016 > @@ -25,7 +25,6 @@ > \ > /* Sanity checks */ \ > ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \ > - ASSERT(_Thread == KeGetCurrentThread()); \ > ASSERT((_Thread->SpecialApcDisable <= 0) && \ > (_Thread->SpecialApcDisable != -32768)); \ > \ > @@ -42,7 +41,6 @@ > \ > /* Sanity checks */ \ > ASSERT(KeGetCurrentIrql() <= APC_LEVEL); \ > - ASSERT(_Thread == KeGetCurrentThread()); \ > ASSERT(_Thread->SpecialApcDisable < 0); \ > \ > /* Leave region and check if APCs are OK now */ \ > @@ -66,7 +64,6 @@ > PKTHREAD _Thread = KeGetCurrentThread(); \ > \ > /* Sanity checks */ \ > - ASSERT(_Thread == KeGetCurrentThread()); \ > ASSERT((_Thread->KernelApcDisable <= 0) && \ > (_Thread->KernelApcDisable != -32768)); \ > \ > @@ -82,7 +79,6 @@ > PKTHREAD _Thread = KeGetCurrentThread(); \ > \ > /* Sanity checks */ \ > - ASSERT(_Thread == KeGetCurrentThread()); \ > ASSERT(_Thread->KernelApcDisable < 0); \ > \ > /* Enable Kernel APCs */ \ > >

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev