On Fri, Jul 8, 2016 at 6:18 AM, <gedmurphy(a)svn.reactos.org> wrote:
>
> + if (OpenPacket->InternalFlags & IOP_USE_TOP_LEVEL_DEVICE_HINT)
> + {
> + // FIXME: Verify our device object is good to use
> + ASSERT(DirectOpen == FALSE);
> }
You probably want to take a look at IopCheckTopDeviceHint
Best regards,
Alex Ionescu
This change in incorrect, FltObectDereference does return a value.
It's the public definition that's does match the function.
-----Original Message-----
From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca(a)svn.reactos.org
Sent: 08 July 2016 18:45
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [hbelusca] 71864: [FLTMGR]: Remove a MSVC warning: FltObjectDereference, whose prototype is publicly defined in fltkernel.h, doesn't return any value.
Author: hbelusca
Date: Fri Jul 8 17:44:59 2016
New Revision: 71864
URL: http://svn.reactos.org/svn/reactos?rev=71864&view=rev
Log:
[FLTMGR]: Remove a MSVC warning: FltObjectDereference, whose prototype is publicly defined in fltkernel.h, doesn't return any value.
Actually, this (duplicated) function looks quite poorly designed (not
your fault, obviously :-p).
The more you fix it, the more it seems natural that the first specific
case should be integrated in the while loop for real. That would make
the function more robust, with less duplicated code (and thus, less bugs
:-p).
GSoC note: this is not a "todo" task. This is just an open discussion
about a possible improvement if some day someone's bored.
Le 04/07/2016 19:02, tthompson(a)svn.reactos.org a écrit :
> Author: tthompson
> Date: Mon Jul 4 17:02:10 2016
> New Revision: 71807
>
> URL: http://svn.reactos.org/svn/reactos?rev=71807&view=rev
> Log:
> [NTFS][FREELDR]
> Fix ReadAttribute() and NtfsReadAttribute() in the case when an attribute contains two data runs; Remove extra if statement that prevents second data run from being read after it's decoded.
>
> Modified:
> branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c
> branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c
>
> Modified: branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/boot/freeldr/fre…
> ==============================================================================
> --- branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c [iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/boot/freeldr/freeldr/lib/fs/ntfs.c [iso-8859-1] Mon Jul 4 17:02:10 2016
> @@ -320,9 +320,6 @@
> }
> else
> DataRunStartLCN = -1;
> -
> - if (*DataRun == 0)
> - return AlreadyRead;
> }
>
> while (Length > 0)
>
> Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c
> URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst…
> ==============================================================================
> --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] (original)
> +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] Mon Jul 4 17:02:10 2016
> @@ -384,9 +384,6 @@
> }
> else
> DataRunStartLCN = -1;
> -
> - if (*DataRun == 0)
> - return AlreadyRead;
> }
>
> while (Length > 0)
>
>
--
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
On Mon, Jul 4, 2016 at 1:28 PM, <hbelusca(a)svn.reactos.org> wrote:
> + if (!NT_SUCCESS(Status))
> + _SEH2_LEAVE;
> + }
>
For the love of God can you please follow our coding standards.
Also, I'm pretty familiar with this code path -- are you sure that this is
the correct place to do this duplication?
Best regards,
Alex Ionescu
Hi Eric, are you sure this will not break compatibility with WIn2k3 applications? For example by quickly googling I've noticed some people rely on this Index value for their Time Zone stuff.
Example: https://www.experts-exchange.com/questions/24948382/How-to-get-Time-Zone-in…
Also, since http://microsoft.public.win32.programmer.ui.narkive.com/SOU9r3ef/time-zones… clearly says that the "IndexMapping" reg_multi_sz is for doing the mapping with the "Index" values of each time zone, you could have also deleted it! (note that this mapping value is indeed absent on Windows 7 for example).
Cheers,
Hermès
========================================
Message du : 03/07/2016 20:42
De : ros-diffs-request(a)reactos.org
A : ros-diffs(a)reactos.org
Copie à :
Sujet : Ros-diffs Digest, Vol 150, Issue 29
[...]
Today's Topics:
[...]
3. [ekohl] 71801: [BOOTDATA] Remove the Index value from the
time zone entries. We do not need it any more and it has been
removed from Windows Vista. (ekohl(a)svn.reactos.org)
----------------------------------------------------------------------
Message: 3
Date: Sun, 03 Jul 2016 18:40:27 -0000
From: ekohl(a)svn.reactos.org
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [ekohl] 71801: [BOOTDATA] Remove the Index value
from the time zone entries. We do not need it any more and it has been
removed from Windows Vista.
Message-ID:
Content-Type: text/plain; charset="utf-8"
Author: ekohl
Date: Sun Jul 3 18:40:27 2016
New Revision: 71801
URL: http://svn.reactos.org/svn/reactos?rev=71801&view=rev
Log:
[BOOTDATA]
Remove the Index value from the time zone entries. We do not need it any more and it has been removed from Windows Vista.
Modified:
trunk/reactos/boot/bootdata/hivesft.inf
Modified: trunk/reactos/boot/bootdata/hivesft.inf
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft.inf?…
==============================================================================
--- trunk/reactos/boot/bootdata/hivesft.inf [iso-8859-1] (original)
+++ trunk/reactos/boot/bootdata/hivesft.inf [iso-8859-1] Sun Jul 3 18:40:27 2016
@@ -406,7 +406,6 @@
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Display",0x00000000,"(GMT-12:00) International Date Line West"
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Dlt",0x00000000,"Dateline Daylight Time"
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Std",0x00000000,"Dateline Standard Time"
-HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","Index",0x00010001,0
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Dateline Standard Time","TZI",0x00000001,\
0xd0,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0xc4,0xff,0xff,0xff,\
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,\
(skipping........)
@@ -1125,7 +1046,6 @@
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Display",0x00000000,"(GMT+13:00) Nuku'alofa"
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Dlt",0x00000000,"Tonga Daylight Time"
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Std",0x00000000,"Tonga Standard Time"
-HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Index",0x00010001,300
HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","TZI",0x00000001,\
0xf4,0xfc,0xff,0xff,0x00,0x00,0x00,0x00,0xc4,0xff,0xff,0xff,\
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,\
------------------------------
Subject: Digest Footer
_______________________________________________
Ros-diffs mailing list
Ros-diffs(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-diffs
------------------------------
End of Ros-diffs Digest, Vol 150, Issue 29
******************************************