Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

Re: [ros-dev] [ros-diffs] [apriyadarshi] 71530: Added INF File for driver installation with minimal configuration. Device Detection and Initialization working -- tested on VMware. StorPortAllocatePool not working, so asked ...
by Alex Ionescu 06 Jun '16

06 Jun '16

Hi, Implementing MSAHCI would be "more correct" for the system, however MSAHCI also doesn't use STORPORT, it uses ATAPORT, which requires changing our PCIIDEX model to support that. Which I think would put Aman's work out of scope. Now, MSAHCI would be ported to use STORPORT instead, but then we'd essentially be implementing a legacy component on top of a legacy port driver. At least, by implementing STORAHCI on top of STORPORT, we can implement a 'modern' component on top of the legacy port driver. And for this, I would either recommend doing things like implementing StorPortExtendedFunction if Aman can do it -- or if someone can help him, or, avoiding its use with temporary work/arounds, etc. _as long as those workarounds still work in Windows_. Best regards, Alex Ionescu On Sun, Jun 5, 2016 at 9:10 PM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > I'm not an expert so I'm not sure what way is best. But I see at least > 4 solutions: > * There seems to be a way to get the extended function table through > StorPortNotification/GetExtendedFunctionTable. This would provide > some of the newer functionality even with older storport, but is > potentially an undocumented hack > * Avoid using the modern functionality and implement an old-storport > compatible storahci, which implies using only memory from the adapter > extension, and probably a few more things > * Rely on a "modern" storport and do the testing in a newer Windows > version. Then when ROS gets storport it simply needs to be a "modern" > version > * Do not use storport and implement msahci rather than storahci > > Option 2 would give the greatest compatibility but I can't pretend to > understand what limitations it will imply. > > > On 2016-06-05 21:43, Aman Priyadarshi wrote: > > Yeah msahci is ataport miniport driver. > > Then what would be the best idea? Leave it with the implementation I made > > there. "Allocated memory for all port extension within device extension?" > > ᐧ > > > > > > Regards > > *Aman Priyadarshi* > > *www.atomixos.com <http://www.atomixos.com>* > > > > > > On Mon, Jun 6, 2016 at 1:02 AM, Thomas Faber <thomas.faber(a)reactos.org> > > wrote: > > > >> On 2016-06-05 14:40, apriyadarshi(a)svn.reactos.org wrote: > >>> Author: apriyadarshi > >>> Date: Sun Jun 5 12:40:49 2016 > >>> New Revision: 71530 > >>> > >>> URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev > >>> Log: > >>> Added INF File for driver installation with minimal configuration. > >>> Device Detection and Initialization working -- tested on VMware. > >>> StorPortAllocatePool not working, so asked Storport to allocate all > >> memory just after loading up the driver -- Bad idea (will change it > later). > >> > >> StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not > >> implemented in Win2003. As you can see in WDK samples, 2003's msahci is > >> not a storport miniport driver. Maybe storport wasn't advanced enough > >> for complex drivers back then? > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

2 1

05 Jun '16

On 2016-06-05 14:40, apriyadarshi(a)svn.reactos.org wrote: > Author: apriyadarshi > Date: Sun Jun 5 12:40:49 2016 > New Revision: 71530 > > URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev > Log: > Added INF File for driver installation with minimal configuration. > Device Detection and Initialization working -- tested on VMware. > StorPortAllocatePool not working, so asked Storport to allocate all memory just after loading up the driver -- Bad idea (will change it later). StorPortAllocatePool uses StorPortExtendedFunction, which indeed is not implemented in Win2003. As you can see in WDK samples, 2003's msahci is not a storport miniport driver. Maybe storport wasn't advanced enough for complex drivers back then?

2 2

Re: [ros-dev] [ros-diffs] [hbelusca] 71524: [SHELL32] - Minor stylistic whitespace changes. - Use 'IDA_DESKBROWSER' instead of hardcoding its value. - The shell progman window uses the COLOR_DESKTOP as its hbrBackground: pa...
by Thomas Faber 05 Jun '16

05 Jun '16

On 2016-06-05 01:29, hbelusca(a)svn.reactos.org wrote: > - rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN); > - rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN); > - rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN); > - rcDesk.bottom = rcDesk.top + GetSystemMetrics(SM_CYVIRTUALSCREEN); > + rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN); > + rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN); > + rcDesk.right = GetSystemMetrics(SM_CXVIRTUALSCREEN); > + rcDesk.bottom = GetSystemMetrics(SM_CYVIRTUALSCREEN); Are you sure about this? "CX" normally means width, so right = left + cx seems more logical. And SM_XVIRUTALSCREEN is probably 0 most of the time so it would be hard to notice.

2 3

https://code.reactos.org/ does not show recent revisions
by Alexander Rechitskiy 03 Jun '16

03 Jun '16

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71486: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-t...
by Ged Murphy 01 Jun '16

01 Jun '16

There's another one of these when the OS is running in test mode. "Bcdedit -set TESTSIGNING ON" will display the following: Test Mode Windows (n) Build (n) Maybe you can add that one when Alex finishes his UEFI/BCD stuff :) -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca(a)svn.reactos.org Sent: 01 June 2016 16:25 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [hbelusca] 71486: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-t... Author: hbelusca Date: Wed Jun 1 15:24:38 2016 New Revision: 71486 URL: http://svn.reactos.org/svn/reactos?rev=71486&view=rev Log: [WIN32K] Display a nice ReactOS version desktop watermark (with different fonts) when the corresponding registry values are set. See http://winaero.com/blog/a-new-way-to-display-the-windows-version-on-your-de… for more details (which works on Windows 2003 too). CORE-11349 #resolve

1 0

Re: [ros-dev] [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ...
by Ged Murphy 31 May '16

31 May '16

Would it not be better to do all this in C++ and let wine write a C interface around it? When we're trying to move to C++, it seems like a step backwards in order to support wine's insistence on using C -----Original Message----- From: Ros-diffs [mailto:ros-diffs-bounces@reactos.org] On Behalf Of mjansen(a)svn.reactos.org Sent: 28 May 2016 17:43 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [mjansen] 71439: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim ... Author: mjansen Date: Sat May 28 16:42:57 2016 New Revision: 71439 URL: http://svn.reactos.org/svn/reactos?rev=71439&view=rev Log: [APPHELP] Begin shimlib implementation. CORE-11329 Implement some macro's and functions that help when registering shims. These are all written in C, so that wine can use the shim libraries as well.

4 4

Semi-protection of our Wikipedia page
by Jared Smudde 29 May '16

29 May '16

Hello all, It seems that our Wikipedia page seems to have somewhat incorrect information in some sections on the page. Some of it seems to come from IP address which means that they are unregistered. Some of the information could be correct but some of the other information added could be incorrect. I propose that we can see if the wiki page could be Semi-Protected. If the page is Semi-Protected, that means that non-registered users (People logged as IPs in the log) and newly registered users (people that have less than 10 edits and that have been only registered for 4 days). This would mean that people that have been registered for a while and have made edits could edit the page. I hope that this would help with some of the incorrect information on the web page. Not sure what your thoughts are on this but I think it would be nice to have. Jared

1 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 71412: [REISERFSLIB] Stub the ReiserFS lib CORE-11005
by Timo Kreuzer 29 May '16

29 May '16

I thought the idea of the folder reorganization was to get some sense into it. But that doesn't work if people keep adding stuff to the sdk/lib folder, just because it is a lib! I don't see why a file system library would have any reason to go into the SDK. Thanks, Timo Am 26.05.2016 um 20:08 schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Thu May 26 18:08:42 2016 > New Revision: 71412 > > URL: http://svn.reactos.org/svn/reactos?rev=71412&view=rev > Log: > [REISERFSLIB] > Stub the ReiserFS lib > > CORE-11005 > > Added: > trunk/reactos/sdk/lib/fslib/reiserfslib/ > trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt (with props) > trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c (with props) > trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h (with props) > Modified: > trunk/reactos/sdk/lib/fslib/CMakeLists.txt > > Modified: trunk/reactos/sdk/lib/fslib/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/CMakeLists.t… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/sdk/lib/fslib/CMakeLists.txt [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -2,5 +2,6 @@ > add_subdirectory(btrfslib) > add_subdirectory(ext2lib) > add_subdirectory(ntfslib) > +add_subdirectory(reiserfslib) > add_subdirectory(vfatlib) > add_subdirectory(vfatxlib) > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,3 @@ > + > +add_library(reiserfslib reiserfslib.c) > +add_dependencies(reiserfslib psdk) > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/CMakeLists.txt > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,36 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS ReiserFS library > + * FILE: lib/fslib/reiserfslib/reiserfslib.c > + * PURPOSE: ReiserFS lib > + * PROGRAMMERS: Pierre Schweitzer > + */ > +#include "reiserfslib.h" > + > +#define NDEBUG > +#include <debug.h> > + > +NTSTATUS NTAPI > +ReiserfsFormat(IN PUNICODE_STRING DriveRoot, > + IN FMIFS_MEDIA_FLAG MediaFlag, > + IN PUNICODE_STRING Label, > + IN BOOLEAN QuickFormat, > + IN ULONG ClusterSize, > + IN PFMIFSCALLBACK Callback) > +{ > + UNIMPLEMENTED; > + return STATUS_SUCCESS; > +} > + > + > +NTSTATUS WINAPI > +ReiserfsChkdsk(IN PUNICODE_STRING DriveRoot, > + IN BOOLEAN FixErrors, > + IN BOOLEAN Verbose, > + IN BOOLEAN CheckOnlyIfDirty, > + IN BOOLEAN ScanDrive, > + IN PFMIFSCALLBACK Callback) > +{ > + UNIMPLEMENTED; > + return STATUS_SUCCESS; > +} > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/fslib/reiserfslib/… > ============================================================================== > --- trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h (added) > +++ trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h [iso-8859-1] Thu May 26 18:08:42 2016 > @@ -0,0 +1,8 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS ReiserFS library > + * FILE: lib/fslib/reiserfslib/reiserfslib.h > + */ > +#define NTOS_MODE_USER > +#include <ndk/umtypes.h> > +#include <fmifs/fmifs.h> > > Propchange: trunk/reactos/sdk/lib/fslib/reiserfslib/reiserfslib.h > ------------------------------------------------------------------------------ > svn:eol-style = native > > >

1 0

Re: [ros-dev] [ros-diffs] [hbelusca] 71419: [NETSHELL]: Fix french orthograph.
by Pierre Schweitzer 27 May '16

27 May '16

Le 27/05/2016 00:37, hbelusca(a)svn.reactos.org a écrit : > @@ -95,7 +95,7 @@ > FONT 8, "MS Shell Dlg" > BEGIN > LTEXT "Pour le pÃ©riphÃ©rique :", IDC_STATIC, 33, 2, 100, 50 > - LTEXT "s. o.", IDC_NETWORK_DEVICE, 105, 2, 253, 20 > + LTEXT "n/a", IDC_NETWORK_DEVICE, 105, 2, 253, 20 > LTEXT "Les composants sÃ©lectionnÃ©s sont utilisÃ©s par cette connexion :", IDC_STATIC, 33, 12, 253, 20 > CONTROL "", IDC_COMPONENT_LIST, "SysListView32", LVS_REPORT | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_NOCOLUMNHEADER | LVS_NOSORTHEADER | WS_BORDER | WS_TABSTOP, 33, 22, 250, 50 > PUSHBUTTON "&Installer...", IDC_NETWORK_INSTALL, 122, 75, 50, 14, WS_DISABLED | WS_TABSTOP For the record, "n/a" isn't French. n/a means "Not available". "s. o." means "Sans objet" which is the closest. -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Wiki is under spam attack again
by Alexander Rechitskiy 26 May '16

26 May '16

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev