Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-svn] [greatlrd] 16563: Change some error msg from ConErr to ConOut for they are being pipe so the behover are equal with ms windows cmd
by Hartmut Birr 19 Jul '05

19 Jul '05

greatlrd(a)svn.reactos.com wrote: >Change some error msg from ConErr to ConOut for they are being pipe so the behover are equal with ms windows cmd > > > >Updated files: >trunk/reactos/subsys/system/cmd/error.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > > Hi, I think this change is wrong (also some parts from 16579). The error messages have always to go to the error output (STD_ERROR_HANDLE). - Hartmut

2 3

Re: [ros-svn] [ion] 16635: - Fix nasty APC delivery bug (in case a Kernel-Mode Special APC still returned with a Normal Routine, the Normal Routine was called with incorrect values (Special Routines take PVOID* arguments, while Normal Routines do not!))
by Hartmut Birr 19 Jul '05

19 Jul '05

ion(a)svn.reactos.com wrote: > - Fix nasty APC delivery bug (in case a Kernel-Mode Special APC still returned with a Normal Routine, the Normal Routine was called with incorrect values (Special Routines take PVOID* arguments, while Normal Routines do not!)) > - Remove APC from list before setting it to non-inserted. > - Do proper thread termination piggybacking; terminate threads in user-mode as Hartmut correctly fixed. > > >Updated files: >trunk/reactos/ntoskrnl/ke/apc.c >trunk/reactos/ntoskrnl/ps/kill.c > > > Hi, I do not agree to this changes. For a non system thread, we use a kernel mode apc first, which uses a second user mode apc. This overhead isn't necessary. For system threads it isn't possible to use a kernel mode apc which calls PspExitThread. A system thread must terminate it self. It is only possible to help by marking a flag, setting an event or unwait the thread. - Hartmut

2 1

RE: [ros-diffs] [chorns] 16647: Generate RPC interface headers inintermediate directory
by Casper Hornstrup 19 Jul '05

19 Jul '05

You need to "del include\idl\*.h" after this change. Casper

2 1

re: ps/kill.c change
by Alex Ionescu 18 Jul '05

18 Jul '05

Hi, Sorry but I accidentally lost 60 emails including the one I'm supposed to reply to. Hartmut, you have done a recent change in kill.c in which you change the APC inside PspTerminateThreadByPointer to a user-mode APC. This is incorrect and I don't understand why it was done... furthermore, I've even documented a source of information which proves my code was correct (on top of the function header), so why did you change it? Best regards, Alex Ionescu

2 2

Re: web page
by yash 18 Jul '05

18 Jul '05

Website proposal looks good. I don't know if my opinion worth a cent, but I think the lines between left bar menu items make it harder to read and understand. The freebsd.org style is much simpler for brain to acquire and understand, when you only have one bold line around the whole navigation panel, and the items are separated with simple BR tag. Every extra line creates an extra load in your reception systems and occupy brain neuro cycles that can be used for thinking about content or other high abstract concepts instead. Thanks Yash >> http://frik85.fr.funpic.de/reactos/en/index.htm (HTML version) > >Nice and clear design, fresh colors. :) >I'd like to see this proposal as new homepage. > Martin

1 0

Website Design and Layout
by Rick Langschultz 18 Jul '05

18 Jul '05

Hey all, Just a second thought about the website that ReactOS is planning on updating. There are several ideas out there and several layouts. Here are my suggestions: Fedora Core 4 OpenLDAP for user information and Login functions Perl and PHP Apache 2.0.xx POP3 and Imap4 email access NNTP service MySQL for CMS, Wiki, Portal Postgresql for CMS, Portal, Wiki I also believe in sticking with a header, and a three column layout, as well as a footer. The site should be updateable by either database (MySQL or Postgresql) or XML. Should provide login credential system that will allow admins to add news and features. I think users should be allowed or have access to giving detailed system data to allow developers to focus on certain devices, drivers, and applications. This would allow a user to also check the status on a new optimized driver or binary, or any updates that React my want to distribute for download. Later ReactOS.com should integrate with the currently installed software on the users system to alert them of new releases, patches, updates, and information; much like windows update. I also think that the portal system should allow users to check @reactos.com email or provide it in attempts to raise money for the site. Another great thing that I know major OS manufacturers include is a development library/ I think that we should list the source code and allow users to browse it much like webCVS but also to annotate it, and allow a user to chat in a forum type environment if they don't understand a line of the code. Just a few thoughts on color: KISS (Keep it simple stupid). Keep color usage minimal and allow the user to customize it to their liking with templates.

1 0

(no subject)
by reactos 18 Jul '05

18 Jul '05

I wonder how the development of the USB stack is going, the wiki "blog" is kind of old, I tested the USB tool mentioned in the forum some month ago, but it was just info it provided, how is it going with for example keyboard and mouse support? Yours sincerely, Jaix Bly

1 0

Re: [ros-svn] [robertk] 16570: the release branch should be dbg=0
by Emanuele Aliberti 18 Jul '05

18 Jul '05

robertk(a)svn.reactos.com wrote: >the release branch should be dbg=0 > > >Updated files: >branches/ros-branch-0_2_7/reactos/config.template.xml > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > Hi Robert, shouldn't the config.template.xml be read only? -- :Emanuele Aliberti

4 6

Re: [ros-svn] [mbosma] 16593: - Build failure
by Gge 17 Jul '05

17 Jul '05

mbosma(a)svn.reactos.com wrote: > HUMA2000: Spanish translation > > > Updated files: > trunk/rosapps/packmgr/lib/es.rc > Building the Rosapps module fails with the following error : D:\Reactos\Svn\rosapps>svn update U packmgr\lib\es.rc Updated to revision 16597. D:\Gerard\Reactos\Svn\rosapps>mingw32-make clean mingw32-make: *** No rule to make target `clean'. Stop. Any idea ? Best regards

3 7

ArrangeIconicWindows
by James Tabor 16 Jul '05

16 Jul '05

Hi All, I'm starting to get a headache. This is a port from wine to win32k/ntuser/winpos.c. It does compile. But it is so butt ugly! I'm in the process of fixing MDI. So far, testing with winefile.exe has come down to this one function. So this is open for peer review. I'm tired. 8^( Thanks, James BOOL FASTCALL IntIsIconic(HWND hWnd) { return (NtUserGetWindowLong( hWnd, GWL_STYLE, FALSE) & WS_MINIMIZE) != 0; } BOOL FASTCALL IntIsWindowEnabled( HWND hWnd) { return (! (NtUserGetWindowLong(hWnd, GWL_STYLE, FALSE) & WS_DISABLED)); } #define MAKEINTATOMW(atom) ((LPCWSTR)((ULONG_PTR)((WORD)(atom)))) #define ICONTITLE_CLASS_ATOM MAKEINTATOMW(32772) static ATOM atomInternalPos; extern HWND FASTCALL IntSetOwner(HWND hWnd, HWND hWndNewOwner); extern HWND STDCALL IntCreateWindowEx(DWORD dwExStyle, PUNICODE_STRING ClassName, PUNICODE_STRING WindowName, DWORD dwStyle, LONG x, LONG y, LONG nWidth, LONG nHeight, HWND hWndParent, HMENU hMenu, HINSTANCE hInstance, LPVOID lpParam, DWORD dwShowMode, BOOL bUnicodeWindow); HWND FASTCALL ICONTITLE_Create( HWND owner ) { HWND hWnd; UNICODE_STRING ClassName; HINSTANCE instance = (HINSTANCE)NtUserGetWindowLong( owner, GWL_HINSTANCE, FALSE ); LONG style = WS_CLIPSIBLINGS; RtlInitUnicodeString(&ClassName, NULL); ClassName.Buffer = (LPWSTR)ICONTITLE_CLASS_ATOM; if (!IntIsWindowEnabled(owner)) style |= WS_DISABLED; if( NtUserGetWindowLong( owner, GWL_STYLE,FALSE ) & WS_CHILD ) hWnd = IntCreateWindowEx( 0, &ClassName, NULL, style | WS_CHILD, 0, 0, 1, 1, NtUserGetParent(owner), 0, instance, NULL,SW_SHOW,TRUE ); else hWnd = IntCreateWindowEx( 0, &ClassName, NULL, style, 0, 0, 1, 1, owner, 0, instance, NULL,SW_SHOW,TRUE ); IntSetOwner( hWnd, owner ); /* MDI depends on this */ NtUserSetWindowLong( hWnd, GWL_STYLE, NtUserGetWindowLong( hWnd, GWL_STYLE,FALSE ) & ~(WS_CAPTION | WS_BORDER), FALSE ); return hWnd; } BOOL FASTCALL WinPosShowIconTitle(HWND hWnd, BOOL bShow) { PWINDOW_OBJECT WindowObject; PINTERNALPOS lpPos; /* This way or??? */ lpPos = (PINTERNALPOS)NtUserGetProp( hWnd, atomInternalPos ); if (!(WindowObject = IntGetWindowObject(hWnd))) { return FALSE; } /* This way? Dont know! */ lpPos = WindowObject->InternalPos; if (lpPos ) { HWND title = 0;//lpPos->hwndIconTitle; if( !title ) // lpPos->hwndIconTitle = title = ICONTITLE_Create( hWnd ); if( bShow ) { if (!IntIsWindowVisible(title)) { IntSendMessage( title, WM_SHOWWINDOW, TRUE, 0 ); WinPosSetWindowPos( title, 0, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE | SWP_NOZORDER | SWP_SHOWWINDOW ); } } else WinPosShowWindow( title, SW_HIDE ); } IntReleaseWindowObject(WindowObject); return TRUE; } UINT FASTCALL WinPosArrangeIconicWindows(PWINDOW_OBJECT parent) { RECT rectParent; HWND hwndChild; INT i, x, y, xspacing, yspacing; HWND *List = IntWinListChildren(parent); IntGetClientRect( parent, &rectParent ); x = rectParent.left; y = rectParent.bottom; xspacing = NtUserGetSystemMetrics(SM_CXICONSPACING); yspacing = NtUserGetSystemMetrics(SM_CYICONSPACING); for( i = 0; List[i]; i++) { hwndChild = List[i]; if( IntIsIconic( hwndChild ) ) { WinPosShowIconTitle( hwndChild, FALSE ); WinPosSetWindowPos( hwndChild, 0, x + (xspacing - NtUserGetSystemMetrics(SM_CXICON)) / 2, y - yspacing - NtUserGetSystemMetrics(SM_CYICON)/2, 0, 0, SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE ); if( IntIsWindow(hwndChild) ) WinPosShowIconTitle(hwndChild , TRUE ); if (x <= rectParent.right - xspacing) x += xspacing; else { x = rectParent.left; y -= yspacing; } } } ExFreePool(List); return yspacing; }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev