Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-diffs] [hbirr] 16714: - Removed R_EXTRA_STACK because R_EXTRA_STACK and R_STACK must have the same size.

by Royce Mitchell III

hbirr(a)svn.reactos.com wrote: >- Initialized an allocated block completely before release the lock. > >@@ -719,9 +725,9 @@ > > > { > if ( (NewBlock = RQueRemove ( &pool->Que[que][align] )) ) > { > > >- R_RELEASE_MUTEX(pool); > > > RiUsedInit ( NewBlock, Tag ); > RiUsedInitRedZone ( NewBlock, NumberOfBytes ); > > >+ R_RELEASE_MUTEX(pool); > > > return RHdrToBody(NewBlock); > } > queBytes = 16 << que; >@@ -865,11 +871,10 @@ > > > NewBlock = (PR_USED)BestBlock; > RiUsedInit ( NewBlock, Tag ); > > > >- R_RELEASE_MUTEX(pool); >- > > > /* RtlZeroMemory(RHdrToBody(NewBlock), NumberOfBytes);*/ > > RiUsedInitRedZone ( NewBlock, NumberOfBytes ); > > >+ R_RELEASE_MUTEX(pool); > > > > return RHdrToBody(NewBlock); > } > > Hartmut, If you don't mind, I'm curious how this was causing a problem, the stuff that was being initialized outside of the lock shouldn't (in my feeble mind) have been "visible" upon reentry until this block is freed again. Thanks, Royce

20 years, 2 months

win32k message queue problem

by Hartmut Birr

Hi, it seems there exist a problem with the message queues. If a process is terminated (killed) from outside, the thread message queue is deleted before the last window is deleted. If there is a message (key or mouse) for this window, the window does access the already freed message queue. This will crash the system. Possible it is related to the paged pool memory corruption bug. I've a (dirty) fix for this problem. - Hartmut Index: subsys/win32k/ntuser/window.c =================================================================== --- subsys/win32k/ntuser/window.c (Revision 16707) +++ subsys/win32k/ntuser/window.c (Arbeitskopie) @@ -1577,6 +1577,7 @@ IntSetMenu(WindowObject, hMenu, &MenuChanged); } WindowObject->MessageQueue = PsGetWin32Thread()->MessageQueue; + IntReferenceMessageQueue(WindowObject->MessageQueue); WindowObject->Parent = (ParentWindow ? ParentWindow->Self : NULL); if((OwnerWindow = IntGetWindowObject(OwnerWindowHandle))) { @@ -2180,7 +2181,7 @@ if (Window->MessageQueue->CaptureWindow == Window->Self) Window->MessageQueue->CaptureWindow = NULL; IntUnLockMessageQueue(Window->MessageQueue); - + IntDereferenceMessageQueue(Window->MessageQueue); /* Call hooks */ #if 0 /* FIXME */ if (HOOK_CallHooks(WH_CBT, HCBT_DESTROYWND, (WPARAM) hwnd, 0, TRUE))

20 years, 2 months

Off Topic: Programming Salaries...

by Rick Langschultz

Hey all, I am hiring an entry level web programmer for the winter and would like to know what you would suggest to be a good starting salary. We are a small company that deals with serving users with portal services, such as database portals, collaboration portals, e-learning portals, web services, and simple PHP + MySQL websites. What would you want to be paid? Please be reasonable cause I am going to base someones salary on these statistics. Also please only respond directly to me, not to this list. No use clogging it up. Thanks, Rick Langschultz

20 years, 2 months

ReactOS crash on vmware 4.5 when usb controller is enabled .

by Saveliy Tretiakov

(ntoskrnl\ke\main.c:284) --------------------------------------------------------------- (ntoskrnl\ke\main.c:285) ReactOS 0.3-SVN (Build 20050723-r16704) Used memory 65536Kb (ntoskrnl\mm\mminit.c:375) Kernel Stack Limits. InitTop = 0x800f5000, Init = 0x800f2000 (ntoskrnl\mm\mm.c:283) No current process (ntoskrnl\io\pnpmgr.c:1749) Initialization of service vmx_svga failed (Status c0000001) (ntoskrnl\ldr\loader.c:315) Could not open module file: \SystemRoot\System32\DRIVERS\usbuhci.sys (ntoskrnl\io\pnpmgr.c:1749) Initialization of service usbuhci failed (Status c0000001) (ntoskrnl\io\pnpmgr.c:1749) Initialization of service vmx_svga failed (Status c0000001) (ntoskrnl\ldr\loader.c:315) Could not open module file: \SystemRoot\System32\DRIVERS\usbuhci.sys (ntoskrnl\io\pnpmgr.c:1749) Initialization of service usbuhci failed (Status c0000001) (ntoskrnl\ldr\loader.c:315) Could not open module file: \SystemRoot\system32\drivers\ne2000.sys (ntoskrnl\io\pnpmgr.c:1749) Initialization of service Ne2000 failed (Status c0000001) (ntoskrnl\ldr\loader.c:315) Could not open module file: \SystemRoot\system32\drivers\i8042prt.sys (ntoskrnl\io\pnpmgr.c:1749) Initialization of service i8042prt failed (Status c0000001) (ntoskrnl\ldr\loader.c:315) Could not open module file: \SystemRoot\system32\drivers\i8042prt.sys (ntoskrnl\io\pnpmgr.c:1749) Initialization of service i8042prt failed (Status c0000001) (ntoskrnl\io\pnpmgr.c:1749) Initialization of service serial failed (Status c0000034) (ntoskrnl\io\pnpmgr.c:1749) Initialization of service serial failed (Status c0000034) (drivers\input\i8042prt\registry.c:215) Can't read registry: c0000034 (drivers\input\i8042prt\registry.c:226) Manually set defaults (drivers\input\i8042prt\registry.c:215) Can't read registry: c0000034 (drivers\input\i8042prt\registry.c:226) Manually set defaults (drivers\input\i8042prt\i8042prt.c:570) Basic keyboard detection failed: c00000b5 (ntoskrnl\io\pnpmgr.c:1749) Initialization of service serial failed (Status c0000034) (ntoskrnl\io\pnpmgr.c:1749) Initialization of service serial failed (Status c0000034) (ntoskrnl\io\pnpmgr.c:1749) Initialization of service vmx_svga failed (Status c0000001) (drivers\usb\cromwell\uhci\fdo.c:293) UHCI: unknown minor function 0x8 (drivers\usb\cromwell\sys\linuxwrapper.c:466) IoGetDmaAdapter done 0x8CD02938, mapRegisterCount=2 (drivers\usb\cromwell\uhci\uhci-hcd.c:2556) INF: drivers\usb\cromwell\uhci\uhci-hcd.c: USB Universal Host Controller Interface driver v2.1 (drivers\usb\cromwell\core\hcd-pci.c:74) usbcore: usb_hcd_pci_probe() called (drivers\usb\cromwell\sys\linuxwrapper.c:201) driver_register 0: 9d0070b8 9d0008a4(drivers\usb\cromwell\core\usb.c:164) INF: drivers\usb\cromwell\core\usb.c: registered new driver hub (drivers\usb\cromwell\sys\linuxwrapper.c:137) usbcore: Created system thread 60 (drivers\usb\cromwell\sys\linuxwrapper.c:201) driver_register 1: 9d0070e0 9d000890(drivers\usb\cromwell\core\hcd-pci.c:74) usbcore: usb_hcd_pci_probe() called (drivers\usb\cromwell\core\/../linux/pci_hal.c:13) pci_enable_device() called... (drivers\usb\cromwell\core\/../linux/pci_hal.c:44) pci_resource_flags() called, x=0x0 (drivers\usb\cromwell\core\/../linux/pci_hal.c:21) pci_resource_start() called, x=0x0 (drivers\usb\cromwell\core\/../linux/pci_hal.c:33) pci_resource_len() called, x=0x0 (drivers\usb\cromwell\core\/../linux/pci_hal.c:86) request_region(): addr=0x1060, len=0x20 (drivers\usb\cromwell\core\/../linux/pci_hal.c:58) pci_set_drvdata() called... (drivers\usb\cromwell\core\hcd-pci.c:163) UnivHCI PCI-USB Controller (drivers\usb\cromwell\core\hcd-pci.c:183) irq 9, io base 00001060 (drivers\usb\cromwell\core\hcd.c:678) new USB bus registered, assigned bus number 1 (drivers\usb\cromwell\uhci\/../linux/pci_hal.c:33) pci_resource_len() called, x=0x0 (drivers\usb\cromwell\sys\linuxwrapper.c:249) schedule_timeout: 5 ms (drivers\usb\cromwell\sys\linuxwrapper.c:278) schedule DONE!!!!!! (drivers\usb\cromwell\sys\linuxwrapper.c:249) schedule_timeout: 1 ms (drivers\usb\cromwell\sys\linuxwrapper.c:278) schedule DONE!!!!!! (drivers\usb\cromwell\sys\linuxwrapper.c:795) pci_alloc_consistent() size=8196 (drivers\usb\cromwell\sys\linuxwrapper.c:626) pci_pool_create(): UHCD PCI Slot/uhci_td size 48, 85/page (4096 alloc) (drivers\usb\cromwell\sys\linuxwrapper.c:626) pci_pool_create(): UHCD PCI Slot/uhci_qh size 48, 85/page (4096 alloc) (drivers\usb\cromwell\uhci\uhci-hcd.c:2264) INF: drivers\usb\cromwell\uhci\uhci-hcd.c: detected 2 ports (drivers\usb\cromwell\sys\linuxwrapper.c:656) pci_pool_alloc() called, blocks already allocated=0 (drivers\usb\cromwell\sys\linuxwrapper.c:656) pci_pool_alloc() called, blocks already allocated=0 KeBugCheckWithTf at ntoskrnl\ke\catch.c:228 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. The problem seems to be caused by the following file: ntoskrnl.exe Technical information: *** STOP: 0x0000001E (0xc0000005,0x80059827,0x00000000,0x0000000b) *** ntoskrnl.exe - Address 0x80059827 base at 0x80000000, DateStamp 0x0 Page Fault Exception: 14(0) Processor: 0 CS:EIP 8:80059827 <ntoskrnl.exe:59827 (ntoskrnl/mm/marea.c:86 (MmIterateNextNode))> cr2 b cr3 22000 Proc: 8050a7d8 Pid: 4 <System> Thrd: 8050b1d0 Tid: 0 DS 10 ES 10 FS 30 GS 10 EAX: ffffffff EBX: 80699640 ECX: 800ef1a0 EDX: 9cf67fff EBP: 800f477c ESI: 00000000 ESP: 800f4700 EDI: 00076514 EFLAGS: 00210286 kESP 800f4700 kernel stack base 800f2000 Frames: <ntoskrnl.exe:59e59 (ntoskrnl/mm/marea.c:505 (MmFindGapBottomUp))> <ntoskrnl.exe:5a0b9 (ntoskrnl/mm/marea.c:638 (MmFindGap))> <ntoskrnl.exe:5a578 (ntoskrnl/mm/marea.c:957 (MmCreateMemoryArea))> <ntoskrnl.exe:54be5 (ntoskrnl/mm/cont.c:60 (MmAllocateContiguousAlignedMemory))> <hal.dll:2681 (hal/halx86/generic/dma.c:64 (HalAllocateCommonBuffer))> <ntoskrnl.exe:4302a (ntoskrnl/io/pnpdma.c:46 (IopAllocateCommonBuffer))> <usbuhci.sys:8eb3 (drivers/usb/cromwell/sys/linuxwrapper.c:663 (my_pci_pool_alloc))> <usbuhci.sys:3f2f (drivers/usb/cromwell/uhci/uhci-hcd.c:313 (uhci_alloc_qh))> <usbuhci.sys:7897 (drivers/usb/cromwell/uhci/uhci-hcd.c:2289 (uhci_start))> <usbcore.sys:45b3 (drivers/usb/cromwell/core/hcd-pci.c:193 (usb_hcd_pci_probe))> <usbuhci.sys:1202 (drivers/usb/cromwell/uhci/fdo.c:56 (InitLinuxWrapper))> <usbuhci.sys:152e (drivers/usb/cromwell/uhci/fdo.c:192 (UhciFdoStartDevice))> <usbuhci.sys:1627 (drivers/usb/cromwell/uhci/fdo.c:243 (UhciPnpFdo))> <usbuhci.sys:2a74 (drivers/usb/cromwell/uhci/uhci.c:269 (DispatchPnp))> <ntoskrnl.exe:414ff (ntoskrnl/io/irp.c:1080 (IofCallDriver))> <ntoskrnl.exe:4409b (ntoskrnl/io/pnpmgr.c:636 (IopInitiatePnpIrp))> <ntoskrnl.exe:30894 (ntoskrnl/io/device.c:145 (IopStartDevice))> <ntoskrnl.exe:45738 (ntoskrnl/io/pnpmgr.c:1733 (IopActionInitChildServices))> <ntoskrnl.exe:457cb (ntoskrnl/io/pnpmgr.c:1773 (IopActionInitAllServices))> <ntoskrnl.exe:44110 (ntoskrnl/io/pnpmgr.c:666 (IopTraverseDeviceTreeNode))> <ntoskrnl.exe:44143 (ntoskrnl/io/pnpmgr.c:680 (IopTraverseDeviceTreeNode))> <ntoskrnl.exe:44143 (ntoskrnl/io/pnpmgr.c:680 (IopTraverseDeviceTreeNode))> <ntoskrnl.exe:44186 (ntoskrnl/io/pnpmgr.c:706 (IopTraverseDeviceTree))> <ntoskrnl.exe:45834 (ntoskrnl/io/pnpmgr.c:1833 (IopInitializePnpServices))> <800B7BC0> <800B5428> <ntoskrnl.exe:6456 (ntoskrnl/ke/main.c:95 (KiSystemStartup))> <800B384E> <0> KeBugCheckWithTf at ntoskrnl\ke\catch.c:228 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. The problem seems to be caused by the following file: ntoskrnl.exe Technical information: *** STOP: 0x0000001E (0x80000003,0x80091527,0x00000000,0x00000000) *** ntoskrnl.exe - Address 0x80091527 base at 0x80000000, DateStamp 0x0

20 years, 2 months

services in livecd

by Saveliy Tretiakov

I found that SCM is not started in livecd. This is wrong imho (I use livecd to debug ROS and I need SCM). This small patch will fix this. Index: winlogon.c =================================================================== --- winlogon.c (revision 16707) +++ winlogon.c (working copy) @@ -593,6 +593,8 @@ DbgPrint("WL: Cannot switch to Winlogon desktop (0x%X)\n", GetLastError()); } + InitServices(); + /* Check for pending setup */ if (GetSetupType () != 0) { @@ -616,8 +618,6 @@ return 2; } - InitServices(); - #if 0 /* real winlogon uses "Winlogon" */ RtlInitUnicodeString((PUNICODE_STRING)&ProcessName, L"Winlogon");

20 years, 2 months

RE: [ros-dev] Re: Reactos.com problems

by Murphy, Ged (Bolton)

Agreed. This is a perfect opportunity to bring in the new website. -----Original Message----- From: mf [mailto:mf@mufunyo.net] Sent: 23 July 2005 11:27 To: ros-dev(a)reactos.com Cc: ros-general(a)reactos.com Subject: [ros-dev] Re: Reactos.com problems Ge van Geldorp wrote: > For the moment, I've moved the mailing lists to a backup box. I am not > moving the website, since it seems the attack was carried out via the > website (a vulnerability in one of the php script packages we use). > I'll put up a dummy page informing visitors. Am I the only one thinking this is the perfect moment to put up the new static webpage along with the new design *hint hint* ? _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

20 years, 3 months

Re: [ros-svn] [ion] 16675: - Freetype Update to 2.1.10. Reduces memory usage, increases speed and fixes drawing bugs.

by Steven Edwards

--- ion(a)svn.reactos.com wrote: > - Freetype Update to 2.1.10. Reduces memory usage, increases speed and fixes drawing bugs. > - Enable Bytecode. Weird_W's fonts finally look humanly readable. Turn it off. ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

20 years, 3 months

Re: [ros-svn] [ekohl] 16685: Add parameter checks.

by James Tabor

Hi, ekohl(a)svn.reactos.com wrote: > Add parameter checks. > > > Updated files: > trunk/reactos/lib/setupapi/cfgmgr.c > [CC] lib/setupapi/cfgmgr.c lib/setupapi/cfgmgr.c: In function `CM_Locate_DevNode_ExW': lib/setupapi/cfgmgr.c:991: error: `CM_LOCATE_DEVNODE_BITS' undeclared (first use in this function) lib/setupapi/cfgmgr.c:991: error: (Each undeclared identifier is reported only once lib/setupapi/cfgmgr.c:991: error: for each function it appears in.) make: *** [obj-i386/lib/setupapi/cfgmgr.o] Error 1 I found /w32api/include/ddk/cfgmgr32.h adding <ddk/cfgmgr32.h> did help, but it created more problems. Thanks, James

20 years, 3 months

Reactos.com unavailable

by Ge van Geldorp

There are strong indications that the reactos.com box got cracked. Unfortunately, I'm on vacation right now and unable to fix things. Since it is causing problems on the network it will be isolated, meaning no network traffic in or out. This will mean the website will go down and the mailing lists will become inactive. I'm sorry about this, but there is not much I can do for the next week. Ge van Geldorp.

20 years, 3 months

Re: [ros-svn] [ekohl] 16685: Add parameter checks.

by Thomas Weidenmueller

ekohl(a)svn.reactos.com wrote: > Add parameter checks. > > > Updated files: > trunk/reactos/lib/setupapi/cfgmgr.c > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn > lib\setupapi\cfgmgr.c: In function `CM_Locate_DevNode_ExW': lib\setupapi\cfgmgr.c:991: error: `CM_LOCATE_DEVNODE_BITS' undeclared (first use in this function) lib\setupapi\cfgmgr.c:991: error: (Each undeclared identifier is reported only o nce lib\setupapi\cfgmgr.c:991: error: for each function it appears in.) mingw32-make: *** [obj-i386\lib\setupapi\cfgmgr.o] Error 1

20 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev