Ros-dev

ros-dev@reactos.org

5788 discussions

by Saveliy Tretiakov

I sent this to ros-dev about 3 months ago but nobody commited. ChangeLog: Correct return values. Fix suggested by w3seek. Index: misc/comm.c =================================================================== --- misc/comm.c (revision 16707) +++ misc/comm.c (working copy) @@ -834,7 +834,7 @@ CommConfigDialogA(LPCSTR lpszName, HWND hWnd, LPCOMMCONFIG lpCC) { PWCHAR NameW; - BOOL result; + DWORD result; /* don't use the static thread buffer so operations in serialui don't overwrite the string */ @@ -858,9 +858,9 @@ STDCALL CommConfigDialogW(LPCWSTR lpszName, HWND hWnd, LPCOMMCONFIG lpCC) { - BOOL (STDCALL *drvCommDlgW)(LPCWSTR, HWND, LPCOMMCONFIG); + DWORD (STDCALL *drvCommDlgW)(LPCWSTR, HWND, LPCOMMCONFIG); HMODULE hSerialuiDll; - BOOL result; + DWORD result; //FIXME: Get dll name from registry. (setupapi needed) if(!(hSerialuiDll = LoadLibraryW(L"serialui.dll"))) @@ -869,7 +869,8 @@ return FALSE; } - drvCommDlgW = GetProcAddress(hSerialuiDll, "drvCommConfigDialogW"); + drvCommDlgW = (DWORD (STDCALL *)(LPCWSTR, HWND, LPCOMMCONFIG)) + GetProcAddress(hSerialuiDll, "drvCommConfigDialogW"); if(!drvCommDlgW) { @@ -879,8 +880,10 @@ } result = drvCommDlgW(lpszName, hWnd, lpCC); + SetLastError(result); FreeLibrary(hSerialuiDll); - return result; + + return (result == ERROR_SUCCESS ? TRUE : FALSE); } Index: serialui.h =================================================================== --- serialui.h (revision 16707) +++ serialui.h (working copy) @@ -11,8 +11,7 @@ #include "resource.h" #define UNIMPLEMENTED \ - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); \ - return FALSE; + return ERROR_CALL_NOT_IMPLEMENTED ; #define DEFAULT_BAUD_INDEX 6 #define DEFAULT_BYTESIZE_INDEX 3 @@ -45,27 +44,27 @@ * ************************************/ -BOOL WINAPI drvCommConfigDialogW(LPCWSTR lpszDevice, +DWORD WINAPI drvCommConfigDialogW(LPCWSTR lpszDevice, HWND hWnd, LPCOMMCONFIG lpCommConfig); -BOOL WINAPI drvCommConfigDialogA(LPCSTR lpszDevice, +DWORD WINAPI drvCommConfigDialogA(LPCSTR lpszDevice, HWND hWnd, LPCOMMCONFIG lpCommConfig); -BOOL WINAPI drvSetDefaultCommConfigW(LPCWSTR lpszDevice, +DWORD WINAPI drvSetDefaultCommConfigW(LPCWSTR lpszDevice, LPCOMMCONFIG lpCommConfig, DWORD dwSize); -BOOL WINAPI drvSetDefaultCommConfigA(LPCSTR lpszDevice, +DWORD WINAPI drvSetDefaultCommConfigA(LPCSTR lpszDevice, LPCOMMCONFIG lpCommConfig, DWORD dwSize); -BOOL WINAPI drvGetDefaultCommConfigW(LPCWSTR lpszDevice, +DWORD WINAPI drvGetDefaultCommConfigW(LPCWSTR lpszDevice, LPCOMMCONFIG lpCommConfig, LPDWORD lpdwSize); -BOOL WINAPI drvGetDefaultCommConfigA(LPCSTR lpszDevice, +DWORD WINAPI drvGetDefaultCommConfigA(LPCSTR lpszDevice, LPCOMMCONFIG lpCommConfig, LPDWORD lpdwSize); Index: serialui.c =================================================================== --- serialui.c (revision 16707) +++ serialui.c (working copy) @@ -98,7 +98,7 @@ /* * @implemented */ -BOOL WINAPI drvCommConfigDialogW(LPCWSTR lpszDevice, +DWORD WINAPI drvCommConfigDialogW(LPCWSTR lpszDevice, HWND hWnd, LPCOMMCONFIG lpCommConfig) { @@ -106,7 +106,7 @@ if(!lpszDevice || !lpCommConfig) { - return FALSE; + return ERROR_INVALID_PARAMETER; } DialogInfo.lpszDevice = lpszDevice; @@ -119,7 +119,7 @@ /* * @implemented */ -BOOL WINAPI drvCommConfigDialogA(LPCSTR lpszDevice, +DWORD WINAPI drvCommConfigDialogA(LPCSTR lpszDevice, HWND hWnd, LPCOMMCONFIG lpCommConfig) { @@ -136,13 +136,13 @@ return result; } else - return FALSE; + return ERROR_NOT_ENOUGH_MEMORY; } /* * @unimplemented */ -BOOL WINAPI drvSetDefaultCommConfigW(LPCWSTR lpszDevice, +DWORD WINAPI drvSetDefaultCommConfigW(LPCWSTR lpszDevice, LPCOMMCONFIG lpCommConfig, DWORD dwSize) { @@ -152,7 +152,7 @@ /* * @unimplemented */ -BOOL WINAPI drvSetDefaultCommConfigA(LPCSTR lpszDevice, +DWORD WINAPI drvSetDefaultCommConfigA(LPCSTR lpszDevice, LPCOMMCONFIG lpCommConfig, DWORD dwSize) { @@ -162,7 +162,7 @@ /* * @unimplemented */ -BOOL WINAPI drvGetDefaultCommConfigW(LPCWSTR lpszDevice, +DWORD WINAPI drvGetDefaultCommConfigW(LPCWSTR lpszDevice, LPCOMMCONFIG lpCommConfig, LPDWORD lpdwSize) { @@ -172,7 +172,7 @@ /* * @unimplemented */ -BOOL WINAPI drvGetDefaultCommConfigA(LPCSTR lpszDevice, +DWORD WINAPI drvGetDefaultCommConfigA(LPCSTR lpszDevice, LPCOMMCONFIG lpCommConfig, LPDWORD lpdwSize) { @@ -231,7 +231,7 @@ /* Initialize baud rate combo */ if(!(hBox = GetDlgItem(hDlg, IDC_BAUDRATE))) - EndDialog(hDlg, 0); + EndDialog(hDlg, ERROR_CANCELLED); for(i = 0; Bauds[i]; i++) { @@ -246,7 +246,7 @@ /* Initialize byte size combo */ if(!(hBox = GetDlgItem(hDlg, IDC_BYTESIZE))) - EndDialog(hDlg, 0); + EndDialog(hDlg, ERROR_CANCELLED); for(i = 0; ByteSizes[i]; i++) { @@ -261,7 +261,7 @@ /* Initialize parity combo */ if(!(hBox = GetDlgItem(hDlg, IDC_PARITY))) - EndDialog(hDlg, 0); + EndDialog(hDlg, ERROR_CANCELLED); for(i = 0; Parities[i].StrId; i++) { @@ -278,7 +278,7 @@ /* Initialize stop bits combo */ if(!(hBox = GetDlgItem(hDlg, IDC_STOPBITS))) - EndDialog(hDlg, 0); + EndDialog(hDlg, ERROR_CANCELLED); for(i = 0; StopBits[i].StrId; i++) { @@ -295,7 +295,7 @@ /* Initialize flow control combo */ if(!(hBox = GetDlgItem(hDlg, IDC_FLOW))) - EndDialog(hDlg, 0); + EndDialog(hDlg, ERROR_CANCELLED); if(LoadStringW(hDllInstance, IDS_FC_NO, wstr, sizeof(wstr) / sizeof(wstr[0]))) { @@ -337,11 +337,11 @@ switch(wParam) { case IDC_CANCELBTN: - EndDialog(hDlg, FALSE); + EndDialog(hDlg, ERROR_CANCELLED); break; case IDC_OKBTN: OkButton(hDlg); - EndDialog(hDlg, TRUE); + EndDialog(hDlg, ERROR_SUCCESS); break; } return TRUE; @@ -349,11 +349,11 @@ case WM_CLOSE: { - EndDialog(hDlg, FALSE); + EndDialog(hDlg, ERROR_CANCELLED); return TRUE; } /* WM_CLOSE */ - default: + default: return FALSE; }

19 years, 5 months

API status

by Casper Hornstrup

Hi. I've set up the API status at: http://svn.reactos.com/api/ Casper

19 years, 5 months

RE: [ros-diffs] [ea] 16854: Various fixex to make HEAD compile.

by Casper Hornstrup

Why not just remove the code in #if 0/#endif? It serves no purpose. ________________________________________ From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com] On Behalf Of ea(a)svn.reactos.com Sent: 29. juli 2005 12:05 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [ea] 16854: Various fixex to make HEAD compile. Various fixex to make HEAD compile. I hope I did break nothing. Modified: trunk/reactos/hal/halx86/generic/processor.c Modified: trunk/reactos/lib/advapi32/sec/trustee.c Modified: trunk/reactos/lib/advapi32/service/scm.c Modified: trunk/reactos/subsys/csrss/win32csr/desktopbg.c Modified: trunk/reactos/subsys/ntvdm/ntvdm.c Modified: trunk/reactos/subsys/smss/client.c Modified: trunk/reactos/subsys/system/setup/setup.c Modified: trunk/reactos/subsys/system/winlogon/setup.c Modified: trunk/reactos/subsys/win32k/ntuser/keyboard.c ________________________________________ Modified: trunk/reactos/hal/halx86/generic/processor.c --- trunk/reactos/hal/halx86/generic/processor.c 2005-07-29 09:51:08 UTC (rev 16853) +++ trunk/reactos/hal/halx86/generic/processor.c 2005-07-29 10:04:38 UTC (rev 16854) @@ -39,7 +39,9 @@ HalStartNextProcessor(ULONG Unknown1, ULONG ProcessorStack) { +#if 0 DPRINT("HalStartNextProcessor(%x %x)\n", ProcessorNumber, ProcessorStack); +#endif return TRUE; }

19 years, 5 months

Re: [ros-dev] Regression in 15402

by Filip Navara

19 years, 5 months

Geda Tool GSchem with Gdi Object Bug

by James Tabor

Hi, If anyone likes EDA programming tools and stuff. I've been testing geda tools from http://geda.seul.org/. The mingw32 tool set. At least I had the canvas and the info window popped up. Still more work to be done, but better than ~9 mo ago. Here is the debug log, (lib/ntdll/ldr/utils.c:2037) Failed to create or open dll section of 'Wintab32.d ll' (Status c0000135) GDI32: GetTextCharsetInfo is unimplemented, please try again later. (lib/ntdll/ldr/utils.c:2094) Relocating (10000000 -> dc1000) C:\geda\lib\pango\1 .2.0\modules\pango-basic-win32.dll (lib/ntdll/ldr/utils.c:1215) LdrGetExportByName(): failed to find g_module_check _init (lib/ntdll/ldr/utils.c:1215) LdrGetExportByName(): failed to find g_module_unloa d (lib/ntdll/ldr/utils.c:2037) Failed to create or open dll section of 'usp10.dll' (Status c0000135) WARNING: NtGdiGetGlyphOutline at subsys/win32k/objects/text.c:2163 is UNIMPLEME NTED! WARNING: NtGdiGetGlyphOutline at subsys/win32k/objects/text.c:2163 is UNIMPLEME NTED! <snip... .> WARNING: NtGdiGetGlyphOutline at subsys/win32k/objects/text.c:2163 is UNIMPLEME NTED! (ntoskrnl/io/file.c:3366) Invalid access rights (lib/ntdll/ldr/utils.c:2094) Relocating (10000000 -> de1000) C:\geda\lib\gtk-2.0 \2.2.0\loaders\libpixbufloader-xpm.dll (lib/ntdll/ldr/utils.c:1215) LdrGetExportByName(): failed to find g_module_check _init (lib/ntdll/ldr/utils.c:1215) LdrGetExportByName(): failed to find g_module_unloa d WARNING: NtGdiGetGlyphOutline at subsys/win32k/objects/text.c:2163 is UNIMPLEME NTED! <snip... .> WARNING: NtGdiOffsetClipRgn at subsys/win32k/objects/cliprgn.c:330 is UNIMPLEME NTED! WARNING: NtGdiOffsetClipRgn at subsys/win32k/objects/cliprgn.c:330 is UNIMPLEME NTED! WARNING: NtGdiOffsetClipRgn at subsys/win32k/objects/cliprgn.c:330 is UNIMPLEME NTED! (ntoskrnl/mm/mm.c:300) Address: ffffffff _SEHCallHandler: REG 006de75c _SEHCallHandler: REG 006dec28 _SEHCallHandler: REG 006dec28 Unhandled exception Address: 7c819641 C:\ReactOS\system32\kernel32.dll CS:EIP 1b:7c819641 DS 23 ES 23 FS 3b GS 0 EAX: 7c8b95c8 EBX: 27100250 ECX: 006df0f0 EDX: 00005453 EBP: 006df148 ESI: 10043ea3 ESP: 006df100 EDI: 000003d7 EFLAGS: 00010217 Frames: 7c800000+199b9 C:\ReactOS\system32\kernel32.dll 80b000+62493 C:\geda\lib\libglib-2.0-0.dll 10000000+4e718 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+442b0 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+334d6 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+33b67 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+3ea1 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+3ea1 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+1f133 C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+3ea1 C:\geda\lib\libgdk-win32-2.0-0.dll 9de000+1512a3 C:\geda\lib\libgtk-win32-2.0-0.dll 9de000+1571b2 C:\geda\lib\libgtk-win32-2.0-0.dll 9de000+21090e C:\geda\lib\libgtk-win32-2.0-0.dll 9de000+2109af C:\geda\lib\libgtk-win32-2.0-0.dll 9de000+eeffa C:\geda\lib\libgtk-win32-2.0-0.dll 966000+4469 C:\geda\lib\libgobject-2.0-0.dll 966000+3cbc C:\geda\lib\libgobject-2.0-0.dll 966000+1727f C:\geda\lib\libgobject-2.0-0.dll 966000+166f1 C:\geda\lib\libgobject-2.0-0.dll 966000+16b36 C:\geda\lib\libgobject-2.0-0.dll 9de000+1fe4bb C:\geda\lib\libgtk-win32-2.0-0.dll 9de000+ed9dd C:\geda\lib\libgtk-win32-2.0-0.dll 10000000+2123e C:\geda\lib\libgdk-win32-2.0-0.dll 10000000+212da C:\geda\lib\libgdk-win32-2.0-0.dll 9de000+44160 C:\geda\lib\libgtk-win32-2.0-0.dll 80b000+1c865 C:\geda\lib\libglib-2.0-0.dll 80b000+1d07c C:\geda\lib\libglib-2.0-0.dll 80b000+1d6e3 C:\geda\lib\libglib-2.0-0.dll 80b000+1a21f C:\geda\lib\libglib-2.0-0.dll 9de000+ed0e9 C:\geda\lib\libgtk-win32-2.0-0.dll 400000+8f60 C:\geda\bin\gschem.exe 6eb00000+1dae1 C:\geda\lib\libguile.dll 6eb00000+2113c C:\geda\lib\libguile.dll 6eb00000+45696 C:\geda\lib\libguile.dll 6eb00000+20ef8 C:\geda\lib\libguile.dll 6eb00000+20dcb C:\geda\lib\libguile.dll 6eb00000+1db0b C:\geda\lib\libguile.dll 400000+9266 C:\geda\bin\gschem.exe 400000+1182 C:\geda\bin\gschem.exe 400000+1018 C:\geda\bin\gschem.exe 7c800000+2efec C:\ReactOS\system32\kernel32.dll _SEHCallHandler: REG 006deca8 _SEHCallHandler: REG 006dffb8 _SEHCallHandler: REG 006dffb8 (subsys/win32k/objects/gdiobj.c:545) GdiHdr->Locks: 1 Assertion 'FALSE' failed at subsys/win32k/objects/gdiobj.c line 549 KeBugCheckWithTf at ntoskrnl/ke/catch.c:228 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. The problem seems to be caused by the following file: ntoskrnl.exe Technical information: *** STOP: 0x0000001E (0x80000003,0x8009fdc1,0x9dcf624e,0x00000009) *** ntoskrnl.exe - Address 0x8009fdc1 base at 0x80000000, DateStamp 0x0 Breakpoint Exception: 3(0) Processor: 0 CS:EIP 8:8009fdc1 <ntoskrnl.exe:9fdc1 ({standard input}:23 ())> cr2 76179ed5 cr3 3ac9d000 Proc: 816d71b0 Pid: 120 <gschem.exe> Thrd: 816d8c40 Ti d: 124 DS 10 ES 10 FS 30 GS 0 EAX: 00000044 EBX: 000000d5 ECX: 00000000 EDX: 000003f8 EBP: 9f0ffc14 ESI: 006dfef0 ESP: 9f0ffb84 EDI: 9f0ffd74 EFLAGS: 00000292 kESP 9f0ffb84 kernel stack base 9f0fd000 Frames: <win32k.sys:802d8 (subsys/win32k/objects/gdiobj.c:549 (GDIOBJ_FreeObj))> <win32k.sys:805f2 (subsys/win32k/objects/gdiobj.c:670 (GDI_CleanupForProcess))> <win32k.sys:3aea3 (subsys/win32k/main/dllmain.c:102 (Win32kProcessCallback))> <ntoskrnl.exe:82bce (ntoskrnl/ps/win32.c:99 (PsTerminateWin32Process))> <ntoskrnl.exe:7a6a2 (ntoskrnl/ps/kill.c:295 (PspExitThread))> <ntoskrnl.exe:7ae16 (ntoskrnl/ps/kill.c:591 (NtTerminateProcess))> <ntoskrnl.exe:958b2 ({standard input}:177 (KiSystemService))> <kernel32.dll:32222 (lib/kernel32/process/proc.c:592 (ExitProcess))>

19 years, 5 months

Forward to or put a link to http://reactosde.re.funpic.de on the ROS homepage?

by reactos

Wouldn't it be good to forward web-users to http://reactosde.re.funpic.de ? or at least put a link for those wanting to go on with something? Yours sincerely, Jaix Bly

19 years, 5 months

Upgrading Subversion to 1.2.1

by Casper Hornstrup

Hi. I'm upgrading Subversion on svn.reactos.com to version 1.2.1 to correct some memory leaks in svnserve. Subversion 1.2.x also brings us: Faster access to old revisions. svn blame, svn checkout, svn update, svn diff, svn merge will be faster. Locking. If you have an 1.2.x client you can lock files and directories. This is mostly useful for binaries so it's possibly not something we will use much. For faster access to old revisions, a "dump and load" of the repository is needed so the repository will be unavailable for a few hours today. Casper

19 years, 5 months

Regression in 15402

by Alex Ionescu

Hi, It seems that the problem regarding Ged's RTL network card is related to patch 15402: http://svn.reactos.com/viewcvs?view=rev&rev=15402. Is it possible that the card is incorrectly (or not in the same way we are expecting) telling us its resource data? Or that somethign has been overlooked? Ged has done a terrible deal of network testing for us but he's been unable to work since his network card couldn't even ping anymore. I've helped him find the regression and I hope someone more experienced in PnP can help him out... at least we know what patch did it. Best regards, Alex Ionescu

19 years, 5 months

Re: [ros-diffs] [ion] 16730: - Final ROSRTL removal patch. The next patch will remove the actual library and code.

by Hartmut Birr

ion(a)svn.reactos.com wrote: >- Final ROSRTL removal patch. The next patch will remove the actual library and code. >- Changes: > - CreateProcess > * Cleanup creation of the initial thread using new utility functions and remove rosrtl > * Almost entirely rewrote the function to support features such as: > - SxS (locally only, patch will follow), > - SFP (SAFER) (locally only, patch will follow), > - DllPaths (locally only, patch will follow), > - Proper process environment/paramter block creation > - Proper console handle management (needs more work in kernel32/csr), > - Tokens/CreateProcessAsUser (locally only, patch will follow), > - Simpler code for path lookup, and more robust. > - Support for "auto-correction" (see Raymond Chen's blog) > - 16-bit/NE detection > - A variety of creation flags are now properly supported > - Added support for an undocumented-yet-known (see comment) shell flag > - Alert for flags we don't support yet > - Catch invalid flag combinations and other caller errors > - Improve and correct path searcing to use documented behaviours > - Created a multitude of helper functions to make the code easier to read > and allow them to be used for other apis as time goes on. > > - BaseProcessStartup > * Call NtSetThreadInformation to let the Kernel know of the Thread's Start Address. > * Correct prototype of Thread Startup function for this case. > >This fixes MANY things, some of which may not be evident, and possibly creates regressions which I have not yet seen but will try to correct. Some of these may be caused by the fact that I've seen code send CreateProcessW incorrect flags. Some things of note: DO NOT send partial names as "lpApplicationName". It's not supposed to work unless you're in the same current directory. Also, do NOT send CREATE_UNICODE_ENVIRONMENT if you don't have a unicode environement, and vice-versa. I've seen lots of code doing mistakes related to this. I hope you appreciate this patch and won't all jump on me for possbile regressions :(. > >Modified: trunk/reactos/lib/kernel32/process/create.c >Modified: trunk/reactos/lib/kernel32/thread/i386/thread.S >Modified: trunk/reactos/lib/kernel32/thread/thread.c >Modified: trunk/reactos/ntoskrnl/mm/process.c > > > ------------------------------------------------------------------------ Hi, your rewrite of CreateProcess is broken. Before you can inform csrss about the process creation, you have to gather all informations about handles and creation options. After your commit, each console application creates its own console window and the redirection of standard handles is broken. It seems also that the inheritance of msvcrt file id's is broken. This stops compiling ros on ros. - Hartmut

19 years, 5 months

Crash by starting OOo1.4 setup.exe (r16740)

by reactos

OOo1.4 Setup is crashing ROS, here comes a crashreport ROS r16740 Yours sincerely, Jaix Bly

19 years, 5 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev