Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-svn] [ion] 15941: Fix strpbrk
by Steven Edwards 17 Jun '05

17 Jun '05

Hi, --- ion(a)svn.reactos.com wrote: > Fix strpbrk Not to be rude Alex and this is not mainly directed at you but everyone that does SVN commits but this and your other commit tell me nothing. Fix gate code and fix strpbrk. How was it broken/fixed? I mean something like "fixed a race in gate code" or "fixed a lock in gate code" would be enough to make me happy. Like I said its not meant to be directed just at you. I would not mind the terse commit messages as much if I just had to click a url embedded in the commit message to see the diff. Could we get the url to the diff in svn for ros-svn so I don't have to be on yet another mailing list if I want to review the diff? I know I asked about this before but I don't quite remeber what the problem was. Thanks Steven ____________________________________________________ Yahoo! Sports Rekindle the Rivalries. Sign up for Fantasy Football http://football.fantasysports.yahoo.com

1 0

RE: [ros-dev] Patch up for testing
by Ge van Geldorp 16 Jun '05

16 Jun '05

> From: Filip Navara > > Fast mutexes in paged pool ... aren't that good idea. Alex talked me into using guarded mutexes instead of fast mutexes. That solves the paged pool problem too. Gé van Geldorp.

1 0

xml question
by Hartmut Birr 16 Jun '05

16 Jun '05

Hi, I would like to build the string library with the assembler sources. I've modified string.xml, but I get the following warning: makefile.auto:23675: warning: overriding commands for target `.\up\obj-i386\lib\string\memccpy.o' makefile.auto:23659: warning: ignoring old commands for target `.\up\obj-i386\lib\string\memccpy.o' makefile.auto:23683: warning: overriding commands for target `.\up\obj-i386\lib\string\memcmp.o' makefile.auto:23663: warning: ignoring old commands for target `.\up\obj-i386\lib\string\memcmp.o' makefile.auto:23731: warning: overriding commands for target `.\up\obj-i386\lib\string\strcspn.o' makefile.auto:23667: warning: ignoring old commands for target `.\up\obj-i386\lib\string\strcspn.o' makefile.auto:23743: warning: overriding commands for target `.\up\obj-i386\lib\string\strspn.o' makefile.auto:23671: warning: ignoring old commands for target `.\up\obj-i386\lib\string\strspn.o' What is wrong in string.xml? - Hartmut

2 1

Re: [ros-dev] Patch up for testing
by Filip Navara 16 Jun '05

16 Jun '05

1 0

lib/crt/stdlib/strtoull.c buggy?
by Mark Junker 16 Jun '05

16 Jun '05

Hi, the strtoull function should work with "long long"s instead of "long"s. A patch is attached. However, it would be better to test for the existence of a 64 bit integral data type and compile this function optionally ... BTW: It seems that all sources in lib/crtdll/ (except dllmain.c and precomp.h) are unused. Is this correct? Regards, Mark Index: lib/crt/stdlib/strtoull.c =================================================================== --- lib/crt/stdlib/strtoull.c (revision 15932) +++ lib/crt/stdlib/strtoull.c (working copy) @@ -4,21 +4,49 @@ #include <ctype.h> #include <errno.h> #include <stdlib.h> -//#include <msvcrt/unconst.h> +/* #include <msvcrt/unconst.h> */ +/* required to get prototype for __set_errno() */ +#include <internal/file.h> + +#if defined(LONG_LONG_MAX) +/* GCC-style constant */ +#define ROS_LLONG_MAX LONG_LONG_MAX +#define ROS_ULLONG_MAX ULONG_LONG_MAX +typedef long long ros_ll; +typedef unsigned long long ros_ull; +#elif defined(_I64_MAX) +/* MSVC-style constant */ +#define ROS_LLONG_MAX _I64_MAX +#define ROS_ULLONG_MAX _UI64_MAX +typedef __int64 ros_ll; +typedef unsigned __int64 ros_ull; +#elif defined(LLONG_MAX) +/* C9x-style constant */ +#define ROS_LLONG_MAX LLONG_MAX +#define ROS_ULLONG_MAX ULLONG_MAX +#include <stdint.h> +typedef int64_t ros_ll; +typedef uint64_t ros_ull; +#else +#define ROS_LLONG_MAX LONG_MAX +#define ROS_ULLONG_MAX ULONG_MAX +typedef long ros_ll; +typedef unsigned long ros_ull; +#endif + /* * Convert a string to an unsigned long integer. * * Ignores `locale' stuff. Assumes that the upper and lower case * alphabets and digits are each contiguous. */ -unsigned long +ros_ull strtoull(const char *nptr, char **endptr, int base) { const char *s = nptr; - unsigned long acc; + ros_ull acc, cutoff; int c; - unsigned long cutoff; int neg = 0, any, cutlim; /* @@ -43,8 +71,8 @@ } if (base == 0) base = c == '0' ? 8 : 10; - cutoff = (unsigned long)ULONG_MAX / base; - cutlim = (unsigned long)ULONG_MAX % base; + cutoff = (ros_ull)ROS_ULLONG_MAX / base; + cutlim = (int) ((ros_ull)ROS_ULLONG_MAX % base); for (acc = 0, any = 0;; c = *s++) { if (isdigit(c)) @@ -65,7 +93,7 @@ } if (any < 0) { - acc = ULONG_MAX; + acc = ROS_ULLONG_MAX; __set_errno ( ERANGE ); } else if (neg)

1 0

rbuild issue
by Hartmut Birr 15 Jun '05

15 Jun '05

Hi, our new build system doesn't use the assembler string functions in lib\string. - Hartmut

2 1

Re: [ros-svn] [ion] 14754: Add KDBG debugging hack from old code and convert it to fit new one. Not enabled yet because it underflows the stack after a while (researching why).
by Anich Gregor 13 Jun '05

13 Jun '05

This breaks parts of KDB too. Please finish your changes to ctxswitch.S and put back the old functionality (which KDB relies on) if possible.

2 2

Re: [ros-svn] [ion] 14790: Don't use hack for trap frames anymore, read TempEsp and TempSegSs for kernel-mode traps during debugging.
by Anich Gregor 13 Jun '05

13 Jun '05

Please revert these changes if possible, they are part of KDBs current breakage and pretty much incorrect (from KDBs point of view)

2 2

crash in win32k with the cirrus driver
by Hartmut Birr 13 Jun '05

13 Jun '05

Hi, if I use the cirrus driver in qemu, I get always wrong colors. After the first double click to the cmd icon, ros crashs in DIB_16BPP_BitBltSrcCopy. I've add the following code: Index: subsys/win32k/dib/dib16bpp.c =================================================================== --- subsys/win32k/dib/dib16bpp.c (Revision 15885) +++ subsys/win32k/dib/dib16bpp.c (Arbeitskopie) @@ -228,6 +228,8 @@ } else { + DPRINT1("%d %d %d\n", BltInfo->SourceSurface->lDelta, BltInfo->SourcePoint.x, BltInfo->SourcePoint.y); + DPRINT1("%d %d %d %d %d\n", BltInfo->DestSurface->lDelta, BltInfo->DestRect.left, BltInfo->DestRect.top, BltInfo->DestRect.right, BltInfo->DestRect.bottom); I see often negative values for the source surface: ... (subsys\win32k\dib\dib16bpp.c:231) -1120 -69 -69 (subsys\win32k\dib\dib16bpp.c:232) 1600 0 0 0 0 (subsys\win32k\dib\dib16bpp.c:231) -1120 -69 -69 (subsys\win32k\dib\dib16bpp.c:232) 1600 0 0 0 0 (subsys\win32k\dib\dib16bpp.c:231) -1120 0 13 (subsys\win32k\dib\dib16bpp.c:232) 1600 69 69 629 87 KeBugCheckWithTf at ntoskrnl\ke\catch.c:222 A problem has been detected and ReactOS has been shut down to prevent damage to your computer. ... I seems that win32k doesn't handle the negative values. I doesn't know what they mean. - Hartmut

3 4

RE: [ros-dev] Visual IDE for ROS
by Murphy, Ged (Bolton) 13 Jun '05

13 Jun '05

Joseph Miller wrote: > So I am currently working on making my Visual GWin++ > project work under ReactOS. If it works under windows, it should work under ROS. If it doesn't, it's likely there is some missing functionality or bugs in ROS at the moment. You shouldn't modify your program to work under ROS if it breaks Windows functionality, as it's likely to be fixed in the future. If it works under Windows but not ROS, try to establish why and report it. This would be a more productive way for both projects. Regards, Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev