Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] Service Control Manager, Plug and Pray, SMB and RPC

by Steven Edwards

--- Eric Kohl <eric.kohl(a)t-online.de> wrote: > IMHO, adding missing features to WIDL and fixing resulting bugs in > rpcrt4 is much more important right now. Access to remote machines, new > transports (tcp, udp, http, etc.) and a dynamic endpoint mapper (aka > rpcss) is not that important. Would it be possible to go ahead and port some of the Wine advapi32 SCM code? Its able to install and run services such as the Windows Installer so that might solve a few problems we are facing with the Msi service and CoLinux. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

19 years, 7 months

RE: [ros-dev] ping Alex regarding log2() for scheduler

by Waldo Alvarez Cañizares

Can't that one be transformed to do a Bit Scan Reverse? I guess there are alogorithms for it too. Try near the link I provided. Or try the Angner Fog's optimization manual. If that does not works you could try SuperOptimizer. Is a program that finds algorithms in assembler for some arch (x86 included of course) by means of trying instructions using bruteforce (you can use several computers if you want), usually can be converted back to a HLL. This function is little enought to let superoptimizer work. Find it, is open source software, a little complex and MACROfied piece of code but somehow modifiable to suit your needs. Best Regards Waldo Alvarez ________________________________ From: ros-dev-bounces(a)reactos.com on behalf of Royce Mitchell III Sent: Fri 3/25/2005 4:19 PM To: ReactOS Development List Subject: Re: [ros-dev] ping Alex regarding log2() for scheduler Waldo Alvarez Cañizares wrote: >but if you are searching a fast BSF replacement... > > Unfortunately we have no need of BSF :( Is there a similar algo for BSR, which is what we need? _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev

19 years, 7 months

call for an atapi tester

by Hartmut Birr

Hi, does anyone own a motherboard with an intel chipset and with an ICH5/6 io controller hub? I've modified atapi a little bit. Atapi may detect the second ide (SATA) controller of an ICH5/6. I'm interested on the debug output from atapi while booting. - Hartmut M:\Sandbox\ros_work\reactos>set SVN_EDITOR=notepad M:\Sandbox\ros_work\reactos>d:\programme\subversion\bin\svn.exe diff drivers\storage\atapi\atapi.c Index: drivers/storage/atapi/atapi.c =================================================================== --- drivers/storage/atapi/atapi.c (revision 14209) +++ drivers/storage/atapi/atapi.c (working copy) @@ -123,7 +123,15 @@ ULONG Dummy; } UNIT_EXTENSION, *PUNIT_EXTENSION; -PCI_SLOT_NUMBER LastSlotNumber; +#if 1 +/* + * FIXME: + * ScsiPortGetDeviceBase must check if a resource is already in use. + * This needs to implement IoReportResourceUsage or IoReportResourceForDetection. + */ +ULONG CommandPortArray[64]; +ULONG CommandPortCount = 0; +#endif #ifdef ENABLE_NATIVE_PCI typedef struct _PCI_NATIVE_CONTROLLER @@ -388,8 +396,6 @@ InitData.DeviceId = 0; InitData.DeviceIdLength = 0; - LastSlotNumber.u.AsULONG = 0xFFFFFFFF; - Status = ScsiPortInitialize(DriverObject, RegistryPath, &InitData, @@ -437,6 +443,27 @@ #ifdef ENABLE_DMA ULONG Length; #endif +#if 1 + /* + * FIXME: + * ScsiPortGetDeviceBase must check if a resource is already in use. + * This needs to implement IoReportResourceUsage or IoReportResourceForDetection. + */ + ULONG i; + + for (i = 0; i < CommandPortCount; i++) + { + if (CommandPortArray[i] == CommandPortBase) + { + break; + } + } + if (i < CommandPortCount || + CommandPortCount >= 64) + { + return FALSE; + } +#endif IoAddress = ScsiPortConvertUlongToPhysicalAddress(CommandPortBase); IoBase = ScsiPortGetDeviceBase((PVOID)DevExt, InterfaceType, @@ -534,6 +561,14 @@ { ConfigInfo->AtdiskSecondaryClaimed = TRUE; } +#if 1 + /* + * FIXME: + * ScsiPortGetDeviceBase must check if a resource is already in use. + * This needs to implement IoReportResourceUsage or IoReportResourceForDetection. + */ + CommandPortArray[CommandPortCount++] = CommandPortBase; +#endif return TRUE; } @@ -559,7 +594,7 @@ BOOLEAN DeviceFound; ULONG BusMasterBasePort = 0; - DPRINT("AtapiFindCompatiblePciController() Bus: %lu Slot: %lu\n", + DPRINT1("AtapiFindCompatiblePciController() Bus: %lu Slot: %lu\n", ConfigInfo->SystemIoBusNumber, ConfigInfo->SlotNumber); @@ -600,10 +635,10 @@ } } - DPRINT("%x %x\n", PciConfig.BaseClass, PciConfig.SubClass); - if (PciConfig.BaseClass == 0x01 && - PciConfig.SubClass == 0x01) // && -// (PciConfig.ProgIf & 0x05) == 0) + DPRINT("%x %x %x\n", PciConfig.BaseClass, PciConfig.SubClass, PciConfig.ProgIf); + if (PciConfig.BaseClass == PCI_CLASS_MASS_STORAGE_CTLR && + PciConfig.SubClass == PCI_SUBCLASS_MSC_IDE_CTLR && + (PciConfig.ProgIf & 0x05) == 0) { /* both channels are in compatibility mode */ DPRINT("Bus %1lu Device %2lu Func %1lu VenID 0x%04hx DevID 0x%04hx\n", @@ -692,7 +727,7 @@ BOOLEAN ChannelFound = FALSE; BOOLEAN DeviceFound = FALSE; - DPRINT("AtapiFindIsaBusController() called!\n"); + DPRINT1("AtapiFindIsaBusController() called!\n"); *Again = FALSE; @@ -770,7 +805,7 @@ ULONG Count; BOOLEAN ChannelFound; - DPRINT("AtapiFindNativePciController() called!\n"); + DPRINT1("AtapiFindNativePciController() called!\n"); SlotNumber.u.AsULONG = ConfigInfo->SlotNumber; StartDeviceNumber = SlotNumber.u.bits.DeviceNumber; @@ -799,9 +834,30 @@ break; } } - if (Count < sizeof(PciNativeController)/sizeof(PCI_NATIVE_CONTROLLER)) + if (PciConfig.BaseClass == 0x01) { - /* We have found a known native pci ide controller */ + DPRINT1("Bus %1lu Device %2lu Func %1lu VenID 0x%04hx DevID 0x%04hx\n", + ConfigInfo->SystemIoBusNumber, + SlotNumber.u.bits.DeviceNumber, + SlotNumber.u.bits.FunctionNumber, + PciConfig.VendorID, + PciConfig.DeviceID); + DPRINT1("BaseClass %02x, SubClass %02x, ProgIF %02x\n", PciConfig.BaseClass, PciConfig.SubClass, PciConfig.ProgIf); + DPRINT1("BaseAddresses[0] %08x\n", PciConfig.u.type0.BaseAddresses[0]); + DPRINT1("BaseAddresses[1] %08x\n", PciConfig.u.type0.BaseAddresses[1]); + DPRINT1("BaseAddresses[2] %08x\n", PciConfig.u.type0.BaseAddresses[2]); + DPRINT1("BaseAddresses[3] %08x\n", PciConfig.u.type0.BaseAddresses[3]); + DPRINT1("BaseAddresses[4] %08x\n", PciConfig.u.type0.BaseAddresses[4]); + DPRINT1("BaseAddresses[5] %08x\n", PciConfig.u.type0.BaseAddresses[5]); + DPRINT1("InterruptLine %d\n", PciConfig.u.type0.InterruptLine); + } + + if (Count < sizeof(PciNativeController)/sizeof(PCI_NATIVE_CONTROLLER) || + (PciConfig.BaseClass == PCI_CLASS_MASS_STORAGE_CTLR && + PciConfig.SubClass == PCI_SUBCLASS_MSC_IDE_CTLR && + (PciConfig.ProgIf & 0x05) == 0x05)) + { + /* We have found a known or a native pci ide controller */ if ((PciConfig.ProgIf & 0x80) && (PciConfig.u.type0.BaseAddresses[4] & PCI_ADDRESS_IO_SPACE)) { DPRINT("Found IDE Bus Master controller!\n"); @@ -813,40 +869,24 @@ BusMasterBasePort = 0; } - DPRINT("VendorID: %04x, DeviceID: %04x\n", PciConfig.VendorID, PciConfig.DeviceID); + DPRINT1("VendorID: %04x, DeviceID: %04x\n", PciConfig.VendorID, PciConfig.DeviceID); ConfigInfo->NumberOfBuses = 1; ConfigInfo->MaximumNumberOfTargets = 2; ConfigInfo->MaximumTransferLength = 0x10000; /* max 64Kbyte */ - /* FIXME: - We must not store and use the last tested slot number. If there is a recall - to the some device and we will claim the primary channel again than the call - to ScsiPortGetDeviceBase in AtapiClaimHwResource will fail and we can try to - claim the secondary channel. - */ ChannelFound = FALSE; - if (LastSlotNumber.u.AsULONG != SlotNumber.u.AsULONG) + /* try to claim primary channel */ + if ((PciConfig.u.type0.BaseAddresses[0] & PCI_ADDRESS_IO_SPACE) && + (PciConfig.u.type0.BaseAddresses[1] & PCI_ADDRESS_IO_SPACE)) { - /* try to claim primary channel */ - if ((PciConfig.u.type0.BaseAddresses[0] & PCI_ADDRESS_IO_SPACE) && - (PciConfig.u.type0.BaseAddresses[1] & PCI_ADDRESS_IO_SPACE)) - { - /* primary channel is enabled */ - ChannelFound = AtapiClaimHwResources(DevExt, - ConfigInfo, - PCIBus, - PciConfig.u.type0.BaseAddresses[0] & PCI_ADDRESS_IO_ADDRESS_MASK, - PciConfig.u.type0.BaseAddresses[1] & PCI_ADDRESS_IO_ADDRESS_MASK, - BusMasterBasePort, - PciConfig.u.type0.InterruptLine); - if (ChannelFound) - { - AtapiFindDevices(DevExt, ConfigInfo); - *Again = TRUE; - ConfigInfo->SlotNumber = LastSlotNumber.u.AsULONG = SlotNumber.u.AsULONG; - return SP_RETURN_FOUND; - } - } + /* primary channel is enabled */ + ChannelFound = AtapiClaimHwResources(DevExt, + ConfigInfo, + PCIBus, + PciConfig.u.type0.BaseAddresses[0] & PCI_ADDRESS_IO_ADDRESS_MASK, + PciConfig.u.type0.BaseAddresses[1] & PCI_ADDRESS_IO_ADDRESS_MASK, + BusMasterBasePort, + PciConfig.u.type0.InterruptLine); } if (!ChannelFound) { @@ -862,21 +902,21 @@ PciConfig.u.type0.BaseAddresses[3] & PCI_ADDRESS_IO_ADDRESS_MASK, BusMasterBasePort ? BusMasterBasePort + 8 : 0, PciConfig.u.type0.InterruptLine); - if (ChannelFound) - { - AtapiFindDevices(DevExt, ConfigInfo); - *Again = FALSE; - LastSlotNumber.u.AsULONG = 0xFFFFFFFF; - return SP_RETURN_FOUND; - } } } + if (ChannelFound) + { + CHECKPOINT1; + AtapiFindDevices(DevExt, ConfigInfo); + *Again = TRUE; + ConfigInfo->SlotNumber = SlotNumber.u.AsULONG; + return SP_RETURN_FOUND; + } } } StartFunctionNumber = 0; } *Again = FALSE; - LastSlotNumber.u.AsULONG = 0xFFFFFFFF; DPRINT("AtapiFindNativePciController() done!\n"); return(SP_RETURN_NOT_FOUND);

19 years, 7 months

Changing syntax style of files to ms style...

by Gregor Anich

Hi! Sorry if I sound a little harsh, but I am upset by the fact that i don't understand what has driven someone to change the style of a file when adding one line of code from the old (whatever) style to ms style (where '{' and '}' are on the same line as the if/else keywords - that makes multiline if/else blocks unreadable to me, I esp. dislike it when the if-expression is also multiline - like if (some_very_long_expression_which_does && not_fit_onto_a_signle_line) { ... } ) I am not sure, but I think it was Alex. Would you please tell me why you changed the style of the file? I am pretty much used to the old style, esp. if i have been working on the file before it's strange for me to see the syntax changed in a way which i dislike as much as the ms style or whatever it is. :-/

19 years, 7 months

Re: [ros-dev] STATEMENT

by \(\) Thomas Larsen \(\)

> > Taking credits for others work is not a nice thing to todo (Thx Alot).. > > but you made it worse anyway so no hard feelings :-) > What is it about? Can you point me to time/date/subject you refer to. Just Wierd that i make one implention of taskmgr their where better than the previous then some just take some of the work modify it and credit themself.. i where planning of release the version today with network status and user tab also an vc++ comp. but can see it dont matter.. :-) > > To talk about something else i start a new projekt called CubeOs > > and i would like to know if their are any special copyrights in reactos..? > Just curious: what is the project about? Its an Reactos Clone did alot of work my self and with some developers not to make a competition but to make an alternativ with some of my ideas and visions it has allways been my dream... hope its okay with the reactos team.. By the way thx for your german translation its a littel useless now on reactos but will be very happy to use it on CubeOS Greetz Thomas

19 years, 7 months

Re: [ros-dev] Service Control Manager, Plug and Pray, SMB and RPC

by Steven Edwards

Hi, --- Royce Mitchell III <royce3(a)ev1.net> wrote: > Part of the reason he's bringing this up is because I was asking what > was necessary to get working before we could dynamically load drivers > through SCM. I'm working on learning driver development, but want to do > it in ReactOS. > > Anyways, these functions look most necessary... > > OpenSCManager > CreateService > ControlService > OpenService > CloseServiceHandle > DeleteService > QueryServiceStatus > EnumServicesStatus Yes those are most of the functions I need for CoLinux and the Windows Installer service. Wine has a good bit of that implemented using a pipe for communitcation but I assume on Windows its all LPC/RPC to support "net start servicename". Anyway if no one objects I will look at importing the hackish Wine code and see if I can make it work. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

19 years, 7 months

Re: [ros-dev] STATEMENT

by \(\) Thomas Larsen \(\)

Just Mean that it is not fair when i uploade taskmgr with alot of bugfixes and translation and then someone just modify the code and take the credits but now ill just use my version on my new project on CubeOs so its okay but cant see why its done.. But thx about the license stuff Greetz Thomas

19 years, 7 months

Explorer Prob.

by James Tabor

Hi all! Just reporting some strange things with explorer. When Start->Browse Files->Drives-> (E:), this happens; (KERNEL32:mem/global.c:412) Memory Load: 17 (MSVCRT:io/open.c:103) not valid fd 0, g_fdend 5, fdinfo 7802d2f0, bucket 7802d2 f0, fdflags 0 (MSVCRT:io/open.c:700) _setmode: inval fd (0) (cm/ntfunc.c:1438) ObReferenceObjectByHandle() failed with status c0000008 (cm/ntfunc.c:1438) ObReferenceObjectByHandle() failed with status c0000008 (cm/ntfunc.c:1438) ObReferenceObjectByHandle() failed with status c0000008 (KERNEL32:mem/global.c:412) Memory Load: 17 (KERNEL32:mem/global.c:412) Memory Load: 17 (MSVCRT:io/open.c:103) not valid fd 0, g_fdend 5, fdinfo 7802d2f0, bucket 7802d2 f0, fdflags 0 (MSVCRT:io/open.c:700) _setmode: inval fd (0) (shellole.c:237:SHELL32_DllGetClassObject) failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (shellole.c:167:SHCoCreateInstance) LoadFromShell failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (shellole.c:237:SHELL32_DllGetClassObject) failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) (shellole.c:167:SHCoCreateInstance) LoadFromShell failed for CLSID= {645ff040-5081-101b-9f08-00aa002f954e} (unknown) E_ACCESSDENIED - WIN32 access denied error Context: ShellFolder::ShellFolder(IShellFolder*, LPCITEMIDLIST) Location: utility/shellclasses.cpp:280 Context Trace: - ShellFolder::ShellFolder(IShellFolder*, LPCITEMIDLIST) - ShellDirectory::read_directory() - Entry::read_directory_base() - Entry::smart_scan() - explorer_main - WinMain() - main mm/mm.c:337 Unhandled exception Address: 467ae6 C:\ReactOS\explorer.exe CS:EIP 1b:467ae6 DS 23 ES 23 FS 3b GS 23 EAX: 00000000 EBX: 00a88f58 ECX: 007fe234 EDX: 00a88f28 EBP: 007fe404 ESI: 007ff6ac ESP: 007fe3fc EDI: 007ff638 EFLAGS: 00010202 Frames: 400000+3aeae C:\ReactOS\explorer.exe 400000+7d49f C:\ReactOS\explorer.exe 400000+13aa5 C:\ReactOS\explorer.exe 400000+bed0 C:\ReactOS\explorer.exe 400000+c467 C:\ReactOS\explorer.exe 400000+295a9 C:\ReactOS\explorer.exe 400000+29262 C:\ReactOS\explorer.exe 400000+3e258 C:\ReactOS\explorer.exe 900000+12a8f C:\ReactOS\system32\user32.dll 900000+13a6e C:\ReactOS\system32\user32.dll 7c900000+9ea2 C:\ReactOS\system32\ntdll.dll (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (ntuser/class.c:114) Failed to lookup class atom! (KERNEL32:mem/global.c:412) Memory Load: 17 (KERNEL32:mem/global.c:412) Memory Load: 17 (cm/registry.c:885) Hive is still in use (hc 18, rc 10623) (cm/ntfunc.c:2370) CmiDisconnectHive() failed (Status c0000001) (profile.c:899) RegUnLoadKeyW() failed (Error 31) ex/power.c:90 Drive E is HD vfat32, D is HD ext2 ( no problem there ), I can select F and G w/o any problems (Zip Drives) Just logs out and blue screens when selecting E. James

19 years, 7 months

Re: [ros-svn] [frik85] 14355: Remove all hardcode english phrases from the source code and add the phrases to the resource file.

by James Tabor

frik85(a)svn.reactos.com wrote: > Remove all hardcode english phrases from the source code and add the phrases to the resource file. > > > Updated files: > trunk/reactos/subsys/system/taskmgr/De.rc > trunk/reactos/subsys/system/taskmgr/En.rc > trunk/reactos/subsys/system/taskmgr/affinity.c > trunk/reactos/subsys/system/taskmgr/applpage.c > trunk/reactos/subsys/system/taskmgr/column.c > trunk/reactos/subsys/system/taskmgr/debug.c > trunk/reactos/subsys/system/taskmgr/endproc.c > trunk/reactos/subsys/system/taskmgr/priority.c > trunk/reactos/subsys/system/taskmgr/resource.h > trunk/reactos/subsys/system/taskmgr/run.c > trunk/reactos/subsys/system/taskmgr/taskmgr.c > trunk/reactos/subsys/system/taskmgr/trayicon.c > Hi, The tabs list only ones and the process list is all zero's. The columns tags in the process list have no data at all. Everything else is okay. James

19 years, 7 months

Submit your changes fpr RC2

by Robert Köpferl

In ca. 16 h I will do SVN update again for the build 0.2.6 RC2 So think wether your patch should be submittet now or later. How about your feelings? Will RC2 be == final actually RC2

19 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev