Ros-dev

ros-dev@reactos.org

5789 discussions

by Robert Köpferl

In ca. 16 h I will do SVN update again for the build 0.2.6 RC2 So think wether your patch should be submittet now or later. How about your feelings? Will RC2 be == final actually RC2

20 years, 3 months

RE: [ros-diffs] [greatlrd] 14366: did foget the icon form mf

by Ge van Geldorp

Please don't do this. shell32 is a component shared with Wine. I'd very much prefer to get the new icons into Wine. If that's not possible at least follow the way Wine does things (i.e. ascii-encoding the .ico files in the .rc), as it will make the job of keeping ReactOS and Wine in sync easier. Thanks, Gé van Geldorp. -----Original Message----- From: ros-diffs-bounces(a)reactos.com [mailto:ros-diffs-bounces@reactos.com] On Behalf Of greatlrd(a)svn.reactos.com Sent: Monday, March 28, 2005 18:51 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [greatlrd] 14366: did foget the icon form mf did foget the icon form mf Added: trunk/reactos/lib/shell32/res/folder.ico Added: trunk/reactos/lib/shell32/res/folder_open.ico Added: trunk/reactos/lib/shell32/res/mycomputer.ico

20 years, 3 months

feature request for (xml) build

by Hartmut Birr

Hi, I would like it if I can build ros outside from the source tree. This makes it possible to build ros with different configurations from the same (highly modified) source tree. - Hartmut

20 years, 3 months

kernel32\comm.c improvements

by Saveliy Tretiakov

Hi. This is what I've changed: 1. Implement ClearCommError. I din't test it too much, but it should be ok. I've reveresed WinXP's ClearCommError to ensure that my implementation is correct :) 2. Correct badly implemented apis. For Example: ClearCommBreak(HANDLE hFile) { BOOL result = FALSE; DWORD dwBytesReturned; if (hFile == INVALID_HANDLE_VALUE) { return FALSE; } result = DeviceIoControl(hFile, IOCTL_SERIAL_SET_BREAK_OFF, NULL, 0, NULL, 0, &dwBytesReturned, NULL); return TRUE; } Check for INVALID_HANDLE_VALUE is not needed here. I removed all these checks from everywhere in comm.c. Function will return TRUE even if DeviceIoControl fails. This is wrong. Modified functions: ClearCommBreak, EscapeCommFunction, GetCommMask, GetCommModemStatus GetCommState, GetCommTimeouts, PurgeComm, SetCommBreak, SetCommMask, SetCommTimeouts, SetCommState, SetupComm, TransmitCommChar, WaitCommEvent

20 years, 3 months

serial port type detection (pt. 2)

by Mark Junker

Hi, in a documentation I saw that I probably had a bug in the patch for the serial port type detection. The attached patch should fix the problem. This comment in this patch also explains what is/was my problem with the value(s) specified in the documentation. Regards, Mark Index: drivers/dd/serial/legacy.c =================================================================== --- drivers/dd/serial/legacy.c (revision 14297) +++ drivers/dd/serial/legacy.c (working copy) @@ -62,7 +62,11 @@ { case 0x00: return Uart16450; + case 0x40: case 0x80: + /* Not sure about this but the documentation says that 0x40 + * indicates an unusable FIFO but my tests only worked + * with 0x80 */ return Uart16550; }

20 years, 3 months

KeRundownThread question

by Hartmut Birr

Hi, in KeRundownThread is an ASSERT statement. What is the reason for that? ApcDisable is never changed. It is always 1 for mutex objects and always 0 for mutant objects. If a mutant object is on the list, ros does crash. - Hartmut Index: ntoskrnl/ke/kthread.c =================================================================== --- ntoskrnl/ke/kthread.c (revision 14297) +++ ntoskrnl/ke/kthread.c (working copy) @@ -360,7 +360,7 @@ /* Get the Mutant */ Mutant = CONTAINING_RECORD(CurrentEntry, KMUTANT, MutantListEntry); - ASSERT(Mutant->ApcDisable); +// ASSERT(Mutant->ApcDisable);

20 years, 3 months

Re: [ros-dev] New proposed frontpage for reactos.com

by Steven Edwards

--- Jason Filby <jason.filby(a)gmail.com> wrote: > None of the links go anywhere yet. ezPublish will be phased out and > most of the content hosted in a wiki (editable only by people trusted > in the project). > > The wiki/forums/blogs would require a bit of a face-lift so as to look similar. > > Comments? I like it except I think the description of what ReactOS is needs to say something like "A effort to create a FreeSoftware replacement for Microsoft Windows(TM) that is compatbile with existing hardware and software". It does not violate trademark as we are describing what we do. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

20 years, 3 months

Re: [ros-svn] [hbirr] 14296: - Guarded the calls to IoSetCancelRoutine with IoAcquireCancelSpinLock/IoReleaseCancelSpinLock.

by Filip Navara

hbirr(a)svn.reactos.com wrote: >- Guarded the calls to IoSetCancelRoutine with IoAcquireCancelSpinLock/IoReleaseCancelSpinLock. >- Used a fastmutex as lock for the data queue. >- Used paged pool for the data buffers. >- Allowed the server to read (and to wait) on a listening pipe. >- Implemented the non blocking read operations. > >Updated files: >trunk/reactos/drivers/fs/np/create.c >trunk/reactos/drivers/fs/np/fsctrl.c >trunk/reactos/drivers/fs/np/npfs.c >trunk/reactos/drivers/fs/np/npfs.h >trunk/reactos/drivers/fs/np/rw.c > > This change seems to break RPC connection reads. I'm currently busy working on other things so I can't look at the problem. Any help is appreciated... (little test application attached, source available on request or in PSDK examples) - Filip

20 years, 3 months

Service Control Manager, Plug and Pray, SMB and RPC

by Steven Edwards

Hi, Am I correct in understanding we are going to need a real rpc implementation to correctly support Plug and Play as well as Services, DCOM and SMB related stuff? I know the Wine DCOM and Service Code does everything over named pipes on the local system but I assume we want to do things "properly". Should we look at doing a mingw build of FreeDCE or the DEC-RPC? I am happy to try and help import any code if it will help. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

20 years, 3 months

Re: [ros-dev] Re: [ros-svn] [gvg] 14302: Build freeldr as elf executable, initial Xen support

by Steven Edwards

--- Filip Navara <xnavara(a)volny.cz> wrote: > Just to let you know, there's no need to change the wide-character > string literals. You can use the -fshort-wchar GCC switch to get the > desired behaviour without touching the sources... I was under the impression short-wchar could differ depending on the platform and thats why wide-characters were a no-no in wine. Or is it that only newer gcc's support this option? Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

20 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev