Ros-dev

ros-dev@reactos.org

5790 discussions

Memory Manager Patch to allow mapping of device memory into UserMode - please review.
by Gregor Anich 03 Mar '05

03 Mar '05

Hi! I have changed the memory manager to allow mapping of sections from \Device\PhysicalMemory which are outside of RAM - this gets NVIDIA OpenGL working. I hope my changes are correct (according to Hartmuts suggestions in this mail: http://reactos.com:8080/archives/public/ros-kernel/2004-August/004444.html) I changed MmProbeAndLockPages to set MDL_IO_SPACE in the MdlFlags of the Mdl if one of the Pfns described in the MDL is outside of the RAM (>= MmPageArraySize) which is then used in MmMapLockedPagesSpecifyCache to decide wether to call MmCreateVirtualMapping or MmCreateVirtualMappingUnsafe (in order to prevent bugchecks in mm/freelist.c when Pfns are checked against MmPageArraySize) - blight Index: include/internal/mm.h =================================================================== --- include/internal/mm.h (revision 13428) +++ include/internal/mm.h (working copy) @@ -626,6 +626,7 @@ VOID MmSetLRULastPage(PFN_TYPE Page); VOID MmLockPage(PFN_TYPE Page); +VOID MmLockPageUnsafe(PFN_TYPE Page); VOID MmUnlockPage(PFN_TYPE Page); @@ -710,6 +711,7 @@ VOID MmDereferencePage(PFN_TYPE Page); VOID MmReferencePage(PFN_TYPE Page); +VOID MmReferencePageUnsafe(PFN_TYPE Page); BOOLEAN MmIsAccessedAndResetAccessPage(struct _EPROCESS* Process, PVOID Address); Index: mm/section.c =================================================================== --- mm/section.c (revision 13428) +++ mm/section.c (working copy) @@ -721,6 +721,9 @@ MmSharePageEntrySectionSegment(Segment, Offset); + /* FIXME: Should we call MmCreateVirtualMappingUnsafe if + * (Section->AllocationAttributes & SEC_PHYSICALMEMORY) is true? + */ Status = MmCreateVirtualMapping(MemoryArea->Process, Address, Attributes, @@ -823,14 +826,14 @@ * Just map the desired physical page */ Page = (Offset + MemoryArea->Data.SectionData.ViewOffset) >> PAGE_SHIFT; - Status = MmCreateVirtualMapping(AddressSpace->Process, - Address, - Region->Protect, - &Page, - 1); + Status = MmCreateVirtualMappingUnsafe(AddressSpace->Process, + Address, + Region->Protect, + &Page, + 1); if (!NT_SUCCESS(Status)) { - DPRINT("MmCreateVirtualMapping failed, not out of memory\n"); + DPRINT("MmCreateVirtualMappingUnsafe failed, not out of memory\n"); KEBUGCHECK(0); return(Status); } @@ -840,7 +843,7 @@ */ if (Locked) { - MmLockPage(Page); + MmLockPageUnsafe(Page); } /* Index: mm/mdl.c =================================================================== --- mm/mdl.c (revision 13428) +++ mm/mdl.c (working copy) @@ -29,7 +29,7 @@ /* MDL Flags desc. -MDL_PAGES_LOCKED MmProbelAndLockPages has been called for this mdl +MDL_PAGES_LOCKED MmProbeAndLockPages has been called for this mdl MDL_SOURCE_IS_NONPAGED_POOL mdl has been build by MmBuildMdlForNonPagedPool MDL_PARTIAL mdl has been built by IoBuildPartialMdl MDL_MAPPING_CAN_FAIL in case of an error, MmMapLockedPages will return NULL instead of to bugcheck @@ -300,7 +300,7 @@ { memcpy(Mdl + 1, Pages, sizeof(PFN_TYPE) * (PAGE_ROUND_UP(Mdl->ByteOffset+Mdl->ByteCount)/PAGE_SIZE)); - //FIXME: this flag should be set by the caller perhaps? + /* FIXME: this flag should be set by the caller perhaps? */ Mdl->MdlFlags |= MDL_IO_PAGE_READ; } @@ -374,8 +374,8 @@ ASSERT(NrPages <= (Mdl->Size - sizeof(MDL))/sizeof(PFN_TYPE)); - if (Mdl->StartVa >= (PVOID)KERNEL_BASE && - MmGetPfnForProcess(NULL, Mdl->StartVa) > MmPageArraySize) + if (Mdl->StartVa >= (PVOID)KERNEL_BASE && + MmGetPfnForProcess(NULL, Mdl->StartVa) >= MmPageArraySize) { /* phys addr is not phys memory so this must be io memory */ @@ -391,13 +391,13 @@ if (Mdl->StartVa >= (PVOID)KERNEL_BASE) { - //FIXME: why isn't AccessMode used? + /* FIXME: why isn't AccessMode used? */ Mode = KernelMode; Mdl->Process = NULL; } else { - //FIXME: why isn't AccessMode used? + /* FIXME: why isn't AccessMode used? */ Mode = UserMode; Mdl->Process = CurrentProcess; } @@ -455,7 +455,10 @@ } Page = MmGetPfnForProcess(NULL, Address); MdlPages[i] = Page; - MmReferencePage(Page); + if (Page >= MmPageArraySize) + Mdl->MdlFlags |= MDL_IO_SPACE; + else + MmReferencePage(Page); } MmUnlockAddressSpace(&CurrentProcess->AddressSpace); @@ -848,11 +851,18 @@ Protect |= PAGE_NOCACHE; else if (CacheType == MmWriteCombined) DPRINT("CacheType MmWriteCombined not supported!\n"); - Status = MmCreateVirtualMapping(CurrentProcess, - Base, - Protect, - MdlPages, - PageCount); + if (Mdl->MdlFlags & MDL_IO_SPACE) + Status = MmCreateVirtualMappingUnsafe(CurrentProcess, + Base, + Protect, + MdlPages, + PageCount); + else + Status = MmCreateVirtualMapping(CurrentProcess, + Base, + Protect, + MdlPages, + PageCount); if (!NT_SUCCESS(Status)) { DbgPrint("Unable to create virtual mapping\n"); Index: mm/freelist.c =================================================================== --- mm/freelist.c (revision 13428) +++ mm/freelist.c (working copy) @@ -612,15 +612,15 @@ } VOID -MmReferencePage(PFN_TYPE Pfn) +MmReferencePageUnsafe(PFN_TYPE Pfn) { KIRQL oldIrql; - DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); + DPRINT("MmReferencePageUnsafe(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); if (Pfn == 0 || Pfn >= MmPageArraySize) { - KEBUGCHECK(0); + return; } KeAcquireSpinLock(&PageListLock, &oldIrql); @@ -635,6 +635,19 @@ KeReleaseSpinLock(&PageListLock, oldIrql); } +VOID +MmReferencePage(PFN_TYPE Pfn) +{ + DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); + + if (Pfn == 0 || Pfn >= MmPageArraySize) + { + KEBUGCHECK(0); + } + + MmReferencePageUnsafe(Pfn); +} + ULONG MmGetReferenceCountPage(PFN_TYPE Pfn) { @@ -781,15 +794,15 @@ } VOID -MmLockPage(PFN_TYPE Pfn) +MmLockPageUnsafe(PFN_TYPE Pfn) { KIRQL oldIrql; - DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); + DPRINT("MmLockPageUnsafe(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); if (Pfn == 0 || Pfn >= MmPageArraySize) { - KEBUGCHECK(0); + return; } KeAcquireSpinLock(&PageListLock, &oldIrql); @@ -805,6 +818,19 @@ } VOID +MmLockPage(PFN_TYPE Pfn) +{ + DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); + + if (Pfn == 0 || Pfn >= MmPageArraySize) + { + KEBUGCHECK(0); + } + + MmLockPageUnsafe(Pfn); +} + +VOID MmUnlockPage(PFN_TYPE Pfn) { KIRQL oldIrql;

2 2

Re: Re: [ros-dev] added a proposed patch to bugzilla
by Roman Hoegg 02 Mar '05

02 Mar '05

1 0

Re: Re: [ros-dev] added a proposed patch to bugzilla
by Johannes Olofsson 02 Mar '05

02 Mar '05

Hi! The CAPS constant is defined to be KSHIFT, which if I understand this correct means that the shifted value is used when caps lock is used. Try to change the line : /* none, shift, ctrl-alt, ctrl, ctrl-shift */ { VK_OEM_7, NOCAPS, 0xe4, 0xe0, 0x7b, WCH_NONE, 0x00 }, /* ä à { */ to: { VK_OEM_7, KCTRL, 'code for ä', 'code for à', 0x7b, 'code for Ä', 'code for À }, /* ä à { */ in order to use the ctrl and ctrl-shift states for caps lock for this key. I don't have a test environment set up at the moment to test this, but it is possible that windows uses something like this. Regards Johannes Olofsson > Från: art yerkes <ayerkes(a)speakeasy.net> > Till: ReactOS Development List <ros-dev(a)reactos.com> > Rubrik: Re: [ros-dev] added a proposed patch to bugzilla > Datum: Tue, 1 Mar 2005 12:23:52 -0600 > <pre>On Thu, 24 Feb 2005 15:51:38 +0100 > Roman Hoegg <roman.hoegg(a)unisg.ch> wrote: > > > > > > > > as NOCAPS in your layout file > > > > yes that's true but I did that for a reason. I had two choices. Either > > can't set differentiate between SHIFT and CAPS LOCK. > > I wasn't aware that NOCAPS could be different from SHIFT, so NOCAPS always > implies shift in our current model. I'll try to fix it. > -- 10 Gigabyte Mailbox - http://mail.spray.se

1 0

Re:[ros-dev] RE: [ros-diffs] [ea] 13792: Fix SMSubsystemsRequired andSMSubsystemsOptional.
by ea＠iol.it 02 Mar '05

02 Mar '05

Date : Wed, 2 Mar 2005 12:46:30 +0100 Subject : [ros-dev] RE: [ros-diffs] [ea] 13792: Fix SM\Subsystems\Required andSM\Subsystems\Optional. Casper> Why is it needed to expand the unicode characters to hex? With value type 0x00070000 I get garbage from the SM when I pick up the Required names. If there is a way to make a REG_MULTI_SZ with a string, I'd be happy. ea ____________________________________________________________ Navighi a 2 MEGA e i primi 3 mesi sono GRATIS. Scegli Libero Adsl Flat senza limiti su http://www.libero.it

1 0

SysInternals Process Explorer
by James Tabor 02 Mar '05

02 Mar '05

Hi all! http://www.sysinternals.com/ntw2k/freeware/procexp.shtml Debug output from execution of procexp on ROS, (api/handle.c:71) CsrGetObject returning invalid handle (NTDLL:ldr/utils.c:2092) Relocating (76260000 -> 700000) C:\ReactOS\system32\ole aut32.dll (NTDLL:ldr/utils.c:2092) Relocating (77800000 -> 4e1000) C:\ReactOS\system32\win spool.drv 0 bytes requested - initiating pool verification 0 bytes requested - initiating pool verification FIXME: CopyImage doesn't support IMAGE_ICON correctly! 0 bytes requested - initiating pool verification 0 bytes requested - initiating pool verification (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find auxMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find midMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find modMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find widMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find wodMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find auxMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find mxdMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find midMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find widMessage (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find wodMessage (cm/ntfunc.c:379) NtDeleteKey(KeyHandle dc) called (cm/ntfunc.c:418) PointerCount 1 (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find AllocateAndGetTcpE xTableFromStack (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find AllocateAndGetUdpE xTableFromStack (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of '.dll' (Status c0000135) (NTDLL:ldr/utils.c:2092) Relocating (76160000 -> db1000) C:\ReactOS\system32\dbg help.dll (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find NtSuspendProcess (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find NtResumeProcess (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find EnumServicesStatus ExA (NTDLL:ldr/utils.c:1211) LdrGetExportByName(): failed to find QueryServiceConfig 2A (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'winsta.dll' (S tatus c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'uxtheme.dll' ( Status c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (fsctl.c:277) SysType (KERNEL32:mem/global.c:412) Memory Load: 4 *My little hack* (ex/sysinfo.c:827) NtQuerySystemInformation - SystemHandleInformation (ex/sysinfo.c:835) SystemHandleInformation 1 (ex/sysinfo.c:854) SystemHandleInformation 2 (ex/sysinfo.c:872) SystemHandleInformation 4 (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (NTDLL:ldr/utils.c:2034) Failed to create or open dll section of 'Powrprof.dll' (Status c0000135) (NTDLL:ldr/utils.c:1091) LdrGetExportByName(): no export directory! (ex/sysinfo.c:1046) NtQuerySystemInformation - SystemInterruptInformation not im plemented (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub *Here again* (ex/sysinfo.c:827) NtQuerySystemInformation - SystemHandleInformation (ex/sysinfo.c:835) SystemHandleInformation 1 (ex/sysinfo.c:854) SystemHandleInformation 2 (ex/sysinfo.c:872) SystemHandleInformation 4 (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (KERNEL32:misc/stubs.c:1457) GetLongPathNameA() is UNIMPLEMENTED! (sec/lsa.c:221) LsaOpenPolicy - stub (sec/lsa.c:32) (ffffffff):LsaClose stub KeBugCheckWithTf at ke/catch.c:177 Bug detected (code 1e param 0 0 0 0) KMODE_EXCEPTION_NOT_HANDLED Page Fault Exception: 14(0) Processor: 0 CS:EIP 8:8009f441 <ntoskrnl.exe: 9f441> cr2 4ea000 cr3 3b854000 Proc: 80c246b8 Pid: 130 <procexp.> Thrd: 80cc2af0 Tid: 1 34 DS 10 ES 10 FS 30 GS 23 EAX: 80c246b8 EBX: 0000009b ECX: 00001800 EDX: 00010000 EBP: 9e2d7cf8 ESI: 004ea000 ESP: 9e2d7c7c EDI: 005e8424 EFLAGS: 00010216 kESP 9e2d7c7c kernel stack base 9e2d5000 Frames: <ntoskrnl.exe: 72801> <ntoskrnl.exe: 399b> <7FFE0304>

4 5

Re: [ros-svn] [gdalsnes] 13791: tcharize a couple of routines
by Royce Mitchell III 02 Mar '05

02 Mar '05

shouldn't _tfopen() be a #define?

2 1

Re: [ros-dev] added a proposed patch to bugzilla
by Johannes Olofsson 01 Mar '05

01 Mar '05

Hi! What about the ö and ä keys? Should they behave the same way? (note that these keys and the ü key are marked as NOCAPS in your layout file). Regards Johannes Olofsson > Från: Roman Hoegg <roman.hoegg(a)unisg.ch> > Till: ros-dev(a)reactos.com > Rubrik: [ros-dev] added a proposed patch to bugzilla > Datum: Wed, 23 Feb 2005 22:58:02 +0100 Hello everybody! I've been a long time lurker and have decided to finaly contribute something to this wonderful project. quick introduction: 29, male, research assistent at the University of St. Gallen (Switzerland), some C/C++ knowledge (but not enough for serious contributions to an OS) I'm in the process of creating a keyboard layout (it's nearly finished) and have run into a problem which I posted in bugzilla. I was told on #reactos that this is the way to do it. http://reactos.com/bugzilla/show_bug.cgi?id=509 would be cool if someone with experience with keyboard layouts could give me a tip. thanks! Roman Hoegg (RomanH)_______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev Otur i kärlek - http://www.spray.se/spel Tur i kärlek - http://www.spraydate.com

3 2

RE: [ros-svn] [ion] 13776: Test commit. Not official branch release --it will follow shortly in 15 minutes. If this ends up in HEADi will revert immediately (i have svn switched so it shouldn't)
by Casper Hornstrup 28 Feb '05

28 Feb '05

There is no need to commit to check that. You can use "svn info". Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com > [mailto:ros-svn-bounces@reactos.com] On Behalf Of ion(a)svn.reactos.com > Sent: 28. februar 2005 17:45 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [ion] 13776: Test commit. Not official > branch release --it will follow shortly in 15 minutes. If > this ends up in HEADi will revert immediately (i have svn > switched so it shouldn't) > > Test commit. Not official branch release -- it will follow > shortly in 15 minutes. If this ends up in HEAD i will revert > immediately (i have svn switched so it shouldn't)

2 1

Uptime.exe
by James Tabor 28 Feb '05

28 Feb '05

Hi, I had this for a long time, Org unknown, Good luck, James

1 0

Explorer in XP and Wallpaper changing...
by Alex Ionescu 28 Feb '05

28 Feb '05

Hi everyone, Firstly, it seems our explorer doesn't load in WXP anymore. Looks like we are directly importing NtGdiBitBlt (undocumented function) instead of relying on BitBlt. I don't see any need to use undocumented native API in explorer... I've also heard that it's impossible to built it with msvc because of numerous (43) template errors. Bizzeh on IRC knows more about this. Secondly, I've tried out the new wallpaper changing, and it crashes on my build, inside win32k. I am running qemu + optimized build...can anyone else repro? I will try other BMPs to make sure mine isn't corrupted (which still means there' s a bug). Best regards, Alex Ionescu

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev