Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-diffs] [ekohl] 13825: Fix calls to ReadFile and WriteFile for asynchronous I/O.

by Hartmut Birr

Hi, you should send this mail to the Ros-Dev list because some people with a deal-up connection dosn't read the Ros-Diffs list. - Hartmut Gunnar Dalsnes schrieb: > Eric: Ping? > > Gunnar Dalsnes wrote: > >> From MSDN OVERLAPPED: "Functions such as WriteFile set the event to >> the nonsignaled state before they begin an I/O operation" >> >> So the ResetEvent additions are meaningless... Why did you add them? >> >> Gunnar >> >> ekohl(a)svn.reactos.com wrote: >> >>> Fix calls to ReadFile and WriteFile for asynchronous I/O. >>> >>> Modified: trunk/reactos/lib/rpcrt4/rpc_message.c >>> >>> ------------------------------------------------------------------------ >>> >>> *Modified: trunk/reactos/lib/rpcrt4/rpc_message.c* >>> >>> --- trunk/reactos/lib/rpcrt4/rpc_message.c 2005-03-05 11:27:15 >>> UTC (rev 13824) >>> +++ trunk/reactos/lib/rpcrt4/rpc_message.c 2005-03-05 11:38:48 >>> UTC (rev 13825) >>> @@ -265,10 +265,15 @@ >>> >>> } >>> >>> /* transmit packet header */ >>> >>> - if (!WriteFile(Connection->conn, Header, hdr_size, &count, >>> NULL)) { >>> >>> + ResetEvent(Connection->ovl.hEvent); >>> + if (!WriteFile(Connection->conn, Header, hdr_size, &count, >>> &Connection->ovl)) { >>> >>> WARN("WriteFile failed with error %ld\n", GetLastError()); >>> return GetLastError(); >>> } >>> >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &count, TRUE)) { >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> + return GetLastError(); >>> + } >>> >>> >>> /* fragment consisted of header only and is the last one */ >>> if (hdr_size == Header->common.frag_len && >>> @@ -277,10 +282,15 @@ >>> >>> } >>> >>> /* send the fragment data */ >>> >>> - if (!WriteFile(Connection->conn, buffer_pos, >>> Header->common.frag_len - hdr_size, &count, NULL)) { >>> >>> + ResetEvent(Connection->ovl.hEvent); >>> + if (!WriteFile(Connection->conn, buffer_pos, >>> Header->common.frag_len - hdr_size, &count, &Connection->ovl)) { >>> >>> WARN("WriteFile failed with error %ld\n", GetLastError()); >>> return GetLastError(); >>> } >>> >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &count, TRUE)) { >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> + return GetLastError(); >>> + } >>> >>> >>> Header->common.flags &= ~RPC_FLG_FIRST; >>> } >>> @@ -309,9 +319,15 @@ >>> >>> TRACE("(%p, %p, %p)\n", Connection, Header, pMsg); >>> >>> /* read packet common header */ >>> >>> - if (!ReadFile(Connection->conn, &common_hdr, sizeof(common_hdr), >>> &dwRead, NULL)) { >>> >>> + ResetEvent(Connection->ovl.hEvent); >>> + if (!ReadFile(Connection->conn, &common_hdr, sizeof(common_hdr), >>> &dwRead, &Connection->ovl)) { >>> + WARN("ReadFile failed with error %ld\n", GetLastError()); >>> + status = RPC_S_PROTOCOL_ERROR; >>> + goto fail; >>> + } >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &dwRead, TRUE)) { >>> >>> if (GetLastError() != ERROR_MORE_DATA) { >>> >>> - WARN("ReadFile failed with error %ld\n", GetLastError()); >>> >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> >>> status = RPC_S_PROTOCOL_ERROR; >>> goto fail; >>> } >>> @@ -339,10 +355,16 @@ >>> >>> memcpy(*Header, &common_hdr, sizeof(common_hdr)); >>> >>> /* read the rest of packet header */ >>> >>> + ResetEvent(Connection->ovl.hEvent); >>> >>> if (!ReadFile(Connection->conn, &(*Header)->common + 1, >>> >>> - hdr_length - sizeof(common_hdr), &dwRead, NULL)) { >>> >>> + hdr_length - sizeof(common_hdr), &dwRead, >>> &Connection->ovl)) { >>> + WARN("ReadFile failed with error %ld\n", GetLastError()); >>> + status = RPC_S_PROTOCOL_ERROR; >>> + goto fail; >>> + } >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &dwRead, TRUE)) { >>> >>> if (GetLastError() != ERROR_MORE_DATA) { >>> >>> - WARN("ReadFile failed with error %ld\n", GetLastError()); >>> >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> >>> status = RPC_S_PROTOCOL_ERROR; >>> goto fail; >>> } >>> @@ -352,6 +374,7 @@ >>> >>> goto fail; >>> } >>> >>> >>> + >>> >>> /* read packet body */ >>> switch (common_hdr.ptype) { >>> case PKT_RESPONSE: >>> @@ -379,13 +402,20 @@ >>> >>> goto fail; >>> } >>> >>> >>> - if (data_length == 0) dwRead = 0; else >>> - if (!ReadFile(Connection->conn, buffer_ptr, data_length, >>> &dwRead, NULL)) { >>> - if (GetLastError() != ERROR_MORE_DATA) { >>> >>> + if (data_length == 0) dwRead = 0; else { >>> + ResetEvent(Connection->ovl.hEvent); >>> + if (!ReadFile(Connection->conn, buffer_ptr, data_length, >>> &dwRead, &Connection->ovl)) { >>> >>> WARN("ReadFile failed with error %ld\n", GetLastError()); >>> status = RPC_S_PROTOCOL_ERROR; >>> goto fail; >>> } >>> >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &dwRead, TRUE)) { >>> + if (GetLastError() != ERROR_MORE_DATA) { >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> + status = RPC_S_PROTOCOL_ERROR; >>> + goto fail; >>> + } >>> + } >>> >>> } >>> if (dwRead != data_length) { >>> status = RPC_S_PROTOCOL_ERROR; >>> @@ -403,10 +433,16 @@ >>> >>> TRACE("next header\n"); >>> >>> /* read the header of next packet */ >>> >>> - if (!ReadFile(Connection->conn, *Header, hdr_length, &dwRead, >>> NULL)) { >>> >>> + ResetEvent(Connection->ovl.hEvent); >>> + if (!ReadFile(Connection->conn, *Header, hdr_length, &dwRead, >>> &Connection->ovl)) { >>> + WARN("ReadFile failed with error %ld\n", GetLastError()); >>> + status = GetLastError(); >>> + goto fail; >>> + } >>> + if (!GetOverlappedResult(Connection->conn, &Connection->ovl, >>> &dwRead, TRUE)) { >>> >>> if (GetLastError() != ERROR_MORE_DATA) { >>> >>> - WARN("ReadFile failed with error %ld\n", GetLastError()); >>> - status = GetLastError(); >>> >>> + WARN("GetOverlappedResult failed with error %ld\n", >>> GetLastError()); >>> + status = RPC_S_PROTOCOL_ERROR; >>> >>> goto fail; >>> } >>> } >>> >>> >>> ------------------------------------------------------------------------ >>> >>>

20 years, 3 months

Re: [ros-svn] [ion] 13847: Merge with 13846. Fixes QEMU+KDBG problem.

by James Tabor

Hi! ion(a)svn.reactos.com wrote: > Merge with 13846. Fixes QEMU+KDBG problem. > > > Added files: > branches/alex_devel_branch/reactos/media/drivers/etc/KDBinit > > Updated files: > branches/alex_devel_branch/reactos/Makefile > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb.h > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_cli.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_keyboard.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_serial.c > > Deleted files: > branches/alex_devel_branch/reactos/media/drivers/etc/KDB.init > I think is is caused by blight patch. Gcc 3.4.2 bin utils 2.15.94. ntoskrnl: [CC] dbg/kdb_cli.c dbg/kdb_cli.c: In function `KdbpPrint': dbg/kdb_cli.c:1721: warning: implicit declaration of function `isalpha' make[1]: *** [dbg/kdb_cli.o] Error 1 make: *** [ntoskrnl] Error 2 Thanks, James

20 years, 3 months

Build ros on ros is broken

by Hartmut Birr

Hi, since my last svn update, I'm not able to compile ros on ros. It seems that something is wrong with the pipes. - Hartmut f:\Sandbox\Ros\ReactOS>_make ReactOS Build Number Generator Current date : 2005-03-06 ROS Version : 0.3-CVS (build 20050306) ar: creating zlib.host.a ntoskrnl: [DLLTOOL] libntoskrnl.a hal: [CC] hal.c gcc: pipe: Invalid argument (EINVAL) _make[1]: *** [hal.o] Error 1 _make: *** [hallib] Error 2

20 years, 3 months

Re: Re: Re: [ros-dev] added a proposed patch to bugzilla

by Roman Hoegg

20 years, 3 months

Re: [ros-svn] [blight] 13841: Little KDB update ; -) If you have any problems and/or questions let me know. I hope it was tested enough and works well enough for everybody.

by Hartmut Birr

Hi, compiling fails if KDBG = 0 and DBG = 1. objects/ke.o: In function `InitializeListHead': M:/Sandbox/ros_work/reactos/ntoskrnl/../include/ntos/rtl.h:96: undefined reference to `KdbInit' objects/ps.o: In function `PsUnlockProcess': M:/Sandbox/ros_work/reactos/ntoskrnl/ps/process.c:2973: undefined reference to `KdbDeleteProcessHook' collect2: ld returned 1 exit status _make[1]: *** [ntoskrnl.nostrip.exe] Error 1 _make: *** [ntoskrnl] Error 2 - Hartmut blight(a)svn.reactos.com schrieb: >Little KDB update ;-) If you have any problems and/or questions let me know. I hope it was tested enough and works well enough for everybody. > > >Added files: >trunk/reactos/media/drivers/etc/KDB.init >trunk/reactos/ntoskrnl/dbg/i386/longjmp.S >trunk/reactos/ntoskrnl/dbg/i386/setjmp.S >trunk/reactos/ntoskrnl/dbg/kdb_cli.c >trunk/reactos/ntoskrnl/dbg/kdb_expr.c >trunk/reactos/ntoskrnl/dbg/kdb_string.c > >Updated files: >trunk/reactos/Makefile >trunk/reactos/drivers/input/keyboard/keyboard.c >trunk/reactos/ntoskrnl/Makefile >trunk/reactos/ntoskrnl/dbg/i386/i386-dis.c >trunk/reactos/ntoskrnl/dbg/i386/kdb_help.S >trunk/reactos/ntoskrnl/dbg/kdb.c >trunk/reactos/ntoskrnl/dbg/kdb.h >trunk/reactos/ntoskrnl/dbg/kdb_keyboard.c >trunk/reactos/ntoskrnl/dbg/kdb_serial.c >trunk/reactos/ntoskrnl/dbg/kdb_symbols.c >trunk/reactos/ntoskrnl/include/internal/i386/ke.h >trunk/reactos/ntoskrnl/include/internal/kd.h >trunk/reactos/ntoskrnl/ke/catch.c >trunk/reactos/ntoskrnl/ke/i386/trap.s >trunk/reactos/ntoskrnl/ke/i386/tskswitch.S >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/main.c >trunk/reactos/ntoskrnl/ps/w32call.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > >

20 years, 3 months

ATTN CASPER: case-conflicts in svn

by Royce Mitchell III

Casper: could we please have this hook installed in the svn server?: http://svn.collab.net/viewcvs/svn/trunk/contrib/hook-scripts/check-case-ins…

20 years, 3 months

Boot Failure after Merging...

by Alex Ionescu

I'm getting this after merging... Filip/Eric, this seems to be related to your changes...any clue? Assertion Irp->CancelRoutine == NULL failed at io/irp.c:310 Best regards, Alex Ionescu

20 years, 3 months

Re: [ros-svn] [ion] 13842: Merge with blight's rewrite

by James Tabor

Hi Alex! Good job! I let the testing go on through the night (23 hours) and started testing your last commit, it's running great! ion(a)svn.reactos.com wrote: > Merge with blight's rewrite > > > Added files: > branches/alex_devel_branch/reactos/media/drivers/etc/KDB.init > branches/alex_devel_branch/reactos/ntoskrnl/dbg/i386/longjmp.S > branches/alex_devel_branch/reactos/ntoskrnl/dbg/i386/setjmp.S > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_cli.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_expr.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_string.c > > Updated files: > branches/alex_devel_branch/reactos/Makefile > branches/alex_devel_branch/reactos/drivers/input/keyboard/keyboard.c > branches/alex_devel_branch/reactos/ntoskrnl/Makefile > branches/alex_devel_branch/reactos/ntoskrnl/dbg/i386/i386-dis.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/i386/kdb_help.S > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb.h > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_keyboard.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_serial.c > branches/alex_devel_branch/reactos/ntoskrnl/dbg/kdb_symbols.c > branches/alex_devel_branch/reactos/ntoskrnl/include/internal/i386/ke.h > branches/alex_devel_branch/reactos/ntoskrnl/include/internal/kd.h > branches/alex_devel_branch/reactos/ntoskrnl/io/iomgr.c > branches/alex_devel_branch/reactos/ntoskrnl/ke/catch.c > branches/alex_devel_branch/reactos/ntoskrnl/ke/i386/trap.s > branches/alex_devel_branch/reactos/ntoskrnl/ke/i386/tskswitch.S > branches/alex_devel_branch/reactos/ntoskrnl/ke/kthread.c > branches/alex_devel_branch/reactos/ntoskrnl/ke/main.c > branches/alex_devel_branch/reactos/ntoskrnl/ps/w32call.c > BTW, I'm getting this; ntoskrnl: [CC] ke/kthread.c ke/kthread.c: In function `KeInitializeThread': ke/kthread.c:254: error: too many arguments to function `RtlZeroMemory' ke/kthread.c:266: error: too many arguments to function `RtlZeroMemory' ke/kthread.c:267: error: too many arguments to function `RtlZeroMemory' make[1]: *** [ke/kthread.o] Error 1 make: *** [ntoskrnl] Error 2 Thanks, James

20 years, 3 months

Are there any plans for apache + svn?

by Waldo Alvarez Cañizares

Hi guys: I was reading about subversion an in fact installed one svn server because I think that I could benefict from using a versioning system even doing non collaborative programming. Now the part that is related with ReactOS is that svn can be used locally, lite svnserve and (apache + svn modules) concurrently. I beleive you are using only or mostly: svn://svn.reactos.com/ Are there any chances for us the firewalled to get an apache 2.x listening on port 80? I know you are using apache 1.3.x in www.reactos.com but the configuration should be very similar. I never mentioned anything like this when CVS because it was probably too wuch work for those administrating CVS but hey SVN is modern so it comes ready for it with little effort. So it won´t affect those using the subversion protocol directly. I always had intention to collaborate but never got the chance. I could never do proper checkouts from CVS using tunnels but this way will be direct so probably this could be my chance to get in and maybe get write acces after learning more about svn using it locally on my machine. Thanks in advance Regards Waldo Alvarez

20 years, 3 months

RE: [ros-svn] [mf] 13830: add ibrowser to XML build

by Casper Hornstrup

There is no need to update this branch since I'll merge changes from trunk once in a while. Also, always be sure to use svn merge to merge changes from trunk to the branches so subversion knows where the changes comes from. If done, then we are less likely to get conflicts in a future merge. Casper > -----Original Message----- > From: ros-svn-bounces(a)reactos.com > [mailto:ros-svn-bounces@reactos.com] On Behalf Of mf(a)svn.reactos.com > Sent: 5. marts 2005 18:52 > To: ros-svn(a)reactos.com > Subject: [ros-svn] [mf] 13830: add ibrowser to XML build > > add ibrowser to XML build > > > > Added files: > branches/xmlbuildsystem/reactos/subsys/system/ibrowser/ibrowser.xml > > Updated files: > branches/xmlbuildsystem/reactos/bootdata/packages/reactos.dff > branches/xmlbuildsystem/reactos/subsys/system/directory.xml > branches/xmlbuildsystem/reactos/subsys/system/ibrowser/Makefile > > _______________________________________________ > Ros-svn mailing list > Ros-svn(a)reactos.com > http://reactos.com:8080/mailman/listinfo/ros-svn

20 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev