Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount

by Jérôme Gardou

Hey Pierre! This flag > + if (DeviceExt->VolumeFcb->Flags & VCB_CLEAR_DIRTY) > + { > + /* Set clean shutdown bit */ > + Status = GetNextCluster(DeviceExt, 1, &eocMark); > + if (NT_SUCCESS(Status)) > + { > + eocMark |= DeviceExt->CleanShutBitMask; > + if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark))) and that one > + DeviceExt->VolumeFcb->Flags &= ~VCB_IS_DIRTY; > + } > + } > + > /* Flush volume & files */ > VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext); > > > don't really seem to match. Or is the former a part of a OR combination defining the latter ? Cheers. Jérôme.

10 years, 5 months

Selling ReactOS CDs

by Hermès BÉLUSCA - MAÏTO

Hi all ! In the forums some spokesperson of an Indian company offering services related to FOSS wants to add us to their online shop, see http://www.reactos.org/forum/viewtopic.php?f=13 <http://www.reactos.org/forum/viewtopic.php?f=13&t=13780> &t=13780 for more information. What do you think about this? How should we react? Should we make clearer our line of conduct about such kind of things? Cheers, Hermès.

10 years, 5 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 65462: [NTFS] - In NtfsQueryDirectory(), don't upcase name in dir search pattern, it can conflict with POSIX names. - In CompareFileName(), handle the fact that for Win32 & DOS we do ...

by Thomas Faber

On 2014-11-23 10:49, pschweitzer(a)svn.reactos.org wrote: > + ASSERT(NT_SUCCESS(RtlUpcaseUnicodeString(&IntFileName, FileName, TRUE))); You need NT_VERIFY here or this will break debug builds.

10 years, 5 months

Re: [ros-dev] [ros-diffs] [akhaldi] 65249: [SHELL32] * bool => BOOL.

by Timo Kreuzer

There is a difference between a C++ bool and a win32 BOOL. bool is 8 bit and aware of things like (bool Foo = FlagsValue & 0x80000000); BOOLEAN BooleanFlag = Foo;" with BOOL this would fail. I don't really know whether a BOOL is really the right thing to use here. Am 04.11.2014 21:00, schrieb akhaldi(a)svn.reactos.org: > Author: akhaldi > Date: Tue Nov 4 20:00:09 2014 > New Revision: 65249 > > URL: http://svn.reactos.org/svn/reactos?rev=65249&view=rev > Log: > [SHELL32] > * bool => BOOL. > > Modified: > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > branches/shell-experiments/dll/win32/shell32/shellfolder.h > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1189,7 +1189,7 @@ > return ret; > } > > -HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy) > +HRESULT WINAPI CDesktopFolder::CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CDesktopFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -88,7 +88,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLDESKTOP) > DECLARE_NOT_AGGREGATABLE(CDesktopFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -1030,7 +1030,7 @@ > * copies items to this folder > */ > HRESULT WINAPI CFSFolder::CopyItems(IShellFolder * pSFFrom, UINT cidl, > - LPCITEMIDLIST * apidl, bool bCopy) > + LPCITEMIDLIST * apidl, BOOL bCopy) > { > CComPtr<IPersistFolder2> ppf2 = NULL; > WCHAR szSrcPath[MAX_PATH]; > > Modified: branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/folders/CFSFolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -102,7 +102,7 @@ > virtual HRESULT WINAPI GetUniqueName(LPWSTR pwszName, UINT uLen); > virtual HRESULT WINAPI AddFolder(HWND hwnd, LPCWSTR pwszName, LPITEMIDLIST *ppidlOut); > virtual HRESULT WINAPI DeleteItems(UINT cidl, LPCITEMIDLIST *apidl); > - virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, bool bCopy); > + virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); > > DECLARE_REGISTRY_RESOURCEID(IDR_SHELLFSFOLDER) > DECLARE_NOT_AGGREGATABLE(CFSFolder) > > Modified: branches/shell-experiments/dll/win32/shell32/shellfolder.h > URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… > ============================================================================== > --- branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] (original) > +++ branches/shell-experiments/dll/win32/shell32/shellfolder.h [iso-8859-1] Tue Nov 4 20:00:09 2014 > @@ -42,7 +42,7 @@ > STDMETHOD(GetUniqueName)(THIS_ LPWSTR lpName, UINT uLen) PURE; > STDMETHOD(AddFolder)(THIS_ HWND hwnd, LPCWSTR lpName, LPITEMIDLIST * ppidlOut) PURE; > STDMETHOD(DeleteItems)(THIS_ UINT cidl, LPCITEMIDLIST * apidl) PURE; > - STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, bool bCopy) PURE; > + STDMETHOD(CopyItems)(THIS_ IShellFolder * pSFFrom, UINT cidl, LPCITEMIDLIST * apidl, BOOL bCopy) PURE; > }; > #undef INTERFACE > > > >

10 years, 5 months

Re: [ros-dev] Replacing unsafe TRUE comparisons (Following Re: bool => BOOL)

by Daniel Reimer

Heheh, who could it be... ^^ It was always a event to watch you two arguing. ^^ Am 23.11.2014 21:57 schrieb Alex Ionescu <ionucu(a)videotron.ca>: > > I'm just going to chime in here and confirm that Timo does indeed own a master's diploma on surviving pissing contests, taught by the greatest master there ever was. > > Best regards, > Alex Ionescu > > On Sat, Nov 22, 2014 at 11:47 AM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote: >> >> Am 22.11.2014 11:39, schrieb Love Nystrom: >>> >>> >>> On 2014-11-21 04.00, Timo Kreuzer wrote: >>>> >>>> Am 20.11.2014 14:18, schrieb Love Nystrom: >>>>> >>>>> >>>>> Well... Actually not exactly the same.. ;) >>>>> "if (f != FALSE)" requires an explicit comparison with a second operand, >>>> >>>> No, it does not. It requries the compiler to generate code that executes the following statement, when f is not 0. >>> >>> >>> I suspect we look at it from two different viewpoints here.. >>> Yours is "C centric" and mine is "object code centric". >>> You talk about what the compiler is required to do, >>> and I talk about what comes out at the end of compilation. >> >> And what comes out at the end of the compilation is what the compiler creates. And the compiler is following the rules of the C standard and the rules of logic. >> You claimed '"if (f != FALSE)" requires an explicit comparison with a second operand,' and that is factually wrong. No matter whether you are looking at it from the compiler perspective or from the perspective of an expressionist painter living in a yellow tree house on the bottom of Lake Tanganyika. >> >>> >>> And.. dear friend.. don't turn this into a pissing contest. >> >> Don't even get me started. I battled the grand master and I survived. >> >> >>> Let's check the egos in with the coat check girl at the entrance. >>> May I ask how old you are? >> >> Are we talking about age or maturity? >> >> We better end this discussion, it's not leading anywhere. And you don't want me to turn into the Grinch and steal your Christmas. >> >> Thanks, >> Timo >> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> >

10 years, 5 months

Re: [ros-dev] [ros-diffs] [aandrejevic] 65441: [FAST486] Attempt to write the value to the stack before subtracting from the actual ESP register in Fast486StackPush.

by Timo Kreuzer

Are you sure this is the correct order of execution? The instruction is documented as first lowering the stack pointer, then writing to the new location. If a stack exception occurs, you might have esp off by 4. Am 21.11.2014 10:46, schrieb aandrejevic(a)svn.reactos.org: > Author: aandrejevic > Date: Fri Nov 21 09:46:57 2014 > New Revision: 65441 > > URL: http://svn.reactos.org/svn/reactos?rev=65441&view=rev > Log: > [FAST486] > Attempt to write the value to the stack before subtracting from the actual ESP register > in Fast486StackPush. > > > Modified: > trunk/reactos/lib/fast486/common.inl > > Modified: trunk/reactos/lib/fast486/common.inl > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.inl?rev… > ============================================================================== > --- trunk/reactos/lib/fast486/common.inl [iso-8859-1] (original) > +++ trunk/reactos/lib/fast486/common.inl [iso-8859-1] Fri Nov 21 09:46:57 2014 > @@ -317,15 +317,19 @@ > return FALSE; > } > > + /* Store the value in SS:[ESP - 4] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + State->GeneralRegs[FAST486_REG_ESP].Long - sizeof(ULONG), > + &Value, > + sizeof(ULONG))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract ESP by 4 */ > State->GeneralRegs[FAST486_REG_ESP].Long -= sizeof(ULONG); > - > - /* Store the value in SS:ESP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].Long, > - &Value, > - sizeof(ULONG)); > } > else > { > @@ -339,16 +343,22 @@ > return FALSE; > } > > + /* Store the value in SS:[SP - 2] */ > + if (!Fast486WriteMemory(State, > + FAST486_REG_SS, > + LOWORD(State->GeneralRegs[FAST486_REG_ESP].LowWord - sizeof(USHORT)), > + &ShortValue, > + sizeof(USHORT))) > + { > + /* Exception occurred */ > + return FALSE; > + } > + > /* Subtract SP by 2 */ > State->GeneralRegs[FAST486_REG_ESP].LowWord -= sizeof(USHORT); > - > - /* Store the value in SS:SP */ > - return Fast486WriteMemory(State, > - FAST486_REG_SS, > - State->GeneralRegs[FAST486_REG_ESP].LowWord, > - &ShortValue, > - sizeof(USHORT)); > - } > + } > + > + return TRUE; > } > > FORCEINLINE > > >

10 years, 5 months

Rant

by Giannis Adamopoulos

I don't know how many times I need to send the same link here but let's say that this is the last time: this is a post about wpf but in the middle there is a paragraph about how win32k in windows processes mouse messages: http://blogs.msdn.com/b/dwayneneed/archive/2008/09/08/transparent-windows-i… And here is the important part: Which HWND is the mouse over? The operating system must respond very quickly to mouse movement. Windows uses a dedicated Raw Input Thread (RIT), running in the kernel, to handle the signals from the mouse hardware. The RIT quickly scans over the HWND hierarchy to see which window the mouse is over. Because the system must be responsive, no application code is invoked. For normal windows, the RIT checks the mouse position against the window's rectangle (or region, if one is set). But for layered windows, the RIT looks in the bitmap that specifies the content for the window and checks the effective transparency at that location (which can be affected by the constant opacity setting, the color key setting, or the per-pixel alpha channel). If the pixel is 100% transparent, the RIT skips the window and keeps looking. Once a window has been located, the mouse move flag is set on the thread that owns the window. This will cause the thread to receive a WM_MOUSEMOVE message the next time it calls GetMessage() and there are no other higher-priority messages. Now let me explain why a flag is needed. The window manager needs to coalesce mouse move messages. If the mouse moves over a window and the system registers 10 positions over it, if the window doesn't process messages fast enough the unprocessed positions are dropped and only the last is kept. Even if another message gets between these mouse move messages get lost. That's why the last mouse position is not stored in a message queue but in a field in the thread info. That's how the window manager worked the last 20 years in windows. I'm sick and tired to see readable and correct code to be rewritten by shitty code, that is not readable and has obvious bugs without any reason why the previous implementation was wrong. I just give up. Do whatever you like with this shitty project of yours. I don't care anymore.

10 years, 5 months

Re: [ros-dev] [ros-diffs] [dquintana] 65415: [SHELL32] * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems th...

by Thomas Faber

On 2014-11-15 13:34, dquintana(a)svn.reactos.org wrote: > [SHELL32] > * Commit the folder location fixes. They are mostly untested due to being unable to boot to desktop, but looking at the contents of the HDD after syssetup runs seems that the shortcuts are all created in their rightful place. If anyone is able to boot, feel free to test. > > Modified: > branches/shell-experiments/dll/win32/shell32/wine/shellpath.c So which is it; to Wine or not to Wine? If we need to fork this then let's put it in another file? Or at least #ifdef __REACTOS__?

10 years, 5 months

Re: [ros-dev] EPIC: ReactOS@Samsung Galaxy S III mini

by Love Nystrom

On 2014-09-29 19.00, ros-dev-request(a)reactos.org wrote: > w0000t > natively? via an emulator??? > what the.... > \o/ @ Javier I just stumbled by and saw it.. Выглядит безумно, но я установил и запустил ReactOS через обертку Qemu - Limbo ARM 7 на своем Samsung Galaxy S III mini. It looks crazy, but I installed and started the ReactOS through wrapper Qemu - Limbo ARM 7 on your Samsung Galaxy S III mini. // It might be interesting to try wedging an ARM build into the S3 though. I was mulling over the possibility to squeeze it into an Maple Native.. Love

10 years, 5 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 65390: [WIN32SS] if (BooleanValue == TRUE) -> if (!BooleanValue) Patch by Love Nystrom CORE-8799

by Timo Kreuzer

obviously it was meant to be "if (BooleanValue == TRUE) -> if (BooleanValue)" Am 13.11.2014 11:31, schrieb tkreuzer(a)svn.reactos.org: > Author: tkreuzer > Date: Thu Nov 13 10:31:45 2014 > New Revision: 65390 > > URL: http://svn.reactos.org/svn/reactos?rev=65390&view=rev > Log: > [WIN32SS] > if (BooleanValue == TRUE) -> if (!BooleanValue) > Patch by Love Nystrom > CORE-8799 > > Modified: > trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > trunk/reactos/win32ss/gdi/dib/floodfill.c > trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > trunk/reactos/win32ss/user/ntuser/hotkey.c > trunk/reactos/win32ss/user/ntuser/message.c > trunk/reactos/win32ss/user/ntuser/msgqueue.c > trunk/reactos/win32ss/user/user32/controls/appswitch.c > trunk/reactos/win32ss/user/user32/misc/desktop.c > trunk/reactos/win32ss/user/user32/misc/winsta.c > trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > trunk/reactos/win32ss/user/winsrv/usersrv/register.c > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebuf/pointer.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -110,7 +110,7 @@ > VOID FASTCALL > IntShowMousePointer(PPDEV ppdev, SURFOBJ *DestSurface) > { > - if (ppdev->PointerAttributes.Enable == TRUE) > + if (ppdev->PointerAttributes.Enable) > { > return; > } > > Modified: trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/framebufacc/ddenable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -38,7 +38,7 @@ > { > PPDEV ppdev = (PPDEV)dhpdev; > > - if (ppdev->bDDInitialized == TRUE) > + if (ppdev->bDDInitialized) > { > return TRUE; > } > @@ -237,7 +237,7 @@ > { > ppdev->pvmList = pvmList; > > - if ( bDDrawHeap == TRUE) > + if (bDDrawHeap) > { > pvmList->dwFlags = VIDMEM_ISLINEAR ; > pvmList->fpStart = ppdev->ScreenHeight * ppdev->ScreenDelta; > > Modified: trunk/reactos/win32ss/drivers/displays/vga/main/enable.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/main/enable.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -302,7 +302,7 @@ > PPDEV ppdev = (PPDEV)DPev; > ULONG returnedDataLength; > > - if(Enable==TRUE) > + if (Enable) > { > /* Reenable our graphics mode */ > if (!InitPointer(ppdev)) > > Modified: trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/v… > ============================================================================== > --- trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/drivers/displays/vga/vgavideo/vgavideo.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -560,7 +560,7 @@ > pb++; > } > > - if (edgePixel == TRUE) > + if (edgePixel) > { > b1 = *pb; > if(b1 != trans) vgaPutPixel(x2, j, b1); > > Modified: trunk/reactos/win32ss/gdi/dib/floodfill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/floodfill.… > ============================================================================== > --- trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/dib/floodfill.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -61,7 +61,7 @@ > { > if (RECTL_bPointInRect(DstRect,x,y)) > { > - if (isSurf == TRUE && > + if (isSurf && > DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color) > { > return; > > Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdi… > ============================================================================== > --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1837,7 +1837,7 @@ > { > /* Free it */ > Return = NtGdiDdDeleteDirectDrawObject((HANDLE)pDirectDrawGlobal->hDD); > - if (Return == TRUE) > + if (Return) > { > pDirectDrawGlobal->hDD = 0; > } > @@ -1852,7 +1852,7 @@ > { > /* Delete the object */ > Return = NtGdiDdDeleteDirectDrawObject(ghDirectDraw); > - if (Return == TRUE) > + if (Return) > { > ghDirectDraw = 0; > } > > Modified: trunk/reactos/win32ss/user/ntuser/hotkey.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/hotkey… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/hotkey.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -212,7 +212,7 @@ > if (!bIsDown) > { > /* WIN and F12 keys are not hardcoded here. See comments on top of this file. */ > - if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive == TRUE) > + if (pHotKey->id == IDHK_WINKEY && bWinHotkeyActive) > { > pWnd = ValidateHwndNoErr(InputWindowStation->ShellWindow); > if (pWnd) > > Modified: trunk/reactos/win32ss/user/ntuser/message.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/messag… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -2087,7 +2087,7 @@ > > UserLeave(); > > - if (Ret == TRUE) > + if (Ret) > { > _SEH2_TRY > { > > Modified: trunk/reactos/win32ss/user/ntuser/msgqueue.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/msgque… > ============================================================================== > --- trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -805,7 +805,7 @@ > *Message->Result = Result; > } > > - if (Message->HasPackedLParam == TRUE) > + if (Message->HasPackedLParam) > { > if (Message->Msg.lParam) > ExFreePool((PVOID)Message->Msg.lParam); > @@ -887,7 +887,7 @@ > KeSetEvent(SentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (SentMessage->HasPackedLParam == TRUE) > + if (SentMessage->HasPackedLParam) > { > if (SentMessage->Msg.lParam) > ExFreePool((PVOID)SentMessage->Msg.lParam); > @@ -1966,7 +1966,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > @@ -1998,7 +1998,7 @@ > KeSetEvent(CurrentSentMessage->CompletionEvent, IO_NO_INCREMENT, FALSE); > } > > - if (CurrentSentMessage->HasPackedLParam == TRUE) > + if (CurrentSentMessage->HasPackedLParam) > { > if (CurrentSentMessage->Msg.lParam) > ExFreePool((PVOID)CurrentSentMessage->Msg.lParam); > > Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/contro… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -522,7 +522,7 @@ > return TRUE; > > case WM_SHOWWINDOW: > - if (wParam == TRUE) > + if (wParam) > { > PrepareWindow(); > ati = (PALTTABINFO)GetWindowLongPtrW(hWnd, 0); > > Modified: trunk/reactos/win32ss/user/user32/misc/desktop.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/d… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/desktop.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -610,7 +610,7 @@ > GetProcessWindowStation(), > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/w… > ============================================================================== > --- trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -372,7 +372,7 @@ > hWindowStationsDir, > 0); > > - if( fInherit == TRUE ) > + if( fInherit ) > { > ObjectAttributes.Attributes |= OBJ_INHERIT; > } > > Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1784,7 +1784,7 @@ > static VOID > Copy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > @@ -1814,7 +1814,7 @@ > static VOID > Paste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; > > > Modified: trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/consrv_new/frontends/gui/guiterm.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -1336,7 +1336,7 @@ > static VOID > GuiConsoleCopy(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > @@ -1364,7 +1364,7 @@ > static VOID > GuiConsolePaste(PGUI_CONSOLE_DATA GuiData) > { > - if (OpenClipboard(GuiData->hWindow) == TRUE) > + if (OpenClipboard(GuiData->hWindow)) > { > PCONSOLE Console = GuiData->Console; > PCONSOLE_SCREEN_BUFFER Buffer = ConDrvGetActiveScreenBuffer(Console); > > Modified: trunk/reactos/win32ss/user/winsrv/usersrv/register.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/usersr… > ============================================================================== > --- trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] (original) > +++ trunk/reactos/win32ss/user/winsrv/usersrv/register.c [iso-8859-1] Thu Nov 13 10:31:45 2014 > @@ -53,7 +53,7 @@ > { > PUSER_REGISTER_SERVICES_PROCESS RegisterServicesProcessRequest = &((PUSER_API_MESSAGE)ApiMessage)->Data.RegisterServicesProcessRequest; > > - if (ServicesProcessIdValid == TRUE) > + if (ServicesProcessIdValid) > { > /* Only accept a single call */ > return STATUS_INVALID_PARAMETER; > > >

10 years, 5 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev