Re: [ros-dev] [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call to kernel space

[Ged]

Lol, I've been through this with Aleksey about 30 minutes ago  ;)

 

Ged.

 

 

From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]]
On Behalf Of Alex Ionescu
Sent: 09 January 2009 14:18
To: ros-dev(a)reactos.org
Cc: ros-diffs(a)reactos.org
Subject: Re: [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call
to kernel space

 

I totally disagree with this commit.


Best regards,
Alex Ionescu



On Fri, Jan 9, 2009 at 6:33 AM, <dchapyshev(a)svn.reactos.org> wrote:

Author: dchapyshev
Date: Fri Jan  9 05:33:50 2009
New Revision: 38663

URL: http://svn.reactos.org/svn/reactos?rev=38663
<http://svn.reactos.org/svn/reactos?rev=38663&view=rev> &view=rev
Log:
- Cleanup user32, direct call to kernel space

Modified:
   trunk/reactos/dll/win32/user32/controls/button.c
   trunk/reactos/dll/win32/user32/controls/combo.c
   trunk/reactos/dll/win32/user32/controls/edit.c
   trunk/reactos/dll/win32/user32/controls/icontitle.c
   trunk/reactos/dll/win32/user32/controls/listbox.c
   trunk/reactos/dll/win32/user32/controls/scrollbar.c
   trunk/reactos/dll/win32/user32/controls/static.c
   trunk/reactos/dll/win32/user32/misc/dde.c
   trunk/reactos/dll/win32/user32/misc/ddeserver.c
   trunk/reactos/dll/win32/user32/misc/desktop.c
   trunk/reactos/dll/win32/user32/misc/misc.c
   trunk/reactos/dll/win32/user32/misc/object.c
   trunk/reactos/dll/win32/user32/misc/stubs.c
   trunk/reactos/dll/win32/user32/misc/timer.c
   trunk/reactos/dll/win32/user32/misc/winsta.c
   trunk/reactos/dll/win32/user32/user32.def
   trunk/reactos/dll/win32/user32/windows/accel.c
   trunk/reactos/dll/win32/user32/windows/bitmap.c
   trunk/reactos/dll/win32/user32/windows/caret.c
   trunk/reactos/dll/win32/user32/windows/clipboard.c
   trunk/reactos/dll/win32/user32/windows/cursor.c
   trunk/reactos/dll/win32/user32/windows/dc.c
   trunk/reactos/dll/win32/user32/windows/defwnd.c
   trunk/reactos/dll/win32/user32/windows/dialog.c
   trunk/reactos/dll/win32/user32/windows/draw.c
   trunk/reactos/dll/win32/user32/windows/input.c
   trunk/reactos/dll/win32/user32/windows/mdi.c
   trunk/reactos/dll/win32/user32/windows/menu.c
   trunk/reactos/dll/win32/user32/windows/message.c
   trunk/reactos/dll/win32/user32/windows/messagebox.c
   trunk/reactos/dll/win32/user32/windows/nonclient.c
   trunk/reactos/dll/win32/user32/windows/paint.c
   trunk/reactos/dll/win32/user32/windows/window.c
   trunk/reactos/dll/win32/user32/windows/winpos.c

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/user32/controls/button.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/b
utton.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
button.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/combo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/c
ombo.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
combo.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/edit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/e
dit.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
edit.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/i
contitle.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
icontitle.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/listbox.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/l
istbox.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
listbox.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s
crollbar.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
scrollbar.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/static.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s
tatic.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
static.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/dde.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.c
?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.
c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddese
rver.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddes
erver.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/desktop.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/deskt
op.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/desk
top.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/misc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc.
c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc
.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/object.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/objec
t.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/obje
ct.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/stubs.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stubs
.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stub
s.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/timer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/timer
.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/time
r.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/winsta.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/winst
a.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/wins
ta.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/user32.def
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.def
?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.de
f?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/accel.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ac
cel.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/a
ccel.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/bi
tmap.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/b
itmap.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/caret.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ca
ret.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
aret.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cl
ipboard.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
lipboard.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/cursor.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cu
rsor.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
ursor.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dc
.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
c.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/de
fwnd.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
efwnd.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dialog.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/di
alog.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
ialog.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/draw.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dr
aw.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
raw.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/input.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/in
put.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/i
nput.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/mdi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/md
i.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
di.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/menu.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
nu.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
enu.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/message.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
ssage.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
essage.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
ssagebox.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
essagebox.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/no
nclient.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/n
onclient.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/paint.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/pa
int.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/p
aint.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/window.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi
ndow.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w
indow.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/winpos.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi
npos.c?rev=38663
<http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w
inpos.c?rev=38663&r1=38662&r2=38663&view=diff>
&r1=38662&r2=38663&view=diff