Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service, enable it by default

[Gabriel ilardi]

This is a really nice feature, but why enabling it by default?
XP SP3 default state is disabled.
> Date: Mon, 13 Apr 2009 16:26:50 +0000
> To: [e-mail]
> From: [e-mail]
> Subject: [ros-diffs] [sedwards] 40485: add telnet service,	enable it by default
>
> Author: sedwards
> Date: Mon Apr 13 20:26:49 2009
> New Revision: 40485
>
> URL: http://svn.reactos.org/svn/reactos?rev=40485&view=rev
> Log:
> add telnet service, enable it by default
>
> Modified:
>     trunk/reactos/base/services/services.rbuild
>     trunk/reactos/base/services/telnetd/serviceentry.c
>     trunk/reactos/base/services/telnetd/telnetd.c
>     trunk/reactos/base/services/telnetd/telnetd.rbuild
>     trunk/reactos/boot/bootdata/hivesys_i386.inf
>     trunk/reactos/boot/bootdata/packages/reactos.dff
>
> Modified: trunk/reactos/base/services/services.rbuild
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/services.rbui...
> ==============================================================================
> --- trunk/reactos/base/services/services.rbuild [iso-8859-1] (original)
> +++ trunk/reactos/base/services/services.rbuild [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -22,6 +22,9 @@
>
>    <directory name="tcpsvcs">
>    	<xi:include href="tcpsvcs/tcpsvcs.rbuild" />
>    </directory>
> +	<directory name="telnetd">
> +		<xi:include href="telnetd/telnetd.rbuild" />
> +	</directory>
>    <directory name="umpnpmgr">
>    	<xi:include href="umpnpmgr/umpnpmgr.rbuild" />
>    </directory>
>
> Modified: trunk/reactos/base/services/telnetd/serviceentry.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/servi...
> ==============================================================================
> --- trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1] (original)
> +++ trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -15,19 +15,15 @@
> License along with this library; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>
> */
> -#if 0
>
> #define WIN32_LEAN_AND_MEAN
>
> #include <windows.h>
> +#include "wine/debug.h"
>
> -#define WINE_FIXME printf
> -#define WINE_TRACE printf
> +WINE_DEFAULT_DEBUG_CHANNEL(telnetd);
>
> -//#include "wine/debug.h"
>
> -//WINE_DEFAULT_DEBUG_CHANNEL(spoolsv);
>
> -static WCHAR telnetdW[] = {'T','e','l','n','e','t','D',0};
> +static WCHAR telnetdW[] = {'t','e','l','n','e','t','d',0};
>
> static SERVICE_STATUS_HANDLE service_handle;
>  static HANDLE stop_event;
> @@ -106,6 +102,5 @@
>      StartServiceCtrlDispatcherW(servtbl);
>      return 0;
>  }
> -#endif
>  /* EOF */
>
> Modified: trunk/reactos/base/services/telnetd/telnetd.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/telne...
> ==============================================================================
> --- trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] (original)
> +++ trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -45,7 +45,7 @@
> rename this function
> int kickoff_telnetd(void)
>
> */
> -int main(int argc, char **argv)
> +int kickoff_telnetd(void)
>  {
>    printf("Attempting to start Simple TelnetD\n");
>
> Modified: trunk/reactos/base/services/telnetd/telnetd.rbuild
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/telne...
> ==============================================================================
> --- trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1] (original)
> +++ trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -6,6 +6,7 @@
>    <library>kernel32</library>
>    <library>advapi32</library>
>    <library>ws2_32</library>
>
> <library>wine</library>
>
> <file>telnetd.c</file>
> <file>serviceentry.c</file>
>
> Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386....
> ==============================================================================
> --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -1061,6 +1061,15 @@
>  HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Start",0x00010001,0x00000003
>  HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Type",0x00010001,0x00000020
>
> +; ReactOS Telnet Daemon
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Description",0x00000000,"ReactOS Telnet Daemon"
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","DisplayName",0x00000000,"ReactOS Telnet Daemon"
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ErrorControl",0x00010001,0x00000001
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Group",0x00000000,"Network"
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ImagePath",0x00020000,"%SystemRoot%\system32\telnetd.exe"
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Start",0x00010001,0x00000002
> +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Type",0x00010001,0x00000020
>
> ; Sound Blaster (NT4)
>  ;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","Description",0x00000000,"Sound Blaster (NT4)"
>  ;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","ErrorControl",0x00010001,0x00000001
>
> Modified: trunk/reactos/boot/bootdata/packages/reactos.dff
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/reac...
> ==============================================================================
> --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Mon Apr 13 20:26:49 2009
> @@ -90,6 +90,7 @@
>  base\services\rpcss\rpcss.exe                       1
>  base\services\spoolsv\spoolsv.exe                   1
>  base\services\tcpsvcs\tcpsvcs.exe                   1
> +base\services\telnetd\telnetd.exe                   1
>  base\services\tcpsvcs\quotes                        5
>  base\services\umpnpmgr\umpnpmgr.exe                 1
>  base\services\wlansvc\wlansvc.exe                   1

_________________________________________________________________
Quante ne sai? Scoprilo con CrossWire!
http://clk.atdmt.com/GBL/go/140630367/direct/01/

[Ged]

In my opinion, this shouldn't even be in trunk it should be in rosapps.

From: [e-mail] [mailto:[e-mail]] On
Behalf Of Gabriel ilardi
Sent: 14 April 2009 15:46
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

This is a really nice feature, but why enabling it by default?
XP SP3 default state is disabled.
> Date: Mon, 13 Apr 2009 16:26:50 +0000
> To: [e-mail]
> From: [e-mail]
> Subject: [ros-diffs] [sedwards] 40485: add telnet service, enable it by

default
> Author: sedwards
> Date: Mon Apr 13 20:26:49 2009
> New Revision: 40485
>
> URL: http://svn.reactos.org/svn/reactos?rev=40485&view=rev
> Log:
> add telnet service, enable it by default
>
> Modified:
> trunk/reactos/base/services/services.rbuild
> trunk/reactos/base/services/telnetd/serviceentry.c
> trunk/reactos/base/services/telnetd/telnetd.c
> trunk/reactos/base/services/telnetd/telnetd.rbuild
> trunk/reactos/boot/bootdata/hivesys_i386.inf
> trunk/reactos/boot/bootdata/packages/reactos.dff
>
> Modified: trunk/reactos/base/services/services.rbuild
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/services.rbui
ld?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/base/services/services.rbuild [iso-8859-1] (original)
> +++ trunk/reactos/base/services/services.rbuild [iso-8859-1] Mon Apr 13

20:26:49 2009
> @@ -22,6 +22,9 @@
>
> <directory name="tcpsvcs">
> <xi:include href="tcpsvcs/tcpsvcs.rbuild" />
> </directory>
> + <directory name="telnetd">
> + <xi:include href="telnetd/telnetd.rbuild" />
> + </directory>
> <directory name="umpnpmgr">
> <xi:include href="umpnpmgr/umpnpmgr.rbuild" />
> </directory>
>
> Modified: trunk/reactos/base/services/telnetd/serviceentry.c
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/servi
ceentry.c?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1]

(original)
> +++ trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1] Mon

Apr 13 20:26:49 2009
> @@ -15,19 +15,15 @@
> License along with this library; if not, write to the Free Software
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,

USA
> */
> -#if 0
>
> #define WIN32_LEAN_AND_MEAN
>
> #include <windows.h>
> +#include "wine/debug.h"
>
> -#define WINE_FIXME printf
> -#define WINE_TRACE printf
> +WINE_DEFAULT_DEBUG_CHANNEL(telnetd);
>
> -//#include "wine/debug.h"
>
> -//WINE_DEFAULT_DEBUG_CHANNEL(spoolsv);
>
> -static WCHAR telnetdW[] = {'T','e','l','n','e','t','D',0};
> +static WCHAR telnetdW[] = {'t','e','l','n','e','t','d',0};
>
> static SERVICE_STATUS_HANDLE service_handle;
> static HANDLE stop_event;
> @@ -106,6 +102,5 @@
> StartServiceCtrlDispatcherW(servtbl);
> return 0;
> }
> -#endif
> /* EOF */
>
> Modified: trunk/reactos/base/services/telnetd/telnetd.c
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/telne
td.c?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] (original)
> +++ trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] Mon Apr 13

20:26:49 2009
> @@ -45,7 +45,7 @@
> rename this function
> int kickoff_telnetd(void)
>
> */
> -int main(int argc, char **argv)
> +int kickoff_telnetd(void)
> {
> printf("Attempting to start Simple TelnetD\n");
>
> Modified: trunk/reactos/base/services/telnetd/telnetd.rbuild
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/telne
td.rbuild?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1]

(original)
> +++ trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1] Mon

Apr 13 20:26:49 2009
> @@ -6,6 +6,7 @@
> <library>kernel32</library>
> <library>advapi32</library>
> <library>ws2_32</library>
> <library>wine</library>
>
> <file>telnetd.c</file>
> <file>serviceentry.c</file>
>
> Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386.
inf?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original)
> +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Mon Apr 13

20:26:49 2009
> @@ -1061,6 +1061,15 @@

HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Start",0x00010001,0x000000
03
>

HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Type",0x00010001,0x0000002
0
> +; ReactOS Telnet Daemon

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Description",0x00000000,"
ReactOS Telnet Daemon"
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","DisplayName",0x00000000,"
ReactOS Telnet Daemon"
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ErrorControl",0x00010001,
0x00000001
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Group",0x00000000,"Networ
k"
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ImagePath",0x00020000,"%S
ystemRoot%\system32\telnetd.exe"
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Start",0x00010001,0x00000
002
>

+HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Type",0x00010001,0x000000
20
> ; Sound Blaster (NT4)

;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","Description",0x00000000,"
Sound Blaster (NT4)"
>

;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","ErrorControl",0x00010001,
0x00000001
> Modified: trunk/reactos/boot/bootdata/packages/reactos.dff
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/reac
tos.dff?rev=40485&r1=40484&r2=40485&view=diff
>

============================================================================
==
> --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1]

(original)
> +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Mon Apr

13 20:26:49 2009
> @@ -90,6 +90,7 @@
> base\services\rpcss\rpcss.exe 1
> base\services\spoolsv\spoolsv.exe 1
> base\services\tcpsvcs\tcpsvcs.exe 1
> +base\services\telnetd\telnetd.exe 1
> base\services\tcpsvcs\quotes 5
> base\services\umpnpmgr\umpnpmgr.exe 1
> base\services\wlansvc\wlansvc.exe 1

_____

Il remix esclusivo di Messenger. Scaricalo
http://clk.atdmt.com/GBL/go/140630362/direct/01/  gratis!

[Steven Edwards]

On Tue, Apr 14, 2009 at 11:05 AM, Ged [e-mail] wrote:
> In my opinion, this shouldn’t even be in trunk it should be in rosapps.

Why not? Its a default part of Windows Server.

As for leaving it disabled by default, in a normal production world I
would agree but anyone running ReactOS in any sort of critical
environment in its current state should be forever banned from
touching a computer. If your really paranoid about it though then this
is a good excuse for me to start working on adding authentication to
it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Timo Kreuzer]

Actually there's quite a few people running reactos on their main
machine from a second hdd from time to time.

Having a telnet server running by default on a system that is
automatically connected to the internet without a firewall, doesn't have
any user authentication or limited accounts, has full access to all of
the PC's hardware and tends to be quite buggy doesn't sound like a great
idea. Let's not start with sloppyness in this area.
Please disable. 90% of people don't use it anyway, and I'm quite sure it
isn't enabled by default on a Windows server.

Timo

Steven Edwards schrieb:
> On Tue, Apr 14, 2009 at 11:05 AM, Ged [e-mail] wrote:
> > In my opinion, this shouldn�t even be in trunk it should be in rosapps.
>
> Why not? Its a default part of Windows Server.
>
> As for leaving it disabled by default, in a normal production world I
> would agree but anyone running ReactOS in any sort of critical
> environment in its current state should be forever banned from
> touching a computer. If your really paranoid about it though then this
> is a good excuse for me to start working on adding authentication to
> it.

[Ged]

Steven Edwards wrote:
> On Tue, Apr 14, 2009 at 11:05 AM, Ged [e-mail] wrote:
> > In my opinion, this shouldn't even be in trunk it should be in rosapps.
> Why not? Its a default part of Windows Server.

Because we recently had a discussion about trying to keep non-essential
things out of trunk in an effort to keep the build time down.

[Steven Edwards]

On Tue, Apr 14, 2009 at 2:14 PM, Ged [e-mail] wrote:
> Because we recently had a discussion about trying to keep non-essential
> things out of trunk in an effort to keep the build time down.

Sure I agree with keeping down the build time but I thought we were
going to implement a subset of build targets so the apps that make up
the main distro would still be in the reactos checkout. If there is
consensus that telnetd should be disabled or set to manual then I'll
turn it off. Otherwise my plan was to leave it on until we reach 0.4
in the hopes that people would stress it out and help me develop it.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Ged]

Have you not got your unix head on here?
I don't think most windows users even know what a telnet server is for, let
along help to stress/develop it.

Maybe I'm out of touch here though, if this is indeed useful then I succumb.

Ged.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 15 April 2009 07:03
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

On Tue, Apr 14, 2009 at 2:14 PM, Ged [e-mail] wrote:
> Because we recently had a discussion about trying to keep non-essential
> things out of trunk in an effort to keep the build time down.

Sure I agree with keeping down the build time but I thought we were
going to implement a subset of build targets so the apps that make up
the main distro would still be in the reactos checkout. If there is
consensus that telnetd should be disabled or set to manual then I'll
turn it off. Otherwise my plan was to leave it on until we reach 0.4
in the hopes that people would stress it out and help me develop it.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Steven Edwards]

On Wed, Apr 15, 2009 at 5:57 AM, Ged [e-mail] wrote:
> Have you not got your unix head on here?
> I don't think most windows users even know what a telnet server is for, let
> along help to stress/develop it.

My hope was that it would help us nail down some of the issues we will
face when we implement or support a proper ssh server. Eventually I
plan on setting telnetd to disabled but given we have no other real
security and anyone using ReactOS on any system with any sort of
critical data is insane I don't see a problem with it. I would in fact
be impressed if someone did manage to make a botnet out of a bunch of
ReactOS boxen. The PR would do us some good.
> Maybe I'm out of touch here though, if this is indeed useful then I succumb.

It will be more useful when I fix the remaining console issues so apps
like ctm, tlist, edit, etc work. Stuff like ping, ipconfig, load,
route, etc work. Right now calling Get/SetConsoleMode bombs because it
is parentless and most complex applications expecting to run in
cmd.exe expect to have some sort of real console to set modes. I think
I've found a solution I just need to run it by KJK or get the time to
test it out.

'There is another...' so to speak. I didn't find it until after I had
already started spending a good bit of time working on the current
telnetd implementation.

http://www.kpym.com/2/kpym/index.htm

Its FOSS and does sshd and telnetd and does not seem to suffer from
the console problems we face, however there seems to be some sort of
problem starting or installing the service the last time I tested. I'd
be happy to just dump the current telnetd in favor of it if it can be
made to work under ROS. I just don't want to see what limited remote
access we have now regress which is why i went ahead and enabled it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Ged]

Why would we want to implement an ssh server?
IMO, telnet and ssh servers are things users should install themselves using
well known products.

I don't know of anyone who uses telnet or ssh in the windows world. They're
unix tools for command line junkies.
We have much cooler tools like RDP.

XP/vista doesn't have these services so I'm not really sure why we do.
They just increase the build time and take up OS resources

Maybe a better option would be to add the kpym.com tools to downloader and
let anyone who may want to install them.

Ged.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 15 April 2009 14:27
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

On Wed, Apr 15, 2009 at 5:57 AM, Ged [e-mail] wrote:
> Have you not got your unix head on here?
> I don't think most windows users even know what a telnet server is for,

let
> along help to stress/develop it.

My hope was that it would help us nail down some of the issues we will
face when we implement or support a proper ssh server. Eventually I
plan on setting telnetd to disabled but given we have no other real
security and anyone using ReactOS on any system with any sort of
critical data is insane I don't see a problem with it. I would in fact
be impressed if someone did manage to make a botnet out of a bunch of
ReactOS boxen. The PR would do us some good.
> Maybe I'm out of touch here though, if this is indeed useful then I

succumb.

It will be more useful when I fix the remaining console issues so apps
like ctm, tlist, edit, etc work. Stuff like ping, ipconfig, load,
route, etc work. Right now calling Get/SetConsoleMode bombs because it
is parentless and most complex applications expecting to run in
cmd.exe expect to have some sort of real console to set modes. I think
I've found a solution I just need to run it by KJK or get the time to
test it out.

'There is another...' so to speak. I didn't find it until after I had
already started spending a good bit of time working on the current
telnetd implementation.

http://www.kpym.com/2/kpym/index.htm

Its FOSS and does sshd and telnetd and does not seem to suffer from
the console problems we face, however there seems to be some sort of
problem starting or installing the service the last time I tested. I'd
be happy to just dump the current telnetd in favor of it if it can be
made to work under ROS. I just don't want to see what limited remote
access we have now regress which is why i went ahead and enabled it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Jeremy King]

Lots of people use telnet and ssh in windows.
Since the mass's use windows there is far more people using telnet then you
would think.
They use for things like playing mud games or running simple stuff on there
systems.

King

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Ged
Sent: Wednesday, April 15, 2009 4:47 PM
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

Why would we want to implement an ssh server?
IMO, telnet and ssh servers are things users should install themselves using
well known products.

I don't know of anyone who uses telnet or ssh in the windows world. They're
unix tools for command line junkies.
We have much cooler tools like RDP.

XP/vista doesn't have these services so I'm not really sure why we do.
They just increase the build time and take up OS resources

Maybe a better option would be to add the kpym.com tools to downloader and
let anyone who may want to install them.

Ged.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 15 April 2009 14:27
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

On Wed, Apr 15, 2009 at 5:57 AM, Ged [e-mail] wrote:
> Have you not got your unix head on here?
> I don't think most windows users even know what a telnet server is for,

let
> along help to stress/develop it.

My hope was that it would help us nail down some of the issues we will
face when we implement or support a proper ssh server. Eventually I
plan on setting telnetd to disabled but given we have no other real
security and anyone using ReactOS on any system with any sort of
critical data is insane I don't see a problem with it. I would in fact
be impressed if someone did manage to make a botnet out of a bunch of
ReactOS boxen. The PR would do us some good.
> Maybe I'm out of touch here though, if this is indeed useful then I

succumb.

It will be more useful when I fix the remaining console issues so apps
like ctm, tlist, edit, etc work. Stuff like ping, ipconfig, load,
route, etc work. Right now calling Get/SetConsoleMode bombs because it
is parentless and most complex applications expecting to run in
cmd.exe expect to have some sort of real console to set modes. I think
I've found a solution I just need to run it by KJK or get the time to
test it out.

'There is another...' so to speak. I didn't find it until after I had
already started spending a good bit of time working on the current
telnetd implementation.

http://www.kpym.com/2/kpym/index.htm

Its FOSS and does sshd and telnetd and does not seem to suffer from
the console problems we face, however there seems to be some sort of
problem starting or installing the service the last time I tested. I'd
be happy to just dump the current telnetd in favor of it if it can be
made to work under ROS. I just don't want to see what limited remote
access we have now regress which is why i went ahead and enabled it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Ged]

I'm talking about servers.
Considering both telnet and ssh servers aren't included with Windows, I find
this odd.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Jeremy King
Sent: 15 April 2009 17:36
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

Lots of people use telnet and ssh in windows.
Since the mass's use windows there is far more people using telnet then you
would think.
They use for things like playing mud games or running simple stuff on there
systems.

King

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Ged
Sent: Wednesday, April 15, 2009 4:47 PM
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

Why would we want to implement an ssh server?
IMO, telnet and ssh servers are things users should install themselves using
well known products.

I don't know of anyone who uses telnet or ssh in the windows world. They're
unix tools for command line junkies.
We have much cooler tools like RDP.

XP/vista doesn't have these services so I'm not really sure why we do.
They just increase the build time and take up OS resources

Maybe a better option would be to add the kpym.com tools to downloader and
let anyone who may want to install them.

Ged.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 15 April 2009 14:27
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

On Wed, Apr 15, 2009 at 5:57 AM, Ged [e-mail] wrote:
> Have you not got your unix head on here?
> I don't think most windows users even know what a telnet server is for,

let
> along help to stress/develop it.

My hope was that it would help us nail down some of the issues we will
face when we implement or support a proper ssh server. Eventually I
plan on setting telnetd to disabled but given we have no other real
security and anyone using ReactOS on any system with any sort of
critical data is insane I don't see a problem with it. I would in fact
be impressed if someone did manage to make a botnet out of a bunch of
ReactOS boxen. The PR would do us some good.
> Maybe I'm out of touch here though, if this is indeed useful then I

succumb.

It will be more useful when I fix the remaining console issues so apps
like ctm, tlist, edit, etc work. Stuff like ping, ipconfig, load,
route, etc work. Right now calling Get/SetConsoleMode bombs because it
is parentless and most complex applications expecting to run in
cmd.exe expect to have some sort of real console to set modes. I think
I've found a solution I just need to run it by KJK or get the time to
test it out.

'There is another...' so to speak. I didn't find it until after I had
already started spending a good bit of time working on the current
telnetd implementation.

http://www.kpym.com/2/kpym/index.htm

Its FOSS and does sshd and telnetd and does not seem to suffer from
the console problems we face, however there seems to be some sort of
problem starting or installing the service the last time I tested. I'd
be happy to just dump the current telnetd in favor of it if it can be
made to work under ROS. I just don't want to see what limited remote
access we have now regress which is why i went ahead and enabled it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Kingpinzs]

Windows 2000(also Professional)/2003/2008 server comes with telnet server.
But I apologize I thought you were talking about telnet client mainly. 
And in windows XP its disabled and by default in vista it's not installed. I
might be sounding dumb. 
But I think it should be installed by default but not turned on. 
But make it easy to enable and always run as a service.

King
-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Ged
Sent: Wednesday, April 15, 2009 8:55 PM
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

I'm talking about servers.
Considering both telnet and ssh servers aren't included with Windows, I find
this odd.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] 
Sent: 15 April 2009 17:36
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

Lots of people use telnet and ssh in windows.
Since the mass's use windows there is far more people using telnet then you
would think.
They use for things like playing mud games or running simple stuff on there
systems.

King

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Ged
Sent: Wednesday, April 15, 2009 4:47 PM
To: 'ReactOS Development List'
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

Why would we want to implement an ssh server?
IMO, telnet and ssh servers are things users should install themselves using
well known products.

I don't know of anyone who uses telnet or ssh in the windows world. They're
unix tools for command line junkies.
We have much cooler tools like RDP.

XP/vista doesn't have these services so I'm not really sure why we do.
They just increase the build time and take up OS resources

Maybe a better option would be to add the kpym.com tools to downloader and
let anyone who may want to install them.

Ged.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 15 April 2009 14:27
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,
enable it by default

On Wed, Apr 15, 2009 at 5:57 AM, Ged [e-mail] wrote:
> Have you not got your unix head on here?
> I don't think most windows users even know what a telnet server is for,

let
> along help to stress/develop it.

My hope was that it would help us nail down some of the issues we will
face when we implement or support a proper ssh server. Eventually I
plan on setting telnetd to disabled but given we have no other real
security and anyone using ReactOS on any system with any sort of
critical data is insane I don't see a problem with it. I would in fact
be impressed if someone did manage to make a botnet out of a bunch of
ReactOS boxen. The PR would do us some good.
> Maybe I'm out of touch here though, if this is indeed useful then I

succumb.

It will be more useful when I fix the remaining console issues so apps
like ctm, tlist, edit, etc work. Stuff like ping, ipconfig, load,
route, etc work. Right now calling Get/SetConsoleMode bombs because it
is parentless and most complex applications expecting to run in
cmd.exe expect to have some sort of real console to set modes. I think
I've found a solution I just need to run it by KJK or get the time to
test it out.

'There is another...' so to speak. I didn't find it until after I had
already started spending a good bit of time working on the current
telnetd implementation.

http://www.kpym.com/2/kpym/index.htm

Its FOSS and does sshd and telnetd and does not seem to suffer from
the console problems we face, however there seems to be some sort of
problem starting or installing the service the last time I tested. I'd
be happy to just dump the current telnetd in favor of it if it can be
made to work under ROS. I just don't want to see what limited remote
access we have now regress which is why i went ahead and enabled it.
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Gabriel ilardi]

It is not just that, you're adding another program that uses resources.
I remove everything I don't need from autostart in my pc. If normally you don't need it, why always enable it ?
It's easier to enable it if you need it than always stopping it cause you don't.
The default state in Windows is disabled, we are trying to replicate its behavior, aren't we?
Authentication would be a good thing anyway. ;)

This is just my thought...
> Date: Tue, 14 Apr 2009 12:48:10 -0400
> From: [e-mail]
> To: [e-mail]
> Subject: Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service,	enable it by default
>
> On Tue, Apr 14, 2009 at 11:05 AM, Ged [e-mail] wrote:
> > In my opinion, this shouldn’t even be in trunk it should be in rosapps.
>
> Why not? Its a default part of Windows Server.
>
> As for leaving it disabled by default, in a normal production world I
> would agree but anyone running ReactOS in any sort of critical
> environment in its current state should be forever banned from
> touching a computer. If your really paranoid about it though then this
> is a good excuse for me to start working on adding authentication to
> it.
>
> -- 
> Steven Edwards
>
> "There is one thing stronger than all the armies in the world, and
> that is an idea whose time has come." - Victor Hugo
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

_________________________________________________________________
Quante ne sai? Scoprilo con CrossWire!
http://clk.atdmt.com/GBL/go/140630367/direct/01/