Wine Gecko

[Adam Kachwalla]

I think that Wine Gecko should be integrated in the ReactOS releases. It  
is needed IIRC for things like Winhlp32 (I think) and HTML Help  
(defiitely) and applications which use IE browser controls.

[Olaf Siejka]

IIRC, we have a strict policy of not bundling binaries in ROS trunk. On the
other hand my buildbot's ISOs do have it included via modules\optional,
mostly because i had to skip this nagging check in 2nd stage for roscdtest
purpose.

Regards

2010/10/27 Adam Kachwalla [e-mail]
> I think that Wine Gecko should be integrated in the ReactOS releases. It is
> needed IIRC for things like Winhlp32 (I think) and HTML Help (defiitely) and
> applications which use IE browser controls.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Adam Kachwalla]

What about Wine Gecko from source? Also, I would think that because it is  
a GPL module, it wouldn't matter if the binaries are there or not?

http://wiki.winehq.org/BuildingWineGecko

By the way, did you have to extract the cab file into the modules/optional  
folder, or how did you integrate it?

On Thu, 28 Oct 2010 01:08:44 +1100, Olaf Siejka [e-mail] wrote:
> IIRC, we have a strict policy of not bundling binaries in ROS trunk. On  
> the other hand my buildbot's ISOs do have it included via  
> modules\optional, >mostly because i had to skip this nagging check in  
> 2nd stage for roscdtest purpose.
>
> Regards
>
> 2010/10/27 Adam Kachwalla [e-mail]
> > I think that Wine Gecko should be integrated in the ReactOS releases.  
> > It is needed IIRC for things like Winhlp32 (I think) and HTML Help
> > > > (defiitely) and applications which use IE browser controls.
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Give a man a fish and he will eat for a day.
Teach a man to fish and he will eat for a lifetime.
Give a man religion and he will die praying for a fish.

[Olaf Siejka]

Sure, why dont we add another 5-10 minutes to ros compile time....

As for integration i just placed wine_gecko-1.0.0-x86.cab in
trunk\modules\optional\

Regards

2010/10/27 Adam Kachwalla [e-mail]
> What about Wine Gecko from source? Also, I would think that because it is a
> GPL module, it wouldn't matter if the binaries are there or not?
>
> http://wiki.winehq.org/BuildingWineGecko
>
> By the way, did you have to extract the cab file into the modules/optional
> folder, or how did you integrate it?

[Adam Kachwalla]

Shouldn't matter too much... we stick rosapps and rostests in there as  
optional components, I'm sure Wine Gecko shouldn't be too much of a  
problem to insert this way.

On Thu, 28 Oct 2010 01:24:28 +1100, Olaf Siejka [e-mail] wrote:
> Sure, why dont we add another 5-10 minutes to ros compile time....
>
> As for integration i just placed wine_gecko-1.0.0-x86.cab in  
> trunk\modules\optional\
>
> Regards
>
> 2010/10/27 Adam Kachwalla [e-mail]
> > What about Wine Gecko from source? Also, I would think that because it  
> > is a GPL module, it wouldn't matter if the binaries are there or not?
> >
> > http://wiki.winehq.org/BuildingWineGecko
> >
> > By the way, did you have to extract the cab file into the  
> > modules/optional folder, or how did you integrate it?
-- 
Give a man a fish and he will eat for a day.
Teach a man to fish and he will eat for a lifetime.
Give a man religion and he will die praying for a fish.

[Zachary Gorden]

Probably will be in the future.  Only reason it wasn't was because I was not
aware of the concern, the component wasn't listed on any of the packaging
pages as should be included, and none of the testers pointed out a desire
for it.  One of the devs says he suggested this a while ago, but I had no
awareness of the suggestion.

On Wed, Oct 27, 2010 at 9:45 AM, Adam Kachwalla [e-mail]:
> Shouldn't matter too much... we stick rosapps and rostests in there as
> optional components, I'm sure Wine Gecko shouldn't be too much of a problem
> to insert this way.
>
> On Thu, 28 Oct 2010 01:24:28 +1100, Olaf Siejka [e-mail]
> wrote:
>
> Sure, why dont we add another 5-10 minutes to ros compile time....
>
> As for integration i just placed wine_gecko-1.0.0-x86.cab in
> trunk\modules\optional\
>
> Regards
>
> 2010/10/27 Adam Kachwalla [e-mail]
> > What about Wine Gecko from source? Also, I would think that because it
> > is a GPL module, it wouldn't matter if the binaries are there or not?
> >
> > http://wiki.winehq.org/BuildingWineGecko
> >
> > By the way, did you have to extract the cab file into the modules/optional
> > folder, or how did you integrate it?
>
> --
> Give a man a fish and he will eat for a day.
> Teach a man to fish and he will eat for a lifetime.
> Give a man religion and he will die praying for a fish.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Bernd Blaauw]

Op 27-10-2010 18:06, Zachary Gorden schreef:
> Probably will be in the future.  Only reason it wasn't was because I 
> was not aware of the concern, the component wasn't listed on any of 
> the packaging pages as should be included, and none of the testers 
> pointed out a desire for it.  One of the devs says he suggested this a 
> while ago, but I had no awareness of the suggestion.

I'm a bit surprised this Gecko engine download is present in phase 2 
rather than inside the downloader application in phase 3 as some kind of 
'recommended addon'.
(and it wouldn't hurt to have that Downloader program as a desktop icon 
either just like CMD, so people know where to go first instead of being 
confronted with a fresh OS that can't do much yet, and then having to 
hunt for 'how can I get more programs when not even a browser is 
present'..they'd have to search the start menu for this Downloader 
program which is hidden among quite a few other programs).

[Sven Barth]

On 27.10.2010 18:37, Bernd Blaauw wrote:
> Op 27-10-2010 18:06, Zachary Gorden schreef:
> > Probably will be in the future. Only reason it wasn't was because I
> > was not aware of the concern, the component wasn't listed on any of
> > the packaging pages as should be included, and none of the testers
> > pointed out a desire for it. One of the devs says he suggested this a
> > while ago, but I had no awareness of the suggestion.
>
> I'm a bit surprised this Gecko engine download is present in phase 2
> rather than inside the downloader application in phase 3 as some kind of
> 'recommended addon'.

It might be, because that's part of the "COM registration startup" of 
the mshtml DLL... (just guessing here)
> (and it wouldn't hurt to have that Downloader program as a desktop icon
> either just like CMD, so people know where to go first instead of being
> confronted with a fresh OS that can't do much yet, and then having to
> hunt for 'how can I get more programs when not even a browser is
> present'..they'd have to search the start menu for this Downloader
> program which is hidden among quite a few other programs).

The last time I looked at my ReactOS 0.3.12 desktop (1 minute ago) I saw 
a "ReactOS Anwendungsmanager" (free translation: "ReactOS Application 
Manager") which is that downloader.

Regards,
Sven

[Olaf Siejka]

I am not a fan of such placement myself, this was caused by WINE
dependencies and just popped out after one of the winesyncs. It could be
changed, but i was told this would increase difficulty of each subsequent
winesync.

Regards

On 27.10.2010 18:37, Bernd Blaauw wrote:
> I'm a bit surprised this Gecko engine download is present in phase 2
> rather than inside the downloader application in phase 3 as some kind of
>  'recommended addon'.

[Bernd Blaauw]

Op 27-10-2010 18:53, Sven Barth schreef:
> The last time I looked at my ReactOS 0.3.12 desktop (1 minute ago) I 
> saw a "ReactOS Anwendungsmanager" (free translation: "ReactOS 
> Application Manager") which is that downloader.
>
> Regards,
> Sven

You are indeed correct Sven, my mistake, apologies for that.
I'll have to verify if this is release-only or also in trunk builds 
(older ones didn't have it, anything later than 0.3.12 I didn't look at 
yet).

Any FireFox 4.0 (beta) in that download list would be convenient, 3.6.9 
still has address bar text input issues (verified working keyboard by 
entering text in a CMD Console window).
Ofcourse along with being able to doubleclick a program in downloader 
rather than select, then choose Install or having to rightclick the 
entry, then select Install. Mostly a convenience issue I guess, nothing big.

[Colin Finck]

Bernd Blaauw [e-mail] wrote:
> I'll have to verify if this is release-only or also in trunk builds
> (older ones didn't have it  [...]

The mshtml winesync in question has occured shortly after 0.3.11 had 
been released, so this also affects trunk builds for quite a while now.
To make a long story short:

- Yes, the Wine-Gecko CAB should have been integrated into 0.3.12, but
   due to a communication issue during the release engineering process,
   this hasn't been done.

- Yes, this message is shown in second stage setup, because it's part
   of the DllRegisterServer() of mshtml.

- Someday in the future, when our build system can afford such big
   packages and when ReactOS starts to depend more on the availability of
   a HTML engine (e.g. for HTML Help), we will certainly integrate a
   full mshtml including a HTML engine.
   I just doubt it will still be Gecko by then as you (AFAIK) need to
   integrate the sources of a whole Mozilla browser for compiling the
   engine.

Cheers,

Colin

[Bernd Blaauw]

Op 27-10-2010 20:45, Colin Finck schreef:
> The mshtml winesync in question has occured shortly after 0.3.11 had 
> been released, so this also affects trunk builds for quite a while now.
> To make a long story short:

Thanks for your detailed explanation Colin, everything seems to have its 
perfectly justified reason, which is just fine.
My remark was more about 'hey when actually did the Downloader end up on 
desktop' as that was a nice suggestion which I overlooked as being 
implemented after all.
> Yes, this message is shown in second stage setup, because it's part
> of the DllRegisterServer() of mshtml.

Ah ok. I'm just wondering which exact advantages it has if you're 
installing it during phase 2, or which disadvantages if you don't. I 
can't recall the ReactOS help program (in start menu) working as it says 
'help not implemented yet' or something alike, so just wondering :)
Also, does installing FireFox compensate for not installing Gecko 
package during phase 2?
It's nice to see the installation process (and LiveCD I guess) having 
network/internet access.