0.3.10 branching

[Aleksey Bragin]

Hi,
after thorough testing, 41446 appears to be the revision it would  
make sense to branch 0.3.10 from (according to Victor Martinez).

Colin - please do a branch from 41446, and besides applying our usual  
hacks, revert the most recent wininet sync since it breaks Download!  
app. If you could do a prerelease iso for testing too, that would be  
great.


WBR,
Aleksey Bragin.

[Ged]

My car could do with a clean, oh an cup of tea would be nice too.
Cheers Colin :)


-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Aleksey Bragin
Sent: 22 June 2009 15:50
To: ReactOS Development List; Colin Finck
Subject: [ros-dev] 0.3.10 branching

Hi,
after thorough testing, 41446 appears to be the revision it would  
make sense to branch 0.3.10 from (according to Victor Martinez).

Colin - please do a branch from 41446, and besides applying our usual  
hacks, revert the most recent wininet sync since it breaks Download!  
app. If you could do a prerelease iso for testing too, that would be  
great.


WBR,
Aleksey Bragin.
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Cameron Gutman]

Why such an old revision?

On Mon, Jun 22, 2009 at 10:50 AM, Aleksey Bragin <aleksey(a)reactos.org>wrote;wrote:

>   Hi,
>  after thorough testing, 41446 appears to be the revision it would
>  make sense to branch 0.3.10 from (according to Victor Martinez).
>
>  Colin - please do a branch from 41446, and besides applying our usual
>  hacks, revert the most recent wininet sync since it breaks Download!
>  app. If you could do a prerelease iso for testing too, that would be
>  great.
>
>
>  WBR,
>  Aleksey Bragin.
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[victor martinez]

Hi :)

Well it isnt really old (just 41575-41446= 129). 

Im not supporter of including ARM commits to 0.3.10 release, their commits need more
testing since they are touching critical code.

We have seen a break build and not booting builds.They are fixed now,but we are taking an
extra risk adding these commits to 0.3.10.

I think it´s better to add them to 0.3.11 so we can test in the next 1-2 months.Their
first commit was 41503. 

Also recently we have synced some code with Wine. Syncs are always small risks.And these
risks can lead to regressions.

One wininet sync (as you know) regressed Download! (all downloaded files were corrupted).


Talking about Winesyncs, I think we should sync just after a release is done so we have
1-2 months to discover any regression due to syncing, 

and wait until next release to sync again.This can avoid to find regressions caused by a
late sync. 

These two reasons push me(ARM+lateSyncs) to not include revisions after 41503.

So 41503-41446= 57 commits.

>  From these 57 commits there are a bunch of commits to
> make ReactOS compatible with MSVC, there are some formatting,reverting and fixing commits.
These are nice commits,but the users arent going to feel them.

A Release is mainly User oriented and a ReactOS checkpoint, imo.

 

To 41446 is going to be added the "Wininet revert"commit to fix a regression, 

if after 41446 you(Devs) have sent other patches which fix regressions tell to Aleksey. 

 

If anyone wants to point a better revision i can hear opinions but then he will have to
help me with the re-testing(about 45 apps) :)

 

WBR,

 

Víctor Martínez

GoldenApps Testing Team

 

_________________________________________________________________
Nuevo Windows Live, un mundo lleno de posibilidades. Descúbrelo.
http://www.microsoft.com/windows/windowslive/default.aspx