Re: [ros-dev] Re : ReactOS doesn't compile well

[carlo.bramix]

Hello,
unfortunately, the problem really exists, since it seems that at least someone else saw the error when compiling.
Hopefully, I discovered a solution.
I changed windres.exe with another one.
The one into RosBE 0.3.6 says:

GNU windres (GNU Binutils) 2.17.50.20070608
Copyright 2007 Free Software Foundation, Inc.

The one into my MSYS installation says:

GNU windres 2.17.50 20060824
Copyright 2005 Free Software Foundation, Inc.

I renamed windres.exe into c:\RosBE\4.1.3\bin and I copied the old one. And surprise, now it all works.
Don't ask me why... at the moment I don't know the reason but this trick made it working.

Sincerely,

Carlo Bramini

---------- Initial Header -----------
> From      : [e-mail]

To          : "ReactOS Development List" [e-mail]
Cc          : 
Date      : Tue, 10 Jul 2007 19:01:28 +0200
Subject : Re: [ros-dev] Re :  ReactOS doesn't compile well
> Hi,
>
> I just tested building latest trunk under Windows and 32-bit Linux (both
> with RosBE 0.3.6) and both builds resulted in correct ISOs.
> Our BuildBot also has no such problems.
>
> I tested your examples "intl.cpl" and "sysdm.cpl" and both are shown in
> english for me.
> When I switch the locale to any german locale, I get german versions of
> these apps, meaning that the whole localization thing works for me.
>
> Maybe you have to do a clean build.
>
> Best regards,
>
> Colin
> > -----Original Message-----
> > From: [e-mail] 
> > [mailto:[e-mail]] On Behalf Of carlo.bramix
> > Sent: Tuesday, July 10, 2007 5:25 PM
> > To: ros-dev
> > Subject: Re: [ros-dev] Re : ReactOS doesn't compile well
> >
> > Hello,
> > yep, the errors don't interrupt the compilation of ReactOS.
> > But the resources into those coffs seem corrupted to me.
> > For example, if I open the control panel I will see inl.cpl 
> > in german language(!) while all others are in english or if I 
> > open the system applet I can see some text without sense.
> >
> > Sincerely,
> >
> > Carlo Bramini
> >
> > ---------- Initial Header -----------
> > > From      : [e-mail]
> >
> > To          : "ReactOS Development List" [e-mail]
> > Cc          : 
> > Date      : Tue, 10 Jul 2007 15:07:58 +0000 (GMT)
> > Subject : [ros-dev] Re :  ReactOS doesn't compile well
> > > hi,
> > > I got some of them but it didnt bother the build.
> > >
> > > Kind regards,
> > > Sylvain Petreolle (aka Usurp)
> > >
> > > Run your favorite Windows apps with free ReactOS :
> >
> > http://www.reactos.org
> > > Listen to non-DRMised Music: http://www.jamendo.com
> > >
> > > ----- Message d'origine ----
> > > De : carlo.bramix [e-mail]
> > > À : ros-dev [e-mail]
> > > Envoyé le : Mardi, 10 Juillet 2007, 16h52mn 51s
> > > Objet : Re: [ros-dev] ReactOS doesn't compile well
> > >
> > > Hello,
> > > while regedit compilation was done successfully, some files
> >
> > aren't still generated correctly:
> > > [WRC]      obj-i386\base\shell\cmd\cmd.coff
> > > [WRC]      obj-i386\base\system\expand\expand.coff
> > > [WRC]      obj-i386\dll\cpl\intl\intl.coff
> > > [WRC]      obj-i386\dll\cpl\intl_new\intl.coff
> > > [WRC]      obj-i386\dll\cpl\sysdm\sysdm.coff
> > > [WRC]      obj-i386\dll\win32\comdlg32\rsrc.coff
> > > [WRC]      obj-i386\dll\win32\hhctrl.ocx\hhctrl.coff
> > > [WRC]      obj-i386\dll\win32\shdocvw\shdocvw.coff
> > >
> > > <built-in>:0: fatal error: when writing output to : Invalid argument
> > > compilation terminated.
> > >
> > > I hope it could be fixed.
> > >
> > > Sincerely,
> > >
> > > Carlo Bramini
> > >
> > > ---------- Initial Header -----------
> > > > From      : [e-mail]
> > >
> > > To          : "ros-dev" [e-mail]
> > > Cc          : 
> > > Date      : Mon,  9 Jul 2007 18:34:34 +0200
> > > Subject : Re: [ros-dev] ReactOS doesn't compile well
> > > > Hello,
> > > > problem with compilation of regedit seems to be gone with
> >
> > revision 27541.
> > > > Sincerely,
> > > >
> > > > Carlo Bramini
> > > >
> > > > ---------- Initial Header -----------
> > > > > From      : [e-mail]
> > > >
> > > > To          : "ros-dev" [e-mail]
> > > > Cc          : 
> > > > Date      : Mon,  9 Jul 2007 11:24:29 +0200
> > > > Subject : [ros-dev] ReactOS doesn't compile well
> > > > > Hello,
> > > > > it looks like something wrong happens when I compile ReactOS.
> > > > > I also did a complete clean and a make for a total
> >
> > rebuild, but I'm still having problems.
> > > > > I saw the first problem when I tried to test Regedit
> >
> > after committed changes.
> > > > > The tree window and the listview window aren't visible
> >
> > (or they aren't created successfully, I didn't check this yet).
> > > > > I tested that executable into WinXP and those child
> >
> > windows aren't visible too.
> > > > > So I did these steps:
> > > > > I compiled Regedit with Visual C and I verified that
> >
> > it worked fine.
> > > > > I grabbed regedit.res and I manually generated
> >
> > regedit.coff with "windres -i regedit.res -o regedit.coff".
> > > > > I launched "make" again and it regenerated regedit.exe.
> > > > >
> > > > > This last regedit.exe works fine and it has all child
> >
> > window controls visible. It's really a problem when 
> > generating te coff file from resources.
> > > > > I also saw a possible second problem when compiling.
> > > > > Some compilation of '.coff' files failed.
> > > > > On the console I read some messages like this one:
> > > > >
> > > > > [WRC]      obj-i386\dll\win32\comdlg32\rsrc.coff
> > > > > <built-in>:0: fatal error: when writing output to :
> >
> > Invalid argument
> > > > > compilation terminated.
> > > > >
> > > > > Actually I'm using RosBE 0.3.6 but I never got such
> >
> > problems with previouses svn versions of the sources.
> > > > > Sincerely,
> > > > >
> > > > > Carlo Bramini
> > > > >
> > > > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind
> > > > > http://i-mode.wind.it/
> > > > >
> > > > > Ros-dev mailing list
> > > > > [e-mail]
> > > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > > >
> > > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind
> > > > http://i-mode.wind.it/
> > > >
> > > > Ros-dev mailing list
> > > > [e-mail]
> > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > >
> > > Scegli infostrada: ADSL gratis per tutta l´estate e
> >
> > telefoni senza canone Telecom
> > > http://click.libero.it/infostrada
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> > Scegli infostrada: ADSL gratis per tutta l’estate e telefoni 
> > senza canone Telecom
> > http://click.libero.it/infostrada
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

------------------------------------------------------
Scegli infostrada: ADSL gratis per tutta l’estate e telefoni senza canone Telecom
http://click.libero.it/infostrada

[Ged]

carlo.bramix wrote:
> The one into my MSYS installation says:

You shoudn't be using anything other than RosBE otherwise you're on your 
own with any build problems you may have.

[Timo Kreuzer]

You should read the whole post.
He was using RosBE 0.3.6 and got problems, after replacing windres with 
the MSYS one it worked.
I also got those problems with latest RosBE. Replacing windres with the 
older *MinGW* version didn't help.

revision 27557: 268 KB, no icon
revision 27541: 372 KB, with icon

But it has in fact nothing todo with SUBLANG_XX

You see the problem when opening it with a hexeditor:
the file begins with EF BB BF
when you remove it and reopen the file with windows notepad, it will be 
put there again.

Don't use windows notepad to edit rc files!

fixed in 27574

Ged schrieb:
> carlo.bramix wrote:
> > The one into my MSYS installation says:
>
> You shoudn't be using anything other than RosBE otherwise you're on your 
> own with any build problems you may have.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Klemens Friedl]

2007/7/10, Timo Kreuzer [e-mail]:
> You see the problem when opening it with a hexeditor:
> the file begins with EF BB BF
> when you remove it and reopen the file with windows notepad, it will be put
> there again.
>
> Don't use windows notepad to edit rc files!

The UTF-8 representation of the BOM (Byte Order Mark) is the byte
sequence EF BB BF, which appears as the ISO-8859-1 characters "" in
most text editors and web browsers not prepared to handle UTF-8.

While UTF-8 does not have byte order issues (in contrary to UTF-16), a
BOM encoded in UTF-8 may be used to mark text as UTF-8. It only
identifies a file as UTF-8 and does not state anything about byte
order.

Most Win32 software (inclusive notepad.exe) are aware of that leading
characters and interprate it in the "correct" way. In fact these chars
help the software to "guess" the right character encoding. If no such
leading chars are there, the software has to check the first few chars
and guess the hopefully right one. And latest versions of the Windows
notepad.exe do a good job at detecting the variations.

Our problem is that gcc and overall most unix software simple don't
know (or care) to handle that chars.

"[...]  gcc reports stray characters at the beginning of a source file
[...]" as the related Wikipedia page mentions.

Further information:

* Raymond Chen's blog entry about notepad.exe & BOM:
http://blogs.msdn.com/oldnewthing/archive/2004/03/24/95235.aspx

* http://en.wikipedia.org/wiki/Byte_Order_Mark

Klemens

[Michael Fritscher]

> You see the problem when opening it with a hexeditor:
> the file begins with EF BB BF
> when you remove it and reopen the file with windows notepad, it will be
> put there again.

This is the BOM of UTF-8...
which bring me to the question: Do you save the rc-files as iso-8859 or
utf (without BOM)?

Michael Fritscher

[Colin Finck]

Hi,

All the other RC files I found are saved with ANSI (ISO-8859-1) encoding.
Therefore we should save them all with this encoding.

If a RC file still uses another encoding than ANSI, this should be changed.

Best regards,

Colin
> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of Michael Fritscher
> Sent: Tuesday, July 10, 2007 11:07 PM
> To: ReactOS Development List
> Subject: Re: [ros-dev] Re : ReactOS doesn't compile well
> > You see the problem when opening it with a hexeditor:
> > the file begins with EF BB BF
> > when you remove it and reopen the file with windows
>
> notepad, it will be
> > put there again.
>
> This is the BOM of UTF-8...
> which bring me to the question: Do you save the rc-files as 
> iso-8859 or
> utf (without BOM)?
>
> Michael Fritscher
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Klemens Friedl]

> All the other RC files I found are saved with ANSI (ISO-8859-1) encoding.
> Therefore we should save them all with this encoding.
> If a RC file still uses another encoding than ANSI, this should be changed.

That's not reasonable, you would loose all Unicode characters except
Latin 1 ones. So please don't save as Latin 1 (aka ISO-8859-1) except
for special cases (languages like EN, DE, and other european
lnaguages).

Use UTF-8 or even more WinNT alike UTF-16. For eastern languages
UTF-16 is the prefered way, as UTF-8 would waste more space.

Unicode in Unix is rather a "new" thing, and to keep the apps code
almost the same, Unix coders choose UTF-8, where the first 128 bit are
the same as the ASCII charset. Although Unix apps with UTF-8 support
usually don't add the BOM as leading chars.

P.S.: we have several language files in ros that are stored with chars
encoded in one of the Unicode Transformation Formats.

[Colin Finck]

> That's not reasonable, you would loose all Unicode characters except
> Latin 1 ones. So please don't save as Latin 1 (aka ISO-8859-1) except
> for special cases (languages like EN, DE, and other european
> lnaguages).

We would first have to check if our resource compiler supports Unicode.

Also just take a look at the RC files in reactos/dll/win32/comdlg32. They
are all saved with Latin 1 encoding, even the ones in eastern languages such
as russian and chinese.
We imported them from Wine and it looks like there are no problems using
them.
I assume, this is done by using code pages.

I agree, that UTF-16 is probably the best solution for these problems, but
as long as there might be problems with the resource compiler, we shouldn't
change everything to UTF-16 now.

Best regards,

Colin

[Timo Kreuzer]

MinGW GNU windres 2.17.50 20060824 also doesn't work for me, so maybe it's a MinGW problem rather than a version problem

carlo.bramix schrieb:
> Hello,
> unfortunately, the problem really exists, since it seems that at least someone else saw the error when compiling.
> Hopefully, I discovered a solution.
> I changed windres.exe with another one.
> The one into RosBE 0.3.6 says:
>
> GNU windres (GNU Binutils) 2.17.50.20070608
> Copyright 2007 Free Software Foundation, Inc.
>
> The one into my MSYS installation says:
>
> GNU windres 2.17.50 20060824
> Copyright 2005 Free Software Foundation, Inc.
>
> I renamed windres.exe into c:\RosBE\4.1.3\bin and I copied the old one. And surprise, now it all works.
> Don't ask me why... at the moment I don't know the reason but this trick made it working.
>
> Sincerely,
>
> Carlo Bramini
>
> ---------- Initial Header -----------
> > From      : [e-mail]
>
> To          : "ReactOS Development List" [e-mail]
> Cc          : 
> Date      : Tue, 10 Jul 2007 19:01:28 +0200
> Subject : Re: [ros-dev] Re :  ReactOS doesn't compile well
> > Hi,
> >
> > I just tested building latest trunk under Windows and 32-bit Linux (both
> > with RosBE 0.3.6) and both builds resulted in correct ISOs.
> > Our BuildBot also has no such problems.
> >
> > I tested your examples "intl.cpl" and "sysdm.cpl" and both are shown in
> > english for me.
> > When I switch the locale to any german locale, I get german versions of
> > these apps, meaning that the whole localization thing works for me.
> >
> > Maybe you have to do a clean build.
> >
> > Best regards,
> >
> > Colin
> > > -----Original Message-----
> > > From: [e-mail] 
> > > [mailto:[e-mail]] On Behalf Of carlo.bramix
> > > Sent: Tuesday, July 10, 2007 5:25 PM
> > > To: ros-dev
> > > Subject: Re: [ros-dev] Re : ReactOS doesn't compile well
> > >
> > > Hello,
> > > yep, the errors don't interrupt the compilation of ReactOS.
> > > But the resources into those coffs seem corrupted to me.
> > > For example, if I open the control panel I will see inl.cpl 
> > > in german language(!) while all others are in english or if I 
> > > open the system applet I can see some text without sense.
> > >
> > > Sincerely,
> > >
> > > Carlo Bramini
> > >
> > > ---------- Initial Header -----------
> > > > From      : [e-mail]
> > >
> > > To          : "ReactOS Development List" [e-mail]
> > > Cc          : 
> > > Date      : Tue, 10 Jul 2007 15:07:58 +0000 (GMT)
> > > Subject : [ros-dev] Re :  ReactOS doesn't compile well
> > > > hi,
> > > > I got some of them but it didnt bother the build.
> > > >
> > > > Kind regards,
> > > > Sylvain Petreolle (aka Usurp)
> > > >
> > > > Run your favorite Windows apps with free ReactOS :
> > >
> > > http://www.reactos.org
> > > > Listen to non-DRMised Music: http://www.jamendo.com
> > > >
> > > > ----- Message d'origine ----
> > > > De : carlo.bramix [e-mail]
> > > > Ŕ : ros-dev [e-mail]
> > > > Envoyé le : Mardi, 10 Juillet 2007, 16h52mn 51s
> > > > Objet : Re: [ros-dev] ReactOS doesn't compile well
> > > >
> > > > Hello,
> > > > while regedit compilation was done successfully, some files
> > >
> > > aren't still generated correctly:
> > > > [WRC]      obj-i386\base\shell\cmd\cmd.coff
> > > > [WRC]      obj-i386\base\system\expand\expand.coff
> > > > [WRC]      obj-i386\dll\cpl\intl\intl.coff
> > > > [WRC]      obj-i386\dll\cpl\intl_new\intl.coff
> > > > [WRC]      obj-i386\dll\cpl\sysdm\sysdm.coff
> > > > [WRC]      obj-i386\dll\win32\comdlg32\rsrc.coff
> > > > [WRC]      obj-i386\dll\win32\hhctrl.ocx\hhctrl.coff
> > > > [WRC]      obj-i386\dll\win32\shdocvw\shdocvw.coff
> > > >
> > > > <built-in>:0: fatal error: when writing output to : Invalid argument
> > > > compilation terminated.
> > > >
> > > > I hope it could be fixed.
> > > >
> > > > Sincerely,
> > > >
> > > > Carlo Bramini
> > > >
> > > > ---------- Initial Header -----------
> > > > > From      : [e-mail]
> > > >
> > > > To          : "ros-dev" [e-mail]
> > > > Cc          : 
> > > > Date      : Mon,  9 Jul 2007 18:34:34 +0200
> > > > Subject : Re: [ros-dev] ReactOS doesn't compile well
> > > > > Hello,
> > > > > problem with compilation of regedit seems to be gone with
> > >
> > > revision 27541.
> > > > > Sincerely,
> > > > >
> > > > > Carlo Bramini
> > > > >
> > > > > ---------- Initial Header -----------
> > > > > > From      : [e-mail]
> > > > >
> > > > > To          : "ros-dev" [e-mail]
> > > > > Cc          : 
> > > > > Date      : Mon,  9 Jul 2007 11:24:29 +0200
> > > > > Subject : [ros-dev] ReactOS doesn't compile well
> > > > > > Hello,
> > > > > > it looks like something wrong happens when I compile ReactOS.
> > > > > > I also did a complete clean and a make for a total
> > >
> > > rebuild, but I'm still having problems.
> > > > > > I saw the first problem when I tried to test Regedit
> > >
> > > after committed changes.
> > > > > > The tree window and the listview window aren't visible
> > >
> > > (or they aren't created successfully, I didn't check this yet).
> > > > > > I tested that executable into WinXP and those child
> > >
> > > windows aren't visible too.
> > > > > > So I did these steps:
> > > > > > I compiled Regedit with Visual C and I verified that
> > >
> > > it worked fine.
> > > > > > I grabbed regedit.res and I manually generated
> > >
> > > regedit.coff with "windres -i regedit.res -o regedit.coff".
> > > > > > I launched "make" again and it regenerated regedit.exe.
> > > > > >
> > > > > > This last regedit.exe works fine and it has all child
> > >
> > > window controls visible. It's really a problem when 
> > > generating te coff file from resources.
> > > > > > I also saw a possible second problem when compiling.
> > > > > > Some compilation of '.coff' files failed.
> > > > > > On the console I read some messages like this one:
> > > > > >
> > > > > > [WRC]      obj-i386\dll\win32\comdlg32\rsrc.coff
> > > > > > <built-in>:0: fatal error: when writing output to :
> > >
> > > Invalid argument
> > > > > > compilation terminated.
> > > > > >
> > > > > > Actually I'm using RosBE 0.3.6 but I never got such
> > >
> > > problems with previouses svn versions of the sources.
> > > > > > Sincerely,
> > > > > >
> > > > > > Carlo Bramini
> > > > > >
> > > > > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind
> > > > > > http://i-mode.wind.it/
> > > > > >
> > > > > > Ros-dev mailing list
> > > > > > [e-mail]
> > > > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > > > >
> > > > > Leggi GRATIS le tue mail con il telefonino i-modeTM di Wind
> > > > > http://i-mode.wind.it/
> > > > >
> > > > > Ros-dev mailing list
> > > > > [e-mail]
> > > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > > >
> > > > Scegli infostrada: ADSL gratis per tutta l´estate e
> > >
> > > telefoni senza canone Telecom
> > > > http://click.libero.it/infostrada
> > > >
> > > > Ros-dev mailing list
> > > > [e-mail]
> > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > > >
> > > > Ros-dev mailing list
> > > > [e-mail]
> > > > http://www.reactos.org/mailman/listinfo/ros-dev
> > >
> > > Scegli infostrada: ADSL gratis per tutta l’estate e telefoni 
> > > senza canone Telecom
> > > http://click.libero.it/infostrada
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Scegli infostrada: ADSL gratis per tutta l’estate e telefoni senza canone Telecom
> http://click.libero.it/infostrada
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev