Re: [ros-dev] [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call to kernel space

[Alex Ionescu]

I totally disagree with this commit.
Best regards,
Alex Ionescu

On Fri, Jan 9, 2009 at 6:33 AM, [e-mail] wrote:
> Author: dchapyshev
> Date: Fri Jan  9 05:33:50 2009
> New Revision: 38663
>
> URL: http://svn.reactos.org/svn/reactos?rev=38663&view=rev
> Log:
> Cleanup user32, direct call to kernel space
>
> Modified:
>    trunk/reactos/dll/win32/user32/controls/button.c
>    trunk/reactos/dll/win32/user32/controls/combo.c
>    trunk/reactos/dll/win32/user32/controls/edit.c
>    trunk/reactos/dll/win32/user32/controls/icontitle.c
>    trunk/reactos/dll/win32/user32/controls/listbox.c
>    trunk/reactos/dll/win32/user32/controls/scrollbar.c
>    trunk/reactos/dll/win32/user32/controls/static.c
>    trunk/reactos/dll/win32/user32/misc/dde.c
>    trunk/reactos/dll/win32/user32/misc/ddeserver.c
>    trunk/reactos/dll/win32/user32/misc/desktop.c
>    trunk/reactos/dll/win32/user32/misc/misc.c
>    trunk/reactos/dll/win32/user32/misc/object.c
>    trunk/reactos/dll/win32/user32/misc/stubs.c
>    trunk/reactos/dll/win32/user32/misc/timer.c
>    trunk/reactos/dll/win32/user32/misc/winsta.c
>    trunk/reactos/dll/win32/user32/user32.def
>    trunk/reactos/dll/win32/user32/windows/accel.c
>    trunk/reactos/dll/win32/user32/windows/bitmap.c
>    trunk/reactos/dll/win32/user32/windows/caret.c
>    trunk/reactos/dll/win32/user32/windows/clipboard.c
>    trunk/reactos/dll/win32/user32/windows/cursor.c
>    trunk/reactos/dll/win32/user32/windows/dc.c
>    trunk/reactos/dll/win32/user32/windows/defwnd.c
>    trunk/reactos/dll/win32/user32/windows/dialog.c
>    trunk/reactos/dll/win32/user32/windows/draw.c
>    trunk/reactos/dll/win32/user32/windows/input.c
>    trunk/reactos/dll/win32/user32/windows/mdi.c
>    trunk/reactos/dll/win32/user32/windows/menu.c
>    trunk/reactos/dll/win32/user32/windows/message.c
>    trunk/reactos/dll/win32/user32/windows/messagebox.c
>    trunk/reactos/dll/win32/user32/windows/nonclient.c
>    trunk/reactos/dll/win32/user32/windows/paint.c
>    trunk/reactos/dll/win32/user32/windows/window.c
>    trunk/reactos/dll/win32/user32/windows/winpos.c
>
> [This mail would be too long, it was shortened to contain the URLs only.]
>
> Modified: trunk/reactos/dll/win32/user32/controls/button.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/b...
>
> Modified: trunk/reactos/dll/win32/user32/controls/combo.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/c...
>
> Modified: trunk/reactos/dll/win32/user32/controls/edit.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/e...
>
> Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/i...
>
> Modified: trunk/reactos/dll/win32/user32/controls/listbox.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/l...
>
> Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s...
>
> Modified: trunk/reactos/dll/win32/user32/controls/static.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s...
>
> Modified: trunk/reactos/dll/win32/user32/misc/dde.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.c...
>
> Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddese...
>
> Modified: trunk/reactos/dll/win32/user32/misc/desktop.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/deskt...
>
> Modified: trunk/reactos/dll/win32/user32/misc/misc.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc....
>
> Modified: trunk/reactos/dll/win32/user32/misc/object.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/objec...
>
> Modified: trunk/reactos/dll/win32/user32/misc/stubs.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stubs...
>
> Modified: trunk/reactos/dll/win32/user32/misc/timer.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/timer...
>
> Modified: trunk/reactos/dll/win32/user32/misc/winsta.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/winst...
>
> Modified: trunk/reactos/dll/win32/user32/user32.def
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.def...
>
> Modified: trunk/reactos/dll/win32/user32/windows/accel.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ac...
>
> Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/bi...
>
> Modified: trunk/reactos/dll/win32/user32/windows/caret.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ca...
>
> Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cl...
>
> Modified: trunk/reactos/dll/win32/user32/windows/cursor.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cu...
>
> Modified: trunk/reactos/dll/win32/user32/windows/dc.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dc...
>
> Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/de...
>
> Modified: trunk/reactos/dll/win32/user32/windows/dialog.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/di...
>
> Modified: trunk/reactos/dll/win32/user32/windows/draw.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dr...
>
> Modified: trunk/reactos/dll/win32/user32/windows/input.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/in...
>
> Modified: trunk/reactos/dll/win32/user32/windows/mdi.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/md...
>
> Modified: trunk/reactos/dll/win32/user32/windows/menu.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me...
>
> Modified: trunk/reactos/dll/win32/user32/windows/message.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me...
>
> Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me...
>
> Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/no...
>
> Modified: trunk/reactos/dll/win32/user32/windows/paint.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/pa...
>
> Modified: trunk/reactos/dll/win32/user32/windows/window.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi...
>
> Modified: trunk/reactos/dll/win32/user32/windows/winpos.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi...

[Ged]

Lol, I've been through this with Aleksey about 30 minutes ago  ;)

Ged.

From: [e-mail] [mailto:[e-mail]]
On Behalf Of Alex Ionescu
Sent: 09 January 2009 14:18
To: [e-mail]
Cc: [e-mail]
Subject: Re: [ros-diffs] [dchapyshev] 38663: - Cleanup user32, direct call
to kernel space

I totally disagree with this commit.

Best regards,
Alex Ionescu

On Fri, Jan 9, 2009 at 6:33 AM, [e-mail] wrote:

Author: dchapyshev
Date: Fri Jan  9 05:33:50 2009
New Revision: 38663

URL: http://svn.reactos.org/svn/reactos?rev=38663
http://svn.reactos.org/svn/reactos?rev=38663&view=rev &view=rev
Log:
- Cleanup user32, direct call to kernel space

Modified:
   trunk/reactos/dll/win32/user32/controls/button.c
   trunk/reactos/dll/win32/user32/controls/combo.c
   trunk/reactos/dll/win32/user32/controls/edit.c
   trunk/reactos/dll/win32/user32/controls/icontitle.c
   trunk/reactos/dll/win32/user32/controls/listbox.c
   trunk/reactos/dll/win32/user32/controls/scrollbar.c
   trunk/reactos/dll/win32/user32/controls/static.c
   trunk/reactos/dll/win32/user32/misc/dde.c
   trunk/reactos/dll/win32/user32/misc/ddeserver.c
   trunk/reactos/dll/win32/user32/misc/desktop.c
   trunk/reactos/dll/win32/user32/misc/misc.c
   trunk/reactos/dll/win32/user32/misc/object.c
   trunk/reactos/dll/win32/user32/misc/stubs.c
   trunk/reactos/dll/win32/user32/misc/timer.c
   trunk/reactos/dll/win32/user32/misc/winsta.c
   trunk/reactos/dll/win32/user32/user32.def
   trunk/reactos/dll/win32/user32/windows/accel.c
   trunk/reactos/dll/win32/user32/windows/bitmap.c
   trunk/reactos/dll/win32/user32/windows/caret.c
   trunk/reactos/dll/win32/user32/windows/clipboard.c
   trunk/reactos/dll/win32/user32/windows/cursor.c
   trunk/reactos/dll/win32/user32/windows/dc.c
   trunk/reactos/dll/win32/user32/windows/defwnd.c
   trunk/reactos/dll/win32/user32/windows/dialog.c
   trunk/reactos/dll/win32/user32/windows/draw.c
   trunk/reactos/dll/win32/user32/windows/input.c
   trunk/reactos/dll/win32/user32/windows/mdi.c
   trunk/reactos/dll/win32/user32/windows/menu.c
   trunk/reactos/dll/win32/user32/windows/message.c
   trunk/reactos/dll/win32/user32/windows/messagebox.c
   trunk/reactos/dll/win32/user32/windows/nonclient.c
   trunk/reactos/dll/win32/user32/windows/paint.c
   trunk/reactos/dll/win32/user32/windows/window.c
   trunk/reactos/dll/win32/user32/windows/winpos.c

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/user32/controls/button.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/b
utton.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
button.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/combo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/c
ombo.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
combo.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/edit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/e
dit.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
edit.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/icontitle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/i
contitle.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
icontitle.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/listbox.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/l
istbox.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
listbox.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/scrollbar.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s
crollbar.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
scrollbar.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/controls/static.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/s
tatic.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/
static.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/dde.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.c
?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dde.
c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/ddeserver.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddese
rver.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/ddes
erver.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/desktop.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/deskt
op.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/desk
top.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/misc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc.
c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/misc
.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/object.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/objec
t.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/obje
ct.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/stubs.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stubs
.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/stub
s.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/timer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/timer
.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/time
r.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/misc/winsta.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/winst
a.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/wins
ta.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/user32.def
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.def
?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/user32.de
f?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/accel.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ac
cel.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/a
ccel.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/bi
tmap.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/b
itmap.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/caret.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/ca
ret.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
aret.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/clipboard.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cl
ipboard.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
lipboard.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/cursor.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/cu
rsor.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c
ursor.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dc
.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
c.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/de
fwnd.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
efwnd.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/dialog.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/di
alog.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
ialog.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/draw.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/dr
aw.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d
raw.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/input.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/in
put.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/i
nput.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/mdi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/md
i.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
di.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/menu.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
nu.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
enu.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/message.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
ssage.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
essage.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/messagebox.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/me
ssagebox.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m
essagebox.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/nonclient.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/no
nclient.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/n
onclient.c?rev=38663&r1=38662&r2=38663&view=diff
&r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/paint.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/pa
int.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/p
aint.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/window.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi
ndow.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w
indow.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

Modified: trunk/reactos/dll/win32/user32/windows/winpos.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/wi
npos.c?rev=38663
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w
inpos.c?rev=38663&r1=38662&r2=38663&view=diff &r1=38662&r2=38663&view=diff

[Aleksey Bragin]

It was not confirmed with me or anyone from Win32k team, however  
after talking with Dmitry it looks like there is nothing bad in it.  
All those substituted functions are direct forwarders to win32k both  
in ReactOS and in Windows.

If James or Timo object, feel free to revert.

WBR,
Aleksey.

On Jan 9, 2009, at 5:49 PM, Ged wrote:
> Lol, I’ve been through this with Aleksey about 30 minutes ago  ;)
>
> Ged.

[Alex Ionescu]

The Windows binaries don't have this behavior, why should ReactOS?
The NtUser/Gdi layer should be internal, not called from these sorts of
functions -- it violates principles of private vs public methods... I know
the code isn't OOP but Nt still has strong OOP design principles at its
core.

The code in the libraries should, as much as possible, be Win32 code, not
Native API -- ESPECIALLY in the case of NtUser/Gdi.

It also makes the binaries MUCH harder to test on Windows, as the NtUser/Gdi
layer in ReactOS Isn't yet compatible with Windows...so functions would take
different parameters, maybe even have different names.

Best regards,
Alex Ionescu

2009/1/9 Aleksey Bragin [e-mail]
> It was not confirmed with me or anyone from Win32k team, however after
> talking with Dmitry it looks like there is nothing bad in it. All those
> substituted functions are direct forwarders to win32k both in ReactOS and in
> Windows.
> If James or Timo object, feel free to revert.
>
> WBR,
> Aleksey.
>
> On Jan 9, 2009, at 5:49 PM, Ged wrote:
>
> Lol, I've been through this with Aleksey about 30 minutes ago  ;)
>
> Ged.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Aleksey Bragin]

Please come to a decision. As for my own opinion, there is no need in  
#defines, because those functions are most probably inlined by the  
compiler anyway (they are forwarders).

On Jan 9, 2009, at 6:26 PM, Alex Ionescu wrote:
> The Windows binaries don't have this behavior, why should ReactOS?
>
> The NtUser/Gdi layer should be internal, not called from these  
> sorts of functions -- it violates principles of private vs public  
> methods... I know the code isn't OOP but Nt still has strong OOP  
> design principles at its core.
>
> The code in the libraries should, as much as possible, be Win32  
> code, not Native API -- ESPECIALLY in the case of NtUser/Gdi.
>
> It also makes the binaries MUCH harder to test on Windows, as the  
> NtUser/Gdi layer in ReactOS Isn't yet compatible with Windows...so  
> functions would take different parameters, maybe even have  
> different names.
>
> Best regards,
> Alex Ionescu
>
> 2009/1/9 Aleksey Bragin [e-mail]
> It was not confirmed with me or anyone from Win32k team, however  
> after talking with Dmitry it looks like there is nothing bad in it.  
> All those substituted functions are direct forwarders to win32k  
> both in ReactOS and in Windows.
>
> If James or Timo object, feel free to revert.
>
> WBR,
> Aleksey.
>
> On Jan 9, 2009, at 5:49 PM, Ged wrote:
> > Lol, I've been through this with Aleksey about 30 minutes ago  ;)
> >
> > Ged.

[Steven Edwards]

2009/1/9 Aleksey Bragin [e-mail]:
> Please come to a decision. As for my own opinion, there is no need in
> #defines, because those functions are most probably inlined by the compiler
> anyway (they are forwarders).

I was going to comment on the commit too, at least the parts that
touch Wine code because it will make diffs harder. I didn't comment
because I don't contribute much these days but I think its a bad idea.
Maybe the inline functions are the right way to go. In anycase, I
suggest removing the changes for the Wine code at least just to save
trouble on doing the diffs.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Timo Kreuzer]

Aleksey Bragin schrieb:
> Please come to a decision. As for my own opinion, there is no need in
> #defines, because those functions are most probably inlined by the
> compiler anyway (they are forwarders).

The compiler knows nothing about the def file. And the linker linker
doesn't link to it's own exports. If you reference Foo() in your code,
but only implement NtFoo() and the def file forwards the export Foo to
NtFoo, it won't link.

So let's add inline functions.

If noone wants to I volunteer to do this job.

Timo

[Thomas Bluemel]

I also oppose this commit. I like Timo's suggesting of using inline 
functions (not #define). This would ease porting WINE code and would 
provide all the benefits Alex outlined.

Thomas

Aleksey Bragin wrote:
> Please come to a decision. As for my own opinion, there is no need in 
> #defines, because those functions are most probably inlined by the 
> compiler anyway (they are forwarders).
>
> On Jan 9, 2009, at 6:26 PM, Alex Ionescu wrote:
> > The Windows binaries don't have this behavior, why should ReactOS?
> >
> > The NtUser/Gdi layer should be internal, not called from these sorts 
> > of functions -- it violates principles of private vs public 
> > methods... I know the code isn't OOP but Nt still has strong OOP 
> > design principles at its core.
> >
> > The code in the libraries should, as much as possible, be Win32 code, 
> > not Native API -- ESPECIALLY in the case of NtUser/Gdi.
> >
> > It also makes the binaries MUCH harder to test on Windows, as the 
> > NtUser/Gdi layer in ReactOS Isn't yet compatible with Windows...so 
> > functions would take different parameters, maybe even have different 
> > names.
> >
> > Best regards,
> > Alex Ionescu
> >
> > 2009/1/9 Aleksey Bragin <[e-mail] 
> > mailto:[e-mail]>
> > It was not confirmed with me or anyone from Win32k team, however
> > after talking with Dmitry it looks like there is nothing bad in
> > it. All those substituted functions are direct forwarders to
> > win32k both in ReactOS and in Windows.
> >
> > If James or Timo object, feel free to revert.
> >
> > WBR,
> > Aleksey.
> >
> >
> > On Jan 9, 2009, at 5:49 PM, Ged wrote:
> >
> > > Lol, I've been through this with Aleksey about 30 minutes ago  ;)
> > >
> > >
> > >
> > > Ged.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[James Tabor]

Hi,
Just place the defines in user32p.h. It should not be hard to do, just
read the patch related to this, and add them.
James

On Fri, Jan 9, 2009 at 7:11 PM, Thomas Bluemel [e-mail] wrote:
> I also oppose this commit. I like Timo's suggesting of using inline
> functions (not #define). This would ease porting WINE code and would
> provide all the benefits Alex outlined.
>
> Thomas

[Timo Kreuzer]

I have added the inlines. For the rest I'm just waiting for an ok from
dchapichev, cause it would revert part of his commit.

James Tabor schrieb:
> Hi,
> Just place the defines in user32p.h. It should not be hard to do, just
> read the patch related to this, and add them.
> James
>
> On Fri, Jan 9, 2009 at 7:11 PM, Thomas Bluemel [e-mail] wrote:
> > I also oppose this commit. I like Timo's suggesting of using inline
> > functions (not #define). This would ease porting WINE code and would
> > provide all the benefits Alex outlined.
> >
> > Thomas
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[James Tabor]

Hi!

The changes are correct, most of those are direct calls. Saved me
weeks of work! Thanks goes out to Dmitry aka Lentin, good job!

Thanks,
James

2009/1/9 Aleksey Bragin [e-mail]:
> It was not confirmed with me or anyone from Win32k team, however after
> talking with Dmitry it looks like there is nothing bad in it. All those
> substituted functions are direct forwarders to win32k both in ReactOS and in
> Windows.
> If James or Timo object, feel free to revert.
> WBR,
> Aleksey.

[Timo Kreuzer]

Sigh, again one of Alex' I-have-no-time-guess-what-I-mean comments.
Does this commit hurt your religious feelings?
If you have reasons, tell us, if not ...

Here's my point:
I do agree with this commit partly. But as we share some code with wine,
I'd suggest adding inline definitions rather than using Nt functions
directly.

Thanks,
Timo

Alex Ionescu schrieb:
> I totally disagree with this commit.
> Best regards,
> Alex Ionescu
>
> On Fri, Jan 9, 2009 at 6:33 AM, [e-mail] wrote: