Re: [ros-dev] [ros-diffs] [tkreuzer] 64757: [NTOSKRNL] Don't use an uninitialized variable in MmArmAccessFault (Alex, please review). Brought to you by MSVC runtime checks.

[Alex Ionescu]

Wow, does static analyzer really not catch this?

Best regards,
Alex Ionescu

On Wed, Oct 15, 2014 at 3:03 PM, <tkreuzer(a)svn.reactos.org> wrote:

>   Author: tkreuzer
>  Date: Wed Oct 15 22:03:50 2014
>  New Revision: 64757
>
>  URL: http://svn.reactos.org/svn/reactos?rev=64757&view=rev
>  Log:
>  [NTOSKRNL]
>  Don't use an uninitialized variable in MmArmAccessFault (Alex, please
>  review). Brought to you by MSVC runtime checks.
>
>  Modified:
>      trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c
>
>  Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c
>  URL:
>
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.…
>
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c   [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c   [iso-8859-1] Wed Oct 15
>  22:03:50 2014
>  @@ -1511,7 +1511,7 @@
>       NTSTATUS Status;
>       PMMSUPPORT WorkingSet;
>       ULONG ProtectionCode;
>  -    PMMVAD Vad;
>  +    PMMVAD Vad = NULL;
>       PFN_NUMBER PageFrameIndex;
>       ULONG Color;
>       BOOLEAN IsSessionAddress;
>
>
>

[Timo Kreuzer]

No. Not even coverity seems to have caught this.

Am 16.10.2014 07:59, schrieb Alex Ionescu:
>   Wow, does static analyzer really not catch this?
>
>  Best regards,
>  Alex Ionescu
>
>  On Wed, Oct 15, 2014 at 3:03 PM, <tkreuzer(a)svn.reactos.org 
>  <mailto:[e-mail]>> wrote:
>
>      Author: tkreuzer
>      Date: Wed Oct 15 22:03:50 2014
>      New Revision: 64757
>
>      URL: http://svn.reactos.org/svn/reactos?rev=64757&view=rev
>      Log:
>      [NTOSKRNL]
>      Don't use an uninitialized variable in MmArmAccessFault (Alex,
>      please review). Brought to you by MSVC runtime checks.
>
>      Modified:
>          trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c
>
>      Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c
>      URL:
>     
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.…
>      ==============================================================================
>      --- trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c   [iso-8859-1]
>      (original)
>      +++ trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c   [iso-8859-1] Wed
>      Oct 15 22:03:50 2014
>      @@ -1511,7 +1511,7 @@
>           NTSTATUS Status;
>           PMMSUPPORT WorkingSet;
>           ULONG ProtectionCode;
>      -    PMMVAD Vad;
>      +    PMMVAD Vad = NULL;
>           PFN_NUMBER PageFrameIndex;
>           ULONG Color;
>           BOOLEAN IsSessionAddress;
>
>
>
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev