Ros-dev February 2005

ros-dev@reactos.org

42 participants
88 discussions

__attribute__((weak)) - in mingw
by Boaz Harrosh 14 Feb '05

14 Feb '05

Hi List I'm finally on my ass trying to redo the ATL/MFC Job from a year ago. This time I decided to start on windows with MinGW than move the MinGW makefiles to be used with winegcc. It is a grate test for winegcc and the windows API in general. Well it turns out to be a very big test for MinGW as well. The headers are in a very bad shape. I had to use Wine headers to be able to compile. but I'll leave all that to a later e-mail. [Q] I'm (well ATL is) using __attribute__((weak)) (translated from __declspec( selectany) ) for instantiation of members and variables in headers. I had no problem with it On GCC in Linux (gcc 3.2.2). On MinGW I get below warning. And needless to say that I get a Linker duplicate symbol Error. Any Ideas on how to overcome this. Is this a g++ only bug? <g++ warning example> H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlhost.h:56: warning: weak declaration of `UINT ATL::WM_ATLGETCONTROL' not supported </g++ warrning example> <linker error example> H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlwin.h: multiple definition of `ATL::WM_ATLGETCONTROL' H:\Dinosaur\OneSource\MinGWStudio\Samples\AtlWB\Debug\aboutdlg.o(.bss+0x1c):H:\Dinosaur\OneSource\MinGWStudio\msvc\atl\include\atlwin.h: first defined here </linker error example> Please forgive me for sending it here and not to MinGW list. But I feel more at home here than there. ( :( ) Free Life Boaz

3 2

creating a branch
by Hartmut Birr 13 Feb '05

13 Feb '05

Hi, I would like to create a branch in our repository. I'm not sure what I have to do exactly. Is the following command correct? svn copy http://svn.reactos.com/trunk/reactos http://svn.reactos.com/branches/cache_manager_rewrite/reactos - Hartmut

3 8

Re: [ros-svn] [gvg] 13518: Sync to Wine-20050211
by Steven Edwards 13 Feb '05

13 Feb '05

--- gvg(a)svn.reactos.com wrote: > Sync to Wine-20050211 > - add support for Edit boxes in MSI dialogs ..... Just a short note. With this patch most installars using MSI might be able start on ReactOS but there seems to be some sort of communication issue when they try to tell services to load msiexec. I added a Windows Installer service here in my tree but still have not had much luck. If someone wants to sync msiexec.exe with winehq and have a look we can then see how far iTunes and Office will get. Thanks Steven __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

2 3

Re: [ros-svn] [gvg] 13518: Sync to Wine-20050211
by James Tabor 13 Feb '05

13 Feb '05

Hi! There are CR's in the files! James gvg(a)svn.reactos.com wrote: > Sync to Wine-20050211 snip.. > > > > Added files: > trunk/reactos/include/wine/msidefs.h > trunk/reactos/lib/msi/action.h > trunk/reactos/lib/msi/appsearch.c > trunk/reactos/lib/msi/custom.c > trunk/reactos/lib/msi/dialog.c > trunk/reactos/lib/msi/format.c > trunk/reactos/lib/msi/msi.rc > trunk/reactos/lib/msi/msi_En.rc > trunk/reactos/lib/msi/preview.c > trunk/reactos/lib/msi/registry.c > > Updated files: > trunk/reactos/include/wine/msi.h > trunk/reactos/lib/msi/Makefile.in > trunk/reactos/lib/msi/action.c > trunk/reactos/lib/msi/cond.tab.c > trunk/reactos/lib/msi/cond.tab.h > trunk/reactos/lib/msi/cond.y > trunk/reactos/lib/msi/create.c > trunk/reactos/lib/msi/distinct.c > trunk/reactos/lib/msi/handle.c > trunk/reactos/lib/msi/insert.c > trunk/reactos/lib/msi/msi.c > trunk/reactos/lib/msi/msi.spec > trunk/reactos/lib/msi/msipriv.h > trunk/reactos/lib/msi/msiquery.c > trunk/reactos/lib/msi/order.c > trunk/reactos/lib/msi/package.c > trunk/reactos/lib/msi/record.c > trunk/reactos/lib/msi/select.c > trunk/reactos/lib/msi/sql.tab.c > trunk/reactos/lib/msi/sql.y > trunk/reactos/lib/msi/string.c > trunk/reactos/lib/msi/suminfo.c > trunk/reactos/lib/msi/table.c > trunk/reactos/lib/msi/update.c > trunk/reactos/lib/msi/where.c >

1 0

Re: [ros-svn] [weiden] 13502: The structure layout of self-relative security descriptors may be different from absolute security descriptors depending on the platform. Self-relative security descriptors always use 32 bit offsets while absolute security descriptors use pointers which could be 64 bits.
by Alex Ionescu 12 Feb '05

12 Feb '05

weiden(a)svn.reactos.com wrote: >The structure layout of self-relative security descriptors may be different from absolute security descriptors depending on the platform. Self-relative security descriptors always use 32 bit offsets while absolute security descriptors use pointers which could be 64 bits. > > >Updated files: >trunk/reactos/include/ntos/rtl.h >trunk/reactos/include/ntos/security.h >trunk/reactos/lib/advapi32/sec/sec.c >trunk/reactos/lib/rtl/sd.c >trunk/reactos/ntoskrnl/se/sd.c >trunk/reactos/w32api/include/ddk/ntifs.h >trunk/reactos/w32api/include/ddk/winddk.h >trunk/reactos/w32api/include/winnt.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.com >http://reactos.com:8080/mailman/listinfo/ros-svn > > > Well after arguing with me on IRC I'm happy to see that you finally realized I was right. Best regards, Alex Ionescu

2 1

Freeldy & NTVDMPAT/Deptool
by Alex Ionescu 12 Feb '05

12 Feb '05

Hi, First of all, what's up with ntvdmpath in the freeloader tree? I fail to see what it has to do with ROS, much less with freeloader...I'm recommending removal. Secondly... is there any problem with freeloader using the ros depends tool instead of deptool? I know before this was necessary because of different trees, but I would like to share as much as possible. Best regards, Alex Ionescu

2 1

Re: [ros-svn] [arty] 13483: Patch to fix NtCreateSempahore, in the case where the initial lookup
by Thomas Weidenmueller 10 Feb '05

10 Feb '05

arty(a)svn.reactos.com wrote: >Patch to fix NtCreateSempahore, in the case where the initial lookup >succeeds. We previously left the function without initializing >hSemaphore. Patch suggested by me and executed by hpoussin. > > To me it looks totally wrong. First of all, the handle in my tests is never written if the function fails (just create a testcase where your application tries to create thousands of semaphore objects to reproduce it). Second of all you initialize the semaphore object only if creating it failed, as in you initialize a semaphore object on a NULL pointer. Third of all you insert a handle to the object no matter if you previously could create it, so you would end up creating a handle to a null-pointer. The previous version I wrote just had one small bug, it checked if ObCreateObject failed to continue initialization and handle creation instead of checking if it succeeded. I'm going to revert this version of NtCreateSemaphore as it introduces even more bugs and adds behavior neither documented nor reproducable. I guess in case an application failed due to this function it was because of the fact that the function succeeded and didn't return a handle to a semaphore object even though one was created. Best Regards Thomas

2 1

vncviewer is oh so close
by art yerkes 10 Feb '05

10 Feb '05

The good news is that vncviewer is oh so close to running. If you apply this patch it *does* run, but I think the patch is wrong. Hopefully, after illustrating a wrong solution somebody might be able to see a right one. The problem it runs into is that the 2nd 'Alertability failed' message in KeWaitForMultipleObjects is always triggered, which makes vncviewer unable to display anything. If i #if 0 that block out, then it appears to work fine. I suspected that either we were being too conservative or there are too many APCs happening on that thread, and this confirms that one of the suspicions is true. The attached patch illustrates the probably broken solution. Screen: http://64.81.145.152/~arty/vncviewer2.jpg -- Here's a simple experiment. Stand on a train track between two locomotives which are pushing on you with equal force in opposite directions. You will exhibit no net motion. None the less, you may soon begin to notice that something important is happening. -- Robert Stirniman

1 0

Re: [ros-svn] [gvg] 13476: Fix EOL setting
by Martin Fuchs 09 Feb '05

09 Feb '05

Hi, did you know it is possible to configure Subversion, such that it automatically sets the correct properties for new checked in files? It looks at the file extensions to set properties such as the EOL style, mime type and to configure keyword expansion strings. For Windows the settings are stored in the registry, and for Unix they are stored in the file ~/.subversion/config. I attached a registry import file as an example, which contains settings I am using myself. Regards, Martin

2 1

RE: [weiden] 13459: moved smdll to rosrtl. We just _can't_have separate dlls for everything internal, that's what static libraries are for. Unless we want a dll hell evenworse than necessary...
by Ge van Geldorp 08 Feb '05

08 Feb '05

> From: weiden(a)svn.reactos.com > > moved smdll to rosrtl. We just _can't_ have separate dlls for > everything internal, that's what static libraries are for. > Unless we want a dll hell even worse than necessary... I think you are acting unbelievably rude here. Please revert your change and discuss this on the mailinglist first. Gé van Geldorp.

5 4

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2005