Ros-dev December 2008

ros-dev@reactos.org

29 participants
44 discussions

[ros-diffs] [dgorbachev] 38083: - Use HEAP_ZERO_MEMORY instead of memset(). - Do not crash if no adapter found.
by Dmitry Gorbachev 15 Dec '08

15 Dec '08

Hi, Alex Ionescu wrote: > You should always use memset and void HEAP_ZERO_MEMORY. Could you please tell why HEAP_ZERO_MEMORY should not be used? It is used in many places, so if something wrong with RtlAllocateHeap, maybe better to fix it? Thanks, Dmitry

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 38083: - Use HEAP_ZERO_MEMORY instead of memset(). - Do not crash if no adapter found.
by Alex Ionescu 14 Dec '08

14 Dec '08

You should always use memset and void HEAP_ZERO_MEMORY. On 14-Dec-08, at 3:45 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Sun Dec 14 14:45:16 2008 > New Revision: 38083 > > URL: http://svn.reactos.org/svn/reactos?rev=38083&view=rev > Log: > - Use HEAP_ZERO_MEMORY instead of memset(). > - Do not crash if no adapter found. > > Modified: > trunk/reactos/dll/cpl/desk/desk.c > trunk/reactos/dll/cpl/desk/settings.c > > Modified: trunk/reactos/dll/cpl/desk/desk.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/desk.c?rev=38… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/cpl/desk/desk.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/desk.c [iso-8859-1] Sun Dec 14 > 14:45:16 2008 > @@ -162,7 +162,7 @@ > InitPropSheetPage(&psh, PropPages[i].idDlg, > PropPages[i].DlgProc, PropPages[i].Callback); > } > > - /* NOTE: Don;t call SHAddFromPropSheetExtArray here because > this applet only allows > + /* NOTE: Don't call SHAddFromPropSheetExtArray here because > this applet only allows > replacing the background page but not extending the > applet by more pages */ > > ret = (LONG)(PropertySheet(&psh) != -1); > > Modified: trunk/reactos/dll/cpl/desk/settings.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/settings.c?re… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/dll/cpl/desk/settings.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/settings.c [iso-8859-1] Sun Dec 14 > 14:45:16 2008 > @@ -151,8 +151,7 @@ > DWORD ResolutionsCount = 1; > DWORD i; > > - newEntry = HeapAlloc(GetProcessHeap(), 0, > sizeof(DISPLAY_DEVICE_ENTRY)); > - memset(newEntry, 0, sizeof(DISPLAY_DEVICE_ENTRY)); > + newEntry = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(DISPLAY_DEVICE_ENTRY)); > if (!newEntry) goto ByeBye; > > newEntry->Settings = GetPossibleSettings(DisplayDevice->DeviceName, > &newEntry->SettingsCount, &newEntry->CurrentSettings); > @@ -311,6 +310,7 @@ > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_RESOLUTION), FALSE); > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_RESOLUTION_TEXT), > FALSE); > EnableWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_ADVANCED), FALSE); > + ShowWindow(GetDlgItem(hwndDlg, IDC_SETTINGS_SPECTRUM), SW_HIDE); > } > else if (Result == 1) > { > Best regards, Alex Ionescu

1 0

Type definition in NDK
by Dmitry Gorbachev 12 Dec '08

12 Dec '08

May I know from where comes NLS_FILE_HEADER structure definition in include/ndk/rtltypes.h ? I think it is not correct.

1 0

why IOCTL_DISK_GET_DRIVE_GEOMETRY_EX failed in windows 2000?
by Jack Yi 10 Dec '08

10 Dec '08

hi,guys: I don't know if it is proper to ask such a question here. I'm sorry if I break some rules. why IOCTL_DISK_GET_DRIVE_GEOMETRY_EX fail in windows 2000 and succeed in windows xp and greater version? or how can I get a disk(whatever,ATA,SCSI,USB )'s real size(including additional sectors) in a easy way in windows 2000, just like there is such a function, __int 64GetDiskRealSize(HANDLE hDisk); Could anybody help me? Waiting for reply. Thank you!

4 6

Re: [ros-dev] [ros-diffs] [cwittich] 37955: SeUnsolicitedInputPrivilege is obsolete - the LUID is used by SE_MACHINE_ACCOUNT_PRIVILEGE now
by Alex Ionescu 10 Dec '08

10 Dec '08

Hm? On 9-Dec-08, at 3:33 AM, cwittich(a)svn.reactos.org wrote: > - Luid->LowPart = Priv + 1; > + Luid->LowPart = Priv + 2; Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37952: - Add CP_UNIXCP for CP_ACP, this will help cross tests.
by Steven Edwards 09 Dec '08

09 Dec '08

On Tue, Dec 9, 2008 at 12:58 AM, <jimtabor(a)svn.reactos.org> wrote: > Author: jimtabor > Date: Mon Dec 8 23:58:23 2008 > New Revision: 37952 > > URL: http://svn.reactos.org/svn/reactos?rev=37952&view=rev > Log: > - Add CP_UNIXCP for CP_ACP, this will help cross tests. > > Added: > trunk/reactos/include/reactos/wine/winnls.h (with props) > +#ifndef __WINE_WINNLS_H > +#define __WINE_WINNLS_H > + > +#define CP_UNIXCP CP_ACP Rather than keep the include_next brokeness, perhaps we should add the define to wine/port.h and include that in any offending source file. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

compatibility vs. correctness
by Matthias Kupfer 09 Dec '08

09 Dec '08

Hi folks, yesterday a user shows me a program what is working properly under windows, but not working under reactos. It was an open source program and it was easy to figure out the problem. It was an invalid win-api-call (wrong parameter value). Due to this situation I would like to ask one question. How compatible reactos should be? Even fault compatible? Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

11 12

compatibility vs. correctness
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

I believe that people wish "perfect world" API as an optional feature, not that they really want to broke compatibility.

3 2

compatibility vs. correctness
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

Steven Edwards wrote: > We discussed something like this years ago. It would be nice if every sort > of legacy API that has any sort of hacks for brokeness as part of its > implementation, could be isolated and a simple recompile with something > like a #define NO_LEGACY_WIN32 so you could recompile without the hacks. > Not really that useful for the real world as you need the backward > compatibility but it is a nice idea for embedded or non-normal windows > targets like ARM. I think this is like compiler warnings. Some checks are disabled by default as they would cause more harm than good. But there is an option to enable them. It will help to catch bugs in software.

1 0

Please dont break functionality due to a compiler problem, just fix it.
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

>> It was already broken in r37496. > Gdi is right Win32k is wrong. I mean that GCC (by default) silently discards code like if (i < 0) { ... } where i is unsigned. So there was a bug in GDI...

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2008