Ros-dev December 2008

ros-dev@reactos.org

29 participants
44 discussions

Re: [ros-dev] [ros-diffs] [ekohl] 37801: Sync to wine-1.1.1 (Patch 4 of 10): ATTENTION: You MUST run "clean" before building ReactOS, otherwise WIDL will crash when it is run. - Dan Hipschman <dsh at linux.ucla.edu> Tue, 1 Jul 2008 widl: Implement type redefinition

by Colin Finck

Hi Eric, Just wanted to tell you that your patch is correct and the Release Buildslave is failing as you can see from its log. For some reason, it stopped cleaning properly today and also has weird file deletion issues sometimes. But as long as the patch builds on the Debug slave, it's correct in 99% of all cases. Wanted to finish this mail before you reverted in r37802, but I was too slow. :-( So, it's safe for you to reapply r37801 and it's here to stay! Best regards, Colin

16 years, 11 months

Re: [ros-dev] [ros-diffs] [gschneider] 37774: Update C++ demangle code to recent wine, now all msvcrt cpp tests pass except one.

by Aleksey Bragin

On Nov 30, 2008, at 10:19 PM, gschneider(a)svn.reactos.org wrote: > Author: gschneider > Date: Sun Nov 30 13:19:45 2008 > New Revision: 37774 > - if (!(tmp = (char*)und_alloc(sym, len))) return NULL; > + if (!(tmp = und_alloc(sym, len))) return NULL; You might want to keep these when syncing, it reduces compiler warnings.

16 years, 11 months

Question about east asian language support

by Ashuaria Lee

Hello, everyone. Since I'm new to this mailing list, I may ask stupid questions, so don't be mad at me. ;-) I was trying to get the status of east asian language support, but couldn't find it in the wiki. Could someone tell me some brief status about east asian support? -- Regards, Ashuaria Lee

16 years, 11 months

Re: [ros-dev] [ros-diffs] [jimtabor] 37766: - Sync in rev 37720: Magnus Olsen, add GdiGetBitmapBitsSize is a new api from windows xp sp3, the code was tested in vs2003.

by Aleksey Bragin

Instead of copying the whole formula, it could be done as ULONG Height; if (lpbmi->bmiHeader.biHeight >=0 ) Height = lpbmi->bmiHeader.biHeight; else Height = -lpbmi->bmiHeader.biHeight; retSize = Height * ((lpbmi->bmiHeader.biWidth * lpbmi->bmiHeader.biPlanes * lpbmi- >bmiHeader.biBitCount + 31) & -32) / 8; Also comments contain typos /* Make height postiive if it negitve then calc the bits Size and align it*/ postiive, negitive WBR, Aleksey. On Nov 30, 2008, at 4:17 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Sun Nov 30 07:17:19 2008 > New Revision: 37766 > + if (lpbmi->bmiHeader.biHeight >=0 ) > + { > + /* Calc the bits Size and align it*/ > + retSize = lpbmi->bmiHeader.biHeight * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + } > + else > + { > + /* Make height postiive if it negitve then calc > the bits Size and align it*/ > + retSize = (-lpbmi->bmiHeader.biHeight) * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + }

16 years, 11 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2008