Now that Stefan has cleaned up some stuff in the ddk headers, maybe we
should think of some additional design fixes here.
We currently have ntddk.h include "per version" headers: winxp.h,
win2k.h, winnt4.h. These contain very few stuff.
My suggestion is to merge them into winddk.h. We could also merge
winddk.h and ntddk.h
It might make sense to split wdm.h and ntddk.h into architecture
specific files
Layout suggestion:
- ntddk.h: includes wdm.h and contains arch-independent definitions
currently in winddk.h/win2k.h/winnt4.h
- wdm.h: includes arch-dependent headers, contains arch-independend wdm
definitions
- ddk_x86.h / ddk_x64.h, ddk_arm.h, ddk_ppc.h / ddk_mips.h:
arch-dependent definitions for both wdm.h and ntddk.h definitions
(#ifdef _NTDDK_ ...)
Comments appreciated.
Timo
What's the reason to copy & paste comments from ms headers?
Please remember: Interfaces are not copyrighted, header files (including
the comments) are!
> +//
> +// Types to use to contain PFNs and their counts.
> +//
> +typedef ULONG PFN_COUNT;
> typedef ULONG PFN_NUMBER, *PPFN_NUMBER;
> +typedef LONG SPFN_NUMBER, *PSPFN_NUMBER;
>
Hi! I'm sorry I broke the trunk.
About "extra" comma within braces, it is not a mistake. It is allowed.
There is a fragment of C grammar:
initializer
: assignment_expression
| '{' initializer_list '}'
| '{' initializer_list ',' '}'
;
Hello,
booting bootcd leads to a stackfault of VMWare, build server
experiences similar problems.
Trunk is locked with write access available to Dmitry Gorbachev to
fix the issue, and to anyone by request who has the fix.
WBR,
Aleksey Bragin.
On Dec 3, 2008, at 8:34 PM, dgorbachev(a)svn.reactos.org wrote:
> Author: dgorbachev
> Date: Wed Dec 3 11:34:49 2008
> New Revision: 37830
> -static FREELDR_SETTINGS Settings = { 0, {0}, 0 };
> +static FREELDR_SETTINGS Settings = { 0, { 0, }, 0, 0, FALSE };
I suspect there is a typo in the above line ("extra" comma within
braces, should've been something like 0, {0, 0}, 0, FALSE instead
probably).
WBR,
Aleksey.