Ros-dev December 2008

ros-dev@reactos.org

29 participants
44 discussions

Start a nNew thread

Please dont break functionality due to a compiler problem, just fix it.
by Dmitry Gorbachev 08 Dec '08

08 Dec '08

It was already broken in r37496.

2 1

[ros-diffs] [ekohl] 37891: Replace call to ExtractIconExW (shell32.dll) by a call to PrivateExtractIconExw (user32.dll) and remove shell32.dll from the list of linked libraries because shell32.dll requires a valid user account upon initialization. Pl
by James Tabor 07 Dec '08

07 Dec '08

Eric Kohl is an Ace Programmer! Thanks Eric! James

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 37876: - Implement SetupInstallFileA/W - Stub implement SetupPromptForDiskA/W All from Wine.
by teknopup 07 Dec '08

07 Dec '08

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 37876: - Implement SetupInstallFileA/W - Stub implement SetupPromptForDiskA/W All from Wine.
by Ged 06 Dec '08

06 Dec '08

dchapyshev(a)svn.reactos.org wrote: > + if (!(inf_source = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) > + { > + SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > + return FALSE; > + } > + if (!SetupGetStringFieldW( inf_context, 1, inf_source, len, NULL )) return FALSE; > + source = inf_source; There's a memory leak here. It's best to read Wine code when throughly, they have bugs too ;) Ged.

1 0

ddk header cleanup
by Timo Kreuzer 05 Dec '08

05 Dec '08

Now that Stefan has cleaned up some stuff in the ddk headers, maybe we should think of some additional design fixes here. We currently have ntddk.h include "per version" headers: winxp.h, win2k.h, winnt4.h. These contain very few stuff. My suggestion is to merge them into winddk.h. We could also merge winddk.h and ntddk.h It might make sense to split wdm.h and ntddk.h into architecture specific files Layout suggestion: - ntddk.h: includes wdm.h and contains arch-independent definitions currently in winddk.h/win2k.h/winnt4.h - wdm.h: includes arch-dependent headers, contains arch-independend wdm definitions - ddk_x86.h / ddk_x64.h, ddk_arm.h, ddk_ppc.h / ddk_mips.h: arch-dependent definitions for both wdm.h and ntddk.h definitions (#ifdef _NTDDK_ ...) Comments appreciated. Timo

1 0

Re: [ros-dev] [ros-diffs] [jimtabor] 37783: - Fixed hooking bug for Firefox, a plus, new SEH found a bug!
by Timo Kreuzer 04 Dec '08

04 Dec '08

This looks like you're creating a mem leak. > Author: jimtabor > Date: Sun Nov 30 17:39:20 2008 > New Revision: 37783 > > URL: http://svn.reactos.org/svn/reactos?rev=37783&view=rev <http://svn.reactos.org/svn/reactos?rev=37783&view=rev> > Log: > - Fixed hooking bug for Firefox, a plus, new SEH found a bug! > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… <http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…> > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] Sun Nov 30 17:39:20 2008 > @@ -507,12 +507,12 @@ > } > _SEH2_END; > > - IntCbFreeMemory(Argument); > - > if (!NT_SUCCESS(Status)) > { > return 0; > } > + > + if (Argument) IntCbFreeMemory(Argument); > > return Result; > } >

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 37792: - Get rid of DDK's dependency on windef.h and winnt.h - Clean up, fix, and add missing types to ntdef.h/ntifs.h/winddk.h/wdm.h/ntpoapi.h - Add ntimage.h and use it in rossym and NDK - Fix a gcc compatibility issue -- some internal NT structures have their pointer types defined in the DDK headers, but we define them along with the "struct" type when defining the full structure. MSVC is okay with this double definition, but gcc treats it as an error (hidden by syst
by Timo Kreuzer 04 Dec '08

04 Dec '08

What's the reason to copy & paste comments from ms headers? Please remember: Interfaces are not copyrighted, header files (including the comments) are! > +// > +// Types to use to contain PFNs and their counts. > +// > +typedef ULONG PFN_COUNT; > typedef ULONG PFN_NUMBER, *PPFN_NUMBER; > +typedef LONG SPFN_NUMBER, *PSPFN_NUMBER; >

1 0

Boot broken, trunk locked
by Dmitry Gorbachev 04 Dec '08

04 Dec '08

Hi! I'm sorry I broke the trunk. About "extra" comma within braces, it is not a mistake. It is allowed. There is a fragment of C grammar: initializer : assignment_expression | '{' initializer_list '}' | '{' initializer_list ',' '}' ;

1 0

Boot broken, trunk locked
by Aleksey Bragin 03 Dec '08

03 Dec '08

Hello, booting bootcd leads to a stackfault of VMWare, build server experiences similar problems. Trunk is locked with write access available to Dmitry Gorbachev to fix the issue, and to anyone by request who has the fix. WBR, Aleksey Bragin.

2 1

Re: [ros-dev] [ros-diffs] [dgorbachev] 37830: Silence compiler warnings (8/11).
by Aleksey Bragin 03 Dec '08

03 Dec '08

On Dec 3, 2008, at 8:34 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Wed Dec 3 11:34:49 2008 > New Revision: 37830 > -static FREELDR_SETTINGS Settings = { 0, {0}, 0 }; > +static FREELDR_SETTINGS Settings = { 0, { 0, }, 0, 0, FALSE }; I suspect there is a typo in the above line ("extra" comma within braces, should've been something like 0, {0, 0}, 0, FALSE instead probably). WBR, Aleksey.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev December 2008