Hi,
Are there any bugs:
/reactos/dll/directx/ksproxy/allocator.cpp: In member function 'void
CKsAllocator::FreeMediaSamples()':
/reactos/dll/directx/ksproxy/allocator.cpp:586:16: warning: deleting
object of abstract class type 'IMediaSample' which has non-virtual
destructor will cause undefined behaviour [-Wdelete-non-virtual-dtor]
/reactos/dll/directx/ksproxy/proxy.cpp: In function 'HRESULT
CKsProxy_Constructor(IUnknown*, const IID&, void**)':
/reactos/dll/directx/ksproxy/proxy.cpp:3188:16: warning: deleting
object of polymorphic class type 'CKsProxy' which has non-virtual
destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
In file included from /reactos/dll/win32/browseui/precomp.h:8:0,
from /reactos/dll/win32/browseui/browseui.cpp:21:
/reactos/lib/atl/atlcom.h: In instantiation of 'static HRESULT
ATL::CComCreator<T1>::CreateInstance(void*, const IID&, void**) [with
T1 = ATL::CComObjectCached<ATL::CComClassFactory>, HRESULT = int, IID
= _GUID, LPVOID = void*]':
/reactos/dll/win32/browseui/browseui.cpp:32:1: required from here
/reactos/lib/atl/atlcom.h:253:5: warning: deleting object of
polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
/reactos/lib/atl/atlcom.h: In instantiation of 'ULONG
ATL::CComObjectCached<Base>::Release() [with Base =
ATL::CComClassFactory, ULONG = unsigned int]':
/reactos/dll/win32/browseui/browseui.cpp:121:1: required from here
/reactos/lib/atl/atlcom.h:304:4: warning: deleting object of
polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
In file included from /reactos/dll/win32/shell32/precomp.h:50:0,
from /reactos/dll/win32/shell32/shell32_main.cpp:22:
/reactos/lib/atl/atlcom.h: In instantiation of 'static HRESULT
ATL::CComCreator<T1>::CreateInstance(void*, const IID&, void**) [with
T1 = ATL::CComObjectCached<ATL::CComClassFactory>, HRESULT = long int,
IID = _GUID, LPVOID = void*]':
/reactos/dll/win32/shell32/shell32_main.cpp:1273:1: required from here
/reactos/lib/atl/atlcom.h:253:5: warning: deleting object of
polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
/reactos/lib/atl/atlcom.h: In instantiation of 'ULONG
ATL::CComObjectCached<Base>::Release() [with Base =
ATL::CComClassFactory, ULONG = long unsigned int]':
/reactos/dll/win32/shell32/shell32_main.cpp:1478:1: required from here
/reactos/lib/atl/atlcom.h:304:4: warning: deleting object of
polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In
member function 'virtual ULONG CMiniportDMusUART::Release()':
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:114:20:
warning: deleting object of polymorphic class type 'CMiniportDMusUART'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In
member function 'virtual ULONG CMiniportDMusUARTStream::Release()':
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:239:20:
warning: deleting object of polymorphic class type
'CMiniportDMusUARTStream' which has non-virtual destructor might cause
undefined behaviour [-Wdelete-non-virtual-dtor]
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In
function 'NTSTATUS NewMiniportDMusUART(IMiniport**, const CLSID&)':
/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:1274:16:
warning: deleting object of polymorphic class type 'CMiniportDMusUART'
which has non-virtual destructor might cause undefined behaviour
[-Wdelete-non-virtual-dtor]
Windows cmake builder is running new BE since yesterday. First thing that i noticed, is the increase of buildtime. Previous version was consistent around 5 minutes, the new candidate - more than 7. I doublechecked it by swapping BE's back and forth.
This might look not serious, but if this problem scales up, we are talking about 35 minutes of buildtime for someone who needed 25 minutes previously.
--
With best regards
Caemyr
Hi,
small note to inform people who were having issues connecting to secured IServ services due to wrong SSL certificate (issued for the wrong address) that the certificate has been renewed today and the issues are gone.
Regards,
Pierre
Sorry but these kinds of fixes are not "readability fixes", in fact they
make things more obtuse.
(*MdlPages << PAGE_SHIFT)) could be interpreted as
*(MdlPages << PAGE_SHIFT).
while
((*MdlPages) << PAGE_SHIFT)
Makes it clear what is happening.
In general, all operations affecting the contents of a *dereference should
be in parens.
Best regards,
Alex Ionescu
On Sun, Sep 11, 2011 at 7:47 AM, <tfaber(a)svn.reactos.org> wrote:
> - ((*MdlPages) << PAGE_SHIFT));
> + (*MdlPages << PAGE_SHIFT));
>