Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org:
> Author: cmihail
> Date: Sat Sep 3 00:08:11 2011
> New Revision: 53537
>
> URL:http://svn.reactos.org/svn/reactos?rev=53537&view=rev
> Log:
> [shell32.dll]
> [FORMATTING]
> - Format the code to a more acceptable level. This is just for my sanity while sifting through it.
> /* skip the remaining spaces */
> - while (*cs==0x0009 || *cs==0x0020) {
> + while (*cs==0x0009 || *cs==0x0020)
> + {
> cs++;
> }
> if (*cs==0)
>
Please don't mix tabs and spaces or we'll end up looking like GNU style ;-)
Since the file already uses spaces (as we use almost everywhere), please
stick to that here.
Regards,
Timo
Hey again,
On 2011-09-01 15:18, dchapyshev(a)svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep 1 13:18:22 2011
> @@ -179,7 +179,7 @@
> pContext->Status = 3;
> }
> }
> - else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED)
> + else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED)
> {
> if (pContext->Status != 4)
> {
>
this should more likely be
else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE ||
IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_DISCONNECTED)
Some nice fixes right there by the way. :)
*hopes this might fix some evil bugs that have been lurking* ;)
Thanks,
Tom