Hi all,
Andrey Karpov of "SiProVer" Ltd (www.viva64.com/ ), the authors of
PVS-Studio, a
statical source code analyzer/checker wrote (in Russian, this
translation is conducted by me):
"Have checked source code of ReactOS with PVS-Studio, I fulfilled
three wishes of mine at once:
Firstly, for a long time I wanted to write an article about ordinary
project. It
is not so interesting to check source code of such projects as Chromium,
It is of too high quality and resources are spending for keeping this level of
quality, resources which are unavailable to ordinary projects.
Secondly, ReactOS appears to be a good example of project, for which high
need of statical analysis of source code can be shown, especially as project
being developed with distributed team of developers with diversely
different experience.
Thirdly, I got confirmation of PVS-Studio getting better and better
and more useful
all along the way..."
Full text of original Russian article is here:
http://habrahabr.ru/blogs/os/127493/
titled on Russian as "PVS-Studio: analysing ReactOS operating system
source code".
Evgeniy Ryzhkov of "SiProVer" adds:
"Soon we will translate and publish article on English. But if you
have questions now
- we are ready for discussion.
If some of English-speaking comrades of ReactOS would like to work
with errors list,
generated with PVS-Studio we have prepared for them translation of
errors explanations, here it is:
http://www.viva64.com/external-pictures/txt/PVS-Studio-vs-ReactOS-en-unicod…
".
Original article refers to long list of generated errors with manually
added explanations for errors
found by their static checker, so this is translated version of that list.
---
Looking backward to few applied patches, it turns out that not all of
them were absolutely useful,
some patches were reversed, etc. But nevertheless, I think it makes
sense to use this tool. They
promised to donate some version of PVS-Studio to project, and it is to
ROS developers to decide is it worth of taking.
What I would suggest: anybody working with some module or part of code
can take corresponding part
of messages (or in future, possibly check with tool only these parts
of interest) and work with them.
Also Karpov gave good advise to check newly written code, since it is
still of interest to developer:
write and time for time test with it.
P.S. Disclaimer: I am not in any connection with "SiProVer"
Regards,
M.A.
Nice work guys.
It was great to watch you pull this together as a team.
Hopefully there's more to come :)
-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of akhaldi(a)svn.reactos.org
Sent: 09 September 2011 11:55
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [akhaldi] 53653: [SHELL32] * Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos ! * Better code quality, more tests run with less failures... and more. * Dedicated to everyone who help...
Author: akhaldi
Date: Fri Sep 9 10:55:09 2011
New Revision: 53653
URL: http://svn.reactos.org/svn/reactos?rev=53653&view=rev
Log:
[SHELL32]
* Reintegrate the c++ shell32 branch. Exemplary team-work.. kudos !
* Better code quality, more tests run with less failures... and more.
* Dedicated to everyone who helped ;)
Le 23/08/2011 10:58, tkreuzer(a)svn.reactos.org a écrit :
> Author: tkreuzer
> Date: Tue Aug 23 08:58:15 2011
> New Revision: 53399
>
> URL: http://svn.reactos.org/svn/reactos?rev=53399&view=rev
> Log:
> [VMWINST] Fix amd64 build
>
What about :
[VMWINST] Get rid of this useless relic.
I mean it's something we have to maintain, it was written for
antediluvian vmware versions, and I see no reason to have such a thing.
I may as well write an application to install specific ATI card drivers,
or intel chipset drivers...
Hello Claudiu!
I notice some weird tab/spaces modifications here.
Regards.
Jérôme.
Le 03/09/2011 16:20, cmihail(a)svn.reactos.org a écrit :
> Author: cmihail
> Date: Sat Sep 3 14:20:03 2011
> New Revision: 53543
>
> URL: http://svn.reactos.org/svn/reactos?rev=53543&view=rev
> Log:
> [shell32.dll]
> - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetests.
> - Fix a bug in ShellLink::SetShowCmd and score one more passed winetest
>
> Modified:
> branches/shell32_new-bringup/dll/win32/shell32/shelllink.cpp
> branches/shell32_new-bringup/dll/win32/shell32/shlfileop.cpp
>
>