Ros-dev

ros-dev@reactos.org

3 participants
5789 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 37783: - Fixed hooking bug for Firefox, a plus, new SEH found a bug!

by Timo Kreuzer

This looks like you're creating a mem leak. > Author: jimtabor > Date: Sun Nov 30 17:39:20 2008 > New Revision: 37783 > > URL: http://svn.reactos.org/svn/reactos?rev=37783&view=rev <http://svn.reactos.org/svn/reactos?rev=37783&view=rev> > Log: > - Fixed hooking bug for Firefox, a plus, new SEH found a bug! > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/callback.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… <http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…> > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/callback.c [iso-8859-1] Sun Nov 30 17:39:20 2008 > @@ -507,12 +507,12 @@ > } > _SEH2_END; > > - IntCbFreeMemory(Argument); > - > if (!NT_SUCCESS(Status)) > { > return 0; > } > + > + if (Argument) IntCbFreeMemory(Argument); > > return Result; > } >

16 years, 1 month

Re: [ros-dev] [ros-diffs] [sginsberg] 37792: - Get rid of DDK's dependency on windef.h and winnt.h - Clean up, fix, and add missing types to ntdef.h/ntifs.h/winddk.h/wdm.h/ntpoapi.h - Add ntimage.h and use it in rossym and NDK - Fix a gcc compatibility issue -- some internal NT structures have their pointer types defined in the DDK headers, but we define them along with the "struct" type when defining the full structure. MSVC is okay with this double definition, but gcc treats it as an error (hidden by syst

by Timo Kreuzer

What's the reason to copy & paste comments from ms headers? Please remember: Interfaces are not copyrighted, header files (including the comments) are! > +// > +// Types to use to contain PFNs and their counts. > +// > +typedef ULONG PFN_COUNT; > typedef ULONG PFN_NUMBER, *PPFN_NUMBER; > +typedef LONG SPFN_NUMBER, *PSPFN_NUMBER; >

16 years, 1 month

Boot broken, trunk locked

by Dmitry Gorbachev

Hi! I'm sorry I broke the trunk. About "extra" comma within braces, it is not a mistake. It is allowed. There is a fragment of C grammar: initializer : assignment_expression | '{' initializer_list '}' | '{' initializer_list ',' '}' ;

16 years, 1 month

Boot broken, trunk locked

by Aleksey Bragin

Hello, booting bootcd leads to a stackfault of VMWare, build server experiences similar problems. Trunk is locked with write access available to Dmitry Gorbachev to fix the issue, and to anyone by request who has the fix. WBR, Aleksey Bragin.

16 years, 1 month

Re: [ros-dev] [ros-diffs] [dgorbachev] 37830: Silence compiler warnings (8/11).

by Aleksey Bragin

On Dec 3, 2008, at 8:34 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Wed Dec 3 11:34:49 2008 > New Revision: 37830 > -static FREELDR_SETTINGS Settings = { 0, {0}, 0 }; > +static FREELDR_SETTINGS Settings = { 0, { 0, }, 0, 0, FALSE }; I suspect there is a typo in the above line ("extra" comma within braces, should've been something like 0, {0, 0}, 0, FALSE instead probably). WBR, Aleksey.

16 years, 1 month

Re: [ros-dev] [ros-diffs] [ekohl] 37801: Sync to wine-1.1.1 (Patch 4 of 10): ATTENTION: You MUST run "clean" before building ReactOS, otherwise WIDL will crash when it is run. - Dan Hipschman <dsh at linux.ucla.edu> Tue, 1 Jul 2008 widl: Implement type redefinition

by Colin Finck

Hi Eric, Just wanted to tell you that your patch is correct and the Release Buildslave is failing as you can see from its log. For some reason, it stopped cleaning properly today and also has weird file deletion issues sometimes. But as long as the patch builds on the Debug slave, it's correct in 99% of all cases. Wanted to finish this mail before you reverted in r37802, but I was too slow. :-( So, it's safe for you to reapply r37801 and it's here to stay! Best regards, Colin

16 years, 1 month

Re: [ros-dev] [ros-diffs] [gschneider] 37774: Update C++ demangle code to recent wine, now all msvcrt cpp tests pass except one.

by Aleksey Bragin

On Nov 30, 2008, at 10:19 PM, gschneider(a)svn.reactos.org wrote: > Author: gschneider > Date: Sun Nov 30 13:19:45 2008 > New Revision: 37774 > - if (!(tmp = (char*)und_alloc(sym, len))) return NULL; > + if (!(tmp = und_alloc(sym, len))) return NULL; You might want to keep these when syncing, it reduces compiler warnings.

16 years, 1 month

Question about east asian language support

by Ashuaria Lee

Hello, everyone. Since I'm new to this mailing list, I may ask stupid questions, so don't be mad at me. ;-) I was trying to get the status of east asian language support, but couldn't find it in the wiki. Could someone tell me some brief status about east asian support? -- Regards, Ashuaria Lee

16 years, 1 month

Re: [ros-dev] [ros-diffs] [jimtabor] 37766: - Sync in rev 37720: Magnus Olsen, add GdiGetBitmapBitsSize is a new api from windows xp sp3, the code was tested in vs2003.

by Aleksey Bragin

Instead of copying the whole formula, it could be done as ULONG Height; if (lpbmi->bmiHeader.biHeight >=0 ) Height = lpbmi->bmiHeader.biHeight; else Height = -lpbmi->bmiHeader.biHeight; retSize = Height * ((lpbmi->bmiHeader.biWidth * lpbmi->bmiHeader.biPlanes * lpbmi- >bmiHeader.biBitCount + 31) & -32) / 8; Also comments contain typos /* Make height postiive if it negitve then calc the bits Size and align it*/ postiive, negitive WBR, Aleksey. On Nov 30, 2008, at 4:17 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Sun Nov 30 07:17:19 2008 > New Revision: 37766 > + if (lpbmi->bmiHeader.biHeight >=0 ) > + { > + /* Calc the bits Size and align it*/ > + retSize = lpbmi->bmiHeader.biHeight * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + } > + else > + { > + /* Make height postiive if it negitve then calc > the bits Size and align it*/ > + retSize = (-lpbmi->bmiHeader.biHeight) * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + }

16 years, 1 month

Silence a warning reported by gcc 4.3.2 (possibly incorrectly, but it's just a stub anyway)

by Dmitry Gorbachev

Yes, incorrectly. GetTraceLoggerHandle() should return 0xFFFFFFFFFFFFFFFF if it fails, but now it returns 0xFFFFFFFF.

16 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev