Ros-dev

ros-dev@reactos.org

5791 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 37766: - Sync in rev 37720: Magnus Olsen, add GdiGetBitmapBitsSize is a new api from windows xp sp3, the code was tested in vs2003.
by Aleksey Bragin 01 Dec '08

01 Dec '08

Instead of copying the whole formula, it could be done as ULONG Height; if (lpbmi->bmiHeader.biHeight >=0 ) Height = lpbmi->bmiHeader.biHeight; else Height = -lpbmi->bmiHeader.biHeight; retSize = Height * ((lpbmi->bmiHeader.biWidth * lpbmi->bmiHeader.biPlanes * lpbmi- >bmiHeader.biBitCount + 31) & -32) / 8; Also comments contain typos /* Make height postiive if it negitve then calc the bits Size and align it*/ postiive, negitive WBR, Aleksey. On Nov 30, 2008, at 4:17 PM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Sun Nov 30 07:17:19 2008 > New Revision: 37766 > + if (lpbmi->bmiHeader.biHeight >=0 ) > + { > + /* Calc the bits Size and align it*/ > + retSize = lpbmi->bmiHeader.biHeight * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + } > + else > + { > + /* Make height postiive if it negitve then calc > the bits Size and align it*/ > + retSize = (-lpbmi->bmiHeader.biHeight) * ((lpbmi- > >bmiHeader.biWidth * > + lpbmi->bmiHeader.biPlanes * lpbmi- > >bmiHeader.biBitCount + 31) & -32) / 8; > + }

2 1

Silence a warning reported by gcc 4.3.2 (possibly incorrectly, but it's just a stub anyway)
by Dmitry Gorbachev 30 Nov '08

30 Nov '08

Yes, incorrectly. GetTraceLoggerHandle() should return 0xFFFFFFFFFFFFFFFF if it fails, but now it returns 0xFFFFFFFF.

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 37739: - Kill off ramdrv, it is deprecated since a long time ago. See issue #3422 for more details.
by Steven Edwards 30 Nov '08

30 Nov '08

On Sat, Nov 29, 2008 at 2:35 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Nov 29 13:35:04 2008 > New Revision: 37739 > > URL: http://svn.reactos.org/svn/reactos?rev=37739&view=rev > Log: > - Kill off ramdrv, it is deprecated since a long time ago. > See issue #3422 for more details. The problem was as far as I can tell not ramdrv but ramdrv/minix. I really think you should revert part of this. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [cgutman] 37713: - Merge aicom-network-fixes up to r37712
by Aleksey Bragin 29 Nov '08

29 Nov '08

Another way of doing this (stylistically) would be: switch (Type) { case NdisWorkItemRequest: if (Adapter->NdisMiniportBlock.PendingRequest || MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest)) Busy = TRUE; break case ...: } On Nov 29, 2008, at 4:51 AM, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 28 19:51:19 2008 > New Revision: 37713 > > +BOOLEAN > +MiniIsBusy( > + PLOGICAL_ADAPTER Adapter, > + NDIS_WORK_ITEM_TYPE Type) > +{ > + BOOLEAN Busy = FALSE; > + KIRQL OldIrql; > + > + KeAcquireSpinLock(&Adapter->NdisMiniportBlock.Lock, &OldIrql); > + > + if (Type == NdisWorkItemRequest && > + (Adapter->NdisMiniportBlock.PendingRequest || > MiniGetFirstWorkItem(Adapter, NdisWorkItemRequest))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemSend && > + (Adapter->NdisMiniportBlock.FirstPendingPacket || > MiniGetFirstWorkItem(Adapter, NdisWorkItemSend))) > + { > + Busy = TRUE; > + } > + else if (Type == NdisWorkItemResetRequested && > + (Adapter->NdisMiniportBlock.ResetStatus == > NDIS_STATUS_PENDING || MiniGetFirstWorkItem(Adapter, > NdisWorkItemResetRequested))) > + { > + Busy = TRUE; > + } > + > + KeReleaseSpinLock(&Adapter->NdisMiniportBlock.Lock, OldIrql); > + > + return Busy; > +}

1 0

Win32k Rewrite Status Report
by James Tabor 28 Nov '08

28 Nov '08

Hi Team! First, here is my personal list of last years goals for the rewrite. Most of you already know what I had plan for last year so please bare with me. ___ December 2007: End of previous year rewrite of definition files and structure integration with updates to ntgdibad.h. Housekeeping, test and verify. Add previous years loose ends and carryovers. Thomas help with user window handle support is a great bonus to the year end progress toward win32k rewrite. Timo win32k cross tests. Magnus integration of DDxD support is still in progress and ticking along nicely. January 2008: Miscellaneous Gdi adds, fix ups and cleanup. February 2008: Integration and implementation of Enhanced/Meta/Dc/File support. This is a wine sync/port that I have started during the beginning of the rewrite. Delayed and carryover. May 2008: Gdi/User Win32k DCE cleanup and fixes. 90% complete. One unique test case needing to be integrated in code base. June 2008: Gdi cleanup and verify testing. Integrate simple multi display support. DC and PDEV integration and cleanup. Partial DC and PDEV structures are supported and minor cleanup and testing was meant. No multi display add ons are included. Delayed and carryover. July 2008: Start prerewrite of User32/Win32k. Cleanup headers and add new types and structures. Started and carryover. September 2008: Housecleaning, Gdi testing and verifying. Still in progress. November 2008: Start User32/Win32 Menu rewrite. Still in progress, new structure support is in and working in test tree. December 2008: End of year housekeeping with cross test and verify. Add previous years loose ends and carryovers. Slow integration of known gdi structures have been completed. Attribute support is only for DC's, investigating a more conservative process of allocation and utilization of Brush/Pen /Regon and Font attribute support that is compatible with gdi. Carryover and finish up window handle and integration support. Timo started integration of user process/thread structures and support, leaving win32k initialization bug open for more investigation. Magnus DDxD is back on track. Stefan cleanup of win32 functions was completed. January 2009: Add new members to the rewrite team, start training and information exchange. Setup freelance hacker member list which would include just about everyone with commit access. -------- This is my personal list and included comments about team members progress. I'll add more after January for 2009. Side Note: Please do not post here if you are interested in joining the rewrite team. If you have commit access you are already in. We need to know your specialties, interests and goals which include what you want to learn so this can be carried into your next career. Resume stuffer for the next job and what knots. Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [gschneider] 37695: Update gdi32 winetests, so we don't run out of things to fix.
by Steven Edwards 28 Nov '08

28 Nov '08

On Thu, Nov 27, 2008 at 3:52 PM, <gschneider(a)svn.reactos.org> wrote: > Author: gschneider > Date: Thu Nov 27 14:52:01 2008 > New Revision: 37695 > > URL: http://svn.reactos.org/svn/reactos?rev=37695&view=rev > Log: > Update gdi32 winetests, so we don't run out of things to fix. Best commit message ever. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

utf-16 data (e.g. inf files)
by Matthias Kupfer 26 Nov '08

26 Nov '08

Hi folks, due to the perpetual problems with utf-16 files I recommend to change the handling in the following way as long as we don't have another working translation system (mui) and we want to keep a win32 compatible inf file: We should store the files in subversion as utf-8 and convert during make and rbuild in utf-16 (e.g. via small c-programm or new rbuild-command), so we can edit and make diffs in an easy way. Comments are very welcome Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

5 5

Migrate ntoskrnl to PSEH 2.0
by Dmitry Gorbachev 24 Nov '08

24 Nov '08

Hi! I have a linking error because GCC-4.4 inserts calls of ___enable_execute_stack() into functions which use PSEH. It seems that this behavior cannot be changed without changing the GCC itself. Or maybe I should provide an empty ___enable_execute_stack() function just to satisfy the linker.

1 0

(no subject)
by Dmitry Gorbachev 22 Nov '08

22 Nov '08

> This is already done, most files which have Wine code are labeled so atop > of the file ("Some parts are taken from Wine project..."). What I see is > that Dmitry Timoshkov says this is not enough. It should be enough if the original copyright notices are kept. No need to research origins of every piece of code. LGPL 2.1: > 1. You may copy and distribute verbatim copies of the Library's complete > source code as you receive it, in any medium, provided that you > conspicuously and appropriately publish on each copy an appropriate > copyright notice and disclaimer of warranty; keep intact all the notices > that refer to this License and to the absence of any warranty; [...] > 2. You may modify your copy or copies of the Library or any portion of > it, thus forming a work based on the Library, and copy and distribute such > modifications or work under the terms of Section 1 above, [...] GPL-HOWTO: > If you have copied code from other programs covered by the same license, > copy their copyright notices too. Put all the copyright notices together, > right near the top of each file.

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 37523: - winternl.h is deprecated since the NDK was invented, don't use
by Steven Edwards 21 Nov '08

21 Nov '08

On Fri, Nov 21, 2008 at 2:23 PM, <sginsberg(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=37523&view=rev > Log: > - winternl.h is deprecated since the NDK was invented, don't use I am sure there are some wine sources somewhere that we have the make use of it but perhaps we could add some sort of check like #ifndef __WINESRC__ #error Don't use winternl.h! #endif or something similar. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev