Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] Event invitation [jornadas Imaginática 2009]

by Marc Piulachs

Hi Victor, I haven't done any special "negotiations" mainly because anyone expressed interest on participating in the event. In case you or anyone else want to participate feel free to contact me and maybe we can workout something Regards, /Marc From: victor martinez Sent: Thursday, November 20, 2008 4:01 PM To: ros-dev(a)reactos.org Subject: [ros-dev] Re: Event invitation [jornadas Imaginática 2009] Hi All,I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles.More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdfRegards,/MarcHi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica?Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled).So being in Imaginatica must be a priority ;)VicmarcalSeville -------------------------------------------------------------------------------- No te aburras más, engánchate a los Juegos de Messenger -------------------------------------------------------------------------------- _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

15 years, 10 months

Re: Event invitation [jornadas Imaginática 2009]

by victor martinez

Hi All, I have been contacted/invited to participate and give a talk about ReactOS in an event organized by the university of Seville, spain (very beautiful city!) on 2-6 March 2009. It would be great if some of the other spanish based members are also interested on participate, I have been disconnected from the project lately due to offline life but would be willing to participate in this event and help to spread the word about reactos in academic circles. More information here (in spanish): http://imaginatica.org/2009/descargas/Dossier.pdf Regards, /Marc Hi Marc, there are spanish people in Seville interested in Imaginatica Event. Does the invitation still available?How goes the "negotiations"?are they still counting on us being at Imaginatica? Thanks in advance. This event mix the most important IT companies,and also there are a lot of skilled developers.This is one of the most important Event in Spain (since SIMO has been cancelled). So being in Imaginatica must be a priority ;) Vicmarcal Seville _________________________________________________________________ Los más de lo más, Especial Rankings http://events.es.msn.com/dinero/listas/default.aspx

15 years, 10 months

Re: [ros-dev] [ros-diffs] [cfinck] 37465: Dmitry Gorbachev - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 See issue #3849 for more details.

by Matthieu Suiche

char buf[MAX_PATH]; [...] strcat(buf, DIR_SEPARATOR_STRING); strcat(buf, source); strcat(buf, entry->d_name); I'm not sure this is really safe. -- Matthieu Suiche On Wed, Nov 19, 2008 at 8:59 PM, <cfinck(a)svn.reactos.org> wrote: > Author: cfinck > Date: Wed Nov 19 13:59:54 2008 > New Revision: 37465 > > URL: http://svn.reactos.org/svn/reactos?rev=37465&view=rev > Log: > Dmitry Gorbachev > - Fix compiler warnings, treated as errors due to our settings, which are emitted when using GCC 4.3.2 > > See issue #3849 for more details. > > Modified: > trunk/reactos/tools/cabman/cabinet.cxx > trunk/reactos/tools/cdmake/cdmake.c > trunk/reactos/tools/rgenstat/rgenstat.c > > Modified: trunk/reactos/tools/cabman/cabinet.cxx > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cabman/cabinet.cxx?r… > ============================================================================== > --- trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] (original) > +++ trunk/reactos/tools/cabman/cabinet.cxx [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -2055,9 +2055,19 @@ > return CAB_STATUS_CANNOT_READ; > } > > - GetFileTimes(SrcFile, FileNode); > - > - GetAttributesOnFile(FileNode); > + if (GetFileTimes(SrcFile, FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file times.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > + > + if (GetAttributesOnFile(FileNode) != CAB_STATUS_SUCCESS) > + { > + DPRINT(MIN_TRACE, ("Cannot read file attributes.\n")); > + FreeMemory(NewFileName); > + return CAB_STATUS_CANNOT_READ; > + } > > CloseFile(SrcFile); > > @@ -3646,7 +3656,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > @@ -3689,7 +3700,8 @@ > strcpy(buf, File->FileName); > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + return CAB_STATUS_CANNOT_READ; > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, File->FileName); > } > > Modified: trunk/reactos/tools/cdmake/cdmake.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/cdmake.c?rev=… > ============================================================================== > --- trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] (original) > +++ trunk/reactos/tools/cdmake/cdmake.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -882,7 +882,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > @@ -943,7 +944,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > } > @@ -994,7 +996,8 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + error_exit("Can't get CWD: %s\n", strerror(errno)); > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, source); > strcat(buf, entry->d_name); > > Modified: trunk/reactos/tools/rgenstat/rgenstat.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rgenstat/rgenstat.c?… > ============================================================================== > --- trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] (original) > +++ trunk/reactos/tools/rgenstat/rgenstat.c [iso-8859-1] Wed Nov 19 13:59:54 2008 > @@ -553,7 +553,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > @@ -611,7 +615,11 @@ > } > else > { > - getcwd(buf, sizeof(buf)); > + if (!getcwd(buf, sizeof(buf))) > + { > + printf("Can't get CWD: %s\n", strerror(errno)); > + return; > + } > strcat(buf, DIR_SEPARATOR_STRING); > strcat(buf, path); > strcat(buf, entry->d_name); > >

15 years, 10 months

OpenWatcom.

by Marcin Dalecki

Has anybody considered to use the openwatcom compiler for ReactOS? http://www.openwatcom.org/index.php/Main_Page At least it provides a proper native SEH implementation and is as free as the GCC is. ➧ Marcin Dalecki ❖

15 years, 10 months

by James Tabor

These are correct changes. On Tue, Nov 18, 2008 at 10:34 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > May I ask why those if (!Info) checks are required? To me it makes no > sense to call those APIs with the cruicial, mandatory working (and in > one case the only) parameter being NULL, and I would put an ASSERT > (Info) there to catch bad callers and fix them. > > WBR, > Aleksey. > > On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > >> Author: jimtabor >> Date: Mon Nov 17 23:36:19 2008 >> New Revision: 37436 >> >> UINT >> FASTCALL >> DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) >> { >> UINT MaxBits = 0; >> + >> + if (!Info) return 0; >> >> >> +UINT >> +FASTCALL >> +DIB_BitmapBitsSize( PBITMAPINFO Info ) >> +{ >> + UINT Ret; >> + >> + if (!Info) return 0; >

15 years, 10 months

[ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.

by Dmitry Gorbachev

gedmurphy wrote: > Let's say you implement a function in our win32k, based on Wine code. How > exactly would you realistically discover which Wine dev wrote that > function, and if the function was merely _based_ on wine code, which parts > of the function would you attribute credit to, and how would you do it? I think if the dev is not known, then all authors should be credited. I.e.: "Parts of this file are Copyright (C) ... ". Or: to gather the original Wine copiright notices into a separate file and put a pointer to it in any file which is based on Wine.

15 years, 10 months

Re: [ros-dev] [ros-diffs] [jimtabor] 37345: - Add path support for ExtTextOut.

by Steven Edwards

Dmitry, On Tue, Nov 18, 2008 at 2:22 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > http://www.reactos.org/archives/public/ros-diffs/2008-November/027021.html > > Please stop copying Wine code without any copyright and source > reference into reactos. This became very bad practice from your > side during last years. I have no power with the ReactOS project other than to ask and try to get policy changed in a democratic manner. I've made the case for the ReactOS to do a better job at proper attribution in code that is imported based on feedback from you in the past. In fact, just yesterday I replied to ros-dev proposing some guidelines for how to handle code imported from Wine. There is nothing more I can do. I have CC'd Alexandre and Jeremy for there thoughts on the subject. I welcome feedback from the Software Freedom Law Center or the FSF with reguards to this issue because on one hand I understand the attribution is important but on the other hand ReactOS is persona non-grata with Wine. Given Wine's reluctance to accept any contributions from ReactOS developers, totally based on guilt by assocation I think its in your best interested not to be credited. The Software is still being released under the terms you granted so I don't see a major violation. >From the LGPL preamble: "...Also, if the library is modified by someone else and passed on, the recipients should know that what they have is not the original version, so that the original author's reputation will not be affected by problems that might be introduced by others." Clearly the ReactOS developer is doing you a favor by not hurting your reputation if ReactOS is as Toxic as Wine makes it out to be. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 10 months

Southern California Linux Expo

by Zachary Gorden

So we've been invited to SCALE and I'm wondering whether any of the devs can actually make it. Arty is a logical choice because he's so close and we might be able to pull in some community members who are close by if we can only get one dev there. We'd get a booth on the show floor which includes table, chairs, power, ethernet drop, and 3-5 passes to the show. Are we going to be able to make it this year at all?

15 years, 10 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c

by gedmurphy

Steven has repeatedly asked for credit, and I quote: " Please add the appropriate copyright headers to the source file stating the original author when implementing code based on third party sources." Is there a reason for not doing it this time? Secondly, why are things being implemented in stubs? Thirdly, it's worth checking implementations before moving out of stubs. Just because Wine does something, doesn't mean it's correct for us. DnsHostnameToComputerName should call RtlDnsHostNameToComputerName. I stopped checking the rest of the code as soon as I read that, in case someone assumes I looked at everything. Fourthly, I'm willing to bet this email gets ignored too. Please take a little more time over commits. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dchapyshev(a)svn.reactos.org Sent: 17 November 2008 11:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Author: dchapyshev Date: Mon Nov 17 05:53:59 2008 New Revision: 37396 URL: http://svn.reactos.org/svn/reactos?rev=37396&view=rev Log: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c trunk/reactos/dll/win32/kernel32/misc/stubs.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -461,4 +461,73 @@ } } + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameA(LPCSTR Hostname, + LPSTR ComputerName, + LPDWORD nSize) +{ + DWORD len; + + DPRINT("(%s, %p, %p)\n", Hostname, ComputerName, nSize); + + if (!Hostname || !nSize) + return FALSE; + + len = lstrlenA(Hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*nSize < len) + { + *nSize = len; + return FALSE; + } + + if (!ComputerName) return FALSE; + + memcpy( ComputerName, Hostname, len ); + ComputerName[len + 1] = 0; + return TRUE; +} + + +/* + * @implemented + */ +BOOL +STDCALL +DnsHostnameToComputerNameW ( + LPCWSTR hostname, + LPWSTR computername, + LPDWORD size + ) +{ + DWORD len; + + DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); + + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len * sizeof(WCHAR) ); + computername[len + 1] = 0; + return TRUE; +} + /* EOF */ Modified: trunk/reactos/dll/win32/kernel32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/st… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/stubs.c [iso-8859-1] Mon Nov 17 05:53:59 2008 @@ -342,18 +342,29 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -BindIoCompletionCallback ( - HANDLE FileHandle, - LPOVERLAPPED_COMPLETION_ROUTINE Function, - ULONG Flags - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +BindIoCompletionCallback(HANDLE FileHandle, + LPOVERLAPPED_COMPLETION_ROUTINE Function, + ULONG Flags) +{ + NTSTATUS Status = 0; + + DPRINT("(%p, %p, %d)\n", FileHandle, Function, Flags); + + Status = RtlSetIoCompletionCallback(FileHandle, + (PRTL_OVERLAPPED_COMPLETION_ROUTINE) Function, + Flags); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -562,20 +573,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -ReadFileScatter( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToRead, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +ReadFileScatter(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToRead, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK pIOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("(%p %p %u %p)\n", hFile, aSegmentArray, nNumberOfBytesToRead, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + pIOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + pIOStatus->Status = STATUS_PENDING; + pIOStatus->Information = 0; + + Status = NtReadFileScatter(hFile, + NULL, + NULL, + NULL, + pIOStatus, + aSegmentArray, + nNumberOfBytesToRead, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -678,20 +714,45 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -WriteFileGather( - HANDLE hFile, - FILE_SEGMENT_ELEMENT aSegmentArray[], - DWORD nNumberOfBytesToWrite, - LPDWORD lpReserved, - LPOVERLAPPED lpOverlapped - ) -{ - STUB; - return 0; + * @implemented + */ +BOOL +STDCALL +WriteFileGather(HANDLE hFile, + FILE_SEGMENT_ELEMENT aSegmentArray[], + DWORD nNumberOfBytesToWrite, + LPDWORD lpReserved, + LPOVERLAPPED lpOverlapped) +{ + PIO_STATUS_BLOCK IOStatus; + LARGE_INTEGER Offset; + NTSTATUS Status; + + DPRINT("%p %p %u %p\n", hFile, aSegmentArray, nNumberOfBytesToWrite, lpOverlapped); + + Offset.LowPart = lpOverlapped->Offset; + Offset.HighPart = lpOverlapped->OffsetHigh; + IOStatus = (PIO_STATUS_BLOCK) lpOverlapped; + IOStatus->Status = STATUS_PENDING; + IOStatus->Information = 0; + + Status = NtWriteFileGather(hFile, + NULL, + NULL, + NULL, + IOStatus, + aSegmentArray, + nNumberOfBytesToWrite, + &Offset, + NULL); + + if (!NT_SUCCESS(Status)) + { + SetLastError(RtlNtStatusToDosError(Status)); + return FALSE; + } + + return TRUE; } /* @@ -705,39 +766,6 @@ { STUB; return 0; -} - -/* - * @unimplemented - */ -BOOL -STDCALL -DnsHostnameToComputerNameW ( - LPCWSTR hostname, - LPWSTR computername, - LPDWORD size - ) -{ - DWORD len; - - DPRINT("(%s, %p, %p): stub\n", hostname, computername, size); - - if (!hostname || !size) return FALSE; - len = lstrlenW(hostname); - - if (len > MAX_COMPUTERNAME_LENGTH) - len = MAX_COMPUTERNAME_LENGTH; - - if (*size < len) - { - *size = len; - return FALSE; - } - if (!computername) return FALSE; - - memcpy( computername, hostname, len * sizeof(WCHAR) ); - computername[len + 1] = 0; - return TRUE; } /* @@ -919,21 +947,6 @@ /* * @unimplemented */ -BOOL -STDCALL -DnsHostnameToComputerNameA ( - LPCSTR Hostname, - LPSTR ComputerName, - LPDWORD nSize - ) -{ - STUB; - return 0; -} - -/* - * @unimplemented - */ HANDLE STDCALL FindFirstVolumeMountPointA( @@ -947,23 +960,22 @@ } /* - * @unimplemented - */ -BOOL -STDCALL -FindNextVolumeA( - HANDLE handle, - LPSTR volume, - DWORD len - ) -{ - WCHAR *buffer = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ); + * @implemented + */ +BOOL +STDCALL +FindNextVolumeA(HANDLE handle, + LPSTR volume, + DWORD len) +{ + WCHAR *buffer = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); BOOL ret; if ((ret = FindNextVolumeW( handle, buffer, len ))) { if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, volume, len, NULL, NULL )) ret = FALSE; } + HeapFree( GetProcessHeap(), 0, buffer ); return ret; }

15 years, 10 months

Re: [ros-dev] [ros-diffs] [jimtabor] 37436: - Fixes bug 3864. While I was at it I fixed most of the gdi max bit max info sizes too. - Added notes for the SEH abuse in win32k dibobj.c. - Tested WinMerge 2.10.2, AbiWord 2.4.1, Firefox 1.5.0.3 and wine gdi32 bitmap cross test. - When testing with gdi cross test in 24 and 32 bit display mode, we have a pixel conversion mismatch. Please fix it!

by Aleksey Bragin

May I ask why those if (!Info) checks are required? To me it makes no sense to call those APIs with the cruicial, mandatory working (and in one case the only) parameter being NULL, and I would put an ASSERT (Info) there to catch bad callers and fix them. WBR, Aleksey. On Nov 18, 2008, at 8:36 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Mon Nov 17 23:36:19 2008 > New Revision: 37436 > > UINT > FASTCALL > DIB_BitmapMaxBitsSize( PBITMAPINFO Info, UINT ScanLines ) > { > UINT MaxBits = 0; > + > + if (!Info) return 0; > > > +UINT > +FASTCALL > +DIB_BitmapBitsSize( PBITMAPINFO Info ) > +{ > + UINT Ret; > + > + if (!Info) return 0;

15 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev