Ros-dev

ros-dev@reactos.org

5788 discussions

by Aleksey Bragin

Hi, this question seems to arise periodically, so let's have a constructive discussion again about the issue once again. The issue is being that a lot of people have direct commit access to the repository, and sooner or later some of them commit patches which introduce a regress in functionality. I will use Magnus (GreatLord) again as an example. He was doing a good thing (as usual), but then somehow lost focus, and along with good fixes committed a breakage for FF2.0 installer (and all other apps using PatBlt functions). I had to (as usual!) spend the whole morning reviewing all his diffs, then regress-testing by bisection to find the guilty revision, then work out a better solution with him, and then come to agreement that the guilty commit could be just reverted for now, since it partly works anyway. This takes up significant amount of my time, which could go into something more productive than just testing patches, finding way to unregress, and so on. Especially I'm angry about this happening right when approaching 0.3.5 release. Ideally (as I explained in #reactos today to blight_), I want the trunk itself be directly committable only by a very limited number of persons, and all developers should be committing to "some other place" at first, and then their patches merged by reviewers/testers (yes, manually, sometimes just reviewing may be enough to commit/ reject the patch, sometimes a thorough testing must be involved, maybe additional devs asked for a review). blight_ called this as a "linux development model" with an intermediate branch - yes, maybe, why not?. What I definately don't want to do is to scare developers away and make their life more complicated by need of sending text patches (this is just not convinient, and as seen on the example of Wine makes a lot of possible contributors going away). I remember what Alex proposed (those who don't, may look up ros-dev ML archives with a similar topic). Would there be any new prepositions? Maybe someone discovered a new CIS for SVN, or a decentralized VCS for patch submission and usual SVN for maintaining HEAD? With time, developers number is only going to increase, so this problem will become more and more annoying. With the best regards, Aleksey Bragin.

16 years, 3 months

[ros-diffs] [jimtabor] 33830: Move xform data from W structure into DcLevel within unions.

by James Tabor

Hi, I'm going to explain this ONCE: 1st: The move was to conserve and reduce space and size of the current structure. Writing a floating point package could be hard to do or just copyleft one off the net.... Problem is if we do the later it will most likely not be compatible with M$ SFPP. BTW, M$ did patent their strange and unusual floating point package. Which means I can not write one! Just writing the storage emulation is almost a problem too... But due to US patent law I can just do what I did, to "Talk to the Interface" with the storage emulation. Keeping the current state of ReactOS FP is my first choice. We use the speed of the FPU which is part of the main processor and reduce the size of the source. (Two pluses so far, Speed and Small Size.) The storage emulation for gdi32 is important for compatibility and with ReactOS concept of drop in replacement and play. Thanks, my 1EU References: Fast floating-point truncation to integer form - US Patent 6535898: http://v3.espacenet.com/textdoc?DB=EPODOC&IDX=US6535898&F=0 Use of indices for queries with comparisons based on a function: http://v3.espacenet.com/textdoc?DB=EPODOC&IDX=EP1193619&F=0 System and method for fast and smooth rendering of lit, textured spheres: http://v3.espacenet.com/textdoc?DB=EPODOC&IDX=EP1227443&F=0 John R. Hauser SoftFloat package : http://www.jhauser.us/arithmetic/SoftFloat.html IEEE 754 floating-point test software: http://www.math.utah.edu/~beebe/software/ieee/

16 years, 3 months

Firefox 1.5 installation regressed

by Aleksey Bragin

Hi, I experience a hang of FF 1.5 installation app at "0% Extracting". Sometimes hangs completely (even mouse doesn't move), sometimes I'm able to click "X" and choose yes to cancel. It started happening at least since yesterday. WBR, Aleksey Bragin.

16 years, 3 months

VIA 6103 Rhine II Net Driver Install Crash

by James Tabor

Hi, I like to start testing FF again on hardware but this bug is still open. http://www.reactos.org/bugzilla/show_bug.cgi?id=2987 I've copied most of the netamd.inf from Ros to match with the inf for the driver. But still the same crash. Please let me know, James

16 years, 3 months

[ros-diffs] [tkreuzer] 33856: - fix mem leak when failing to create an extpen with penstyles

by James Tabor

Hi! There was a reason for doing what I commit'ed,,,, since you are looking at it can you please fix this. 8^) James gdi32_winetest pen ExFreePool of already freed address 80e8ba78 KeBugCheck at ntoskrnl/mm/npool.c:1566 *** Fatal System Error: 0x00000000 (0x00000000,0x00000000,0x00000000,0x00000000) Entered debugger on embedded INT3 at 0x0008:0x808ac7d8. kdb:> bt Eip: <NTOSKRNL.EXE:ac7d9 (lib/rtl/i386/debug_asm.S:42 (RtlpBreakWithStatusInstruction))> Frames: <NTOSKRNL.EXE:29a2 (ntoskrnl/ke/bug.c:1100 (KeBugCheckWithTf@24))> <NTOSKRNL.EXE:2aac (ntoskrnl/ke/bug.c:1364 (KeBugCheck@4))> <NTOSKRNL.EXE:5f00c (ntoskrnl/mm/npool.c:1567 (ExFreeNonPagedPool@4))> <NTOSKRNL.EXE:61e64 (ntoskrnl/mm/pool.c:238 (ExFreePool@4))> <win32k.sys:967ff (subsystems/win32/win32k/objects/pen.c:344 (NtGdiExtCreatePen@44))> <NTOSKRNL.EXE:96eda (ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry))> <ntdll.dll:5dda> <gdi32_winetest.EXE:3b497> <gdi32_winetest.EXE:3d605> <gdi32_winetest.EXE:3d78d> <gdi32_winetest.EXE:3dc3d> <gdi32_winetest.EXE:3dc6a> <kernel32.dll:21610> <00000000>

16 years, 3 months

Re: [ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite for ws2_32.dll It currently tests the features I needed to adjust/implement when fixing the wininet problem. ReactOS currently passes all tests, but fails one if you launch the test app for the second tim

by gedmurphy

Should this not be in the wine tests framework? The API tests framework is quite a specialized model more suited for subsystem testing. Putting the ws2_32 stuff here just makes it more inconvenient to test. Ged. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cfinck(a)svn.reactos.org Sent: 01 June 2008 23:09 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cfinck] 33824: - Add a test suite for ws2_32.dll It currently tests the features I needed to adjust/implement when fixing the wininet problem. ReactOS currently passes all tests, but fails one if you launch the test app for the second time qu Author: cfinck Date: Sun Jun 1 17:08:45 2008 New Revision: 33824 URL: http://svn.reactos.org/svn/reactos?rev=33824&view=rev Log: - Add a test suite for ws2_32.dll It currently tests the features I needed to adjust/implement when fixing the wininet problem. ReactOS currently passes all tests, but fails one if you launch the test app for the second time quickly after the first time (timing problem in the network code?). - Fix the behaviour on an ioctlsocket FIONREAD call: The output buffer is not touched, when we have no socket, but when we have no connection, it is set to 0. - Forward the socket call to WSASocketW instead of WSASocketA, minimal performance improvement Added: trunk/rostests/apitests/ws2_32/ (with props) trunk/rostests/apitests/ws2_32/helpers.c (with props) trunk/rostests/apitests/ws2_32/testlist.c (with props) trunk/rostests/apitests/ws2_32/tests/ trunk/rostests/apitests/ws2_32/tests/ioctlsocket.c (with props) trunk/rostests/apitests/ws2_32/tests/recv.c (with props) trunk/rostests/apitests/ws2_32/ws2_32.c (with props) trunk/rostests/apitests/ws2_32/ws2_32.h (with props) trunk/rostests/apitests/ws2_32/ws2_32.rbuild (with props) Modified: trunk/reactos/dll/win32/ws2_32/misc/dllmain.c trunk/reactos/drivers/network/afd/afd/info.c trunk/rostests/apitests/directory.rbuild Modified: trunk/reactos/dll/win32/ws2_32/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32/misc/dllm… ============================================================================== --- trunk/reactos/dll/win32/ws2_32/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32/misc/dllmain.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -166,7 +166,7 @@ IN INT type, IN INT protocol) { - return WSASocketA(af, + return WSASocketW(af, type, protocol, NULL, Modified: trunk/reactos/drivers/network/afd/afd/info.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/in… ============================================================================== --- trunk/reactos/drivers/network/afd/afd/info.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/afd/afd/info.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -49,9 +49,9 @@ break; case AFD_INFO_RECEIVE_CONTENT_SIZE: - /* Only touch InfoReq if we actually have a valid connection. + /* Only touch InfoReq if a socket has been set up. Behaviour was verified under WinXP SP2. */ - if(FCB->Connection.Handle) + if(FCB->AddressFile.Object) InfoReq->Information.Ulong = FCB->Recv.Content - FCB->Recv.BytesUsed; break; Modified: trunk/rostests/apitests/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/directory.rbuild… ============================================================================== --- trunk/rostests/apitests/directory.rbuild [iso-8859-1] (original) +++ trunk/rostests/apitests/directory.rbuild [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -23,4 +23,8 @@ <directory name="w32knapi"> <xi:include href="w32knapi/w32knapi.rbuild" /> </directory> + + <directory name="ws2_32"> + <xi:include href="ws2_32/ws2_32.rbuild" /> + </directory> </group> Propchange: trunk/rostests/apitests/ws2_32/ ------------------------------------------------------------------------------ --- svn:ignore (added) +++ svn:ignore Sun Jun 1 17:08:45 2008 @@ -1,0 +1,7 @@ +GNUmakefile +*.vcproj +*.user +*.cbp +*.ncb +*.suo +*.sln Added: trunk/rostests/apitests/ws2_32/helpers.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/helpers.c… ============================================================================== --- trunk/rostests/apitests/ws2_32/helpers.c (added) +++ trunk/rostests/apitests/ws2_32/helpers.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,65 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/helpers.c + * PURPOSE: Helper functions for the socket tests + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#include "ws2_32.h" + +int CreateSocket(PTESTINFO pti, SOCKET* psck) +{ + /* Create the socket */ + *psck = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); + TEST(*psck != INVALID_SOCKET); + + if(*psck == INVALID_SOCKET) + { + printf("Winsock error code is %u\n", WSAGetLastError()); + WSACleanup(); + return APISTATUS_ASSERTION_FAILED; + } + + return APISTATUS_NORMAL; +} + +int ConnectToReactOSWebsite(PTESTINFO pti, SOCKET sck) +{ + int iResult; + struct hostent* host; + struct sockaddr_in sa; + + /* Connect to "www.reactos.org" */ + host = gethostbyname("www.reactos.org"); + + sa.sin_family = AF_INET; + sa.sin_addr.s_addr = *(u_long*)host->h_addr_list[0]; + sa.sin_port = htons(80); + + SCKTEST(connect(sck, (struct sockaddr *)&sa, sizeof(sa))); + + return APISTATUS_NORMAL; +} + +int GetRequestAndWait(PTESTINFO pti, SOCKET sck) +{ + const char szGetRequest[] = "GET / HTTP/1.0\r\n\r\n"; + int iResult; + struct fd_set readable; + + /* Send the GET request */ + SCKTEST(send(sck, szGetRequest, strlen(szGetRequest), 0)); + TEST(iResult == strlen(szGetRequest)); + + /* Shutdown the SEND connection */ + SCKTEST(shutdown(sck, SD_SEND)); + + /* Wait until we're ready to read */ + FD_ZERO(&readable); + FD_SET(sck, &readable); + + SCKTEST(select(0, &readable, NULL, NULL, NULL)); + + return APISTATUS_NORMAL; +} Propchange: trunk/rostests/apitests/ws2_32/helpers.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/testlist.… ============================================================================== --- trunk/rostests/apitests/ws2_32/testlist.c (added) +++ trunk/rostests/apitests/ws2_32/testlist.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,33 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/testlist.c + * PURPOSE: Test list file + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#ifndef _WS2_32_TESTLIST_H +#define _WS2_32_TESTLIST_H + +#define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0])) + +#include "ws2_32.h" + +/* include the tests */ +#include "tests/ioctlsocket.c" +#include "tests/recv.c" + +/* The List of tests */ +TESTENTRY TestList[] = +{ + { L"ioctlsocket", Test_ioctlsocket }, + { L"recv", Test_recv } +}; + +/* The function that gives us the number of tests */ +INT NumTests(void) +{ + return ARRAY_SIZE(TestList); +} + +#endif Propchange: trunk/rostests/apitests/ws2_32/testlist.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/tests/ioctlsocket.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/tests/ioc… ============================================================================== --- trunk/rostests/apitests/ws2_32/tests/ioctlsocket.c (added) +++ trunk/rostests/apitests/ws2_32/tests/ioctlsocket.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,83 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/tests/ioctlsocket.c + * PURPOSE: Tests for the ioctlsocket function + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#include "../ws2_32.h" + +/* For valid test results, the ReactOS Website needs to return at least 2 bytes on a "GET / HTTP/1.0" request. */ +INT +Test_ioctlsocket(PTESTINFO pti) +{ + LPSTR pszBuf; + int iResult; + SOCKET sck; + ULONG BytesAvailable; + ULONG BytesToRead; + WSADATA wdata; + + /* Start up Winsock */ + TEST(WSAStartup(MAKEWORD(2, 2), &wdata) == 0); + + /* If we call ioctlsocket without a socket, it should return with an error and do nothing. */ + BytesAvailable = 0xdeadbeef; + TEST(ioctlsocket(0, FIONREAD, &BytesAvailable) == SOCKET_ERROR); + TEST(BytesAvailable == 0xdeadbeef); + + /* Create the socket */ + iResult = CreateSocket(pti, &sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Now we can pass at least a socket, but we have no connection yet. The function should return 0. */ + BytesAvailable = 0xdeadbeef; + TEST(ioctlsocket(sck, FIONREAD, &BytesAvailable) == 0); + TEST(BytesAvailable == 0); + + /* Connect to "www.reactos.org" */ + iResult = ConnectToReactOSWebsite(pti, sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Even with a connection, there shouldn't be any bytes available. */ + TEST(ioctlsocket(sck, FIONREAD, &BytesAvailable) == 0); + TEST(BytesAvailable == 0); + + /* Send the GET request */ + iResult = GetRequestAndWait(pti, sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Try ioctlsocket with FIONREAD. There should be bytes available now. */ + SCKTEST(ioctlsocket(sck, FIONREAD, &BytesAvailable)); + TEST(BytesAvailable != 0); + + /* Get half of the data */ + BytesToRead = BytesAvailable / 2; + pszBuf = (LPSTR) HeapAlloc(g_hHeap, 0, BytesToRead); + SCKTEST(recv(sck, pszBuf, BytesToRead, 0)); + HeapFree(g_hHeap, 0, pszBuf); + + BytesToRead = BytesAvailable - BytesToRead; + + /* Now try ioctlsocket again. BytesAvailable should be at the value saved in BytesToRead now. */ + SCKTEST(ioctlsocket(sck, FIONREAD, &BytesAvailable)); + TEST(BytesAvailable == BytesToRead); + + /* Read those bytes */ + pszBuf = (LPSTR) HeapAlloc(g_hHeap, 0, BytesToRead); + SCKTEST(recv(sck, pszBuf, BytesToRead, 0)); + HeapFree(g_hHeap, 0, pszBuf); + + /* Try it for the last time. BytesAvailable should be at 0 now. */ + SCKTEST(ioctlsocket(sck, FIONREAD, &BytesAvailable)); + TEST(BytesAvailable == 0); + + closesocket(sck); + WSACleanup(); + + return APISTATUS_NORMAL; +} Propchange: trunk/rostests/apitests/ws2_32/tests/ioctlsocket.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/tests/recv.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/tests/rec… ============================================================================== --- trunk/rostests/apitests/ws2_32/tests/recv.c (added) +++ trunk/rostests/apitests/ws2_32/tests/recv.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,69 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/tests/recv.c + * PURPOSE: Tests for the recv function + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#include "../ws2_32.h" + +#define RECV_BUF 4 + +/* For valid test results, the ReactOS Website needs to return at least 8 bytes on a "GET / HTTP/1.0" request. + Also the first 4 bytes and the last 4 bytes need to be different. + Both factors usually apply on standard HTTP responses. */ +INT +Test_recv(PTESTINFO pti) +{ + const char szDummyBytes[RECV_BUF] = {0xFF, 0x00, 0xFF, 0x00}; + + char szBuf1[RECV_BUF]; + char szBuf2[RECV_BUF]; + int iResult; + SOCKET sck; + WSADATA wdata; + + /* Start up Winsock */ + TEST(WSAStartup(MAKEWORD(2, 2), &wdata) == 0); + + /* If we call recv without a socket, it should return with an error and do nothing. */ + memcpy(szBuf1, szDummyBytes, RECV_BUF); + TEST(recv(0, szBuf1, RECV_BUF, 0) == SOCKET_ERROR); + TEST(!memcmp(szBuf1, szDummyBytes, RECV_BUF)); + + /* Create the socket */ + iResult = CreateSocket(pti, &sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Now we can pass at least a socket, but we have no connection yet. Should return with an error and do nothing. */ + memcpy(szBuf1, szDummyBytes, RECV_BUF); + TEST(recv(sck, szBuf1, RECV_BUF, 0) == SOCKET_ERROR); + TEST(!memcmp(szBuf1, szDummyBytes, RECV_BUF)); + + /* Connect to "www.reactos.org" */ + iResult = ConnectToReactOSWebsite(pti, sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Send the GET request */ + iResult = GetRequestAndWait(pti, sck); + if(iResult != APISTATUS_NORMAL) + return iResult; + + /* Receive the data. + MSG_PEEK will not change the internal number of bytes read, so that a subsequent request should return the same bytes again. */ + SCKTEST(recv(sck, szBuf1, RECV_BUF, MSG_PEEK)); + SCKTEST(recv(sck, szBuf2, RECV_BUF, 0)); + TEST(!memcmp(szBuf1, szBuf2, RECV_BUF)); + + /* The last recv() call moved the internal file pointer, so that the next request should return different data. */ + SCKTEST(recv(sck, szBuf1, RECV_BUF, 0)); + TEST(memcmp(szBuf1, szBuf2, RECV_BUF)); + + closesocket(sck); + WSACleanup(); + + return APISTATUS_NORMAL; +} Propchange: trunk/rostests/apitests/ws2_32/tests/recv.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/ws2_32.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/ws2_32.c?… ============================================================================== --- trunk/rostests/apitests/ws2_32/ws2_32.c (added) +++ trunk/rostests/apitests/ws2_32/ws2_32.c [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,24 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/ws2_32.c + * PURPOSE: Program entry point + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#include "ws2_32.h" + +HANDLE g_hHeap; + +BOOL +IsFunctionPresent(LPWSTR lpszFunction) +{ + return TRUE; +} + +int wmain() +{ + g_hHeap = GetProcessHeap(); + + return TestMain(L"ws2_32_apitests", L"ws2_32.dll"); +} Propchange: trunk/rostests/apitests/ws2_32/ws2_32.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/ws2_32.h URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/ws2_32.h?… ============================================================================== --- trunk/rostests/apitests/ws2_32/ws2_32.h (added) +++ trunk/rostests/apitests/ws2_32/ws2_32.h [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,36 @@ +/* + * PROJECT: ws2_32.dll API tests + * LICENSE: GPLv2 or any later version + * FILE: apitests/ws2_32/ws2_32.h + * PURPOSE: Main header file + * COPYRIGHT: Copyright 2008 Colin Finck <mail(a)colinfinck.de> + */ + +#ifndef _WS2_32_APITESTS_H +#define _WS2_32_APITESTS_H + +#include <winsock2.h> + +#include "../apitest.h" + +/* Simple macro for executing a socket command and doing cleanup operations in case of a failure */ +#define SCKTEST(_cmd_) \ + iResult = _cmd_; \ + TEST(iResult != SOCKET_ERROR); \ + if(iResult == SOCKET_ERROR) \ + { \ + printf("Winsock error code is %u\n", WSAGetLastError()); \ + closesocket(sck); \ + WSACleanup(); \ + return APISTATUS_ASSERTION_FAILED; \ + } + +/* helpers.c */ +int CreateSocket(PTESTINFO pti, SOCKET* sck); +int ConnectToReactOSWebsite(PTESTINFO pti, SOCKET sck); +int GetRequestAndWait(PTESTINFO pti, SOCKET sck); + +/* ws2_32.c */ +extern HANDLE g_hHeap; + +#endif Propchange: trunk/rostests/apitests/ws2_32/ws2_32.h ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ws2_32/ws2_32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/ws2_32.rb… ============================================================================== --- trunk/rostests/apitests/ws2_32/ws2_32.rbuild (added) +++ trunk/rostests/apitests/ws2_32/ws2_32.rbuild [iso-8859-1] Sun Jun 1 17:08:45 2008 @@ -1,0 +1,11 @@ +<module name="ws2_32_apitests" type="win32cui" unicode="yes"> + <define name="_WIN32_WINNT">0x0501</define> + <library>apitest</library> + <library>kernel32</library> + <library>user32</library> + <library>shell32</library> + <library>ws2_32</library> + <file>helpers.c</file> + <file>testlist.c</file> + <file>ws2_32.c</file> +</module> Propchange: trunk/rostests/apitests/ws2_32/ws2_32.rbuild ------------------------------------------------------------------------------ svn:eol-style = native

16 years, 3 months

Re: [ros-dev] [ros-diffs] [cfinck] 33824: - Add a test suite forws2_32.dll It currently tests the features I needed toadjust/implement when fixing the wininet problem. ReactOScurrently passes all tests, but fails one if you launch the test app for th

by Steven Edwards

On Tue, Jun 3, 2008 at 5:08 PM, Colin Finck <mail(a)colinfinck.de> wrote: > The Wine test framework is currently only used by tests imported from Wine, > so an own test suite for ws2_32.dll might get lost there. You could have written the tests for the wine test suite and submitted them. > Also Timo's testing framework offers some interesting features like HTML > output not offered by the Wine one. Sure, but given the size of the wine test suite verses Timo's I think the effort is better spent adding this to winetest > Additionally, we have a free hand here and can play with it as we want, > while we can only import and maybe make little changes to the Wine test > framework if we want to avoid a big merging mess. Your always free to fork. As I said given the large number of unit tests in the Wine framework it seems to make more sense to me to extend that rather than develop a new one. Besides you can add the features you need to the Winetest gui and have it be independent of the framework as a whole. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 3 months

Re: [ros-dev] [ros-diffs] [greatlrd] 33807: add Test for EngDeleteSemaphore, it only test if it been create or not

by Alex Ionescu

I'm getting *quite* annoyed with seeing these kinds of tests: ret = SomeFunc(); ASSERT(ret == success); How exactly is this a test anyway? It proves in NO way that the function *worked*, only that it returned success. Furthermore, there are *plenty* of cases where a function could legitimately fail -- it is simply stupid to assume that a failure means a regression. What if the system is out of memory? On Sun, Jun 1, 2008 at 10:38 PM, <greatlrd(a)svn.reactos.org> wrote: > Author: greatlrd > Date: Sun Jun 1 09:38:02 2008 > New Revision: 33807 > > URL: http://svn.reactos.org/svn/reactos?rev=33807&view=rev > Log: > add Test for EngDeleteSemaphore, it only test if it been create or not > > Added: > trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c (with props) > Modified: > trunk/rostests/apitests/gdi32api/testlist.c > > Modified: trunk/rostests/apitests/gdi32api/testlist.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/testlis… > ============================================================================== > --- trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] (original) > +++ trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] Sun Jun 1 09:38:02 2008 > @@ -11,6 +11,7 @@ > #include "tests/CreateFont.c" > #include "tests/CreatePen.c" > #include "tests/CreateRectRgn.c" > +#include "tests/EngCreateSemaphore.c" > #include "tests/ExtCreatePen.c" > #include "tests/GdiConvertBitmap.c" > #include "tests/GdiConvertBrush.c" > @@ -51,6 +52,7 @@ > { L"CreateCompatibleDC", Test_CreateCompatibleDC }, > { L"CreateFont", Test_CreateFont }, > { L"CreatePen", Test_CreatePen }, > + { L"EngCreateSemaphore", Test_EngCreateSemaphore }, > { L"CreateRectRgn", Test_CreateRectRgn }, > { L"ExtCreatePen", Test_ExtCreatePen }, > { L"GdiConvertBitmap", Test_GdiConvertBitmap }, > > Added: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c > URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/tests/E… > ============================================================================== > --- trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c (added) > +++ trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c [iso-8859-1] Sun Jun 1 09:38:02 2008 > @@ -1,0 +1,15 @@ > +/* Simple test of EngAcquireSemaphore only check if we got a lock or not */ > +INT > +Test_EngCreateSemaphore(PTESTINFO pti) > +{ > + > + HSEMAPHORE hsem; > + hsem = EngCreateSemaphore(); > + > + RTEST ( hsem != NULL ); > + > + EngDeleteSemaphore(hsem); > + > + return APISTATUS_NORMAL; > +} > + > > Propchange: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > -- Best regards, Alex Ionescu

16 years, 3 months

[ros-diffs] [greatlrd] 33783: revert my last change

by James Tabor

Hi! I checked this and it is all wrong,,,,, I reverted part of revision 19267: Replacing the code with the original wine code that behaves like "Windows code" but should be called inside EngCreateBitmap if (pvBits) Width = DIB_GetDIBWidthBytes( lWidth, iFormat); . As it should be: INT FASTCALL DIB_GetDIBWidthBytes (INT width, INT depth) { // return ((width * depth + 31) & ~31) >> 3; int words; switch(depth) { case 1: words = (width + 31) / 32; break; case 4: words = (width + 7) / 8; break; case 8: words = (width + 3) / 4; break; case 15: case 16: words = (width + 1) / 2; break; case 24: words = (width * 3 + 3)/4; break; default: DPRINT1("(%d): Unsupported depth\n", depth ); /* fall through */ case 32: words = width; } return 4 * words; }

16 years, 4 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 33792: preserve code for NtGdiCreateEnhMetaFile from win32k (where it's going to be removed later) in gdi32 (where it's going to be implemented later)

by Steven Edwards

On Sat, May 31, 2008 at 7:15 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Sat May 31 18:15:34 2008 > New Revision: 33792 > > URL: http://svn.reactos.org/svn/reactos?rev=33792&view=rev > Log: > preserve code for NtGdiCreateEnhMetaFile from win32k (where it's going to be removed later) in gdi32 (where it's going to be implemented later) if your going to implement it all in usermode are you going to try to just rip the Wine metafile and enhanced metefile drivers? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev