Ros-dev

ros-dev@reactos.org

5788 discussions

by James Tabor

Hi, I did some research and found something very interesting. I kept thinking about the last DCE commit (34289). I had a guess and modified the user32 test for wine. The results are very clear. Apparently windows does not care for which dc is returned if it is Cached or a bug since hWnd is the same. When DCX_NORESETATTRS is set when calling GetDCEx; "Does not reset the attributes of this DC to the default attributes when this DC is released." We do this correctly in ReleaseDC. So the next GetDCEx should keep the original DC data for the next set of tests. Wine test is completely incorrect. So all of our DCE attributes code is good to go. Windows did not pass the modified "Same hDC" check and we still fail the "ROP" check. See the windows results at the end of this message. //////// Changes to user32/tests/dce.c: ReleaseDC( hwnd_cache, hdc ); hdc = GetDCEx( hwnd_cache, 0, DCX_USESTYLE | DCX_NORESETATTRS ); <------ DCX_NORESETATTRS rop = GetROP2( hdc ); ok( rop == def_rop || rop == R2_WHITE, "wrong ROP2 %d after release\n", rop ); ReleaseDC( hwnd_cache, hdc ); + old_hdc = hdc; hdc = GetDCEx( hwnd_cache, 0, DCX_USESTYLE ); rop = GetROP2( hdc ); + ok( old_hdc == hdc, "didn't get same DC %p/%p\n", old_hdc, hdc ); ok( rop == def_rop, "wrong ROP2 %d after release\n", rop ); ReleaseDC( hwnd_cache, hdc ); /* test own DC */ //////// //////// Results from XP: Microsoft Windows XP [Version 5.1.2600] (C) Copyright 1985-2001 Microsoft Corp. Z:\>e: E:\>user32_crosstest dce dce.c:79: Test failed: didn't get same DC F5010866/FC0107E0 dce: 77 tests executed (0 marked as todo, 1 failure), 0 skipped. E:\> /////////

16 years, 2 months

Re: [ros-dev] [ros-diffs] [jimtabor] 34276: GetLastActivePopup is still unimplemented, we return the current window handle if it is valid.

by Aleksey Bragin

It would make sense to add a WARN there or something like that, so it could be seen that it is halfplemented only. WBR, Aleksey. On Jul 3, 2008, at 11:17 AM, jimtabor(a)svn.reactos.org wrote: > Author: jimtabor > Date: Thu Jul 3 02:17:32 2008 > New Revision: 34276 > > URL: http://svn.reactos.org/svn/reactos?rev=34276&view=rev > Log: > GetLastActivePopup is still unimplemented, we return the current > window handle if it is valid. > > Modified: > trunk/reactos/dll/win32/user32/windows/window.c > > Modified: trunk/reactos/dll/win32/user32/windows/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ > user32/windows/window.c?rev=34276&r1=34275&r2=34276&view=diff > ====================================================================== > ======== > --- trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] > Thu Jul 3 02:17:32 2008 > @@ -921,8 +921,24 @@ > HWND STDCALL > GetLastActivePopup(HWND hWnd) > { > - UNIMPLEMENTED; > - return 0; > + PWINDOW Wnd, WndParent; > + HWND Ret = NULL; > + > + Wnd = ValidateHwnd(hWnd); > + if (Wnd != NULL) > + { > + _SEH_TRY > + { > + WndParent = NULL; > + Ret = hWnd; > + } > + _SEH_HANDLE > + { > + /* Do nothing */ > + } > + _SEH_END; > + } > + return Ret; > } > > >

16 years, 2 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll

by Heis Spiter

I also agree. About the last point, in Ged's mail, I'm afraid to say I've real difficulties to code with such build time. I'm obliged to work on outdated revisons, and on partial builds. That's really insane. P. Schweitzer -------------------------------------------------- From: "gedmurphy" <gedmurphy(a)gmail.com> Sent: Wednesday, July 02, 2008 5:49 PM To: "'ReactOS Development List'" <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll > I completely agree, this needs to be clamped down on. Do we really need 78 > different keyboard layouts at this point? > It's fine for the people with mega fast systems and time on their hands, > but > most people don't fall into this category. > > I now try to avoid building as much as possible and I suspect more people > will be following suit if the build time continues to increase. > > Ged > >

16 years, 2 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll

by Heis Spiter

Once again I agree, and I'd like to add my 2 cents, perhaps it will help. We need two solutions right now. A short term one, and a long term one. The short one, purposed by Ged seems, IMO, to be a nice alternative before more important work, and seems to be quite easy to realize. The long one could be a work on rbuild (and makefile) with the hierarchy purposed by Ged. And instead of typing make bootcd, we would have to type make bootcd X where X would be the additionnal components with hierarchy. P. Schweitzer -------------------------------------------------- From: "gedmurphy" <gedmurphy(a)gmail.com> Sent: Thursday, July 03, 2008 9:19 AM To: "'ReactOS Development List'" <ros-dev(a)reactos.org> Subject: Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll > I'm certainly not asking him to stop. But I do think we need a rethink of > our tree structure. > The rosapps thing has never been ideal either, so moving stuff into there > isn't a good solution. > > Perhaps we need a hierarchy of components listed for importance. Let's say > the list ranges from 1 to 10. 1 being core components required to boot the > OS, 2 being additional components to get to the GUI, etc, with 10 being > things like these keyboard dlls I used as an earlier example. > > However, such a solution isn't a 5 minute job so we do need a quick fix in > the meantime. Maybe something similar to how rosapps works, with an > addition > to the /modules rbuild file? > > Ged. > > -----Original Message----- > From: ros-dev-bounces(a)reactos.org [mailto:ros-dev-bounces@reactos.org] On > Behalf Of Aleksey Bragin > Sent: 02 July 2008 22:34 > To: ReactOS Development List > Subject: Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll > > Asking Dmitry to abstain from work would be considered "a hack", not > "a proper solution". > > WBR, > Aleksey. > > On Jul 3, 2008, at 12:45 AM, Heis Spiter wrote: > >> I also agree. >> About the last point, in Ged's mail, I'm afraid to say I've real >> difficulties to code with such build time. I'm obliged to work on >> outdated >> revisons, and on partial builds. That's really insane. >> >> P. Schweitzer > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

16 years, 2 months

Re: [ros-dev] Prevent boolean flags from being optimized away by compiler

by Dmitry Gorbachev

Hi, Something else: there are two FORCEINLINE functions in ntoskrnl/include/internal/ntoskrnl.h, DefaultSetInfoBufferCheck() and DefaultQueryInfoBufferCheck(), but they cannot be inlined because of SEH (i.e. setjmp/longjmp). Timo Kreuzer wrote: > What about wrapping the _SEH_TRY part in a local inline function? In my > tests this successfully prevented the variables from being optimized away. > At least under normal optimisation settings.

16 years, 2 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll

by Marc Piulachs

What's the point of adding all those useless stubbed dlls? It only contributes to increase build time -------------------------------------------------- From: <dchapyshev(a)svn.reactos.org> Sent: Friday, June 27, 2008 7:34 PM To: <ros-diffs(a)reactos.org> Subject: [ros-diffs] [dchapyshev] 34135: - Add fontext.dll > Author: dchapyshev > Date: Fri Jun 27 12:34:08 2008 > New Revision: 34135 > > URL: http://svn.reactos.org/svn/reactos?rev=34135&view=rev > Log: > - Add fontext.dll > > Added: > trunk/reactos/dll/shellext/fontext/ > trunk/reactos/dll/shellext/fontext/fontext.c (with props) > trunk/reactos/dll/shellext/fontext/fontext.def (with props) > trunk/reactos/dll/shellext/fontext/fontext.h (with props) > trunk/reactos/dll/shellext/fontext/fontext.rbuild (with props) > trunk/reactos/dll/shellext/fontext/fontext.rc (with props) > trunk/reactos/dll/shellext/fontext/lang/ > trunk/reactos/dll/shellext/fontext/lang/en-US.rc (with props) > trunk/reactos/dll/shellext/fontext/regsvr.c (with props) > trunk/reactos/dll/shellext/fontext/resource.h (with props) > trunk/reactos/dll/shellext/fontext/rsrc.rc (with props) > Modified: > trunk/reactos/dll/shellext/shellext.rbuild > > Added: trunk/reactos/dll/shellext/fontext/fontext.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/fonte… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/fontext.c (added) > +++ trunk/reactos/dll/shellext/fontext/fontext.c [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,45 @@ > +/* > + * > + * PROJECT: fontext.dll > + * FILE: dll/shellext/fontext/fontext.c > + * PURPOSE: fontext.dll > + * PROGRAMMER: Dmitry Chapyshev (dmitry(a)reactos.org) > + * UPDATE HISTORY: > + * 10-06-2008 Created > + */ > + > +#include "fontext.h" > + > +static HINSTANCE hInstance; > + > +HRESULT WINAPI > +DllCanUnloadNow(VOID) > +{ > + DPRINT1("DllCanUnloadNow() stubs\n"); > + return S_OK; > +} > + > +HRESULT WINAPI > +DllGetClassObject(REFCLSID rclsid, > + REFIID riid, > + LPVOID *ppv) > +{ > + DPRINT1("DllGetClassObject() stubs\n"); > + return S_OK; > +} > + > +BOOL STDCALL > +DllMain(HINSTANCE hinstDLL, > + DWORD dwReason, > + LPVOID lpvReserved) > +{ > + switch (dwReason) > + { > + case DLL_PROCESS_ATTACH: > + hInstance = hinstDLL; > + DisableThreadLibraryCalls(hInstance); > + break; > + } > + > + return TRUE; > +} > > Propchange: trunk/reactos/dll/shellext/fontext/fontext.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/fontext.def > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/fonte… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/fontext.def (added) > +++ trunk/reactos/dll/shellext/fontext/fontext.def [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,6 @@ > +LIBRARY fontext.dll > +EXPORTS > +DllCanUnloadNow > +DllGetClassObject > +DllRegisterServer > +DllUnregisterServer > > Propchange: trunk/reactos/dll/shellext/fontext/fontext.def > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/fontext.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/fonte… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/fontext.h (added) > +++ trunk/reactos/dll/shellext/fontext/fontext.h [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,12 @@ > +#ifndef __FONTEXT__H > +#define __FONTEXT__H > + > +#define COBJMACROS > +#include <windows.h> > +#include <tchar.h> > +#include <stdio.h> > +#include <shlobj.h> > + > +#include <debug.h> > + > +#endif /* __FONTEXT__H */ > > Propchange: trunk/reactos/dll/shellext/fontext/fontext.h > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/fontext.rbuild > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/fonte… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/fontext.rbuild (added) > +++ trunk/reactos/dll/shellext/fontext/fontext.rbuild [iso-8859-1] Fri Jun > 27 12:34:08 2008 > @@ -1,0 +1,21 @@ > +<module name="fontext" type="win32dll" > baseaddress="${BASEADDRESS_FONTEXT}" installbase="system32" > installname="fontext.dll" unicode="yes"> > + <importlibrary definition="fontext.def" /> > + <include base="fontext">.</include> > + <define name="_WIN32_IE">0x0500</define> > + <define name="_WIN32_WINNT">0x0600</define> > + <define name="WINVER">0x0600</define> > + <library>ntdll</library> > + <library>kernel32</library> > + <library>user32</library> > + <library>gdi32</library> > + <library>ole32</library> > + <library>uuid</library> > + <library>msvcrt</library> > + <library>shlwapi</library> > + <library>lz32</library> > + <library>advapi32</library> > + <library>setupapi</library> > + <file>fontext.c</file> > + <file>regsvr.c</file> > + <file>fontext.rc</file> > +</module> > > Propchange: trunk/reactos/dll/shellext/fontext/fontext.rbuild > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/fontext.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/fonte… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/fontext.rc (added) > +++ trunk/reactos/dll/shellext/fontext/fontext.rc [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,10 @@ > +#include <windows.h> > +#include "resource.h" > + > +#define REACTOS_VERSION_DLL > +#define REACTOS_STR_FILE_DESCRIPTION "ReactOS Font Folder\0" > +#define REACTOS_STR_INTERNAL_NAME "fontext\0" > +#define REACTOS_STR_ORIGINAL_FILENAME "fontext.dll\0" > +#include <reactos/version.rc> > + > +#include "rsrc.rc" > > Propchange: trunk/reactos/dll/shellext/fontext/fontext.rc > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/lang/en-US.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/lang/… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/lang/en-US.rc (added) > +++ trunk/reactos/dll/shellext/fontext/lang/en-US.rc [iso-8859-1] Fri Jun > 27 12:34:08 2008 > @@ -1,0 +1,9 @@ > +// Don't translate this file at current time > + > +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US > + > +STRINGTABLE > +BEGIN > + IDS_REACTOS_FONTS_FOLDER "ReactOS Font Folder" > +END > + > > Propchange: trunk/reactos/dll/shellext/fontext/lang/en-US.rc > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/regsvr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/regsv… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/regsvr.c (added) > +++ trunk/reactos/dll/shellext/fontext/regsvr.c [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,38 @@ > +/* > + * > + * PROJECT: fontext.dll > + * FILE: dll/shellext/fontext/regsvr.c > + * PURPOSE: fontext.dll > + * PROGRAMMER: Dmitry Chapyshev (dmitry(a)reactos.org) > + * UPDATE HISTORY: > + * 10-06-2008 Created > + */ > + > +#include <windows.h> > +#include <ole2.h> > + > +#include <fontext.h> > + > +static HRESULT > +REGSVR_RegisterServer() > +{ > + return S_OK; > +} > + > +static HRESULT > +REGSVR_UnregisterServer() > +{ > + return S_OK; > +} > + > +HRESULT WINAPI > +DllRegisterServer(VOID) > +{ > + return REGSVR_RegisterServer(); > +} > + > +HRESULT WINAPI > +DllUnregisterServer(VOID) > +{ > + return REGSVR_UnregisterServer(); > +} > > Propchange: trunk/reactos/dll/shellext/fontext/regsvr.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/resource.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/resou… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/resource.h (added) > +++ trunk/reactos/dll/shellext/fontext/resource.h [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,6 @@ > +#ifndef __RESOURCE__H > +#define __RESOURCE__H > + > +#define IDS_REACTOS_FONTS_FOLDER 151 > + > +#endif /* __RESOURCE__H */ > > Propchange: trunk/reactos/dll/shellext/fontext/resource.h > ------------------------------------------------------------------------------ > svn:eol-style = native > > Added: trunk/reactos/dll/shellext/fontext/rsrc.rc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/fontext/rsrc.… > ============================================================================== > --- trunk/reactos/dll/shellext/fontext/rsrc.rc (added) > +++ trunk/reactos/dll/shellext/fontext/rsrc.rc [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -1,0 +1,4 @@ > +#include <windows.h> > +#include "resource.h" > + > +#include "lang/en-US.rc" > > Propchange: trunk/reactos/dll/shellext/fontext/rsrc.rc > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/dll/shellext/shellext.rbuild > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/shellext.rbui… > ============================================================================== > --- trunk/reactos/dll/shellext/shellext.rbuild [iso-8859-1] (original) > +++ trunk/reactos/dll/shellext/shellext.rbuild [iso-8859-1] Fri Jun 27 > 12:34:08 2008 > @@ -10,6 +10,9 @@ > <directory name="devcpux"> > <xi:include href="devcpux/devcpux.rbuild" /> > </directory> > + <directory name="fontext"> > + <xi:include href="fontext/fontext.rbuild" /> > + </directory> > <directory name="slayer"> > <xi:include href="slayer/slayer.rbuild" /> > </directory> > >

16 years, 2 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 34135: - Add fontext.dll

by Marc Piulachs

>> I now try to avoid building as much as possible and I suspect more people >> will be following suit if the build time continues to increase. > > We could develop a lean target that only builds the bare apps and > libraries required. That's one of the things I experimented with while working on my C# rbuild implementation http://www.marcpiulachs.com/reactos/designer.html . My intention is to end up adding that kind of Platform Builder like feature to our C++ implementation Regards, /Marc

16 years, 2 months

Re: [ros-dev] [ros-diffs] [fireball] 34232: Yuri Sidorov <jura@cp-lab.com> - Prevent boolean flags from being optimized away by compiler (due to PSEH usage) by making them volatile. See issue #3408 for more details.

by Alex Ionescu

What? Why would the compiler optimize these away? This doesn't make any sense. If something is happening to these flags, PSEH should be fixed -- not making every flag in the source base a volatile. On 1-Jul-08, at 3:48 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Tue Jul 1 05:48:50 2008 > New Revision: 34232 > > URL: http://svn.reactos.org/svn/reactos?rev=34232&view=rev > Log: > Yuri Sidorov <jura(a)cp-lab.com> > - Prevent boolean flags from being optimized away by compiler (due > to PSEH usage) by making them volatile. > See issue #3408 for more details. > > Modified: > trunk/reactos/ntoskrnl/mm/virtual.c > > Modified: trunk/reactos/ntoskrnl/mm/virtual.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] Tue Jul 1 > 05:48:50 2008 > @@ -70,7 +70,7 @@ > PFN_NUMBER MdlBuffer[(sizeof(MDL) / sizeof(PFN_NUMBER)) + > MI_MAPPED_COPY_PAGES + 1]; > PMDL Mdl = (PMDL)MdlBuffer; > ULONG TotalSize, CurrentSize, RemainingSize; > - BOOLEAN FailedInProbe = FALSE, FailedInMapping = FALSE, > FailedInMoving; > + volatile BOOLEAN FailedInProbe = FALSE, FailedInMapping = > FALSE, FailedInMoving; > BOOLEAN PagesLocked; > PVOID CurrentAddress = SourceAddress, CurrentTargetAddress = > TargetAddress; > PVOID MdlAddress; > @@ -225,7 +225,7 @@ > { > UCHAR StackBuffer[MI_POOL_COPY_BYTES]; > ULONG TotalSize, CurrentSize, RemainingSize; > - BOOLEAN FailedInProbe = FALSE, FailedInMoving, HavePoolAddress > = FALSE; > + volatile BOOLEAN FailedInProbe = FALSE, FailedInMoving, > HavePoolAddress = FALSE; > PVOID CurrentAddress = SourceAddress, CurrentTargetAddress = > TargetAddress; > PVOID PoolAddress; > KAPC_STATE ApcState; > Best regards, Alex Ionescu

16 years, 2 months

Re: [ros-dev] [ros-diffs] [fireball] 34230: - Fix a problem with normal and special APCs being inserted in the wrong order, spotted by Jury Sidorov. Now Borland Turbo Debugger should be able to debug applications, also it can fix hangs in other applications. - When delivering kernel APC, set the pending flag to false (by analogy with delivering user APC and clearing its pending flag). See issue #3426 for more details.

by Alex Ionescu

Um... KiDeliverApc already sets KernelApcPending = FALSE; Now you're setting it twice...please revert. On 1-Jul-08, at 3:08 AM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Tue Jul 1 05:08:14 2008 > New Revision: 34230 > > URL: http://svn.reactos.org/svn/reactos?rev=34230&view=rev > Log: > - Fix a problem with normal and special APCs being inserted in the > wrong order, spotted by Jury Sidorov. Now Borland Turbo Debugger > should be able to debug applications, also it can fix hangs in other > applications. > - When delivering kernel APC, set the pending flag to false (by > analogy with delivering user APC and clearing its pending flag). > See issue #3426 for more details. > > Modified: > trunk/reactos/ntoskrnl/ke/apc.c (contents, props changed) > > Modified: trunk/reactos/ntoskrnl/ke/apc.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/apc.c?rev=3423… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ke/apc.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/apc.c [iso-8859-1] Tue Jul 1 05:08:14 > 2008 > @@ -145,8 +145,8 @@ > /* Get the APC */ > QueuedApc = CONTAINING_RECORD(NextEntry, KAPC, > ApcListEntry); > > - /* Is this a Normal APC? If so, break */ > - if (QueuedApc->NormalRoutine) break; > + /* Is this a No-Normal APC? If so, break */ > + if (!QueuedApc->NormalRoutine) break; > > /* Move to the next APC in the Queue */ > NextEntry = NextEntry->Blink; > @@ -320,6 +320,9 @@ > break; > } > > + /* It's not pending anymore */ > + Thread->ApcState.KernelApcPending = FALSE; > + > /* Get the next Entry */ > ApcListEntry = Thread->ApcState.ApcListHead[KernelMode].Flink; > Apc = CONTAINING_RECORD(ApcListEntry, KAPC, ApcListEntry); > > Propchange: trunk/reactos/ntoskrnl/ke/apc.c > ------------------------------------------------------------------------------ > --- svn:needs-lock (original) > +++ svn:needs-lock (removed) > @@ -1,1 +1,0 @@ > -* > Best regards, Alex Ionescu

16 years, 2 months

"the input line is too long" bug caused by hpoussin's changes

by Colin Finck

Hello everyone, As most devs including me noticed this "the input line is too long" bug after hpoussin's changes in r34187 to r34191, I did some research on it. Unfortunately, it looks like it's unfixable if we keep on directly using ld for linking (as introduced in these revisions) instead of calling the gcc frontend. First of all, the "length" of the cmd input line under Windows seems to be highly affected by quotation marks. If you add a quotation mark to the working linker command line before hpoussin's commits, it will also be reported as being too long. Previously, we didn't use quotation marks in the command line when linking the binaries. Now we have to do this because of the changed PROJECT_LFLAGS and PROJECT_LPPFLAGS variables: They contain the path to i.e. libgcc and as this path can contain spaces, it has to be put in quotation marks. Just passing "libgcc.a" without a path doesn't work. Passing "-lgcc" also doesn't work, because mingw32-ld only seems to search for libraries in "mingw32/lib", not "lib/gcc/mingw32/4.1.3" as gcc does. I see no other solution than partly reverting hpoussin's changes and using gcc for linking again. If anyone sees another option, please comment or directly commit a fix. Best regards, Colin

16 years, 3 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev