Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [hpoussin] 34856: Revert r34848 and r34850, and replace them by a real fix (hinted by Colin Finck)

by Alex Ionescu

This breaks compiling on Mac OS X... I haven't been able to build since this patch, because now it tries to include windows.h. On 27-Jul-08, at 12:39 PM, hpoussin(a)svn.reactos.org wrote: > Author: hpoussin > Date: Sun Jul 27 14:39:05 2008 > New Revision: 34856 > > URL: http://svn.reactos.org/svn/reactos?rev=34856&view=rev > Log: > Revert r34848 and r34850, and replace them by a real fix (hinted by > Colin Finck) > > Modified: > trunk/reactos/Makefile > trunk/reactos/tools/sysreg/namedpipe_reader.cpp > trunk/reactos/tools/sysreg/os_support.cpp > trunk/reactos/tools/sysreg/os_support.h > trunk/reactos/tools/sysreg/rosboot_test.cpp > trunk/reactos/tools/sysreg/rosboot_test.h > trunk/reactos/tools/sysreg/user_types.h > > Modified: trunk/reactos/Makefile > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/Makefile?rev=34856&r1=3485… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/Makefile [iso-8859-1] (original) > +++ trunk/reactos/Makefile [iso-8859-1] Sun Jul 27 14:39:05 2008 > @@ -182,8 +182,8 @@ > endif > else > HOST=mingw32-linux > -HOST_CFLAGS+=-fshort-wchar -D__LINUX__ > -HOST_CPPFLAGS+=-fshort-wchar -D__LINUX__ > +HOST_CFLAGS+=-fshort-wchar > +HOST_CPPFLAGS+=-fshort-wchar > endif > endif > > > Modified: trunk/reactos/tools/sysreg/namedpipe_reader.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/namedpipe_rea… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/namedpipe_reader.cpp [iso-8859-1] > (original) > +++ trunk/reactos/tools/sysreg/namedpipe_reader.cpp [iso-8859-1] Sun > Jul 27 14:39:05 2008 > @@ -14,7 +14,7 @@ > { > #define MIN(a, b) (((a) < (b)) ? (a) : (b)) > > -#ifdef __LINUX__ > +#ifdef __linux__ > const char * NamedPipeReader::s_LineBreak = "\x0A\0"; > #else > const char * NamedPipeReader::s_LineBreak = "\x0D\x0A\0"; > @@ -46,7 +46,7 @@ > cerr << "NamedPipeReader::openPipe> pipe already open" > << endl; > return false; > } > -#ifndef __LINUX__ > +#ifndef __linux__ > h_Pipe = CreateFile(PipeCmd.c_str(), > GENERIC_WRITE | GENERIC_READ, > 0, > @@ -105,7 +105,7 @@ > cerr << "NamedPipeReader::closePipe> pipe is not open" > << endl; > return false; > } > -#ifdef __LINUX__ > +#ifdef __linux__ > close(h_Pipe); > #else > DisconnectNamedPipe(h_Pipe); > @@ -274,7 +274,7 @@ > bool NamedPipeReader::readPipe(char * buffer, int bufferlength, > long & bytesread) > { > > -#ifdef __LINUX__ > +#ifdef __linux__ > long cbRead = read(h_Pipe, > buffer, > (bufferlength-1) * sizeof(char)); > > Modified: trunk/reactos/tools/sysreg/os_support.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/os_support.cp… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/os_support.cpp [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/os_support.cpp [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -38,7 +38,7 @@ > } > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > if (s_Entries.size()) > { > long secs = s_Entries[i]->tm.tv_sec - tm.tv_sec; > @@ -54,7 +54,7 @@ > void OsSupport::cancelAlarms() > { > > -#ifndef __LINUX__ > +#ifndef __linux__ > if (s_hThread) > { > TerminateThread(s_hThread, 0); > @@ -73,7 +73,7 @@ > } > > > -#ifndef __LINUX__ > +#ifndef __linux__ > > HANDLE OsSupport::s_hThread = 0; > static HANDLE hTimer; > > Modified: trunk/reactos/tools/sysreg/os_support.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/os_support.h?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/os_support.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/os_support.h [iso-8859-1] Sun Jul 27 > 14:39:05 2008 > @@ -10,7 +10,7 @@ > * PROGRAMMERS: Johannes Anderwald (johannes.anderwald at sbox > tugraz at) > */ > > -#ifndef __LINUX__ > +#ifndef __linux__ > #include <windows.h> > #else > #include <unistd.h> > @@ -140,7 +140,7 @@ > OsSupport() > {} > > -#ifdef __LINUX__ > +#ifdef __linux__ > static struct sigaction s_sact; > #else > static HANDLE s_hThread; > > Modified: trunk/reactos/tools/sysreg/rosboot_test.cpp > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/rosboot_test.cpp [iso-8859-1] > (original) > +++ trunk/reactos/tools/sysreg/rosboot_test.cpp [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -46,7 +46,7 @@ > string RosBootTest::XEN_CONFIG_FILE = "XEN_CONFIG_FILE"; > string RosBootTest::XEN_CONFIG_NAME = "XEN_CONFIG_NAME"; > > -#ifdef __LINUX__ > +#ifdef __linux__ > string RosBootTest::ROS_EMU_PATH = "ROS_EMU_PATH_LIN"; > #else > string RosBootTest::ROS_EMU_PATH = "ROS_EMU_PATH_WIN"; > @@ -117,7 +117,7 @@ > img = "output-i386"; > > EnvironmentVariable::getValue("ROS_OUTPUT", img); > -#ifdef __LINUX__ > +#ifdef __linux__ > img += "/ros.hd"; > #else > img += "\\ros.hd"; > @@ -159,7 +159,7 @@ > } > > > -#ifdef __LINUX__ > +#ifdef __linux__ > qemuimgdir += "/qemu-img"; > > #else > @@ -176,7 +176,7 @@ > const char * options[] = {NULL, > "create", > "-f", > -#ifdef __LINUX__ > +#ifdef __linux__ > "raw", > #else > "vmdk", > @@ -241,7 +241,7 @@ > { > string::size_type pos; > > -#ifdef __LINUX__ > +#ifdef __linux__ > pos = m_EmuPath.find_last_of("/"); > #else > pos = m_EmuPath.find_last_of("\\"); > @@ -266,7 +266,7 @@ > m_MaxMem = "64"; > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > > if (mktemp(pipename)) > { > @@ -332,7 +332,7 @@ > return false; > } > > -#ifdef __LINUX__ > +#ifdef __linux__ > /* on linux we need get pid in order to be able > * to terminate the emulator in case of errors > * on windows we can get pid as return of > CreateProcess > @@ -369,7 +369,7 @@ > { > pipe = pipe.substr(0, pos); > } > -#ifdef __LINUX__ > +#ifdef __linux__ > m_Src = pipe; > #else > m_Src = "\\\\.\\pipe\\" + pipe.substr(0, pos); > @@ -577,7 +577,7 @@ > return false; > } > } > -#ifdef __LINUX__ > +#ifdef __linux__ > if (mkfifo(m_Src.c_str(), 400)) > { > /* > @@ -802,7 +802,7 @@ > cleanup(conf_parser); > return false; > } > -#ifdef __LINUX__ > +#ifdef __linux__ > /* > * For linux systems we can only > * check if the emulator runs by > @@ -832,7 +832,7 @@ > } > #endif > OsSupport::cancelAlarms(); > -#ifdef __LINUX__ > +#ifdef __linux__ > // OsSupport::setAlarm (m_MaxTime, m_Pid); > // OsSupport::setAlarm(m_MaxTime, getpid()); > #else > > Modified: trunk/reactos/tools/sysreg/rosboot_test.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/rosboot_test.… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/rosboot_test.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/rosboot_test.h [iso-8859-1] Sun Jul > 27 14:39:05 2008 > @@ -30,12 +30,12 @@ > #include <cstdlib> > #include <cstring> > #include <ctime> > -#ifndef __LINUX__ > +#ifndef __linux__ > #include <io.h> > #include <errno.h> > #endif > > -#ifdef __LINUX__ > +#ifdef __linux__ > #include <unistd.h> > #include <sys/types.h> > #if defined(__FreeBSD__) || defined(__APPLE__) > > Modified: trunk/reactos/tools/sysreg/user_types.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/sysreg/user_types.h?… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/tools/sysreg/user_types.h [iso-8859-1] (original) > +++ trunk/reactos/tools/sysreg/user_types.h [iso-8859-1] Sun Jul 27 > 14:39:05 2008 > @@ -13,7 +13,7 @@ > #include <string> > #include <iostream> > > -#ifndef __LINUX__ > +#ifndef __linux__ > #define popen _popen > #define pclose _pclose > #endif > Best regards, Alex Ionescu

16 years, 9 months

ARM Guy Broke BOOT on Real Hardware

by James Tabor

Hi ARMs, Doing a good job BTW~ Thanks, James (ntoskrnl/kd/kdio.c:191) ----------------------------------------------------- (ntoskrnl/kd/kdio.c:192) ReactOS 0.4-SVN (Build 20080728-r34871) (ntoskrnl/kd/kdio.c:193) Command Line: DEBUG DEBUGPORT=COM1 BUADRATE=115200 SOS (ntoskrnl/kd/kdio.c:194) ARC Paths: multi(0)disk(0)rdisk(0)partition(1) \ multi(0)disk(0)rdisk(0)parti tion(1) \ReactOS\ Used memory 1015348Kb (ntoskrnl/mm/mminit.c:295) Start End Type (ntoskrnl/mm/mminit.c:296) 0x80000000 - 0x80800000 Undefined region (ntoskrnl/mm/mminit.c:299) 0x80800000 - 0x80E00000 FreeLDR Kernel mapping region (ntoskrnl/mm/mminit.c:302) 0x80E00000 - 0x815C0000 PFN Database region (ntoskrnl/mm/mminit.c:309) 0x815C0000 - 0x879C0000 Non paged pool region (ntoskrnl/mm/mminit.c:312) 0x879C0000 - 0x8DDC0000 Paged pool region (ntoskrnl/ke/i386/kiinit.c:47) Large Page support detected but not yet taken advantage of! WARNING: KdDebuggerInitialize1 at drivers/base/kdcom/i386/kdbg.c:489 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:700 is UNIMPLEMENTED! WARNING: IoReportResourceUsage at ntoskrnl/io/iomgr/iorsrce.c:700 is UNIMPLEMENTED! (ntoskrnl/io/iomgr/driver.c:1356) '\Driver\BUSLOGIC' initialization failed, status (0xc00000c0) (ntoskrnl/io/iomgr/driver.c:1356) '\Driver\Floppy' initialization failed, status (0xc000000e) Assertion 'KeGetCurrentIrql()<=(1)' failed at ntoskrnl/ke/gmutex.c line 201 Entered debugger on embedded INT3 at 0x0008:0x808a8262. kdb:> bt Eip: <NTOSKRNL.EXE:a8263 (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))> Frames: <NTOSKRNL.EXE:a027 (ntoskrnl/ke/gmutex.c:201 (@KeAcquireGuardedMutex@4))> <NTOSKRNL.EXE:6d3a2 (ntoskrnl/include/internal/mm.h:1556 (MmProbeAndLockPages@12))> <NTOSKRNL.EXE:4f079 (ntoskrnl/io/iomgr/irp.c:694 (IoBuildAsynchronousFsdRequest@24))> <SCSIPORT.SYS:4671 (drivers/storage/scsiport/scsiport.c:3959 (ScsiPortDpcForIsr@16))> <NTOSKRNL.EXE:823a (ntoskrnl/ke/dpc.c:474 (@KiRetireDpcList@4))> <NTOSKRNL.EXE:9fc59 (ntoskrnl/ke/i386/ctxswitch.S:691 (@KiIdleLoop@0))> <00000000> kdb:>

16 years, 9 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 34860: Fixed some kernel exports

by Alex Ionescu

I would've hoped the ARM guys made it painfully clear by now that ARM functions do not have @xx appended to their names... Author: ros-arm-bringup Date: Sun Jul 27 00:37:54 2008 New Revision: 34820 URL: http://svn.reactos.org/svn/reactos?rev=34820&view=rev Log: - Stop adding those damn @ decorations to ARM builds. Among many others... On 27-Jul-08, at 2:19 PM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Sun Jul 27 16:19:15 2008 > New Revision: 34860 > > URL: http://svn.reactos.org/svn/reactos?rev=34860&view=rev > Log: > Fixed some kernel exports > > Modified: > branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def > branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > > Modified: branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/ntoskrnl_ar… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/ntoskrnl_arm.def [iso-8859-1] Sun > Jul 27 16:19:15 2008 > @@ -187,10 +187,10 @@ > FsRtlDeleteKeyFromTunnelCache > FsRtlDeleteTunnelCache > FsRtlDeregisterUncProvider > -FsRtlDissectDbcs > -FsRtlDissectName > -FsRtlDoesDbcsContainWildCards > -FsRtlDoesNameContainWildCards > +FsRtlDissectDbcs@16 > +FsRtlDissectName@16 > +FsRtlDoesDbcsContainWildCards@4 > +FsRtlDoesNameContainWildCards@4 > FsRtlFastCheckLockForRead > FsRtlFastCheckLockForWrite > FsRtlFastUnlockAll > > Modified: branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def > URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/ntoskrnl_i3… > = > = > = > = > = > = > = > = > ====================================================================== > --- branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] > (original) > +++ branches/pierre-fsd/ntoskrnl/ntoskrnl_i386.def [iso-8859-1] Sun > Jul 27 16:19:15 2008 > @@ -204,9 +204,9 @@ > FsRtlDeleteKeyFromTunnelCache > FsRtlDeleteTunnelCache > FsRtlDeregisterUncProvider > -FsRtlDissectDbcs > +FsRtlDissectDbcs@16 > FsRtlDissectName@16 > -FsRtlDoesDbcsContainWildCards > +FsRtlDoesDbcsContainWildCards@4 > FsRtlDoesNameContainWildCards@4 > FsRtlFastCheckLockForRead > FsRtlFastCheckLockForWrite > Best regards, Alex Ionescu

16 years, 9 months

[ros-diffs] [jimtabor] 34807: - Attempt to initiate hook set from kernel space.

by James Tabor

Hi, Here is a test program to play with, tell me what is wrong. 8^D James Ref info and download the program: http://www.klenotic.com/pl/null_hhook/ http://www.klenotic.com/pl/null_hhook/HookChainTest100.zip

16 years, 9 months

widl problem importing stdole2.tlb

by Steven Edwards

Hi, I've been attempting to sync some of the Wine dlls, namely the IE support dlls and have run in to a bit of a problem which I think is a bug in ReactOS widl. It seems that the import keyword is not working. When trying to build shdocvw.dll it creates a shdocvw_v1.tlb based on shdocvw_v1.idl which imports exdisp.idl from the SDK which in turn does an import ("stdole2.tlb") As you can see from the output below sedwards@mini-gimli:~/source/reactos$ make shdocvw [WIDL] obj-i386/dll/win32/shdocvw/shdocvw_v1.tlb error: Could not open importlib stdole2.tlb. mingw32-make: *** [obj-i386/dll/win32/shdocvw/shdocvw_v1.tlb] Error 2 Total Build Time: 00:00:02 Notice the . at the end of stdole2.tlb? I've tried just renaming the typelib and putting it in several intermediate folders to no effect. If any WIDL Guru can help please find the attached patch which contains an updated shdocvw.rbuild Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 9 months

kernel32

by gedmurphy

Yesterday I was playing around with the test suite in HEAD when I moved onto kernel32. It was, without wanting to sound too harsh, a bit of a disgrace, with large failures throughout the whole test range. I suggest a hacking day on it using the test suite, a joint effort to bring this core lib back into line. Perhaps with some emphasis on trying to make it fun. Whoever gets the most fixes is crowned 'king ding-a-ling' and holds the title until the next one, opening the road up to days on ntdll, user32, gdi32 and crt? Ged.

16 years, 9 months

Java Install

by James Tabor

Hi, When installing Java or anything with java it hangs and just sit there running. It could be OOo 2.4 or installing java, does not mater, I just left the box running all night and just sits there, still installing.. This bug fault right after I restarted. Is it waiting on a lock? Assertion 'WaitBlock->Signaled' failed at ntoskrnl/ex/pushlock.c line 599 Entered debugger on embedded INT3 at 0x0008:0x808ad242. kdb:> bt Eip: <NTOSKRNL.EXE:ad243 (lib/rtl/i386/debug_asm.S:33 (DbgBreakPoint@0))> Frames: <NTOSKRNL.EXE:2da24 (ntoskrnl/ex/pushlock.c:599 (@ExfAcquirePushLockExclusive@4))> <NTOSKRNL.EXE:6eb00 (ntoskrnl/include/internal/ex.h:715 (MiProtectVirtualMemory@20))> <NTOSKRNL.EXE:6fdbf (ntoskrnl/mm/virtual.c:927 (NtProtectVirtualMemory@20))> <NTOSKRNL.EXE:979ca (ntoskrnl/ke/i386/trap.s:244 (KiFastCallEntry))> <ntdll.dll:5e1a> ntdll/main/i386/dispatch.S:297 (KiFastSystemCallRet@0) <kernel32.dll:e0ce> kernel32/mem/virtual.c:127 (VirtualProtect@16) <jvm.dll:149b27> kdb:>

16 years, 9 months

Request for Comment / Setup

by Matthias Kupfer

Hi all, I'm working on first stage gui setup. During the development i reviewed the base/setup directory and the different modules. I suggest following changes: Now: reactos.exe: atm greeting only with disabled first stage setup dialogs setup.exe: switcher for 2nd stage setup (syssetup) or livecd usetup.exe: textmode 1st stage setup vmwinst.exe: don't know exactly, vm-ware driver installation welcome.exe: nice welcome dialog without real functions Future: setup.exe: switcher for 1st stage gui setup, 2nd stage setup, livecd and welcome dialog switched by command line arguments "setup.exe" -> welcome dialog "setup.exe -mini" -> livecd "setup.exe -newsetup1" -> 1st stage gui setup "setup.exe -newsetup2" -> 2nd stage (gui) setup usetup.exe: textmode 1st-stage-setup vmwinst.exe: keeps unchangend reactos.exe, welcome.exe: removed Are there any objections to go this way? If not, so i will change this soon. Matthias -- Matthias Kupfer Telefon +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 Mobil +49 (0) 160 859 43 54 09122 Chemnitz

16 years, 9 months

Re: [ros-dev] Re : [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks

by Steven Edwards

On Tue, Jul 22, 2008 at 9:56 AM, Sylvain Petreolle <spetreolle(a)yahoo.fr> wrote: > It'sToo bad the header is not in an include directory... Maybe it should go in the NDK then. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 9 months

Re : [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks was supposed to

by Sylvain Petreolle

> De : Steven Edwards <winehacker(a)gmail.com> > À : ros-dev(a)reactos.org > Envoyé le : Mardi, 22 Juillet 2008, 11h49mn 04s > Objet : Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 34655: - Build vfatfs instead of CDFS. - Load vfatfs instead of CDFS. - Implement code in the ramdisk driver to handle both ISO and FAT ramdisks. Don't know what the big deal with support ISO ramdisks was supposed to > > On Tue, Jul 22, 2008 at 5:42 AM, Steven Edwards wrote: > > On Tue, Jul 22, 2008 at 1:31 AM, wrote: > >> #include > >> +#include "../../../filesystems/fs_rec/fs_rec.h" > > > > This can cause problems with parallel makes. > > This is what I get for commenting at 5 am...I thought you were > including another .c file directly. ignore the part about parallel > makes. But do try to avoid referencing the header like this. Just set > an include path in the rbuild file and spare my eyes the horror of the > directory traversal. > > -- > Steven Edwards > It'sToo bad the header is not in an include directory... Kind regards, Sylvain Petreolle (aka Usurp) Support artists, not multinationals - http://Iwouldntsteal.net Supportez les artistes, pas les multinationales - http://Iwouldntsteal.net

16 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev