Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [tkreuzer] 35359: The TEB member is called ClientID not Cid on all Windows versions I could check (XP, 2k3, vista).
by Aleksey Bragin 17 Aug '08

17 Aug '08

Please merge this change to trunk too, if NDK author does not object. WBR, Aleksey Bragin. On Aug 16, 2008, at 3:40 AM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Fri Aug 15 18:40:42 2008 > New Revision: 35359 > > URL: http://svn.reactos.org/svn/reactos?rev=35359&view=rev > Log: > The TEB member is called ClientID not Cid on all Windows versions I > could check (XP, 2k3, vista).

1 0

Re: [ros-dev] [ros-web] Developer blog
by Zachary Gorden 15 Aug '08

15 Aug '08

I'd rather pester you to finish work on your SEH paper and translation of parts of your thesis. On Fri, Aug 15, 2008 at 12:31 AM, KJK::Hyperion <hackbunny(a)reactos.org>wrote: > Zachary Gorden ha scritto: > > However, there may be developers who do not wish to maintain > > their own blog or want to keep their ROS bloggings separate and want to > > make use of the system integrated in the CMS. Any thoughts? > > Do both (aggregator AND blog platform). Then pester me to blog > _______________________________________________ > Ros-web mailing list > Ros-web(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-web >

3 3

Developer blog
by Zachary Gorden 14 Aug '08

14 Aug '08

Sending this to both mailing lists as I don't know how many developers are actually subscribed to the web list. For some time now, the blog on the ReactOS site hasn't been used. When I asked if Aleksey was against putting up a "preview" of sorts on the front page in an attempt to revive it, some of the developers such as Ged pointed out no one really used it anymore and a few already had their own blogs and didn't want to maintain two. Ged has already moved to remove the link in the quick menu, though no formal decision has been made yet (the link is still there until a refresh occurs, though we might end up restoring it anyways). I personally believe the blog could be quite useful, even if its current form changes. An alternative would be an aggregation of the RSS feeds from the blogs maintained by each ROS developer, assuming they have a blog. However, there may be developers who do not wish to maintain their own blog or want to keep their ROS bloggings separate and want to make use of the system integrated in the CMS. Any thoughts?

4 4

Re: [ros-dev] [ros-diffs] [sginsberg] 35299: - Reapply the PsTerminateSystemThread typo fix. We do boot fine with this fix. - Note to self: Don't commit after midnight and always test your patches yourself
by Alex Ionescu 13 Aug '08

13 Aug '08

Some credit would've been nice ;-) On 13-Aug-08, at 12:56 AM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Wed Aug 13 02:55:59 2008 > New Revision: 35299 > > URL: http://svn.reactos.org/svn/reactos?rev=35299&view=rev > Log: > - Reapply the PsTerminateSystemThread typo fix. We do boot fine with > this fix. > - Note to self: Don't commit after midnight and always test your > patches yourself > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Wed Aug 13 > 02:55:59 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-diffs] [sginsberg] 35294: - Temporarily revert my last change. We don't set the SystemThread flag appropriately and it is always zero
by Alex Ionescu 13 Aug '08

13 Aug '08

else { /* System Thread */ Thread->StartAddress = StartRoutine; PspSetCrossThreadFlag(Thread, CT_SYSTEM_THREAD_BIT); Looks good to me. And CT_SYSTEM_THREAD_BIT is defined to 0x10 which is correct: union { struct { ULONG Terminated:1; #if (NTDDI_VERSION >= NTDDI_LONGHORN) ULONG ThreadInserted:1; #else ULONG DeadThread:1; #endif ULONG HideFromDebugger:1; ULONG ActiveImpersonationInfo:1; ULONG SystemThread:1; so your patch was correct and should be re-applied. On 12-Aug-08, at 3:22 PM, sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Tue Aug 12 17:22:51 2008 > New Revision: 35294 > > URL: http://svn.reactos.org/svn/reactos?rev=35294&view=rev > Log: > - Temporarily revert my last change. We don't set the SystemThread > flag appropriately and it is always zero > > Modified: > trunk/reactos/ntoskrnl/ps/kill.c > > Modified: trunk/reactos/ntoskrnl/ps/kill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=352… > = > = > = > = > = > = > = > = > ====================================================================== > --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Tue Aug 12 > 17:22:51 2008 > @@ -1086,7 +1086,7 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure this is a system thread */ > - if (!Thread->SystemThread) return STATUS_INVALID_PARAMETER; > + if (Thread->SystemThread) return STATUS_INVALID_PARAMETER; > > /* Terminate it for real */ > return PspTerminateThreadByPointer(Thread, ExitStatus, TRUE); > Best regards, Alex Ionescu

1 0

Re: [ros-dev] [ros-priv] ROS information policy...
by Thomas Bluemel 11 Aug '08

11 Aug '08

Timo Kreuzer wrote: > And when I have already started moaning about this kind of stuff... what > about the arm guys? They are so secret they can't even make their > changelog themselfs? Why that? And why are they so secret that noone > knows? I mean we keep demanding real name and email from everyone > creating a patch, yet a bunch of people have direct commit access and > they keep hiding their names? What reasons are there I thought it was common knowledge already that Alex is the (only) arm "guys". Isn't it more than obvious? Very same coding style, knowledge, comments, rants, ... How stupid does one have to be not to realize the connection? Prove me otherwise... And since you're complaining about not being open, why do you only post this to the private list? Thomas

2 1

[ros-diffs] [fireball] 35140: - Add more intrinsic defines. - SVN maintenance.
by Timo Kreuzer 06 Aug '08

06 Aug '08

MS defines most of those in the wdk, if NO_INTERLOCKED_INTRINSICS is not defined > +#define InterlockedDecrement _InterlockedDecrement > +#define InterlockedDecrement16 _InterlockedDecrement16 > +#define InterlockedIncrement _InterlockedIncrement > +#define InterlockedIncrement16 _InterlockedIncrement16 > +#define InterlockedCompareExchange _InterlockedCompareExchange > +#define InterlockedCompareExchange16 _InterlockedCompareExchange16 > +#define InterlockedCompareExchange64 _InterlockedCompareExchange64 > +#define InterlockedExchange _InterlockedExchange > +#define InterlockedExchangeAdd _InterlockedExchangeAdd >

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 35127: - Add cred.c from Wine
by Steven Edwards 05 Aug '08

05 Aug '08

On Tue, Aug 5, 2008 at 10:45 AM, <dchapyshev(a)svn.reactos.org> wrote: > +#include "../crypt/crypt.h" Minor nitpicking, Do you mind fixing this? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [mkupfer] 35050: revert to 35046, sorry for mistake
by Steven Edwards 03 Aug '08

03 Aug '08

On Sat, Aug 2, 2008 at 6:33 PM, <mkupfer(a)svn.reactos.org> wrote: > Author: mkupfer > Date: Sat Aug 2 17:33:58 2008 > New Revision: 35050 > > URL: http://svn.reactos.org/svn/reactos?rev=35050&view=rev > Log: > revert to 35046, sorry for mistake Ignore my message, I did not see where you fixed it. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [ros-dev] [ros-diffs] [mkupfer] 35047: Reorganize shdocvw: - Moved and renamed language resource files into created 'lang' directory. - Outdated shdocvw_ros.diff removed.
by Steven Edwards 03 Aug '08

03 Aug '08

On Sat, Aug 2, 2008 at 5:57 PM, <mkupfer(a)svn.reactos.org> wrote: > Author: mkupfer > Date: Sat Aug 2 16:57:53 2008 > New Revision: 35047 > > URL: http://svn.reactos.org/svn/reactos?rev=35047&view=rev > Log: > Reorganize shdocvw: > - Moved and renamed language resource files into created 'lang' directory. > - Outdated shdocvw_ros.diff removed. This is wrong, shdocvw will keep being synced as soon as the widl bug is fixed so the resources should stay in the dll root to save whoever is doing the sync the trouble of having to move resources around. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev