Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [cwittich] 35960: change parameter back to DWORD as it is in our headers

by Timo Kreuzer

That it's DWORD in our headers, doesn't mean it's correct. Actually it means that our headers are wrong. cwittich(a)svn.reactos.org schrieb: > Author: cwittich > Date: Fri Sep 5 08:28:12 2008 > New Revision: 35960 > > URL: http://svn.reactos.org/svn/reactos?rev=35960&view=rev > Log: > change parameter back to DWORD as it is in our headers > > Modified: > trunk/reactos/dll/win32/advapi32/crypt/crypt.c > > Modified: trunk/reactos/dll/win32/advapi32/crypt/crypt.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/crypt/c… > ============================================================================== > --- trunk/reactos/dll/win32/advapi32/crypt/crypt.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/advapi32/crypt/crypt.c [iso-8859-1] Fri Sep 5 08:28:12 2008 > @@ -626,7 +626,7 @@ > * Success: TRUE > * Failure: FALSE > */ > -BOOL WINAPI CryptReleaseContext (HCRYPTPROV hProv, ULONG_PTR dwFlags) > +BOOL WINAPI CryptReleaseContext (HCRYPTPROV hProv, DWORD dwFlags) > { > PCRYPTPROV pProv = (PCRYPTPROV)hProv; > BOOL ret = TRUE; > > >

16 years, 8 months

Invitation to Southern California Linux Expo 7x

by Gareth J. Greenaway

Greetings, I would like to formerly invite the ReactOS community to participate at the Southern California Linux Expo. The show will be taking place February 20th - 22nd, 2009 at the Westin LAX in Los Angeles, CA. I am including both a link to our "Call For dotORG Exhibitors" as well as our "Call for Papers" if anyone from the ReactOS community is interested in submitting a talk for consideration. More information about the show can be found at http://www.socallinuxexpo.org Thanks! Gareth http://scale7x.socallinuxexpo.org/s7x_cfp http://scale7x.socallinuxexpo.org/s7x_call_for_dotOrg_exhibitors -- Gareth J. Greenaway <g(a)socallinuxexpo.org> Voice - 877-831-2569 x130 Southern California Linux Expo http://www.socallinuxexpo.org

16 years, 8 months

Re: [ros-dev] [ros-diffs] [janderwald] 35839: - Remove old unused enumeration code - Implement displaying network component properties

by Steven Edwards

On Sun, Aug 31, 2008 at 2:07 PM, <janderwald(a)svn.reactos.org> wrote: > #define REACTOS_STR_ORIGINAL_FILENAME "netshell.dll\0" > #define REACTOS_STR_PRODUCT_VERSION "5.1.2600.3264\0" > #define REACTOS_STR_FILE_VERSION "5.1.2600.3264\0" > +#define REACTOS_STR_COMPANY_NAME "Microsoft Corporation" Is there an application that actually depends on the string "Microsoft Corporation" here? If not then you need to remove it otherwise someone will think your ripping Microsoft's code. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 8 months

anyone seeing this?

by Steven Edwards

ntoskrnl/io/iomgr/file.c: In function 'IopCloseFile': ntoskrnl/io/iomgr/file.c:1407: error: expected expression before '<<' token ntoskrnl/io/iomgr/file.c:1410: error: expected expression before '==' token ntoskrnl/io/iomgr/file.c:1413: error: expected expression before '>>' token mingw32-make: *** [obj-i386/ntoskrnl/io/iomgr/file_ntoskrnl.o] Error 1 -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

16 years, 8 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 35846: Reverted r35812 because of unwanted triple fault bug. See issue #3704, 3706 for more details.

by Aleksey Bragin

But, this was reported to me as working: abiword & firefox install, vmwinst (which exposes vectored handler test) works. I experienced triple fault on a clean build too, so it's not a random problem. How so? People demand explanations about testing techniques Stefan uses. WBR, Aleksey Bragin. On Sep 1, 2008, at 1:58 AM, pschweitzer(a)svn.reactos.org wrote: > Author: pschweitzer > Date: Sun Aug 31 16:58:44 2008 > New Revision: 35846 > > URL: http://svn.reactos.org/svn/reactos?rev=35846&view=rev > Log: > Reverted r35812 because of unwanted triple fault bug. > See issue #3704,3706 for more details. > > Modified: > trunk/reactos/dll/ntdll/dispatch/ (props changed) > trunk/reactos/dll/ntdll/dispatch/dispatch.c > trunk/reactos/dll/ntdll/dispatch/i386/dispatch.S > trunk/reactos/lib/rtl/i386/except.c > trunk/reactos/lib/rtl/rtlp.h > trunk/reactos/lib/rtl/vectoreh.c >

16 years, 8 months

Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)

by Stefan Ginsberg

err, sorry. that should be ntddk.h and not winddk.h ;0) >"Umtypes is only included for user-mode, not for drivers." > >ketypes.h imports umtypes.h -- > >#include <umtypes.h> >#ifndef NTOS_MODE_USER >#include <haltypes.h> >#include <potypes.h> >#include <ifssupp.h> >#endif > >"Drivers do not import winnt.h" >they (still) do in ros as winddk.h imports winnt.h... _________________________________________________________________ Explore the seven wonders of the world http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form=QBRE

16 years, 8 months

by Alex Ionescu

Umtypes is only included for user-mode, not for drivers. My e-mail was about drivers. Drivers do not import winnt.h Drivers import ntifs, wdm and ntddk. Ntifs, wdm and ntddk are the headers that drivers import. Not winnt.h. My e-mail specifically listed those three headers and talked about drivers. You guys come back saying "it's in winnt.h so it's okay!" Are you blind, illiterate, or what? Best regards, Alex Ionescu On Sun, Aug 31, 2008 at 10:35 PM, Alex Ionescu <aionescu(a)gmail.com> wrote: > Umtypes is only included for user-mode, not for drivers. > > My e-mail was about drivers. > > Drivers do not import winnt.h > > Drivers import ntifs, wdm and ntddk. > > Ntifs, wdm and ntddk are the headers that drivers import. > > Not winnt.h. > > My e-mail specifically listed those three headers and talked about drivers. > > You guys come back saying "it's in winnt.h so it's okay!" > > Are you blind, illiterate, or what? > > Best regards, > Alex Ionescu > > > > 2008/8/31 Stefan Ginsberg <stefan__100__(a)hotmail.com>: >> The NDK includes winnt.h through umtypes.h -> windef.h -> winnt.h (MS PSDK's >> windef.h includes winnt.h too, so I assumed this was correct). >> If this is wrong then how should it be done? >> >>> Date: Sun, 31 Aug 2008 01:00:18 +0200 >>> From: ionucu(a)videotron.ca >>> To: ros-dev(a)reactos.org >>> Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR >>> and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to >>> define them in the NDK (the NDK includes winnt.h through windef.h, so this >>> breaks build) >>> >>> Please make sure that these types are available for DRIVERS as well -- >>> otherwise, they belong in the NDK. (Check with WDK >>> wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access >>> pointers/structures of this type, it must be in the NDK). >>> >>> Also, the NDK does not include winnt.h -- at least it's not supposed >>> to, unless someone broke it. >>> >>> For the future, please make suer to review NDK changes with me, since >>> I'm still its owner. >>> >>> Best regards, >>> Alex Ionescu >>> >>> >>> >>> On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote: >>> > Author: sginsberg >>> > Date: Sat Aug 30 16:34:56 2008 >>> > New Revision: 35819 >>> > >>> > URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev >>> > Log: >>> > - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in >>> > winnt.h, so no need to define them in the NDK (the NDK includes winnt.h >>> > through windef.h, so this breaks build) >>> > >>> > Modified: >>> > trunk/reactos/include/ndk/ketypes.h >>> > >>> > Modified: trunk/reactos/include/ndk/ketypes.h >>> > URL: >>> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=… >>> > >>> > ============================================================================== >>> > --- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original) >>> > +++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30 16:34:56 >>> > 2008 >>> > @@ -542,17 +542,6 @@ >>> > } KAPC_ENVIRONMENT; >>> > >>> > // >>> > -// CPU Cache Types >>> > -// >>> > -typedef enum _PROCESSOR_CACHE_TYPE >>> > -{ >>> > - CacheUnified, >>> > - CacheInstruction, >>> > - CacheData, >>> > - CacheTrace, >>> > -} PROCESSOR_CACHE_TYPE; >>> > - >>> > -// >>> > // PRCB DPC Data >>> > // >>> > typedef struct _KDPC_DATA >>> > @@ -571,18 +560,6 @@ >>> > struct _GENERAL_LOOKASIDE *P; >>> > struct _GENERAL_LOOKASIDE *L; >>> > } PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST; >>> > - >>> > -// >>> > -// CPU Cache Descriptor >>> > -// >>> > -typedef struct _CACHE_DESCRIPTOR >>> > -{ >>> > - UCHAR Level; >>> > - UCHAR Associativity; >>> > - USHORT LineSize; >>> > - ULONG Size; >>> > - PROCESSOR_CACHE_TYPE Type; >>> > -} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR; >>> > >>> > // >>> > // Architectural Types >>> > >>> > >>> _______________________________________________ >>> Ros-dev mailing list >>> Ros-dev(a)reactos.org >>> http://www.reactos.org/mailman/listinfo/ros-dev >> >> ________________________________ >> Connect to the next generation of MSN Messenger Get it now! >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> >> >

16 years, 8 months

Re: [ros-dev] [ros-diffs] [sginsberg] 35837: - "0xbadf00d" is not a valid tag. use "PcNt" instead

by Alex Ionescu

And AGAIN, another build break. Best regards, Alex Ionescu On Sun, Aug 31, 2008 at 7:56 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sun Aug 31 12:56:13 2008 > New Revision: 35837 > > URL: http://svn.reactos.org/svn/reactos?rev=35837&view=rev > Log: > - "0xbadf00d" is not a valid tag. use "PcNt" instead > > Modified: > trunk/reactos/drivers/network/dd/pcnet/pcnet.h > > Modified: trunk/reactos/drivers/network/dd/pcnet/pcnet.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/pcnet/p… > ============================================================================== > --- trunk/reactos/drivers/network/dd/pcnet/pcnet.h [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/dd/pcnet/pcnet.h [iso-8859-1] Sun Aug 31 12:56:13 2008 > @@ -146,7 +146,7 @@ > #endif > > /* memory pool tag */ > -#define PCNET_TAG 0xbaadf00d > +#define PCNET_TAG TAG('P', 'c', 'N', 't') > > #endif // _PCNET_H_ > > >

16 years, 8 months

by Alex Ionescu

Please make sure that these types are available for DRIVERS as well -- otherwise, they belong in the NDK. (Check with WDK wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access pointers/structures of this type, it must be in the NDK). Also, the NDK does not include winnt.h -- at least it's not supposed to, unless someone broke it. For the future, please make suer to review NDK changes with me, since I'm still its owner. Best regards, Alex Ionescu On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Aug 30 16:34:56 2008 > New Revision: 35819 > > URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev > Log: > - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build) > > Modified: > trunk/reactos/include/ndk/ketypes.h > > Modified: trunk/reactos/include/ndk/ketypes.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=… > ============================================================================== > --- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original) > +++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30 16:34:56 2008 > @@ -542,17 +542,6 @@ > } KAPC_ENVIRONMENT; > > // > -// CPU Cache Types > -// > -typedef enum _PROCESSOR_CACHE_TYPE > -{ > - CacheUnified, > - CacheInstruction, > - CacheData, > - CacheTrace, > -} PROCESSOR_CACHE_TYPE; > - > -// > // PRCB DPC Data > // > typedef struct _KDPC_DATA > @@ -571,18 +560,6 @@ > struct _GENERAL_LOOKASIDE *P; > struct _GENERAL_LOOKASIDE *L; > } PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST; > - > -// > -// CPU Cache Descriptor > -// > -typedef struct _CACHE_DESCRIPTOR > -{ > - UCHAR Level; > - UCHAR Associativity; > - USHORT LineSize; > - ULONG Size; > - PROCESSOR_CACHE_TYPE Type; > -} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR; > > // > // Architectural Types > >

16 years, 8 months

Re: [ros-dev] [ros-diffs] [sginsberg] 35822: - Fix build...

by Alex Ionescu

Did you even TRY compiling your tree before committing? Clearly not... Best regards, Alex Ionescu On Sun, Aug 31, 2008 at 1:06 AM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Sat Aug 30 18:06:13 2008 > New Revision: 35822 > > URL: http://svn.reactos.org/svn/reactos?rev=35822&view=rev > Log: > - Fix build... > > Modified: > trunk/reactos/include/psdk/winnt.h > > Modified: trunk/reactos/include/psdk/winnt.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winnt.h?rev=3… > ============================================================================== > --- trunk/reactos/include/psdk/winnt.h [iso-8859-1] (original) > +++ trunk/reactos/include/psdk/winnt.h [iso-8859-1] Sat Aug 30 18:06:13 2008 > @@ -4695,10 +4695,7 @@ > MemoryBarrier(VOID) > { > LONG Barrier; > - __asm__ __volatile__ > - { > - xchg Barrier, eax > - } > + __asm__ __volatile__("xchgl %%eax, %[Barrier]" : : [Barrier] "m" (Barrier) : "memory"); > } > #elif defined (_M_AMD64) > #define MemoryBarrier() > >

16 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev